Michael Krasnyk
837dba2191
Don't use sliproad scenario if two name announcements are required
2017-10-09 15:35:26 +01:00
Michael Krasnyk
a7ea6e5327
Allow a single intersection in a cross-road of sliproads, #4348/3
2017-10-09 15:35:26 +01:00
Michael Krasnyk
38ab22ee7c
Sliproad case with a single intersection in a cross-road
2017-10-09 15:35:26 +01:00
Michael Krasnyk
a900f5229e
Fix case for sliproads from link via link to primary, #4348/4
2017-10-04 23:23:55 +02:00
Michael Krasnyk
de72a8adb6
Test case for sliproads from link via link to primary, #4348/4
2017-10-04 23:23:55 +02:00
Michael Krasnyk
de942155bf
Add local left_hand_driving flag in API version 2
2017-10-04 10:03:42 +02:00
Daniel J. Hofmann
d7bcafcb59
Uses parsed len(turn:lanes) to fixup number of lanes, resolves #4472
2017-09-28 00:24:14 +02:00
Michael Krasnyk
2532d56b85
Turn angle calculation needs to respect initial road order, #4331
2017-09-18 21:33:00 +02:00
Michael Krasnyk
00fd869224
Test for turn angle calculation the initial road order breaking, #4331
2017-09-18 21:33:00 +02:00
Moritz Kobitzsch
c2dc7e9cd0
use enter + exit for roundabout instructions ( #4358 )
...
* Expose roundabout/rotary exit instructions as a new instruction type.
2017-09-05 12:30:34 -07:00
Moritz Kobitzsch
f347efb006
detect turning onto oneways at the end of the road as non obvious
2017-08-18 16:33:11 +02:00
Moritz Kobitzsch
af8ddac2af
add test-case illustrating changes to obvious turn discovery
2017-08-18 16:33:11 +02:00
Moritz Kobitzsch
3687b6cb4b
respect difference between continue/turn on changing end-of-road
2017-08-16 09:19:15 +02:00
Moritz Kobitzsch
196ed9eb46
do not change fork directions when combining turns
2017-08-16 09:17:01 +02:00
Moritz Kobitzsch
c34520f3a4
add feature to test naming conventions on divided highways
2017-08-15 09:47:13 +02:00
Moritz Kobitzsch
a17b07bc4c
fix bug in conflict resolution
2017-08-11 11:01:54 +02:00
Michael Krasnyk
a8db269fd5
Adjust lower bound for crossroad angle in sliproads handler, #4348/2
2017-08-04 14:37:13 +02:00
Michael Krasnyk
a5efcfdede
Sliproads test case with acute angle at the main intersection
2017-08-04 14:37:13 +02:00
Michael Krasnyk
1ecc913fc2
Fix sliproad scenario with 4 roads in a target intersection, #4348/1
2017-08-04 14:07:35 +02:00
Michael Krasnyk
08eb3b11bc
Test case for sliproad handling with 4 roads at target intersection
2017-08-04 14:07:35 +02:00
Moritz Kobitzsch
b59d9a2f27
update test-case for changed turn angles
2017-08-04 12:57:55 +02:00
Moritz Kobitzsch
bbcf343e40
compress traffic signals
...
- handle penalties within edges (not phantom nodes)
- changes model from providing penalties on turns to using additional segments
2017-08-04 11:19:32 +02:00
Moritz Kobitzsch
0affec8f17
handle throughabouts -- do not announce going through
2017-07-26 10:37:20 +02:00
Daniel J. Hofmann
54960f9b5d
Adds lane anticipation Oak St -> Franklin St -> Fell St scenario
2017-07-21 19:04:55 +02:00
Emil Tin
e413b25cd9
profiles api v2
2017-07-18 10:09:22 +00:00
Daniel J. Hofmann
5ece65cade
Trigger lane anticipation based on distance, see discussion in #4260
2017-07-18 11:23:46 +02:00
Moritz Kobitzsch
7b755d6f8b
deprecate use-lane -- the information can be found in the intersections array
2017-07-18 11:23:46 +02:00
Moritz Kobitzsch
30b8225812
only consider allowed entries when continuing on motorways
2017-07-13 08:59:01 +00:00
Moritz Kobitzsch
54530a14e9
add test indicating missdetection of continuing on motorways
2017-07-13 08:59:01 +00:00
Daniel J. Hofmann
5e9397fcca
Canonicalizes all OSM string list handling in the profiles
2017-07-12 22:09:01 +00:00
Moritz Kobitzsch
4c7aa8f1c0
only consider narrow turns onto through streets straight
2017-07-04 22:03:04 +00:00
Moritz Kobitzsch
2522f70f86
add test case illustrating 4205
2017-07-04 22:03:04 +00:00
Daniel J. Hofmann
ba2a0b3566
Adds more exits cucumber scenarios
2017-07-04 20:58:19 +00:00
Daniel J. Hofmann
7d900e3b5a
Implements Exit Numbers + Names (junction:ref
way tag for now)
2017-07-04 20:58:19 +00:00
Moritz Kobitzsch
d660c1609c
don't collapse u-turns into combined turns
2017-06-30 09:25:03 +00:00
Michael Krasnyk
74bc8966a8
Test case with incorrect u-turn collapsing
...
http://map.project-osrm.org/?z=18¢er=52.169237%2C10.032722&loc=52.168628%2C10.030759&loc=52.168707%2C10.030952&loc=52.168457%2C10.030432&hl=en&alt=0
2017-06-30 09:25:03 +00:00
Michael Krasnyk
9d8a3e3c97
Propagate lane data across traffic lights
2017-06-29 15:10:37 +00:00
Michael Krasnyk
a308b86056
Test case for #4189
2017-06-29 15:10:37 +00:00
Michael Krasnyk
df4f0d043a
Added driveway handler
2017-06-29 15:07:32 +00:00
Daniel J. Hofmann
df000debe9
Adapts obvious turn classification: no longer take entry_allowed into account, resolves #3987
2017-06-21 18:09:32 +02:00
Daniel J. Hofmann
31511416ed
Adds a failing test case for obvious turn at the end of the road, see #3987
2017-06-21 18:09:32 +02:00
Michael Krasnyk
03e83ec6a0
Fix invalid roundabout instructions for different driving modes, #4129
2017-06-08 15:01:27 +00:00
Michael Krasnyk
9315dc1c73
Test for a roundabout with footway exits, #4129
2017-06-08 15:01:27 +00:00
Moritz Kobitzsch
a92674022a
make all u-turns continue
2017-06-01 12:39:10 +02:00
Moritz Kobitzsch
ceaf065d0e
don't collapse highway ramps into uturns ( #4074 )
2017-06-01 12:39:10 +02:00
Moritz Kobitzsch
9bd2b0deaa
fix invalid turn angle in forks
2017-06-01 11:43:18 +02:00
Michael Krasnyk
dd009322de
Remove roundabout skip as no leavesRoundabout steps after postProcess
2017-06-01 11:13:31 +02:00
Michael Krasnyk
5d4ab4100a
Test for collapsing sliproads after crossing a roundabout, #4100
2017-06-01 11:13:31 +02:00
Michael Krasnyk
1d26deb0be
Allow counting of service exits on service roundabouts, see #4075
2017-05-23 18:27:47 +00:00
Michael Krasnyk
ac35757616
[skip ci] Adjust CHANGELOG and the test description
2017-05-23 14:35:23 +02:00
Michael Krasnyk
47f2f17987
Change order of guidance post-processing, fix #4030
2017-05-23 14:35:23 +02:00
Michael Krasnyk
14582fea5f
Added example for roundabout overlapping
2017-05-22 09:33:59 +00:00
Michael Krasnyk
19494984eb
Fix incorrect exit turn invalidation
2017-05-02 16:55:03 +00:00
Michael Krasnyk
dea3144c4d
Use total angle for turn instruction if entry step has large distance
2017-04-12 23:22:44 +00:00
Patrick Niklaus
4e9e2ed5bd
Emit a notification when turning on a ferry and don't merge step
2017-04-07 15:29:53 +00:00
Moritz Kobitzsch
e0593c7ca2
add failing test for 3762
2017-04-07 15:29:53 +00:00
Moritz Kobitzsch
6c3390f14d
refactor of post-processing
...
- moves collapse into a dedicated set of functions / files
- make collapse scenarios distinct (slight performance cost)
- reduce verbosity for short name segments (now actually working, was supposed to do so before)
2017-02-25 12:17:22 +00:00
Moritz Kobitzsch
8d83c3adbb
add locations to turn scenarios
...
start assigning turn locations to test / further locations
add locations/make roads not overlapping - staggered
larger grid size for utf tests (new name)
2017-02-25 12:17:22 +00:00
Moritz Kobitzsch
03bb6dc161
reduce verbosity of use-lane in combination with lane-anticipation
2017-02-15 21:57:48 +00:00
Moritz Kobitzsch
e4d500f451
fix handling none-tags in presence of multiple turns within
2017-02-13 10:55:40 +00:00
Moritz Kobitzsch
d52ea86cb9
add failing test
2017-02-13 10:55:40 +00:00
Moritz Kobitzsch
c7640903c3
don't emit invalid turns when having u-turns on ferries
2017-01-26 13:08:00 +01:00
Moritz Kobitzsch
b5e289adc3
3605 - fix error in treating end-of-road as choiceless ( #3607 )
2017-01-24 11:23:54 -08:00
Michael Krasnyk
e8167b2e4e
Use round for float to fixed coordinate transformations
2017-01-20 12:31:45 +01:00
Moritz Kobitzsch
6b06c5bd32
fix emitting invalid turn types, now surfacing due to changes in obvious detection
2017-01-18 15:56:48 +01:00
Daniel J. Hofmann
fd57c5b48b
Supports destination:street, resolves #3541
2017-01-13 11:07:01 +05:30
Moritz Kobitzsch
c1f833c80f
fix forks exiting a ferry
2017-01-12 09:58:51 +01:00
Moritz Kobitzsch
06ef3053de
fix coordinate assertion for walking profile with steps
2017-01-11 22:44:23 +01:00
Daniel J. Hofmann
b3483f95a7
Fixes Sliproads onto a roundabout to be classified as sliproads, resolves #3540
2017-01-09 17:46:05 +01:00
Moritz Kobitzsch
32f63e5e0c
add tests for dedicated turn roads
2017-01-09 17:46:05 +01:00
Moritz Kobitzsch
15c8fd326f
Remove assertions that could be triggered by bad data. ( #3469 )
...
When two consecutive nodes have identical coordinates, there is no valid
bearing. For now, make equal nodes have bearing 0.
Full fix still needs to be done via https://github.com/Project-OSRM/osrm-backend/issues/3470 .
2017-01-06 17:10:02 -08:00
Daniel J. Hofmann
b5d5f309a3
Consider number of lanes to cross, resolves #3025 .
...
Lane Anticipation currently triggers on quick steps with lanes. This
changeset makes the "quick" part more dynamic by taking lanes left and
right of the turn into account. The reasoning for this is as follows.
The user can drive on the leftmost or rightmost lane and has to cross
all lanes left or right of the turn, respecitvely.
We scale our threshold appropriately, which now means the threshold
describes the duration the user needs for crossing _a single lane_.
Note: this is a heuristic and assumes the worst case. Which in my
opinion is fine to do since triggering Lane Anticipation in complex
scenarios is desirable.
2017-01-06 12:44:40 +01:00
Moritz Kobitzsch
e6ff17ab2a
refactor merging of segregated roads
...
adjust to generalFindMaximum function
moved parallel detection to ratio/absolute based regression testing
considerably improved detection quality using normalised regression lines
only follow initial direction/narrow turns for parallel detection
2017-01-03 12:32:51 +01:00
Moritz Kobitzsch
b9b52cb857
clean-up unused headers, use NoTurn for ferries instead of suppressed
2016-12-23 15:01:02 +01:00
karenzshea
8ffe915395
do not emit turns on ferries
2016-12-23 15:01:02 +01:00
Moritz Kobitzsch
0a2f934c87
add test for falsely classified obvious turn ( #3364 )
2016-12-20 11:55:10 -08:00
Moritz Kobitzsch
f04d146ca3
improve ascii art reflecting tunnels
2016-12-19 09:57:34 +01:00
Kajari
8c50a42ec4
add ascii art to a set of tests
2016-12-19 09:57:05 +01:00
Moritz Kobitzsch
d584bcad11
fix roundabout handling with lanes
...
instead of artificially removing lanes from a roundabout, we don't assing them in the first place.
this also prevents a problem where we would end up collapsing turns with lanes in a roundabout
2016-12-15 13:07:26 +01:00
Daniel J. Hofmann
e48ca65af4
Advanced Roundabouts
...
These kind of roundabouts came up during Lane Handling for roundabouts.
They're called Turbo-roundabouts or Turbine-roundabouts and are very
popular e.g. in Germany and the UK.
Seems like our roundabout handler sometimes is getting confused.
Trying to figure out why, and codifying some scenarios for cucumber.
References:
- https://github.com/Project-OSRM/osrm-backend/pull/2693
2016-12-15 13:07:26 +01:00
Daniel Patterson
1b51163b1d
Clarify API and ensure bearings returned to users are in the range 0-359
2016-12-15 10:59:17 +01:00
Daniel J. Hofmann
875f482203
Refactors and improves the Sliproad Handler, resolves #3109
2016-12-07 19:22:03 +01:00
Moritz Kobitzsch
a28a20a1ba
fix errors in coordinate extractor due to duplicated coordinates
...
fix offset calculation in curve detection
2016-12-07 11:33:58 +01:00
Moritz Kobitzsch
561b7cc58e
Rember Intersection Shapes
...
Changes the processing order in the edge based graph factory.
Instead of iterating over all outgoing edges in order, we compute the edge
expanded graph in the order of intersections.
This allows to remember intersection shapes and re-use them for all possible ingoing edges.
Also: use low accuracry mode for intersections degree 2 intersections
We can use lower accuracy here, since the `bearing`
after the turn is not as relevant for off-route detection.
Getting lost is near impossible here.
2016-12-01 15:24:20 +01:00
Moritz Kobitzsch
5775679f64
fix coordinate extraction / errors in offset detector
2016-12-01 12:16:25 +01:00
Karen Shea
ef087f963d
Merge pull request #3324 from Project-OSRM/constrain-staggering
...
Constrain staggered intersection detection by mode change and intermediary intersections
2016-11-30 07:35:17 -05:00
Moritz Kobitzsch
a1127c3e09
reduce numbers of intersections in findNextIntersection, don't normalise for turn lanes
2016-11-30 10:21:53 +01:00
Daniel J. Hofmann
fe5cc55b0e
support junction = circular in all profiles, add additional tests
...
References:
- https://wiki.openstreetmap.org/wiki/Tag:junction%3Dcircular
- https://lists.openstreetmap.org/pipermail/tagging/2016-November/030520.html
- https://github.com/Project-OSRM/osrm-backend/issues/3361
2016-11-29 13:44:32 +01:00
Moritz Kobitzsch
12d58ace10
add support for junction=circular, allowing named circular junctions to be treated as rotaries
2016-11-29 13:44:32 +01:00
Moritz Kobitzsch
186cc8340a
handle service roads next to roundabouts - ambiguous exit... :(
2016-11-29 11:47:35 +01:00
karenzshea
0bd08224bf
add comments, refactor find obvious turn
2016-11-21 13:16:30 -05:00
karenzshea
6ba36a2bc7
test and control for pushing both ways
2016-11-18 10:13:38 -05:00
karenzshea
039989a339
fix overlapping roads
2016-11-18 09:58:03 -05:00
karenzshea
a7559077a0
add modes columns to bike tests
2016-11-18 09:21:48 -05:00
Daniel J. Hofmann
bbe80192aa
Staggered Intersections for Bike
2016-11-18 08:52:48 -05:00
karenzshea
9b16b757a4
halfway staggered intersection test
2016-11-18 08:52:48 -05:00
karenzshea
3680fc9d90
add check/test for intermediary intersections
2016-11-18 08:52:47 -05:00
karenzshea
836e8bdff0
don't collapse with mode changes
2016-11-18 08:52:47 -05:00
Moritz Kobitzsch
78583d2c8c
fix getTurnDirection, widen straight
range, adjust tests accordingly
2016-11-14 11:09:14 +01:00
Moritz Kobitzsch
e84a0ea37c
reduce coordinate_extraction overhead. slowdown reduced by 30 percent
2016-11-10 10:44:54 +01:00