Daniel Patterson
649d4ee512
Add support for the 'straight' maneuver direction ( #4995 )
...
Add support for the 'straight' maneuver direction
2018-04-03 17:20:18 -07:00
Duane Gearhart
8a63ad9b4b
Added post process logic to collapse segregated turn instructions ( #4925 )
...
* Added post process logic to collapse segregated turn instructions
* format updates
* Fixed coordinates to reflect reality
Updated left turn road name
* fixed coordinates to fix test
* Skip last step when processing segregated steps
* updated segregated turn test
* Updated segregated test
* Updated test: Segregated Intersection, Cross Belonging to Correct Street - features/guidance/collapse.feature:79
* Fixed all but one for features/guidance/collapse.feature:124
* Fixed Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219
* Fixed 7 of th 9 failures for Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219
* Fixed 7 of the 9 failures for Scenario: Segregated Intersection, Cross Belonging to Mixed Streets - Slight Angles (2) - features/guidance/collapse.feature:318
* Fixed Scenario: Segregated Intersection into Slight Turn - features/guidance/collapse.feature:581
* Updated Scenario: U-turn after a traffic light - features/guidance/turn-lanes.feature:1220
* Updated how we combine segregated steps
* Added test to Verify end of road left turn across divided roads
* Fixed divided highwat tests
* Fixed test failure
* fixed Scenario: Partitioned turn, Slight Curve - maxspeed - features/guidance/turn-lanes.feature:936
* Fixed Scenario: Partitioned turn, Slight Curve - features/guidance/turn-lanes.feature:961
* Added strategies to combine segrgated intersections
* Added setModifier alias for readability
* Added strategies to combine segrgated intersections
* Format updates
* Fixes segregated indentification to not mark `circular` edge as segregated
* Added intersection prior to turn so we still call out end of road
* updated expectation to be turn instead of continue
* Confirmed with @oxidase that the lane information if correct - updated the expectation
* Added logic to handle wider straights
Fixed tests
* Update CHANGELOG.md
Added #4925
* Removed TODO
* Process straight step prior to wider straight step
2018-03-30 07:43:56 -04:00
Patrick Niklaus
3ee8a963cb
Fix formating again
2018-03-26 12:13:07 +00:00
Patrick Niklaus
c322d93435
Make the block size of vector<bool> consistent
2018-03-26 12:12:41 +00:00
Patrick Niklaus
c0dd5d7c76
Fix formating
2018-03-26 11:02:34 +00:00
Patrick Niklaus
f2bace6c1f
Wrap lambda in std::function because of boost version issues
2018-03-26 11:02:33 +00:00
Patrick Niklaus
921235b2dc
Use pair instead of tuple for implicit construction
2018-03-26 11:02:33 +00:00
Patrick Niklaus
bde51a9ef5
Add tar file mmaping
2018-03-26 11:02:33 +00:00
Patrick Niklaus
a52213c885
Get offset of data inside tar file
2018-03-26 11:02:33 +00:00
Patrick Niklaus
c410c200bd
Port .cnbg file to tar format
2018-03-26 11:02:33 +00:00
Patrick Niklaus
8152dcfb4c
Port .ramIndex to tar file and mmap .fileIndex directly
2018-03-26 11:02:33 +00:00
Patrick Niklaus
bed53f5fd5
Remove timestamp file
2018-03-26 11:02:31 +00:00
Patrick Niklaus
2b010fc6f3
Port .enw file to tar format
2018-03-26 11:02:04 +00:00
Patrick Niklaus
b8260e44fa
Port .names file to tar
2018-03-26 11:02:04 +00:00
Patrick Niklaus
a594008e57
Port .edges file to tar
2018-03-26 11:02:04 +00:00
Patrick Niklaus
f407afa694
Move .osrm file to tar format
2018-03-26 11:02:04 +00:00
Patrick Niklaus
06f28ffd34
Add BufferWriter/BufferReader and simplify interface for ConditionalRestrictions
2018-03-26 11:02:04 +00:00
Patrick Niklaus
990e411361
Port turn duration penalties to tar
2018-03-26 11:02:04 +00:00
Patrick Niklaus
73b3d37837
Port maneuver overrides to tar
2018-03-26 11:02:04 +00:00
Patrick Niklaus
5d7d5fceba
Port .tld and .tls data
2018-03-26 11:02:04 +00:00
Patrick Niklaus
b1dfbce675
Port .ebg_nodes to tar file
2018-03-26 11:02:04 +00:00
Patrick Niklaus
da5aebaef3
Port .geometry file to tar format
2018-03-26 11:02:04 +00:00
Patrick Niklaus
bced9a5a6d
Port .datasource_names to tar format
2018-03-26 11:02:04 +00:00
Patrick Niklaus
6ea296fb5c
Port .nbg_nodes file to tar
2018-03-26 11:02:04 +00:00
Patrick Niklaus
cf5f6be472
Swtich EBG to tar file
2018-03-26 11:02:04 +00:00
Patrick Niklaus
c61198b26b
Port over profile properties
2018-03-26 11:02:04 +00:00
Patrick Niklaus
5d1b4ce71d
Port .osrm.icd file over to tar
2018-03-26 11:02:03 +00:00
Patrick Niklaus
cb31f9ec29
Port hsgr file to tar
2018-03-26 11:02:03 +00:00
Patrick Niklaus
fed77c4066
Port cell metrics to tar files
2018-03-26 11:02:03 +00:00
Patrick Niklaus
15b53de056
Switch over partition/ files to tar format
2018-03-26 11:02:03 +00:00
Patrick Niklaus
6d96a9a2e3
Serialize mldgr using the new tar writer
2018-03-26 11:02:03 +00:00
Duane Gearhart
535bb49893
Fixed segregated identification code to not mark circular edges as segregated
2018-03-21 18:02:26 +01:00
Michael Krasnyk
8b52c6c7ac
Update tests expectations and obvious detection
2018-03-20 16:33:15 +01:00
Michael Krasnyk
d166fc6a75
Restructure Obvious Turn Handling, code transfer from #4426
2018-03-20 16:33:15 +01:00
Patrick Niklaus
b80764b6b8
Refactor shared memory layout to expose Block as interface
2018-03-14 17:05:55 +01:00
Frédéric Rodrigo
14082d0e00
Fix typo 'Maximum number of classes if'
2018-03-14 03:16:13 +01:00
Michael Krasnyk
b7af6eb2a4
Remove correctly the last segment in annotation
2018-03-09 15:59:21 +01:00
Michael Krasnyk
0fc8b6289c
Merge IntersectionShapeData and IntersectionEdgeGeometry
2018-03-05 13:19:57 +01:00
Michael Krasnyk
4d0fb89489
Adjust Straight direction modifiers of side roads in driveway handler
2018-03-05 13:19:57 +01:00
Michael Krasnyk
6f4af330ed
Handle oneways in get_forward_backward_by_key
2018-03-05 13:19:57 +01:00
Michael Krasnyk
7c8c25f7bc
Don't use obviousness for links bifurcations
2018-03-05 13:19:57 +01:00
Lev Dragunov
ac23e3b223
clang-format
2018-03-01 11:32:18 +01:00
Lev Dragunov
7922a6172a
Bearing calculation on matching short segments fix.
2018-03-01 11:32:18 +01:00
Michael Krasnyk
c048a36a4c
Use smaller range for U-turn angles in map-matching
2018-02-28 15:21:47 +01:00
Duane Gearhart
33021d37a1
Updated segregated intersection identification ( #4845 )
...
* Initial internal intersection updates
paired with @oxidase and @kdiluca
TODO fix tests and add in new ones
* Added Internal Intersection Model
* removed debug info
* updates per PR 4845
* fixing build errors
* fixing all compile errors
* fixed EdgeID param
* Added is_internal_straight lambda
Added/Updated constexpr names and values
* added rejection case turn degree logic
* debug logging
* added turn angle logic to reject if there are incoming edges that have opposite turn degrees than outgoing edges or if the outgoing edges have opposing turn degrees; also merged with master v5.16
* fixed formatting
* fix to decrease tile size based on latest turn angle internal intersection updates
* Removed breaks
Breaks in code were a mistake and caused a change in the internal intersection identification.
* Update segregated_intersection_classification.cpp
* Update CHANGELOG.md
Added CHANGED #4845 : Updated segregated intersection identification to Unreleased
2018-02-27 15:11:23 -05:00
Patrick Niklaus
31d6d74f90
Update documentation and changelog
2018-02-26 23:32:34 +01:00
Patrick Niklaus
bec57258a4
Add mmap allocator
2018-02-26 23:32:34 +01:00
Michael Krasnyk
83588fd00f
Renumber node IDs in .osrm.maneuver_overrides
2018-02-22 11:42:33 +01:00
Michael Krasnyk
5acf660f37
Check required tags of maneuver relations
2018-02-21 14:49:15 +01:00
Michael Krasnyk
de13834c12
Handle motorway forks with links as a normal motorway ...
...
passing some ramps or mering onto another motorway
2018-02-21 14:19:53 +01:00
Michael Krasnyk
1cafafc4cd
Don't use obvious directions at ramp bifurcations, #4895
2018-02-20 09:02:24 +01:00
Michael Krasnyk
519eae63c6
Use links with lower priority in the motorway handler
...
Ref:
https://wiki.openstreetmap.org/wiki/Highway_link
https://wiki.openstreetmap.org/wiki/Link_roads_between_different_highways_types
2018-02-13 11:20:27 +01:00
Michael Krasnyk
5f598da76d
Add OSM node barrier=height_restrictor handling
2018-02-12 11:40:35 +01:00
Patrick Niklaus
e82b51d0cb
Fix default value for matching radius in routed
2018-02-09 21:12:14 +01:00
Daniel Patterson
5531cace7f
Support maneuver relations ( #4676 )
2018-02-10 05:32:09 +11:00
Patrick Niklaus
26e5c4eae2
Fix formating
2018-02-09 17:51:58 +01:00
Patrick Niklaus
6c2d26f9bd
Make LUA_SOURCE a global for gcc 4.9
2018-02-09 17:51:58 +01:00
Patrick Niklaus
84845ffaa6
Replace optional<EdgeWeight> with constant value
2018-02-09 17:51:58 +01:00
Patrick Niklaus
3d6b667997
No unused warning for alias benchmark
2018-02-09 17:51:58 +01:00
Patrick Niklaus
97d027a173
Fix unused lambda capture warnings
2018-02-09 17:51:58 +01:00
Patrick Niklaus
371dc57dfc
Fix uninitialized warning because of boost::optional
2018-02-09 17:51:58 +01:00
Patrick Niklaus
a06d1782c0
Fix multi-line warning
2018-02-09 17:51:58 +01:00
Huyen Chau Nguyen
fa8d788bb6
Add road priority class to turn function ( #4858 )
...
* expose road priority class to turn function
* update docs
2018-02-07 11:39:02 +01:00
Patrick Niklaus
92b7d581ce
Removed unused geojson logging in partitioner
2018-02-06 11:51:33 +01:00
Patrick Niklaus
b4cfc8d6e0
Fix formating
2018-02-06 11:51:33 +01:00
Patrick Niklaus
71cfb03738
Remove broken check-conditionals tool
2018-02-06 11:51:33 +01:00
Patrick Niklaus
e7bb612050
Move debug printer code to own header
2018-02-06 11:51:33 +01:00
Patrick Niklaus
83d7a57b73
Remove OSM link debug printing from public class
2018-02-06 11:51:33 +01:00
Patrick Niklaus
bb71d9b28a
Remove unused code in partitioner
2018-02-06 11:51:33 +01:00
Michael Krasnyk
9e93f198ae
Add CRC checksums to EBG and turns data
2018-02-02 11:33:38 -05:00
Michael Krasnyk
10de243556
Move guidance turn generation out of EBGF
2018-02-02 11:33:38 -05:00
Michael Krasnyk
988b6e3311
Split intersection analysis and guidance code
...
Intersection analysis occupy in osrm::extractor::intersection namespace
and guidance code osrm::guidance
2018-02-02 11:33:38 -05:00
Michael Krasnyk
36877e4de5
Move guidance pre-processing code into GUIDANCE library
2018-02-02 11:33:38 -05:00
Michael Krasnyk
1794185d43
Refine logging output
2018-02-02 11:33:38 -05:00
Kajari Ghosh
de938df560
remove TurnData from generate_edge function
2018-02-02 11:33:38 -05:00
Kajari Ghosh
e02c5c3c6d
comments
2018-02-02 11:33:38 -05:00
Michael Krasnyk
90ff725125
Duplicate edges and turns generation code
2018-02-02 11:33:38 -05:00
Michael Krasnyk
1cbfbd34cf
Remove unnecessary loading of turns data in updater
2018-02-02 11:33:38 -05:00
Mateusz Loskot
c6d12e064c
Add basic facades for Customizer and Partitioner run methods
2018-02-02 15:52:30 +01:00
Mateusz Loskot
30ed1fae99
Move setting up task_scheduler_init from executables to library
...
Make entry points of individual pipeline stages responsible for
configuring the task scheduler with requested number of threads
passed in corresponding configuration bundle (ie. follow extractor).
2018-02-02 14:34:20 +01:00
Mateusz Loskot
8114104a43
Rename namespace partition to partitioner
...
Rename module partition to partitioner.
This cultivates naming used in existing modules like extractor,
customizer, etc. - noun vs verb (word partition is both though).
2018-02-02 11:07:18 +01:00
Michael Krasnyk
91e6d68604
Increase MAXIMAL_ALLOWED_SEPARATION_WIDTH to 12 meters
...
the check should cover merging of roads at intersections similar
to https://www.openstreetmap.org/node/53020993#map=18/37.86590/-122.25083
2018-02-01 06:21:08 -05:00
Karen Shea
c154875272
Only run step collapsing based on original waypoints parameter ( #4829 )
2018-01-29 12:35:55 -08:00
Michael Krasnyk
77f8a4f741
Set type of trivial intersections where classes change to Suppressed
...
... instead of NoTurn
2018-01-25 11:43:44 -05:00
Huyen Chau Nguyen
61e06fcaba
Making the turn function more flexible ( #4789 )
...
* set and store highway and access classification for the turn function
* expose highway turn classification and access turn classification and speed to the lua profile turn function
* expose whether connection road at turn is incoming or outgoing
* add lua tests for exposed information to turn function
* update docs about attributes in process_turn
* add turn_classification info to docs
* adding warning if uturn and intersection dont match
* handle u turns that do not turn into intersection[0]
* split OSM link generation in an accessible coordinate function
2018-01-24 15:39:55 -05:00
Kajari Ghosh
13bb997525
Revert "Get actual paths for every entry in a matrix."
...
This reverts commit 350bc6f756
2018-01-24 11:52:43 -05:00
Kajari Ghosh
350bc6f756
Get actual paths for every entry in a matrix.
2018-01-24 11:30:26 -05:00
Kajari Ghosh
155772f01f
Refactor isThroughStreet/Intersection options ( #4751 )
...
* refactor isThroughStreet
* refactor HaveIdenticalName
* fix a typo in the unit tests
2018-01-19 13:49:00 -05:00
Michael Krasnyk
341a5345da
Ignore no_*_on_red turn restrictions ( #4804 )
2018-01-19 15:50:54 +01:00
Michael Krasnyk
a8f3474996
Use unsigned type in percent_encoding to prevent overflow for %80..%ff
...
Related fix in Boost.Spirit 80414bc688
2018-01-08 12:09:33 +00:00
karenzshea
55cc06fd8b
Add waypoints parameter to matching service, returns map matching result
...
with selective input coordinates as waypoints
2018-01-08 12:28:20 +01:00
Mateusz Loskot
5b2af6ef09
Restore use of user-provided osmium: 🧵 :Pool instance
...
Pool instance has been removed from Reader ctor parameters
list in PR #4438 , presumably unintentionally.
It is required to prevent potential deadlock during
Pool shutdown as explained in PR #4452 .
2018-01-07 18:29:43 +01:00
Michael Krasnyk
17eb7052ba
Make distance_between_roads symmetrical
2018-01-05 17:35:11 +01:00
Michael Krasnyk
08b88bad63
Still use low precision bearings
2018-01-05 17:35:11 +01:00
Michael Krasnyk
153f9b02a5
Add low precision intersection views back
2018-01-05 17:35:11 +01:00
Michael Krasnyk
0568dca4a3
Adjust to review findings
2018-01-05 17:35:11 +01:00
Michael Krasnyk
60ef179d18
Remove handling of U-turns on motorways
2018-01-05 17:35:11 +01:00
Michael Krasnyk
c64904f5ea
Move roads re-ordering to convertToIntersectionView
2018-01-05 17:35:11 +01:00
Michael Krasnyk
4b9e3a8068
Remove IntersectionGenerator
2018-01-05 17:35:11 +01:00
Michael Krasnyk
db7c76d04d
Remove GetConnectedRoads from IntersectionGenerator
2018-01-05 17:35:11 +01:00
Michael Krasnyk
cc1a5ea78d
Remove usage of IntersectionGenerator in EBGF
2018-01-05 17:35:11 +01:00
Michael Krasnyk
9c033ff461
Free functions for guidance intersections analysis
2018-01-05 17:35:11 +01:00
Mateusz Loskot
da4fb13aa3
Tidy up #include-s for Intel TBB headers
...
Remove unused and add missing headers.
2018-01-05 11:00:31 +01:00
Michael Krasnyk
a5353c7179
Use consistent EBG node weights in duplicated via nodes
2018-01-02 14:26:35 +01:00
Michael Krasnyk
3dec680058
Remove check unnamed check in sliproad handler
2017-12-26 16:18:27 +01:00
Patrick Niklaus
12d1d84b11
Add test case for sliproads converted from forks
2017-12-26 16:18:27 +01:00
Patrick Niklaus
e45d44cb8e
Make sure we only count turns as UTurns for the turn_function
2017-12-26 13:28:12 +00:00
Kajari Ghosh
84b6ef4340
add osrm-routed and node-osrm flags to configure mapmatching radius limit ( #4721 )
2017-12-20 16:53:43 +05:30
Patrick Niklaus
ccfbce5300
Remove superflous sentinel in DynamicGraph, fixes #4738
2017-12-18 10:23:29 +00:00
karenzshea
9a8ed30e95
add assert for untested sliproad cases, removed redundant empty_nameid checks
2017-12-11 15:37:56 +00:00
karenzshea
4166b1ebbf
check for empty on string_ref, rather than string itself
2017-12-11 15:37:56 +00:00
karenzshea
89080fb2b0
check for empty name_id before getting data
2017-12-11 15:37:56 +00:00
karenzshea
56459d37d1
access way names through RouteStep in post processing
2017-12-11 15:37:56 +00:00
karenzshea
d5232d5f5c
check empty name string in roundabout handler
2017-12-11 15:37:56 +00:00
karenzshea
3f7b5da683
check empty name string in turn collapsing
2017-12-11 15:37:56 +00:00
karenzshea
24562acd30
check empty name string in turn handler
2017-12-11 15:37:56 +00:00
karenzshea
8bce061691
check empty name string in sliproad handler
2017-12-11 15:37:56 +00:00
karenzshea
701c5f853d
check empty name string in motorway handler
2017-12-11 15:37:56 +00:00
karenzshea
d1e4ba373a
check empty string name in mergable road detector
2017-12-11 15:37:56 +00:00
karenzshea
8cf8f0d7d6
check empty name string in findBasicTurnType
2017-12-11 15:37:56 +00:00
Patrick Niklaus
2e97c78181
Remove code for checking the .core file, since we do not create it anymore
2017-12-08 11:28:34 +00:00
Patrick Niklaus
994fae0ef6
Fix formating
2017-12-05 19:09:06 +00:00
Patrick Niklaus
88ee51ba2e
const-correctness
2017-12-05 19:09:06 +00:00
Patrick Niklaus
25ee26de3b
Refactor segregated intersection classification to right module
2017-12-05 19:09:06 +00:00
Michael Krasnyk
6fd0b56e32
Don't use removed alternative paths in filterPackedPathsByCellSharing
2017-11-29 13:17:24 +01:00
Michael Krasnyk
7361558c19
Allow single edge paths in MLD alternatives, #4691
2017-11-21 12:28:44 +01:00
vng
8fa98ed27d
Increase max segregated distances.
2017-11-16 15:08:30 +01:00
vng
90e361c3dc
Use immutable node-based-graph for segregated edges.
2017-11-16 15:08:30 +01:00
vng
32e6ccb037
Code review fixes.
2017-11-16 15:08:30 +01:00
vng
92c4a228e1
Revert suppressSegregated routing.
2017-11-16 15:08:30 +01:00
vng
9eae1de9bc
Fixes for segregated length threshold.
2017-11-16 15:08:30 +01:00
vng
76f793533a
Use copressed node-based graph for segregated edges check.
2017-11-16 15:08:30 +01:00
vng
ec7e58e10e
Pass edge-based node segregated flag to the post processing routine.
2017-11-16 15:08:30 +01:00
vng
ac5e095d17
Store and pass segregated flag to the data facade.
2017-11-16 15:08:30 +01:00
vng
ee7912f882
Calculating segregated node-based edges.
2017-11-16 15:08:30 +01:00
Denis Koronchik
f460a9f17e
Add code to draw segregated nodes in a tile layer
2017-11-16 15:08:30 +01:00
Daniel Patterson
5b58445535
Expose driving_side as a property on RouteStep
2017-11-09 10:08:11 -05:00
Michael Krasnyk
5b79640b44
Don't compute new modifier for merge instructions in collapsing
2017-11-08 11:26:47 -05:00
Daniel J. Hofmann
9b83649a03
Fixes AppVeyor tests
2017-11-06 14:38:21 -05:00
Daniel J. Hofmann
aed7bd852d
Prints turn types and modifiers as strings
2017-11-06 14:38:21 -05:00
Daniel J. Hofmann
c5b48e3506
Adds a statistics handler for turn types and modifiers
2017-11-06 14:38:21 -05:00
Kajari Ghosh
73f4e1d45a
update changelog
2017-11-06 13:34:02 -05:00
Kajari Ghosh
cbc96ec492
refactor ExtractionTurn and ProcessTurn c++ code
2017-11-06 13:34:02 -05:00
Denis Koronchik
0fc6903d7e
Fix issue #4585
2017-10-25 14:11:33 +02:00
Moritz Kobitzsch
23fd27422b
normalise angles only if an improvement
2017-10-25 10:17:14 +02:00
Moritz Kobitzsch
910ee0829f
make circular detection covered again
2017-10-23 09:06:59 +02:00
Moritz Kobitzsch
704cf314d4
explicitly check for 90 degree turns / turning onto segregated roads
2017-10-23 09:06:59 +02:00
Moritz Kobitzsch
b8651bfac9
do not merge segregated highways in if there is actual turns involved
2017-10-23 09:06:59 +02:00
Patrick Niklaus
a8de007d98
Rename locations-cache -> location-cache
2017-10-20 15:55:23 +01:00
Patrick Niklaus
27a9603b98
Change --use-location-cache=false to --disbale-location-cache
2017-10-20 15:55:23 +01:00
