Michael Krasnyk
b56a7579a8
Review updates
2018-03-20 16:33:15 +01:00
Michael Krasnyk
8b52c6c7ac
Update tests expectations and obvious detection
2018-03-20 16:33:15 +01:00
Michael Krasnyk
d166fc6a75
Restructure Obvious Turn Handling, code transfer from #4426
2018-03-20 16:33:15 +01:00
Huyen Chau Nguyen
bdb116afe5
Fix wrong one-way identification in the bike profile
...
* upgrade to api version 4
* set bike pushing speed to 4km/h and add mode change penalty
* set cycleways for two-way and one-way roads according correctly
* add changelog
* adjust tests according to change of the walking speed
* adjust tests according to new behaviour of opposite, track and lane in one-ways
* refactor the cycleway identification
* comment to understand weird counterintuitive testcase
* adjust sliproad test because walking speed is now slower
2018-03-19 16:02:25 +01:00
Michael Krasnyk
4d0fb89489
Adjust Straight direction modifiers of side roads in driveway handler
2018-03-05 13:19:57 +01:00
Michael Krasnyk
6f4af330ed
Handle oneways in get_forward_backward_by_key
2018-03-05 13:19:57 +01:00
Duane Gearhart
33021d37a1
Updated segregated intersection identification ( #4845 )
...
* Initial internal intersection updates
paired with @oxidase and @kdiluca
TODO fix tests and add in new ones
* Added Internal Intersection Model
* removed debug info
* updates per PR 4845
* fixing build errors
* fixing all compile errors
* fixed EdgeID param
* Added is_internal_straight lambda
Added/Updated constexpr names and values
* added rejection case turn degree logic
* debug logging
* added turn angle logic to reject if there are incoming edges that have opposite turn degrees than outgoing edges or if the outgoing edges have opposing turn degrees; also merged with master v5.16
* fixed formatting
* fix to decrease tile size based on latest turn angle internal intersection updates
* Removed breaks
Breaks in code were a mistake and caused a change in the internal intersection identification.
* Update segregated_intersection_classification.cpp
* Update CHANGELOG.md
Added CHANGED #4845 : Updated segregated intersection identification to Unreleased
2018-02-27 15:11:23 -05:00
Michael Krasnyk
5acf660f37
Check required tags of maneuver relations
2018-02-21 14:49:15 +01:00
Michael Krasnyk
de13834c12
Handle motorway forks with links as a normal motorway ...
...
passing some ramps or mering onto another motorway
2018-02-21 14:19:53 +01:00
Michael Krasnyk
49811e1f46
Test case for a highway fork with a link
2018-02-21 14:19:53 +01:00
Michael Krasnyk
1cafafc4cd
Don't use obvious directions at ramp bifurcations, #4895
2018-02-20 09:02:24 +01:00
Michael Krasnyk
e2c1956aa5
Test for a ramp bifurcation obviousness
2018-02-20 09:02:24 +01:00
Michael Krasnyk
519eae63c6
Use links with lower priority in the motorway handler
...
Ref:
https://wiki.openstreetmap.org/wiki/Highway_link
https://wiki.openstreetmap.org/wiki/Link_roads_between_different_highways_types
2018-02-13 11:20:27 +01:00
Daniel Patterson
5531cace7f
Support maneuver relations ( #4676 )
2018-02-10 05:32:09 +11:00
Michael Krasnyk
1119a542d6
Announce reference change if names are empty, #4830
2018-01-29 16:32:59 -05:00
Michael Krasnyk
d706696179
Test case for ref changes with empty names, #4830
2018-01-29 16:32:59 -05:00
Michael Krasnyk
77f8a4f741
Set type of trivial intersections where classes change to Suppressed
...
... instead of NoTurn
2018-01-25 11:43:44 -05:00
Michael Krasnyk
cc1a5ea78d
Remove usage of IntersectionGenerator in EBGF
2018-01-05 17:35:11 +01:00
Michael Krasnyk
3dec680058
Remove check unnamed check in sliproad handler
2017-12-26 16:18:27 +01:00
Michael Krasnyk
9237430be2
Test for sliproads to roads with empty names
2017-12-26 16:18:27 +01:00
Patrick Niklaus
12d1d84b11
Add test case for sliproads converted from forks
2017-12-26 16:18:27 +01:00
Patrick Niklaus
6dd029e6ea
Restore original intend of roundabout test
...
When doing the new Lua version refactor we changed the expectation to
use `continue uturn` instead of making a whole circle in the roundabout
as the original test case. This was only the shortest path since there
was no roundabout penalty.
2017-12-26 13:28:12 +00:00
karenzshea
8cf8f0d7d6
check empty name string in findBasicTurnType
2017-12-11 15:37:56 +00:00
Daniel J. Hofmann
978350c388
Adds cucumber test for continue not taking ref into account when name is empty
2017-12-11 15:37:56 +00:00
vng
92c4a228e1
Revert suppressSegregated routing.
2017-11-16 15:08:30 +01:00
vng
ec7e58e10e
Pass edge-based node segregated flag to the post processing routine.
2017-11-16 15:08:30 +01:00
vng
37685dae73
Added segregated test #4273 .
2017-11-16 15:08:30 +01:00
Daniel Patterson
5b58445535
Expose driving_side as a property on RouteStep
2017-11-09 10:08:11 -05:00
Michael Krasnyk
5b79640b44
Don't compute new modifier for merge instructions in collapsing
2017-11-08 11:26:47 -05:00
Michael Krasnyk
921471a153
Test of merging onto a motorway with junction references
2017-11-08 11:26:47 -05:00
Kajari Ghosh
002da129c8
update tests
2017-11-06 13:34:02 -05:00
Moritz Kobitzsch
e197dae54d
do not consider empty-names + empty-refs a valid name for u-turns
2017-11-01 14:25:07 +00:00
Moritz Kobitzsch
4bf3c97476
add test-case illustrating misuse of names in collapse
2017-11-01 14:25:07 +00:00
Moritz Kobitzsch
23fd27422b
normalise angles only if an improvement
2017-10-25 10:17:14 +02:00
Moritz Kobitzsch
e965cf12f8
add testcase illustrating changes to angle adjustments
2017-10-25 10:17:14 +02:00
Moritz Kobitzsch
910ee0829f
make circular detection covered again
2017-10-23 09:06:59 +02:00
Moritz Kobitzsch
b8651bfac9
do not merge segregated highways in if there is actual turns involved
2017-10-23 09:06:59 +02:00
Moritz Kobitzsch
bf28e40ba6
add further tests for segregated roads
2017-10-23 09:06:59 +02:00
Moritz Kobitzsch
37774a331a
fix collapsing into uturns, that aren't u-turns
2017-10-17 15:08:29 +01:00
Moritz Kobitzsch
8719821363
test-case illustrating changes to collapsing
2017-10-17 15:08:29 +01:00
Michael Krasnyk
088d4edc6b
Prevent merging of circular-shaped roads
2017-10-17 11:27:09 +02:00
Michael Krasnyk
bf03dcd1e6
Test case of merging roundabout-like intersections
2017-10-17 11:27:09 +02:00
Moritz Kobitzsch
884ce4025b
fix detection of suffix/prefix changes for name-changes
2017-10-11 14:07:35 +02:00
Michael Krasnyk
837dba2191
Don't use sliproad scenario if two name announcements are required
2017-10-09 15:35:26 +01:00
Michael Krasnyk
a7ea6e5327
Allow a single intersection in a cross-road of sliproads, #4348/3
2017-10-09 15:35:26 +01:00
Michael Krasnyk
38ab22ee7c
Sliproad case with a single intersection in a cross-road
2017-10-09 15:35:26 +01:00
Michael Krasnyk
a900f5229e
Fix case for sliproads from link via link to primary, #4348/4
2017-10-04 23:23:55 +02:00
Michael Krasnyk
de72a8adb6
Test case for sliproads from link via link to primary, #4348/4
2017-10-04 23:23:55 +02:00
Michael Krasnyk
de942155bf
Add local left_hand_driving flag in API version 2
2017-10-04 10:03:42 +02:00
Daniel J. Hofmann
d7bcafcb59
Uses parsed len(turn:lanes) to fixup number of lanes, resolves #4472
2017-09-28 00:24:14 +02:00
