Moritz Kobitzsch
3b81b39998
turn lane handler moved to scenario based handling
2016-09-07 12:16:59 +02:00
Moritz Kobitzsch
802b93fa9a
fix testcases, one case only works by turn restriction, needs investigation
2016-09-07 12:04:17 +02:00
Moritz Kobitzsch
a0ed70f0a2
don't detect sliproads at wrong locations, don't emit invalid instructions
2016-09-06 09:01:06 +02:00
Moritz Kobitzsch
d3a6b5a77e
detect broken roundabout-taggings
2016-09-05 16:49:57 +02:00
Moritz Kobitzsch
f7265892ed
correctly detect loss of prefix/suffix
2016-09-05 15:03:21 +02:00
Moritz Kobitzsch
be266c7c2b
fix copy-paste typo in guidance lib
2016-09-05 15:00:42 +02:00
Moritz Kobitzsch
5d79e0ac2f
catch infinite loops
2016-09-05 14:52:13 +02:00
Moritz Kobitzsch
7528b27f99
mark broken case todo
2016-09-05 11:50:36 +02:00
Daniel Patterson
a4f9499305
Invalid string values in lanes:psv:backward should result in 0 lanes,
...
not `nil`.
2016-09-04 14:23:43 -07:00
Daniel J. Hofmann
bb244e28bb
Adds a failing test case for 255 unicode code points
...
The OSM spec says "up to 255 full unicode chars", so we should be able
to handle 255 x 🐼 --- but we don't.
The internal limit is on 255 _bytes_ in the `std::string`, but there can
be up to four bytes in a utf8 encoded code point.
References:
- http://wiki.openstreetmap.org/wiki/API_v0.6#Tags
- http://www.fileformat.info/info/unicode/char/1f43c/browsertest.htm
- https://en.wikipedia.org/wiki/UTF-8#Description
2016-09-02 16:10:32 +02:00
Moritz Kobitzsch
6fac14dbd8
ignore invalid only_* restrictions
2016-09-01 09:14:01 +02:00
karenzshea
146eb3a20e
add test case for ignoring unknown restrictions
2016-08-31 09:52:05 -04:00
Patrick Niklaus
315823cce1
Use service tag to penaltize alleys and forbid emergency access
2016-08-29 14:15:22 +02:00
Moritz Kobitzsch
d06eec5e42
improve segregated road detection
2016-08-24 10:34:07 +02:00
Moritz Kobitzsch
9648821a79
handle missing cases, cleaning up
2016-08-24 10:34:07 +02:00
Moritz Kobitzsch
6a2518c0df
handle stronger merge cases as well
2016-08-24 10:34:07 +02:00
Moritz Kobitzsch
7886d06839
adjust angles pre-merge as well
2016-08-24 10:34:07 +02:00
Moritz Kobitzsch
b6c3d1d5bf
Cucumber Scenario for #2725
2016-08-24 10:34:07 +02:00
Moritz Kobitzsch
9b2f6585fb
handle non-through case
2016-08-24 10:12:27 +02:00
Moritz Kobitzsch
46fd17a9ff
moved obviousness discovery. updated sliproad handler. back to original cases failing
2016-08-24 10:12:27 +02:00
Daniel J. Hofmann
da73bae9c6
Scenario for unnecessary slight left onto Stralauer Str
2016-08-24 10:12:27 +02:00
Moritz Kobitzsch
766e2713ab
fix segmentation fault for via-routes with invalid intermediate segments
2016-08-23 14:17:32 +02:00
Patrick Niklaus
12d478784b
Enable toll roads by default again.
...
Currently we don't route over the Golden Gate bridge by default.
This sets the value to false by default. To test the behavior for
tolls when ignored, we would need issue #2781 implemented.
2016-08-19 13:01:15 +02:00
Moritz Kobitzsch
38fef77d70
additional collapse cases
2016-08-19 12:43:51 +02:00
Moritz Kobitzsch
e8bae78749
fix errors introduced in refactor
2016-08-18 11:36:36 +02:00
Moritz Kobitzsch
9485c97738
adjusting u-turn handling in lane matching to fully fix 2706
2016-08-18 11:36:36 +02:00
Daniel J. Hofmann
d53c267129
Be more aggresive classifying Roundabout Intersections.
...
Roundabout Intersections are roundabouts with up to four ways and turn
angles which makes the turns obvious, e.g. as in:
```
*
*
* * * *
*
*
```
but not
```
*
*
* * *
* *
* *
```
For Roundabout Intersections we issue instructions such as
"turn <direction>" instead of "take the <nth> exit".
At the moment we have a limit on the radius for these Roundabout
Intersections of 5 meters. Which fails to classify a wide range of
Roundabout Intersections in the US (with the US-wide streets).
This changeset removes the Roundabout Intersection radius limit:
- if the roundabout is larger than a threshold and is named we classify
it as a rotary
- if the roundabout matches our criteria for Roundabout Intersections
we classify it as a Roundabout Intersection
- else fallback to plain old Roundabout
There is a second issue with determining a roundabout's radius.
But that's for another pull request (tracking in #2716 ).
References:
- https://github.com/Project-OSRM/osrm-backend/issues/2716
2016-08-18 10:50:32 +02:00
Patrick Niklaus
2f6de614c1
Ignore any following columns in a CSV file
2016-08-18 10:19:36 +02:00
Moritz Kobitzsch
087080a6c3
mark via-case todo to prevent known failure to show up in local cucumber
2016-08-15 15:52:47 +02:00
Moritz Kobitzsch
464de785cb
fix removal of multiple geometries for first vertex
2016-08-09 12:02:07 +02:00
Daniel Patterson
65def1a9e2
We should be returning an error if any errors that occur during reprocessing.
2016-08-05 15:11:12 -07:00
Daniel Patterson
176c2244ad
Catch and report errors during osrm-contract tests.
2016-08-05 14:19:22 -07:00
Daniel J. Hofmann
5bef5dcb04
Disable our added failing cucumber tests for now
2016-08-05 18:32:42 +02:00
Daniel Patterson
4d84bc0f01
Add a minimal version of the failing test case.
2016-08-05 18:32:42 +02:00
Daniel J. Hofmann
c737635a3b
Reproducing breaking intersection in cucumber scenario
...
Conflicts:
src/extractor/guidance/turn_lane_augmentation.cpp
2016-08-05 18:32:42 +02:00
Daniel J. Hofmann
b7eeafb183
Try to come up with a small test case
2016-08-05 18:32:42 +02:00
Patrick Niklaus
677306eeee
Merge pull request #2707 from oxidase/left_side_driving
...
Left side driving
2016-08-05 18:09:10 +02:00
Daniel J. Hofmann
b1e309b4eb
Collapse Staggered Intersections.
...
Staggered intersection are very short zig-zags of only a few meters.
They are common in rural and exurban areas, especially in the US.
(In addition, these cases could as well be tagging issues)
We do not want to announce these short left-rights or right-lefts:
* -> b a -> *
| or | becomes a -> b
a -> * * -> b
Here is one example:
- https://www.openstreetmap.org/edit#map=20/39.26017/-84.25182
And here are two edge-cases that we don't handle at the moment:
- http://www.openstreetmap.org/edit#map=20/38.87900/-76.98519
- http://www.openstreetmap.org/edit#map=19/45.51056/-122.63462
and probably should not handle since the distance in between is
quite long (roughly 7-15 meters). For these we want to announce
two turns to not confuse the user.
Thanks to @1ec5 for raising this issue and @karenzshea for
providing additional US examples and cultural insights.
2016-08-05 14:35:13 +02:00
Daniel J. Hofmann
8bee57b0b0
Makes toll=yes way's routability configurable in profiles.
...
The primary use-case is conditionally filtering ways such as:
https://www.openstreetmap.org/edit#map=18/38.94198/-77.28127
which we are guiding the user onto in the route from DC to IAD:
http://map.project-osrm.org/?z=12¢er=38.934443%2C-77.167969&loc=38.902656%2C-77.029095&loc=38.952210%2C-77.453424&hl=en&alt=0
This changeset makes `toll=yes` configurable in the profiles, disabling
them by default. Neither do we support time-based fees nor vehicle
category fees at the moment.
References:
- http://wiki.openstreetmap.org/wiki/Key:toll
2016-08-04 14:29:22 +02:00
Daniel J. Hofmann
583aaff286
Makes designated HOV way's routability configurable in profiles.
...
Why only `hov=designated` and not all access tags, such as `hov:yes`,
`hov=no` and so on? From the Wiki:
- designated: The way is designated to high occupancy vehicles.
- yes: High occupancy vehicles are allowed. This by itself does not imply that other vehicles are restricted from using the way.
- no: High occupancy vehicles are not allowed on the way. This by itself does not imply that other vehicle types are allowed to use it.
The primary use-case is conditionally filtering ways such as:
http://www.openstreetmap.org/way/11198593#map=19/37.82571/-122.30521&layers=D
In addition there is a notion of HOV lanes for lane handling:
http://wiki.openstreetmap.org/wiki/Key:hov#hov:lanes.3D.2A
This changeset does not handle lanes at all, only designated HOV ways.
For HOV lane support, a logic similar to the lane access handling needs
to be implemented. This needs to go hand in hand with the existing lane
handling introduced in:
https://github.com/Project-OSRM/osrm-backend/commit/7d076e93445a4d016422a575f1132b267cd13c29
References:
- #2711
- http://wiki.openstreetmap.org/wiki/Key:access
- http://wiki.openstreetmap.org/wiki/Key:hov#Values
2016-08-03 12:24:43 +02:00
Daniel J. Hofmann
026f71934b
Adds Cucumber Scenario for sharp left turn at traffic light
2016-08-03 12:18:31 +02:00
Michael Krasnyk
979f9cab20
Added test for issue #2706
2016-08-02 19:06:10 +02:00
Daniel J. Hofmann
c4718495a0
Add Florida Ave NW scenario for TurnLeft instead of MergeRight
2016-07-30 23:55:39 +02:00
Moritz Kobitzsch
0d36d472c9
change paradigm of merge to only emit on motorway-like roads
2016-07-30 23:55:39 +02:00
Daniel Patterson
d012b44b7f
Filter out edges that have any speed=0 segments.
...
They become non-snappable and non-routable. Note that a single segment
of speed=0 will eliminate the entire edge.
2016-07-30 23:53:38 +02:00
Michael Krasnyk
61e6afdef0
added a lanes test in clockwise roundabouts
2016-07-28 22:59:22 +02:00
Lauren Budorick
951a4dc112
commit test file
2016-07-28 22:59:22 +02:00
Daniel Patterson
280b000f07
Include datasources for each segment in route annotation.
2016-07-27 15:51:11 -07:00
Patrick Niklaus
e83905b783
Fix exception handling around unrecognised options
2016-07-26 11:43:08 +02:00
Moritz Kobitzsch
7d076e9344
handle access flags for lanes
2016-07-25 20:01:58 +02:00