Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity
522d0f066e
osrm-backend/features/guidance/turn-lanes.feature

1252 lines
63 KiB
Gherkin
Raw Normal View History

basic turn lane handling
2016-05-13 13:18:00 -04:00
@routing @guidance @turn-lanes
Feature: Turn Lane Guidance
Background:
Given the profile "car"
refactor of post-processing - moves collapse into a dedicated set of functions / files - make collapse scenarios distinct (slight performance cost) - reduce verbosity for short name segments (now actually working, was supposed to do so before)
2017-02-15 09:12:24 -05:00
Given a grid size of 5 meters
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@simple
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Basic Turn Lane 3-way Turn with empty lanes
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b c
d
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | turn:lanes | turn:lanes:forward | turn:lanes:backward | name |
| ab | | through\|right | | in |
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| bc | | | left\|through\|\| | straight |
basic turn lane handling
2016-05-13 13:18:00 -04:00
| bd | | | left\|right | right |
When I route I should get
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| waypoints | route | turns | lanes |
| a,c | in,straight,straight | depart,new name straight,arrive | ,straight:true right:false, |
| a,d | in,right,right | depart,turn right,arrive | ,straight:false right:true, |
| c,a | straight,in,in | depart,new name straight,arrive | ,left:false straight:true none:true none:true, |
| c,d | straight,right,right | depart,turn left,arrive | ,left:true straight:false none:false none:false, |
handle access flags for lanes
2016-07-08 04:44:49 -04:00
Scenario: Basic Turn Lane 3-way Turn with designated lane
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b c
d
"""
handle access flags for lanes
2016-07-08 04:44:49 -04:00
And the ways
| nodes | turn:lanes | turn:lanes:forward | name | vehicle:lanes:forward |
| ab | | through\|through\|right | in | yes\|no\|yes |
| bc | | | straight | |
| bd | | | right | |
When I route I should get
| waypoints | route | turns | lanes |
| a,c | in,straight,straight | depart,new name straight,arrive | ,straight:true right:false, |
| a,d | in,right,right | depart,turn right,arrive | ,straight:false right:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
add testscases for mode changes / additional assertions
2016-11-04 09:44:23 -04:00
# Turn Lane onto a ferry could end up breaking in intersection generation
Scenario: Basic Turn Lane 3-way Turn with designated lane
Given the node map
"""
a - b ~ ~ c - e
| |
d f
"""
And the ways
| nodes | turn:lanes:forward | name | route |
| ab | through\|through\|right | ferry-route | |
| bc | through\|through\|right | ferry-route | ferry |
| ce | | ferry-route | |
| bd | | right | |
| cf | | right | |
When I route I should get
| waypoints | route | turns |
| a,e | ferry-route,ferry-route,ferry-route,ferry-route | depart,notification straight,notification straight,arrive |
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@simple
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Basic Turn Lane 4-Way Turn
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
e
a b c
d
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | turn:lanes | turn:lanes:forward | turn:lanes:backward | name |
| ab | | \|right | | in |
| bc | | | | straight |
| bd | | | left\| | right |
| be | | | | left |
When I route I should get
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
| waypoints | route | turns | lanes |
| a,c | in,straight,straight | depart,new name straight,arrive | ,none:true right:false, |
| a,d | in,right,right | depart,turn right,arrive | ,none:false right:true, |
| a,e | in,left,left | depart,turn left,arrive | ,none:true right:false, |
| d,a | right,in,in | depart,turn left,arrive | ,left:true none:false, |
| d,e | right,left,left | depart,new name straight,arrive | ,left:false none:true, |
| d,c | right,straight,straight | depart,turn right,arrive | ,left:false none:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@simple @none
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Basic Turn Lane 4-Way Turn using none
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
e
a b c
d
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | turn:lanes | turn:lanes:forward | turn:lanes:backward | name |
| ab | | none\|right | | in |
| bc | | | | straight |
| bd | | | left\|none | right |
| be | | | | left |
When I route I should get
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
| waypoints | route | turns | lanes |
| a,c | in,straight,straight | depart,new name straight,arrive | ,none:true right:false, |
| a,d | in,right,right | depart,turn right,arrive | ,none:false right:true, |
| a,e | in,left,left | depart,turn left,arrive | ,none:true right:false, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@simple @reverse
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Basic Turn Lane 4-Way With U-Turn Lane
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
Rember Intersection Shapes Changes the processing order in the edge based graph factory. Instead of iterating over all outgoing edges in order, we compute the edge expanded graph in the order of intersections. This allows to remember intersection shapes and re-use them for all possible ingoing edges. Also: use low accuracry mode for intersections degree 2 intersections We can use lower accuracy here, since the `bearing` after the turn is not as relevant for off-route detection. Getting lost is near impossible here.
2016-11-18 03:38:26 -05:00
e
f a-1-b---c
d
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
Rember Intersection Shapes Changes the processing order in the edge based graph factory. Instead of iterating over all outgoing edges in order, we compute the edge expanded graph in the order of intersections. This allows to remember intersection shapes and re-use them for all possible ingoing edges. Also: use low accuracry mode for intersections degree 2 intersections We can use lower accuracy here, since the `bearing` after the turn is not as relevant for off-route detection. Getting lost is near impossible here.
2016-11-18 03:38:26 -05:00
| nodes | turn:lanes | turn:lanes:forward | name | # |
| ab | | reverse;left\|through;right | in | |
| bc | | | straight | |
| bd | | | right | |
| be | | | left | |
| fa | | | uturn-avoider | #due to https://github.com/Project-OSRM/osrm-backend/issues/3359 |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
Rember Intersection Shapes Changes the processing order in the edge based graph factory. Instead of iterating over all outgoing edges in order, we compute the edge expanded graph in the order of intersections. This allows to remember intersection shapes and re-use them for all possible ingoing edges. Also: use low accuracry mode for intersections degree 2 intersections We can use lower accuracy here, since the `bearing` after the turn is not as relevant for off-route detection. Getting lost is near impossible here.
2016-11-18 03:38:26 -05:00
| from | to | bearings | route | turns | lanes | locations |
| a | c | 180,180 180,180 | in,straight,straight | depart,new name straight,arrive | ,left;uturn:false straight;right:true, | a,b,c |
| a | d | 180,180 180,180 | in,right,right | depart,turn right,arrive | ,left;uturn:false straight;right:true, | a,b,d |
| a | e | 180,180 180,180 | in,left,left | depart,turn left,arrive | ,left;uturn:true straight;right:false, | a,b,e |
make all u-turns continue
2017-06-01 05:43:53 -04:00
| 1 | a | 90,2 270,2 | in,in,in | depart,continue uturn,arrive | ,left;uturn:true straight;right:false, | _,b,a |
basic turn lane handling
2016-05-13 13:18:00 -04:00
#this next test requires decision on how to announce lanes for going straight if there is no turn
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@simple @psv @none
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Turn with Bus-Lane
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b c
d
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | name | turn:lanes:forward | lanes:psv:forward |
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| ab | road | through\|right\| | 1 |
basic turn lane handling
2016-05-13 13:18:00 -04:00
| bc | road | | |
| bd | turn | | |
When I route I should get
collapse use-lane instructions if possible
2016-07-18 05:24:41 -04:00
| waypoints | route | turns | lanes |
| a,d | road,turn,turn | depart,turn right,arrive | ,straight:false right:true, |
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| a,c | road,road | depart,arrive | ;straight:true right:false, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
fix copy-paste typo in guidance lib
2016-09-05 03:16:56 -04:00
Scenario: Turn with Bus-Lane Left
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
d
a b c f
e
"""
fix copy-paste typo in guidance lib
2016-09-05 03:16:56 -04:00
And the ways
| nodes | name | turn:lanes:forward | lanes:psv:forward | oneway |
| ab | road | left\|through\| | 1 | yes |
| bc | road | | | yes |
| bd | turn | | | yes |
| cf | turn | | | yes |
| ce | side | | | yes |
When I route I should get
| waypoints | route | turns | lanes |
| a,d | road,turn,turn | depart,turn left,arrive | ,left:true straight:false, |
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| a,c | road,road | depart,arrive | ;left:false straight:true, |
fix copy-paste typo in guidance lib
2016-09-05 03:16:56 -04:00
Invalid string values in lanes:psv:backward should result in 0 lanes, not `nil`.
2016-09-04 16:40:48 -04:00
# This tests whether empty/invalid PSV tags cause osrm-extract to crash
Scenario: Turn with Bus-Lane
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b c
d
"""
Invalid string values in lanes:psv:backward should result in 0 lanes, not `nil`.
2016-09-04 16:40:48 -04:00
And the ways
| nodes | name | turn:lanes:forward | lanes:psv:forward | lanes:psv:backward |
| ab | road | through\|right\| | 1 | foo |
| bc | road | | | |
| bd | turn | | | |
When I route I should get
| waypoints | route | turns | lanes |
| a,d | road,turn,turn | depart,turn right,arrive | ,straight:false right:true, |
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@simple @psv
fixing lua issue in profile
2016-06-28 05:00:01 -04:00
Scenario: Turn with Bus-Lane but without lanes
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b c
d
"""
fixing lua issue in profile
2016-06-28 05:00:01 -04:00
And the ways
| nodes | name | lanes:psv |
| ab | road | 1 |
| bc | road | yes |
| bd | turn | |
When I route I should get
| waypoints | route | turns |
| a,d | road,turn,turn | depart,turn right,arrive |
| a,c | road,road | depart,arrive |
basic turn lane handling
2016-05-13 13:18:00 -04:00
#turn lanes are often drawn at the incoming road, even though the actual turn requires crossing the intersection first
Fix "Error: write after end" and removed @bug tags https://nodejs.org/api/child_process.html#child_process_event_exit Note that when the 'exit' event is triggered, child process stdio streams might still be open.
2016-09-20 14:39:55 -04:00
@todo @collapse @partition-lanes
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Turn Lanes at Segregated Road
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
i l
h g f e
a b c d
j k
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward | oneway |
| ab | road | left\|through\|right | yes |
| bc | road | left\|through | yes |
| cd | road | | yes |
| ef | road | \|through\|through;right | yes |
| fg | road | left;through\|through\| | yes |
| gh | road | | yes |
| ig | cross | | yes |
| gb | cross | left\|through | yes |
| bj | cross | | yes |
| kc | cross | left\|through;right | yes |
| cf | cross | left\|through | yes |
| fl | cross | | yes |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes | intersection_lanes |
| a,j | road,cross,cross | depart,turn right,arrive | ,left:false straight:false right:true | ,left:false straight:false right:true |
| a,d | road,road | depart,arrive | , | left:false straight:true right:false, |
| a,l | road,cross,cross | depart,turn left,arrive | ,left:true straight:false right:false, | ,left:true straight:false right:false, |
| a,h | road,road,road | depart,continue uturn,arrive | ,left:true straight:false right:false, | ,left:true straight:false right:false |
| k,d | cross,road,road | depart,turn right,arrive | ,left:false straight;right:true, | ,left:false straight;right:true, |
| k,l | cross,cross | depart,arrive | , | left:false straight;right:true, |
| k,h | cross,road,road | depart,turn left,arrive | ,left:true straight;right:false, | ,left:true straight;right:false, |
| k,j | cross,cross,cross | depart,continue uturn,arrive | ,left:true straight;right:false, | ,left:true straight;right:false, |
| e,l | road,cross,cross | depart,turn right,arrive | ,none:false straight:false straight;right:true, | ,none:false straight:false straight;right:true, |
| e,h | road,road | depart,arrive | , | none:false straight:true straight;right:true, |
| e,j | road,cross,cross | depart,turn left,arrive | ,none:true straight:false straight;right:false, | ,none:true straight:false straight;right:false, |
| e,d | road,road,road | depart,continue uturn,arrive | ,none:true straight:false straight;right:false, | ,none:true straight:false straight;right:false, |
| i,h | cross,road,road | depart,turn right,arrive | ,, | |
| i,j | cross,cross | depart,arrive | | left:false straight:true, |
| i,d | cross,road,road | depart,turn left,arrive | ,left:true straight:false, | ,left:true straight:false, |
| i,l | cross,cross,cross | depart,continue uturn,arrive | ,left:true straight:false, | ,left:true straight:false, |
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
#copy of former case to prevent further regression
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@collapse @partition-lanes
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
Scenario: Turn Lanes at Segregated Road
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
i l
h g f e
a b c d
j k
"""
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward | oneway |
| ab | road | left\|through\|right | yes |
| bc | road | left\|through | yes |
| cd | road | | yes |
| ef | road | \|through\|through;right | yes |
| fg | road | left;through\|through\| | yes |
| gh | road | | yes |
| ig | cross | | yes |
| gb | cross | left\|through | yes |
| bj | cross | | yes |
| kc | cross | left\|through;right | yes |
| cf | cross | left\|through | yes |
| fl | cross | | yes |
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes |
| a,j | road,cross,cross | depart,turn right,arrive | ,left:false straight:false right:true, |
| k,d | cross,road,road | depart,turn right,arrive | ,left:false straight;right:true, |
| e,l | road,cross,cross | depart,turn right,arrive | ,none:false straight:false straight;right:true, |
| i,h | cross,road,road | depart,turn right,arrive | ,, |
| i,j | cross,cross | depart,arrive | ;;left:false straight:true, |
Added post process logic to collapse segregated turn instructions (#4925) * Added post process logic to collapse segregated turn instructions * format updates * Fixed coordinates to reflect reality Updated left turn road name * fixed coordinates to fix test * Skip last step when processing segregated steps * updated segregated turn test * Updated segregated test * Updated test: Segregated Intersection, Cross Belonging to Correct Street - features/guidance/collapse.feature:79 * Fixed all but one for features/guidance/collapse.feature:124 * Fixed Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of th 9 failures for Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of the 9 failures for Scenario: Segregated Intersection, Cross Belonging to Mixed Streets - Slight Angles (2) - features/guidance/collapse.feature:318 * Fixed Scenario: Segregated Intersection into Slight Turn - features/guidance/collapse.feature:581 * Updated Scenario: U-turn after a traffic light - features/guidance/turn-lanes.feature:1220 * Updated how we combine segregated steps * Added test to Verify end of road left turn across divided roads * Fixed divided highwat tests * Fixed test failure * fixed Scenario: Partitioned turn, Slight Curve - maxspeed - features/guidance/turn-lanes.feature:936 * Fixed Scenario: Partitioned turn, Slight Curve - features/guidance/turn-lanes.feature:961 * Added strategies to combine segrgated intersections * Added setModifier alias for readability * Added strategies to combine segrgated intersections * Format updates * Fixes segregated indentification to not mark `circular` edge as segregated * Added intersection prior to turn so we still call out end of road * updated expectation to be turn instead of continue * Confirmed with @oxidase that the lane information if correct - updated the expectation * Added logic to handle wider straights Fixed tests * Update CHANGELOG.md Added #4925 * Removed TODO * Process straight step prior to wider straight step
2018-03-30 07:43:56 -04:00
| i,l | cross,cross,cross | depart,continue uturn,arrive | ,left:true straight:false;left:true straight:false;left:true straight:false;left:false straight:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@partition-lanes
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Turn Lanes at Segregated Road
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
g f
a b c d
j k
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward | oneway |
| ab | road | left\|through\|right | yes |
| bc | road | | yes |
| cd | road | | yes |
| gb | cross | | yes |
| bj | cross | | yes |
| kc | cross | | yes |
| cf | cross | | yes |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| waypoints | route | turns | lanes |
| a,j | road,cross,cross | depart,turn right,arrive | ,left:false straight:false right:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
#this can happen due to traffic lights / lanes not drawn up to the intersection itself
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@2654 @previous-lanes
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Turn Lanes Given earlier than actual turn
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b c d
e
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | name | turn:lanes:forward |
| ab | road | \|right |
| bc | road | |
| cd | road | |
| ce | turn | |
When I route I should get
collapse use-lane instructions if possible
2016-07-18 05:24:41 -04:00
| waypoints | route | turns | lanes |
| a,e | road,turn,turn | depart,turn right,arrive | ,none:false right:true, |
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| a,d | road,road | depart,arrive | ;none:true right:false, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@2654 @previous-lanes
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Turn Lanes Given earlier than actual turn
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b c d e f g h i
j k
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | name | turn:lanes:forward | turn:lanes:backward |
| abc | road | | |
| cd | road | | left\| |
| def | road | | |
| fg | road | \|right | |
| ghi | road | | |
| bj | first-turn | | |
| hk | second-turn | | |
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes |
| a,k | road,second-turn,second-turn | depart,turn right,arrive | ;,none:false right:true, |
| a,i | road,road | depart,arrive | ;;none:true right:false, |
| i,j | road,first-turn,first-turn | depart,turn left,arrive | ;,left:true none:false, |
| i,a | road,road | depart,arrive | ;;left:false none:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@previous-lanes
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Passing a one-way street
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
e f
a b c d
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | name | turn:lanes:forward | oneway |
| ab | road | left\|through | no |
| bcd | road | | no |
| eb | owi | | yes |
| cf | turn | | |
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes |
| a,f | road,turn,turn | depart,turn left,arrive | ;left:true straight:false,left:true straight:false, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@partition-lanes
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Passing a one-way street, partly pulled back lanes
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
e f
a b c d
g
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | name | turn:lanes:forward | oneway |
| ab | road | left\|through;right | no |
| bcd | road | | no |
| eb | owi | | yes |
| cf | turn | | no |
| bg | right | | no |
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes |
| a,f | road,turn,turn | depart,turn left,arrive | ;left:true straight;right:false,left:true straight;right:false, |
| a,d | road,road | depart,arrive | ;left:false straight;right:true;left:false straight;right:true, |
| a,g | road,right,right | depart,turn right,arrive | ,left:false straight;right:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@partition-lanes @previous-lanes
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Passing a one-way street, partly pulled back lanes, no through
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
e f
a b c
g
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | name | turn:lanes:forward | oneway |
| ab | road | left\|right | no |
| bc | road | | no |
| eb | owi | | yes |
| cf | turn | | no |
| bg | right | | no |
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes |
| a,f | road,turn,turn | depart,turn left,arrive | ,left:true right:false;left:true right:false, |
| a,g | road,right,right | depart,turn right,arrive | ,left:false right:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
Fix "Error: write after end" and removed @bug tags https://nodejs.org/api/child_process.html#child_process_event_exit Note that when the 'exit' event is triggered, child process stdio streams might still be open.
2016-09-20 14:39:55 -04:00
@todo @partition-lanes @previous-lanes
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
Scenario: Narrowing Turn Lanes
basic turn lane handling
2016-05-13 13:18:00 -04:00
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
g
a b c d e
f
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward |
| ab | road | left\|through\|right |
| bc | road | |
| cd | road | left\|through |
| de | through | |
| dg | left | |
| cf | right | |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| waypoints | route | turns | lanes |
| a,g | road,left,left | depart,turn left,arrive | ,left:true straight:false right:false, |
| a,e | road,through,through | depart,new name straight,arrive | ,left:false straight:true right:false, |
| a,f | road,right,right | depart,turn right,arrive | ,left:false straight:false right:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@previous-lanes
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
Scenario: Turn at a traffic light
basic turn lane handling
2016-05-13 13:18:00 -04:00
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b c d
e
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the nodes
| node | highway |
| b | traffic_signals |
And the ways
| nodes | name | turn:lanes:forward |
| ab | road | through\|right |
| bc | road | |
| cd | road | |
| ce | turn | |
When I route I should get
collapse use-lane instructions if possible
2016-07-18 05:24:41 -04:00
| waypoints | route | turns | lanes |
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| a,d | road,road | depart,arrive | ;straight:true right:false, |
collapse use-lane instructions if possible
2016-07-18 05:24:41 -04:00
| a,e | road,turn,turn | depart,turn right,arrive | ,straight:false right:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
Fix "Error: write after end" and removed @bug tags https://nodejs.org/api/child_process.html#child_process_event_exit Note that when the 'exit' event is triggered, child process stdio streams might still be open.
2016-09-20 14:39:55 -04:00
@todo @roundabout
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
Scenario: Theodor Heuss Platz
basic turn lane handling
2016-05-13 13:18:00 -04:00
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
i o l
b a m
c
h
j
g
d
e f
k n
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the nodes
| node | highway |
| g | traffic_signals |
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward | junction | oneway | highway |
| abcdef | roundabout | | roundabout | yes | primary |
| gha | roundabout | | roundabout | yes | primary |
| fg | roundabout | slight_left\|slight_left;slight_right\|slight_right\|slight_right | roundabout | yes | primary |
| aoib | top | | | yes | primary |
| cjd | left | | | yes | primary |
| ekf | bottom | | | yes | primary |
| fng | bottom-right | | | yes | primary |
| hma | top-right | | | yes | primary |
| hl | top-right-out | | | yes | secondary |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
| waypoints | route | turns | lanes |
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| i,m | top,top-right,top-right | depart,roundabout-exit-4,arrive | ,slight left:false slight left;slight right:true slight right:true slight right:true, |
| i,l | top,top-right-out,top-right-out | depart,roundabout-exit-4,arrive | ,slight left:true slight left;slight right:true slight right:false slight right:false, |
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
| i,o | top,top,top | depart,roundabout-exit-5,arrive | ,, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@sliproads
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Turn Lanes Breaking up
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
g
c
actually calculate distance instead of using `.distance` which is a timing value
2016-10-20 06:15:36 -04:00
a b d e
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
f
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
turn lane handler moved to scenario based handling
2016-06-30 03:31:08 -04:00
| nodes | name | turn:lanes:forward | oneway | highway |
| ab | road | left\|left\|through\|through\|right | yes | primary |
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
| bd | road | through\|through\|right | yes | primary |
turn lane handler moved to scenario based handling
2016-06-30 03:31:08 -04:00
| bc | road | left\|left | yes | primary |
| de | road | | yes | primary |
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
| fd | cross | | | secondary |
actually calculate distance instead of using `.distance` which is a timing value
2016-10-20 06:15:36 -04:00
| dc | cross | | | secondary |
| cg | cross | | | secondary |
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the relations
| type | way:from | way:to | node:via | restriction |
turn lane handler moved to scenario based handling
2016-06-30 03:31:08 -04:00
| restriction | bd | dc | d | no_left_turn |
| restriction | bc | dc | c | no_right_turn |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes |
| a,g | road,cross,cross | depart,turn left,arrive | ,left:true left:true straight:false straight:false right:false;left:true left:true straight:false straight:false right:false, |
| a,e | road,road | depart,arrive | ;left:false left:false straight:true straight:true right:false;left:false left:false straight:true straight:true right:false, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
fix testcases, one case only works by turn restriction, needs investigation
2016-09-07 05:52:43 -04:00
#NEEDS TO BE INVESTIGATED. Turn restriction shouldn't be here. See #2867
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@reverse @previous-lanes
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: U-Turn Road at Intersection
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
h
f e j
a b
c d i
g
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | name | turn:lanes:forward | oneway | highway |
| ab | road | | no | primary |
| di | road | | yes | primary |
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| bc | road | \|through\|right | yes | primary |
| cd | road | \|through\|right | yes | primary |
basic turn lane handling
2016-05-13 13:18:00 -04:00
| fc | road | | no | tertiary |
fix testcases, one case only works by turn restriction, needs investigation
2016-09-07 05:52:43 -04:00
| je | road | | yes | primary |
| ef | road | | yes | primary |
| fb | road | | yes | primary |
| eh | cross | | no | primary |
| de | cross | | no | primary |
| gd | cross | | no | primary |
basic turn lane handling
2016-05-13 13:18:00 -04:00
fix testcases, one case only works by turn restriction, needs investigation
2016-09-07 05:52:43 -04:00
And the relations
| type | way:from | way:to | node:via | restriction |
| restriction | de | ef | e | no_left_turn |
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| from | to | bearings | route | turns | lanes |
| a | g | 180,180 180,180 | road,cross,cross | depart,turn right,arrive | ;none:false straight:false right:true,none:false straight:false right:true, |
| a | h | 180,180 180,180 | road,cross,cross | depart,turn left,arrive | ;none:true straight:false right:false,none:true straight:false right:false;, |
| a | i | 180,180 180,180 | road,road | depart,arrive | ;none:true straight:true right:false;none:true straight:true right:false, |
| b | a | 90,2 270,2 | road,road,road | depart,continue uturn,arrive | ,none:true straight:false right:false;, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@reverse
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Segregated Intersection Merges With Lanes
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
refactor merging of segregated roads adjust to generalFindMaximum function moved parallel detection to ratio/absolute based regression testing considerably improved detection quality using normalised regression lines only follow initial direction/narrow turns for parallel detection
2016-12-06 07:22:51 -05:00
a e
| |
| |
refactor of post-processing - moves collapse into a dedicated set of functions / files - make collapse scenarios distinct (slight performance cost) - reduce verbosity for short name segments (now actually working, was supposed to do so before)
2017-02-15 09:12:24 -05:00
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
refactor merging of segregated roads adjust to generalFindMaximum function moved parallel detection to ratio/absolute based regression testing considerably improved detection quality using normalised regression lines only follow initial direction/narrow turns for parallel detection
2016-12-06 07:22:51 -05:00
b d
Restructure Obvious Turn Handling, code transfer from #4426
2018-02-06 07:36:45 -05:00
h-----c
| `-f
g
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
refactor merging of segregated roads adjust to generalFindMaximum function moved parallel detection to ratio/absolute based regression testing considerably improved detection quality using normalised regression lines only follow initial direction/narrow turns for parallel detection
2016-12-06 07:22:51 -05:00
| nodes | name | turn:lanes:forward | oneway | highway | lanes |
refactor of post-processing - moves collapse into a dedicated set of functions / files - make collapse scenarios distinct (slight performance cost) - reduce verbosity for short name segments (now actually working, was supposed to do so before)
2017-02-15 09:12:24 -05:00
| abc | road | left\|left\|left\|through\|through | yes | primary | 2 |
| cde | road | | yes | primary | 2 |
refactor merging of segregated roads adjust to generalFindMaximum function moved parallel detection to ratio/absolute based regression testing considerably improved detection quality using normalised regression lines only follow initial direction/narrow turns for parallel detection
2016-12-06 07:22:51 -05:00
| hc | cross | | yes | secondary | |
| cg | straight | | no | tertiary | |
| cf | left | | yes | primary | |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| waypoints | route | turns | lanes |
| a,f | road,left,left | depart,turn left,arrive | ,left:true left:true left:true straight:false straight:false, |
make all u-turns continue
2017-06-01 05:43:53 -04:00
| a,e | road,road,road | depart,continue uturn,arrive | ,left:true left:false left:false straight:false straight:false, |
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| a,g | road,straight,straight | depart,new name straight,arrive | ,left:false left:false left:false straight:true straight:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
Fix "Error: write after end" and removed @bug tags https://nodejs.org/api/child_process.html#child_process_event_exit Note that when the 'exit' event is triggered, child process stdio streams might still be open.
2016-09-20 14:39:55 -04:00
@todo @roundabout
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
Scenario: Passing Through a Roundabout
basic turn lane handling
2016-05-13 13:18:00 -04:00
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
h g
a f k
i
b e
c d
j
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward | oneway | highway | junction |
| efgha | round | | yes | primary | roundabout |
| ab | round | | yes | primary | roundabout |
| bc | round | slight_left\|slight_left\|slight_right | yes | primary | roundabout |
| cd | round | | yes | primary | roundabout |
| de | round | slight_left\|slight_right | yes | primary | roundabout |
| ib | left | slight_left\|slight_left\|slight_right | yes | primary | |
| cj | bottom | | yes | primary | |
| ek | right | | yes | primary | |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
| waypoints | route | turns | lanes |
| i,j | left,bottom,bottom | depart,round-exit-1,arrive | ,0, |
| i,k | left,right,right | depart,round-exit-2,arrive | ,1, |
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@previous-lanes
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Crossing Traffic Light
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b c d
e
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the nodes
| node | highway |
| b | traffic_signals |
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward | highway |
| abc | road | through\|through\|through;slight_right\|slight_right | primary |
| cd | road | | primary |
| ce | cross | | primary |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| waypoints | route | turns | lanes |
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| a,d | road,road | depart,arrive | ;straight:true straight:true straight;slight right:true slight right:false, |
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| a,e | road,cross,cross | depart,turn slight right,arrive | ,straight:false straight:false straight;slight right:true slight right:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@ramp
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Highway Ramp
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b c d
e
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward | highway |
| abc | hwy | through\|through\|through;slight_right\|slight_right | motorway |
| cd | hwy | | motorway |
| ce | ramp | | motorway_link |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| waypoints | route | turns | lanes |
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| a,d | hwy,hwy | depart,arrive | ;straight:true straight:true straight;slight right:true slight right:false, |
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| a,e | hwy,ramp,ramp | depart,off ramp slight right,arrive | ,straight:false straight:false straight;slight right:true slight right:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
Close GH-2795: Rewrite cucumber test caching (and support logic). Fixes #2745
2016-09-19 17:13:44 -04:00
@todo
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
Scenario: Turning Off Ramp
basic turn lane handling
2016-05-13 13:18:00 -04:00
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a
d c b
e f g
h
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | name | turn:lanes:forward | highway | oneway |
| ac | off | left\|right | motorway_link | yes |
| bcd | road | | primary | yes |
| cf | road | | primary | |
| efg | road | | primary | yes |
| fh | on | | motorway_link | yes |
When I route I should get
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
| waypoints | route | turns | lanes |
| a,d | off,road,road | depart,turn_right,arrive | ,left:false right:true, |
| a,g | off,road,road | depart,turn_left,arrive | ,left:true right:false, |
| a,h | | | |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@ramp
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
Scenario: Off Ramp In a Turn
basic turn lane handling
2016-05-13 13:18:00 -04:00
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a
b c
d
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward | highway | oneway |
| ab | hwy | through\|through\|slight_right | motorway | yes |
| bc | hwy | | motorway | yes |
| bd | ramp | | motorway_link | yes |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| waypoints | route | turns | lanes |
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| a,c | hwy,hwy | depart,arrive | ;straight:true straight:true slight right:false, |
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| a,d | hwy,ramp,ramp | depart,off ramp slight right,arrive | ,straight:false straight:false slight right:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@reverse
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
Scenario: Reverse Lane in Segregated Road
basic turn lane handling
2016-05-13 13:18:00 -04:00
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
h g f
e
d
a b c
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward | highway | oneway |
| ab | road | reverse\|through\|through | primary | yes |
| bc | road | | primary | yes |
| bdeg | road | | primary_link | yes |
| fgh | road | | primary | yes |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes |
| a,h | road,road,road | depart,continue uturn,arrive | ,uturn:true straight:false straight:false;,|
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@reverse
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Reverse Lane in Segregated Road with none
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
h g f
e
d
a b c
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward | highway | oneway |
| ab | road | reverse\|through\|none | primary | yes |
| bc | road | | primary | yes |
| bdeg | road | | primary_link | yes |
| fgh | road | | primary | yes |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes |
| a,h | road,road,road | depart,continue uturn,arrive | ,uturn:true straight:false none:false;, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@reverse
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Reverse Lane in Segregated Road with none, Service Turn Prior
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
h g f
e
d
a j b c
i
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
update cucumber to 1.2.1 and remove hack
2016-07-07 09:31:20 -04:00
| nodes | name | turn:lanes:forward | highway | oneway |
| ajb | road | reverse\|through\|none | primary | yes |
| bc | road | | primary | yes |
| bdeg | road | | primary_link | yes |
| fgh | road | | primary | yes |
| ji | park | | service | no |
basic turn lane handling
2016-05-13 13:18:00 -04:00
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes |
| a,h | road,road,road | depart,continue uturn,arrive | ,uturn:true straight:false none:false;, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@simple
basic turn lane handling
2016-05-13 13:18:00 -04:00
Scenario: Don't collapse everything to u-turn / too wide
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b e
refactor of post-processing - moves collapse into a dedicated set of functions / files - make collapse scenarios distinct (slight performance cost) - reduce verbosity for short name segments (now actually working, was supposed to do so before)
2017-02-15 09:12:24 -05:00
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
d c f
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | highway | name | turn:lanes:forward |
| ab | primary | road | through\|right |
| bc | primary | road | |
| dc | primary | road | left\|through |
| be | secondary | top | |
| cf | secondary | bottom | |
When I route I should get
Fix distance calculation consistency. (#6315) Consolidate great circle distance calculations to use cheap ruler library.
2022-08-19 17:31:40 -04:00
| waypoints | turns | route | lanes |
| a,d | depart,continue uturn,arrive | road,road,road | ,straight:false right:true;, |
| d,a | depart,continue uturn,arrive | road,road,road | ,left:true straight:false;, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@simple
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
Scenario: Merge Lanes Onto Freeway
basic turn lane handling
2016-05-13 13:18:00 -04:00
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a b c
d
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | highway | name | turn:lanes:forward |
| abc | motorway | Hwy | |
| db | motorway_link | ramp | slight_right\|slight_right |
When I route I should get
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
| waypoints | turns | route | lanes |
expose lanes as enums, adjusted for comments
2016-06-21 04:41:08 -04:00
| d,c | depart,merge slight left,arrive | ramp,Hwy,Hwy | ,slight right:true slight right:true, |
basic turn lane handling
2016-05-13 13:18:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@2654 @simple
Implement Turn Lane Api
2016-06-15 08:38:24 -04:00
Scenario: Fork on motorway links - don't fork on through but use lane
basic turn lane handling
2016-05-13 13:18:00 -04:00
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
i a
j c b x
"""
basic turn lane handling
2016-05-13 13:18:00 -04:00
And the ways
| nodes | name | highway | turn:lanes:forward |
| xb | xbcj | motorway_link | |
| bc | xbcj | motorway_link | none\|slight_right |
| cj | xbcj | motorway_link | |
| ci | off | motorway_link | |
| ab | on | motorway_link | |
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes |
| a,j | on,xbcj | depart,arrive | ;;none:true slight right:false, |
| a,i | on,off,off | depart,turn right,arrive | ;,none:false slight right:true, |
adding a todo testscase / regression test-case
2016-07-14 05:45:27 -04:00
#http://www.openstreetmap.org/#map=17/52.47414/13.35712
@todo @ramp @2645
Scenario: Kreuz Schoeneberg - Continue on ramp, don't merge
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
i j
k
h g l f e
d c b a
"""
adding a todo testscase / regression test-case
2016-07-14 05:45:27 -04:00
And the ways
| nodes | highway | name | oneway | lanes | turn:lanes |
| ab | motorway | A 100 | yes | 3 | |
| bc | motorway | A 100 | yes | 4 | \|\|\|slight_right |
| cd | motorway | A 100 | yes | 3 | |
| eb | motorway_link | | yes | 1 | |
| cf | motorway_link | | yes | 1 | |
| fj | motorway_link | | yes | 1 | |
| fl | motorway_link | | yes | 1 | |
| kl | motorway_link | | yes | 1 | |
| lg | motorway_link | | yes | 2 | through\|slight_right |
| gi | motorway_link | | yes | 1 | |
| gh | motorway_link | | yes | 1 | |
When I route I should get
| waypoints | route | turns | lanes |
| a,d | A 100,A 100 | depart,arrive | |
| a,i | A 100,,,, | depart,off ramp slight right,fork slight left,turn right,arrive | ,none:false none:false none:false slight right:true,,straight:false slight right:true, |
| e,j | ,,, | depart,off ramp slight right,fork slight right,arrive | ,none:false none:false none:false slight right:true,,, |
| e,i | ,,,, | depart,off ramp right,fork slight left,use lane straight,arrive | ,none:false none:false none:false slight right:true,,straight:false slight right:true, |
| e,d | ,A 100,A 100 | depart,merge slight left,arrive | ,, |
| e,h | ,,,, | depart,off ramp right,fork left,use lane straight,arrive | ,none:false none:false none:false slight right:true,,straight:true slight right:false, |
fix use-lane handling
2016-07-21 10:36:00 -04:00
@collapse @use-lane
Scenario: Collapse Multiple Use Lanes
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
x a b c d
e f
"""
fix use-lane handling
2016-07-21 10:36:00 -04:00
And the ways
| nodes | name | highway | turn:lanes:forward |
adjusting u-turn handling in lane matching to fully fix 2706
2016-08-08 09:44:58 -04:00
| ab | road | primary | through;right |
| bc | road | primary | through;right |
fix use-lane handling
2016-07-21 10:36:00 -04:00
| cd | road | primary | |
| xa | road | primary | |
| be | turn | primary | |
| cf | turn | primary | |
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes |
| x,d | road,road | depart,arrive | ;straight;right:true;straight;right:true, |
fix use-lane handling
2016-07-21 10:36:00 -04:00
don't assign lanes on delayed turns
2016-07-08 05:45:36 -04:00
@partition-lanes
actually calculate distance instead of using `.distance` which is a timing value
2016-10-20 06:15:36 -04:00
Scenario: Partitioned turn, Slight Curve - maxspeed
Given the node map
"""
Added post process logic to collapse segregated turn instructions (#4925) * Added post process logic to collapse segregated turn instructions * format updates * Fixed coordinates to reflect reality Updated left turn road name * fixed coordinates to fix test * Skip last step when processing segregated steps * updated segregated turn test * Updated segregated test * Updated test: Segregated Intersection, Cross Belonging to Correct Street - features/guidance/collapse.feature:79 * Fixed all but one for features/guidance/collapse.feature:124 * Fixed Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of th 9 failures for Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of the 9 failures for Scenario: Segregated Intersection, Cross Belonging to Mixed Streets - Slight Angles (2) - features/guidance/collapse.feature:318 * Fixed Scenario: Segregated Intersection into Slight Turn - features/guidance/collapse.feature:581 * Updated Scenario: U-turn after a traffic light - features/guidance/turn-lanes.feature:1220 * Updated how we combine segregated steps * Added test to Verify end of road left turn across divided roads * Fixed divided highwat tests * Fixed test failure * fixed Scenario: Partitioned turn, Slight Curve - maxspeed - features/guidance/turn-lanes.feature:936 * Fixed Scenario: Partitioned turn, Slight Curve - features/guidance/turn-lanes.feature:961 * Added strategies to combine segrgated intersections * Added setModifier alias for readability * Added strategies to combine segrgated intersections * Format updates * Fixes segregated indentification to not mark `circular` edge as segregated * Added intersection prior to turn so we still call out end of road * updated expectation to be turn instead of continue * Confirmed with @oxidase that the lane information if correct - updated the expectation * Added logic to handle wider straights Fixed tests * Update CHANGELOG.md Added #4925 * Removed TODO * Process straight step prior to wider straight step
2018-03-30 07:43:56 -04:00
f e
| |
i | |
| | c
h - a - b ' |
j g d
actually calculate distance instead of using `.distance` which is a timing value
2016-10-20 06:15:36 -04:00
"""
And the ways
| nodes | name | highway | oneway | turn:lanes:forward | maxspeed |
Added post process logic to collapse segregated turn instructions (#4925) * Added post process logic to collapse segregated turn instructions * format updates * Fixed coordinates to reflect reality Updated left turn road name * fixed coordinates to fix test * Skip last step when processing segregated steps * updated segregated turn test * Updated segregated test * Updated test: Segregated Intersection, Cross Belonging to Correct Street - features/guidance/collapse.feature:79 * Fixed all but one for features/guidance/collapse.feature:124 * Fixed Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of th 9 failures for Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of the 9 failures for Scenario: Segregated Intersection, Cross Belonging to Mixed Streets - Slight Angles (2) - features/guidance/collapse.feature:318 * Fixed Scenario: Segregated Intersection into Slight Turn - features/guidance/collapse.feature:581 * Updated Scenario: U-turn after a traffic light - features/guidance/turn-lanes.feature:1220 * Updated how we combine segregated steps * Added test to Verify end of road left turn across divided roads * Fixed divided highwat tests * Fixed test failure * fixed Scenario: Partitioned turn, Slight Curve - maxspeed - features/guidance/turn-lanes.feature:936 * Fixed Scenario: Partitioned turn, Slight Curve - features/guidance/turn-lanes.feature:961 * Added strategies to combine segrgated intersections * Added setModifier alias for readability * Added strategies to combine segrgated intersections * Format updates * Fixes segregated indentification to not mark `circular` edge as segregated * Added intersection prior to turn so we still call out end of road * updated expectation to be turn instead of continue * Confirmed with @oxidase that the lane information if correct - updated the expectation * Added logic to handle wider straights Fixed tests * Update CHANGELOG.md Added #4925 * Removed TODO * Process straight step prior to wider straight step
2018-03-30 07:43:56 -04:00
| ha | road | primary | yes | | 1 |
actually calculate distance instead of using `.distance` which is a timing value
2016-10-20 06:15:36 -04:00
| ab | road | primary | yes | left\|right | 1 |
| bc | cross | primary | yes | | 1 |
| fbg | cross | primary | yes | | 1 |
| dce | cross | primary | yes | | 1 |
Added post process logic to collapse segregated turn instructions (#4925) * Added post process logic to collapse segregated turn instructions * format updates * Fixed coordinates to reflect reality Updated left turn road name * fixed coordinates to fix test * Skip last step when processing segregated steps * updated segregated turn test * Updated segregated test * Updated test: Segregated Intersection, Cross Belonging to Correct Street - features/guidance/collapse.feature:79 * Fixed all but one for features/guidance/collapse.feature:124 * Fixed Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of th 9 failures for Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of the 9 failures for Scenario: Segregated Intersection, Cross Belonging to Mixed Streets - Slight Angles (2) - features/guidance/collapse.feature:318 * Fixed Scenario: Segregated Intersection into Slight Turn - features/guidance/collapse.feature:581 * Updated Scenario: U-turn after a traffic light - features/guidance/turn-lanes.feature:1220 * Updated how we combine segregated steps * Added test to Verify end of road left turn across divided roads * Fixed divided highwat tests * Fixed test failure * fixed Scenario: Partitioned turn, Slight Curve - maxspeed - features/guidance/turn-lanes.feature:936 * Fixed Scenario: Partitioned turn, Slight Curve - features/guidance/turn-lanes.feature:961 * Added strategies to combine segrgated intersections * Added setModifier alias for readability * Added strategies to combine segrgated intersections * Format updates * Fixes segregated indentification to not mark `circular` edge as segregated * Added intersection prior to turn so we still call out end of road * updated expectation to be turn instead of continue * Confirmed with @oxidase that the lane information if correct - updated the expectation * Added logic to handle wider straights Fixed tests * Update CHANGELOG.md Added #4925 * Removed TODO * Process straight step prior to wider straight step
2018-03-30 07:43:56 -04:00
| iaj | kross | primary | no | | 1 |
actually calculate distance instead of using `.distance` which is a timing value
2016-10-20 06:15:36 -04:00
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes | locations |
Added post process logic to collapse segregated turn instructions (#4925) * Added post process logic to collapse segregated turn instructions * format updates * Fixed coordinates to reflect reality Updated left turn road name * fixed coordinates to fix test * Skip last step when processing segregated steps * updated segregated turn test * Updated segregated test * Updated test: Segregated Intersection, Cross Belonging to Correct Street - features/guidance/collapse.feature:79 * Fixed all but one for features/guidance/collapse.feature:124 * Fixed Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of th 9 failures for Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of the 9 failures for Scenario: Segregated Intersection, Cross Belonging to Mixed Streets - Slight Angles (2) - features/guidance/collapse.feature:318 * Fixed Scenario: Segregated Intersection into Slight Turn - features/guidance/collapse.feature:581 * Updated Scenario: U-turn after a traffic light - features/guidance/turn-lanes.feature:1220 * Updated how we combine segregated steps * Added test to Verify end of road left turn across divided roads * Fixed divided highwat tests * Fixed test failure * fixed Scenario: Partitioned turn, Slight Curve - maxspeed - features/guidance/turn-lanes.feature:936 * Fixed Scenario: Partitioned turn, Slight Curve - features/guidance/turn-lanes.feature:961 * Added strategies to combine segrgated intersections * Added setModifier alias for readability * Added strategies to combine segrgated intersections * Format updates * Fixes segregated indentification to not mark `circular` edge as segregated * Added intersection prior to turn so we still call out end of road * updated expectation to be turn instead of continue * Confirmed with @oxidase that the lane information if correct - updated the expectation * Added logic to handle wider straights Fixed tests * Update CHANGELOG.md Added #4925 * Removed TODO * Process straight step prior to wider straight step
2018-03-30 07:43:56 -04:00
| h,g | road,cross,cross | depart,turn right,arrive | ;,left:false right:true, | h,b,g |
| h,e | road,cross,cross | depart,end of road left,arrive | ;,left:true right:false;left:true right:false, | h,b,e |
actually calculate distance instead of using `.distance` which is a timing value
2016-10-20 06:15:36 -04:00
turn lane handler moved to scenario based handling
2016-06-30 03:31:08 -04:00
Scenario: Partitioned turn, Slight Curve
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
Added post process logic to collapse segregated turn instructions (#4925) * Added post process logic to collapse segregated turn instructions * format updates * Fixed coordinates to reflect reality Updated left turn road name * fixed coordinates to fix test * Skip last step when processing segregated steps * updated segregated turn test * Updated segregated test * Updated test: Segregated Intersection, Cross Belonging to Correct Street - features/guidance/collapse.feature:79 * Fixed all but one for features/guidance/collapse.feature:124 * Fixed Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of th 9 failures for Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of the 9 failures for Scenario: Segregated Intersection, Cross Belonging to Mixed Streets - Slight Angles (2) - features/guidance/collapse.feature:318 * Fixed Scenario: Segregated Intersection into Slight Turn - features/guidance/collapse.feature:581 * Updated Scenario: U-turn after a traffic light - features/guidance/turn-lanes.feature:1220 * Updated how we combine segregated steps * Added test to Verify end of road left turn across divided roads * Fixed divided highwat tests * Fixed test failure * fixed Scenario: Partitioned turn, Slight Curve - maxspeed - features/guidance/turn-lanes.feature:936 * Fixed Scenario: Partitioned turn, Slight Curve - features/guidance/turn-lanes.feature:961 * Added strategies to combine segrgated intersections * Added setModifier alias for readability * Added strategies to combine segrgated intersections * Format updates * Fixes segregated indentification to not mark `circular` edge as segregated * Added intersection prior to turn so we still call out end of road * updated expectation to be turn instead of continue * Confirmed with @oxidase that the lane information if correct - updated the expectation * Added logic to handle wider straights Fixed tests * Update CHANGELOG.md Added #4925 * Removed TODO * Process straight step prior to wider straight step
2018-03-30 07:43:56 -04:00
f e
| |
i | |
| | c
h - a - b ' |
j g d
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
turn lane handler moved to scenario based handling
2016-06-30 03:31:08 -04:00
And the ways
| nodes | name | highway | oneway | turn:lanes:forward |
Added post process logic to collapse segregated turn instructions (#4925) * Added post process logic to collapse segregated turn instructions * format updates * Fixed coordinates to reflect reality Updated left turn road name * fixed coordinates to fix test * Skip last step when processing segregated steps * updated segregated turn test * Updated segregated test * Updated test: Segregated Intersection, Cross Belonging to Correct Street - features/guidance/collapse.feature:79 * Fixed all but one for features/guidance/collapse.feature:124 * Fixed Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of th 9 failures for Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of the 9 failures for Scenario: Segregated Intersection, Cross Belonging to Mixed Streets - Slight Angles (2) - features/guidance/collapse.feature:318 * Fixed Scenario: Segregated Intersection into Slight Turn - features/guidance/collapse.feature:581 * Updated Scenario: U-turn after a traffic light - features/guidance/turn-lanes.feature:1220 * Updated how we combine segregated steps * Added test to Verify end of road left turn across divided roads * Fixed divided highwat tests * Fixed test failure * fixed Scenario: Partitioned turn, Slight Curve - maxspeed - features/guidance/turn-lanes.feature:936 * Fixed Scenario: Partitioned turn, Slight Curve - features/guidance/turn-lanes.feature:961 * Added strategies to combine segrgated intersections * Added setModifier alias for readability * Added strategies to combine segrgated intersections * Format updates * Fixes segregated indentification to not mark `circular` edge as segregated * Added intersection prior to turn so we still call out end of road * updated expectation to be turn instead of continue * Confirmed with @oxidase that the lane information if correct - updated the expectation * Added logic to handle wider straights Fixed tests * Update CHANGELOG.md Added #4925 * Removed TODO * Process straight step prior to wider straight step
2018-03-30 07:43:56 -04:00
| ha | road | primary | yes | |
turn lane handler moved to scenario based handling
2016-06-30 03:31:08 -04:00
| ab | road | primary | yes | left\|right |
| bc | cross | primary | yes | |
| fbg | cross | primary | yes | |
| dce | cross | primary | yes | |
Added post process logic to collapse segregated turn instructions (#4925) * Added post process logic to collapse segregated turn instructions * format updates * Fixed coordinates to reflect reality Updated left turn road name * fixed coordinates to fix test * Skip last step when processing segregated steps * updated segregated turn test * Updated segregated test * Updated test: Segregated Intersection, Cross Belonging to Correct Street - features/guidance/collapse.feature:79 * Fixed all but one for features/guidance/collapse.feature:124 * Fixed Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of th 9 failures for Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of the 9 failures for Scenario: Segregated Intersection, Cross Belonging to Mixed Streets - Slight Angles (2) - features/guidance/collapse.feature:318 * Fixed Scenario: Segregated Intersection into Slight Turn - features/guidance/collapse.feature:581 * Updated Scenario: U-turn after a traffic light - features/guidance/turn-lanes.feature:1220 * Updated how we combine segregated steps * Added test to Verify end of road left turn across divided roads * Fixed divided highwat tests * Fixed test failure * fixed Scenario: Partitioned turn, Slight Curve - maxspeed - features/guidance/turn-lanes.feature:936 * Fixed Scenario: Partitioned turn, Slight Curve - features/guidance/turn-lanes.feature:961 * Added strategies to combine segrgated intersections * Added setModifier alias for readability * Added strategies to combine segrgated intersections * Format updates * Fixes segregated indentification to not mark `circular` edge as segregated * Added intersection prior to turn so we still call out end of road * updated expectation to be turn instead of continue * Confirmed with @oxidase that the lane information if correct - updated the expectation * Added logic to handle wider straights Fixed tests * Update CHANGELOG.md Added #4925 * Removed TODO * Process straight step prior to wider straight step
2018-03-30 07:43:56 -04:00
| iaj | kross | primary | no | |
turn lane handler moved to scenario based handling
2016-06-30 03:31:08 -04:00
When I route I should get
Added post process logic to collapse segregated turn instructions (#4925) * Added post process logic to collapse segregated turn instructions * format updates * Fixed coordinates to reflect reality Updated left turn road name * fixed coordinates to fix test * Skip last step when processing segregated steps * updated segregated turn test * Updated segregated test * Updated test: Segregated Intersection, Cross Belonging to Correct Street - features/guidance/collapse.feature:79 * Fixed all but one for features/guidance/collapse.feature:124 * Fixed Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of th 9 failures for Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of the 9 failures for Scenario: Segregated Intersection, Cross Belonging to Mixed Streets - Slight Angles (2) - features/guidance/collapse.feature:318 * Fixed Scenario: Segregated Intersection into Slight Turn - features/guidance/collapse.feature:581 * Updated Scenario: U-turn after a traffic light - features/guidance/turn-lanes.feature:1220 * Updated how we combine segregated steps * Added test to Verify end of road left turn across divided roads * Fixed divided highwat tests * Fixed test failure * fixed Scenario: Partitioned turn, Slight Curve - maxspeed - features/guidance/turn-lanes.feature:936 * Fixed Scenario: Partitioned turn, Slight Curve - features/guidance/turn-lanes.feature:961 * Added strategies to combine segrgated intersections * Added setModifier alias for readability * Added strategies to combine segrgated intersections * Format updates * Fixes segregated indentification to not mark `circular` edge as segregated * Added intersection prior to turn so we still call out end of road * updated expectation to be turn instead of continue * Confirmed with @oxidase that the lane information if correct - updated the expectation * Added logic to handle wider straights Fixed tests * Update CHANGELOG.md Added #4925 * Removed TODO * Process straight step prior to wider straight step
2018-03-30 07:43:56 -04:00
| waypoints | route | turns | lanes | locations |
| h,g | road,cross,cross | depart,turn right,arrive | ;,left:false right:true, | h,b,g |
| h,e | road,cross,cross | depart,end of road left,arrive | ;,left:true right:false;left:true right:false, | h,b,e |
fix use-lane handling
2016-07-21 10:36:00 -04:00
Lane Handling for multiple indications per lane as in left;left|, fixes #2694 Before we asserted on unique lane indications per lane. Turns out the OSM data contains lane strings such as: left;left|right Which represents two lanes as in: << > || | The two left indications _on a single lane_ look like data issue. And we can't represent this with our enum-approach at the moment. We don't want to crash there, so silently swallow this and generate a single left|right for it.
2016-07-25 05:43:35 -04:00
Scenario: Lane Parsing Issue #2694
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
c
a b
d
"""
Lane Handling for multiple indications per lane as in left;left|, fixes #2694 Before we asserted on unique lane indications per lane. Turns out the OSM data contains lane strings such as: left;left|right Which represents two lanes as in: << > || | The two left indications _on a single lane_ look like data issue. And we can't represent this with our enum-approach at the moment. We don't want to crash there, so silently swallow this and generate a single left|right for it.
2016-07-25 05:43:35 -04:00
And the ways
| nodes | highway | turn:lanes:forward |
| ab | primary | left;left\|right |
| bc | primary | |
| bd | primary | |
fix use-lane handling
2016-07-21 10:36:00 -04:00
Lane Handling for multiple indications per lane as in left;left|, fixes #2694 Before we asserted on unique lane indications per lane. Turns out the OSM data contains lane strings such as: left;left|right Which represents two lanes as in: << > || | The two left indications _on a single lane_ look like data issue. And we can't represent this with our enum-approach at the moment. We don't want to crash there, so silently swallow this and generate a single left|right for it.
2016-07-25 05:43:35 -04:00
When I route I should get
| waypoints | route | turns | lanes |
| a,c | ab,bc,bc | depart,turn left,arrive | ,left:true right:false, |
Try to come up with a small test case
2016-08-01 08:27:38 -04:00
Reproducing breaking intersection in cucumber scenario Conflicts: src/extractor/guidance/turn_lane_augmentation.cpp
2016-08-01 11:20:08 -04:00
# http://www.openstreetmap.org/#map=19/47.97685/7.82933&layers=D
Fix "Error: write after end" and removed @bug tags https://nodejs.org/api/child_process.html#child_process_event_exit Note that when the 'exit' event is triggered, child process stdio streams might still be open.
2016-09-20 14:39:55 -04:00
@todo
Reproducing breaking intersection in cucumber scenario Conflicts: src/extractor/guidance/turn_lane_augmentation.cpp
2016-08-01 11:20:08 -04:00
Scenario: Lane Parsing Issue #2706: None Assignments I
Try to come up with a small test case
2016-08-01 08:27:38 -04:00
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
f j
a b c d e
i
g h
"""
Try to come up with a small test case
2016-08-01 08:27:38 -04:00
And the nodes
| node | highway |
| a | traffic_signals |
| i | traffic_signals |
And the ways
| nodes | highway | name | oneway | turn:lanes:forward |
| ab | secondary | Wiesentalstr | | through;left\|right |
| bc | secondary | Wiesentalstr | | none\|left;through |
| cd | secondary | Wiesentalstr | | none\|left;through |
| de | residential | Wippertstr | | |
| fb | secondary | Merzhauser Str | yes | through\|through\|right |
| bg | secondary | Merzhauser Str | yes | |
| hi | secondary | Merzhauser Str | yes | left;reverse\|none\|none |
| ic | secondary_link | Merzhauser Str | yes | |
| id | secondary | Merzhauser Str | yes | through;right\|none |
| dj | secondary | Merzhauser Str | yes | |
And the relations
| type | way:from | way:to | node:via | restriction |
| restriction | fb | fb | b | no_left_turn |
| restriction | ic | cb | c | only_left_turn |
| restriction | id | dc | d | no_left_turn |
When I route I should get
| waypoints | route | turns | lanes |
| h,a ||||
# Note: at the moment we don't care about routes, we care about the extract process triggering assertions
Reproducing breaking intersection in cucumber scenario Conflicts: src/extractor/guidance/turn_lane_augmentation.cpp
2016-08-01 11:20:08 -04:00
Disable our added failing cucumber tests for now
2016-08-04 05:16:00 -04:00
# https://www.openstreetmap.org/#map=19/47.99257/7.83276&layers=D
Fix "Error: write after end" and removed @bug tags https://nodejs.org/api/child_process.html#child_process_event_exit Note that when the 'exit' event is triggered, child process stdio streams might still be open.
2016-09-20 14:39:55 -04:00
@todo
Reproducing breaking intersection in cucumber scenario Conflicts: src/extractor/guidance/turn_lane_augmentation.cpp
2016-08-01 11:20:08 -04:00
Scenario: Lane Parsing Issue #2706: None Assignments II
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
k l
j a b f
i c d e
h g
"""
Reproducing breaking intersection in cucumber scenario Conflicts: src/extractor/guidance/turn_lane_augmentation.cpp
2016-08-01 11:20:08 -04:00
And the ways
| nodes | highway | name | oneway | turn:lanes |
| ka | secondary | Eschholzstr | yes | left;reverse\|through\|through\|none |
| kj | unclassified | kj | yes | |
| ac | secondary | Eschholzstr | yes | left;reverse\|none\|none\|none |
| ch | secondary | Eschholzstr | yes | |
| gd | secondary | Eschholzstr | yes | left;reverse\|through\|through\|none |
| db | secondary | Eschholzstr | yes | left;reverse\|through\|through\|none |
| bl | secondary | Eschholzstr | yes | |
| fb | residential | Haslacher Str | yes | left;reverse\|left;through\|right |
| ba | secondary_link | Haslacher Str | yes | left;reverse\|left;through |
| aj | unclassified | Haslacher Str | yes | |
| ic | unclassified | Haslacher Str | yes | left;reverse\|left\|through |
| cd | secondary_link | Haslacher Str | yes | left;reverse\|left\|through |
| de | residential | Haslacher Str | yes | |
And the relations
| type | way:from | way:to | node:via | restriction |
| restriction | ka | ac | a | only_straight_on |
| restriction | ic | cd | c | only_straight_on |
| restriction | gd | db | d | only_straight_on |
When I route I should get
| waypoints | route | turns | lanes |
| i,e ||||
# Note: at the moment we don't care about routes, we care about the extract process triggering assertions
Add a minimal version of the failing test case.
2016-08-02 01:41:40 -04:00
Fix "Error: write after end" and removed @bug tags https://nodejs.org/api/child_process.html#child_process_event_exit Note that when the 'exit' event is triggered, child process stdio streams might still be open.
2016-09-20 14:39:55 -04:00
@todo
Add a minimal version of the failing test case.
2016-08-02 01:41:40 -04:00
Scenario: Lane Parsing Issue #2706: None Assignments III - Minimal reproduction recipe
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
l
a b
d
"""
Add a minimal version of the failing test case.
2016-08-02 01:41:40 -04:00
And the ways
| nodes | highway | name | oneway | turn:lanes |
| db | secondary | Eschholzstr | yes | left;reverse\|through\|through\|none |
| bl | secondary | Eschholzstr | yes | |
| ba | secondary_link | Haslacher Str | yes | |
When I route I should get
| waypoints | route | turns | lanes |
| d,a ||||
# Note: at the moment we don't care about routes, we care about the extract process triggering assertions
adjusting u-turn handling in lane matching to fully fix 2706
2016-08-08 09:44:58 -04:00
fix errors introduced in refactor
2016-08-12 11:04:40 -04:00
@reverse @2730 @todo
adjusting u-turn handling in lane matching to fully fix 2706
2016-08-08 09:44:58 -04:00
Scenario: Reverse on the right
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
a c
b d
f e
"""
adjusting u-turn handling in lane matching to fully fix 2706
2016-08-08 09:44:58 -04:00
And the ways
| nodes | highway | name | turn:lanes:forward | oneway |
| ab | primary | in | left\|through\|right;reverse | yes |
| bc | primary | left | | no |
| bd | primary | through | | no |
| be | primary | right | | no |
| bf | primary | in | | yes |
When I route I should get
| waypoints | route | turns | lanes |
| a,c | in,left,left | depart,turn left,arrive | ,left:true straight:false right;uturn:false, |
| a,d | in,through,through | depart,new name straight,arrive | ,left:false straight:true right;uturn:false, |
| a,e | in,right,right | depart,turn right,arrive | ,left:false straight:false right;uturn:true, |
turn lane handler moved to scenario based handling
2016-06-30 03:31:08 -04:00
@todo @2654
#https://github.com/Project-OSRM/osrm-backend/issues/2645
#http://www.openstreetmap.org/export#map=19/52.56054/13.32152
Scenario: Kurt-Schuhmacher-Damm
Given the node map
cucumber: change syntax of node maps
2016-09-30 03:33:08 -04:00
"""
g f
j h e
a b c
i d
"""
turn lane handler moved to scenario based handling
2016-06-30 03:31:08 -04:00
And the ways
| nodes | name | highway | oneway | turn:lanes |
| ab | | motorway_link | yes | left\|none\|right |
| bc | | primary_link | yes | |
| cd | ksd | secondary | yes | |
| cef | ksd | primary | yes | |
| hj | | motorway_link | yes | |
| eh | | secondary_link | yes | |
| gh | ksd | primary | yes | |
| hbi | ksd | secondary | yes | |
When I route I should get
| waypoints | route | turns | lanes |
| a,f | ,ksd,ksd | depart,turn left,arrive | ,left:true none:true right:false, |
| a,i | ,ksd,ksd | depart,turn right,arrive | ,left:false none:true right:true, |
Turn Angles in OSRM were computed using a lookahead of 10 meters. This PR adds more advanced coordinate extraction, analysing the road to detect offsets due to OSM way modelling. In addition it improves the handling of bearings. Right now OSM reports bearings simply based on the very first coordinate along a way. With this PR, we store the bearings for a turn correctly, making the bearings for turns correct.
2016-08-17 03:49:19 -04:00
Scenario: Reverse Not Allowed
Given the node map
"""
n o
f - - e\- - g-j-m
d | |
a - 1 b/- - c-i-l
h k
"""
And the ways
| nodes | name | highway | oneway | turn:lanes:forward |
| abc | road | secondary | yes | left\|through\|right |
| cil | road | secondary | yes | |
| mjgef | road | secondary | yes | |
| bde | road | secondary_link | yes | |
| ngch | turn | secondary | yes | |
| kijo | turn | secondary | yes | |
When I route I should get
| waypoints | bearings | route | turns |
| 1,a | 90,2 180,180 | | |
add failing test
2017-02-10 11:51:01 -05:00
@3379
Scenario: Don't Turn through potential through lanes
Given the node map
"""
d
|
a - - - - b - - - - - c
|
e
"""
And the ways
| nodes | name | oneway | turn:lanes:forward |
| ab | road | yes | left\|none\|none |
| bc | road | yes | |
| ebd | cross | no | |
When I route I should get
| waypoints | route | turns | lanes |
| a,e | road,cross,cross | depart,turn right,arrive | ,left:false none:false none:true, |
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| a,c | road,road | depart,arrive | ;left:false none:true none:true, |
fix handling none-tags in presence of multiple turns within
2017-02-10 12:30:15 -05:00
@3379
Scenario: Don't Turn through potential through lanes
Given the node map
"""
d
|
a - - - - b - - - - - c
|
e
"""
And the ways
| nodes | name | oneway | turn:lanes:forward |
| ab | road | yes | none\|none\|right |
| bc | road | yes | |
| ebd | cross | no | |
When I route I should get
| waypoints | route | turns | lanes |
| a,d | road,cross,cross | depart,turn left,arrive | ,none:true none:false right:false, |
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| a,c | road,road | depart,arrive | ;none:true none:true right:false, |
Test case for #4189
2017-06-22 08:28:32 -04:00
@4189
Scenario: U-turn after a traffic light
Given the node map
"""
j k
: :
f---g-h-i
: :
a-b-c-d-e
: :
l m
"""
And the nodes
| node | highway |
| b | traffic_signals |
And the ways
| nodes | name | lanes | turn:lanes | oneway |
| ab | road1 | 3 | left\|through\|through;right | yes |
| bcde | road1 | 2 | | yes |
| ihgf | road1 | 2 | | yes |
| jgcl | road2 | 2 | | yes |
| mdhk | road2 | 2 | | yes |
When I route I should get
deprecate use-lane -- the information can be found in the intersections array
2017-07-10 06:46:18 -04:00
| waypoints | route | turns | lanes | locations |
Added post process logic to collapse segregated turn instructions (#4925) * Added post process logic to collapse segregated turn instructions * format updates * Fixed coordinates to reflect reality Updated left turn road name * fixed coordinates to fix test * Skip last step when processing segregated steps * updated segregated turn test * Updated segregated test * Updated test: Segregated Intersection, Cross Belonging to Correct Street - features/guidance/collapse.feature:79 * Fixed all but one for features/guidance/collapse.feature:124 * Fixed Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of th 9 failures for Scenario: Partly Segregated Intersection, Two Segregated Roads, Intersection belongs to Second - features/guidance/collapse.feature:219 * Fixed 7 of the 9 failures for Scenario: Segregated Intersection, Cross Belonging to Mixed Streets - Slight Angles (2) - features/guidance/collapse.feature:318 * Fixed Scenario: Segregated Intersection into Slight Turn - features/guidance/collapse.feature:581 * Updated Scenario: U-turn after a traffic light - features/guidance/turn-lanes.feature:1220 * Updated how we combine segregated steps * Added test to Verify end of road left turn across divided roads * Fixed divided highwat tests * Fixed test failure * fixed Scenario: Partitioned turn, Slight Curve - maxspeed - features/guidance/turn-lanes.feature:936 * Fixed Scenario: Partitioned turn, Slight Curve - features/guidance/turn-lanes.feature:961 * Added strategies to combine segrgated intersections * Added setModifier alias for readability * Added strategies to combine segrgated intersections * Format updates * Fixes segregated indentification to not mark `circular` edge as segregated * Added intersection prior to turn so we still call out end of road * updated expectation to be turn instead of continue * Confirmed with @oxidase that the lane information if correct - updated the expectation * Added logic to handle wider straights Fixed tests * Update CHANGELOG.md Added #4925 * Removed TODO * Process straight step prior to wider straight step
2018-03-30 07:43:56 -04:00
| a,f | road1,road1,road1 | depart,continue uturn,arrive | ,;left:true straight:false straight;right:false;;, | a,c,f |
Reference in New Issue Copy Permalink