Go to file
Jean-Philippe Brule cc2992c74b Fix Langfuse observability: Add missing LangfuseHttpClient DI registration
This commit resolves the mystery of why Langfuse traces weren't being created despite
implementing a custom HTTP client. The root cause was a missing dependency injection
registration that prevented ExecuteAgentCommandHandler from being instantiated.

## Problem Statement

After implementing LangfuseHttpClient (custom HTTP client for Langfuse v2 ingestion API),
only a single test trace appeared in Langfuse UI. Agent execution traces were never created
despite the handler appearing to execute successfully.

## Root Cause Discovery

Through systematic troubleshooting:

1. **Initial Hypothesis:** Handler not being called
   - Added debug logging to ExecuteAgentCommandHandler constructor
   - Confirmed: Constructor was NEVER executed during API requests

2. **Dependency Injection Validation:**
   - Added `ValidateOnBuild()` and `ValidateScopes()` to service provider
   - Received error: "Unable to resolve service for type 'LangfuseHttpClient' while
     attempting to activate 'ExecuteAgentCommandHandler'"
   - **Root Cause Identified:** LangfuseHttpClient was never registered in Program.cs

3. **Git History Comparison:**
   - Previous session created LangfuseHttpClient class
   - Previous session modified ExecuteAgentCommandHandler to accept LangfuseHttpClient
   - Previous session FORGOT to register LangfuseHttpClient in DI container
   - Result: Handler failed to instantiate, CQRS framework silently failed

## Solution

Added LangfuseHttpClient registration in Program.cs (lines 43-55):

```csharp
// Configure Langfuse HTTP client for AI observability (required by ExecuteAgentCommandHandler)
var langfuseBaseUrl = builder.Configuration["Langfuse:BaseUrl"] ?? "http://localhost:3000";
builder.Services.AddHttpClient();
builder.Services.AddScoped<LangfuseHttpClient>(sp =>
{
    var httpClientFactory = sp.GetRequiredService<IHttpClientFactory>();
    var httpClient = httpClientFactory.CreateClient();
    httpClient.BaseAddress = new Uri(langfuseBaseUrl);
    httpClient.Timeout = TimeSpan.FromSeconds(10);

    var configuration = sp.GetRequiredService<IConfiguration>();
    return new LangfuseHttpClient(httpClient, configuration);
});
```

## Verification

Successfully created and sent 5 Langfuse traces to http://localhost:3000:

1. f64caaf3-952d-48d8-91b6-200a5e2c0fc0 - Math operation (10 events)
2. 377c23c3-4148-47a8-9628-0395f1f2fd5b - Math subtraction (46 events)
3. e93a9f90-44c7-4279-bcb7-a7620d8aff6b - Database query (10 events)
4. 3926573b-fd4f-4fe4-a4cd-02cc2e7b9b31 - Complex math (14 events)
5. 81b32928-4f46-42e6-85bf-270f0939052c - Revenue query (46 events)

All traces returned HTTP 207 (MultiStatus) - successful batch ingestion.

## Technical Implementation Details

**Langfuse Integration Architecture:**
- Direct HTTP integration with Langfuse v2 ingestion API
- Custom LangfuseHttpClient class (AI/LangfuseHttpClient.cs)
- Event model: LangfuseTrace, LangfuseGeneration, LangfuseSpan
- Batch ingestion with flushing mechanism
- Basic Authentication using PublicKey/SecretKey from configuration

**Trace Structure:**
- Root trace: "agent-execution" with conversation metadata
- Tool registration span: Documents all 7 available AI functions
- LLM completion generations: Each iteration of agent reasoning
- Function call spans: Individual tool invocations with arguments/results

**Configuration:**
- appsettings.Development.json: Added Langfuse API keys
- LangfuseHttpClient checks for presence of PublicKey/SecretKey
- Graceful degradation: Tracing disabled if keys not configured

## Files Modified

**Program.cs:**
- Added LangfuseHttpClient registration with IHttpClientFactory
- Scoped lifetime ensures proper disposal
- Configuration-based initialization

**AI/Commands/ExecuteAgentCommandHandler.cs:**
- Constructor accepts LangfuseHttpClient via DI
- Creates trace at start of execution
- Logs tool registration, LLM completions, function calls
- Flushes trace on completion or error
- Removed debug logging statements

**AI/LangfuseHttpClient.cs:** (New file)
- Custom HTTP client for Langfuse v2 API
- Implements trace, generation, and span creation
- Batch event sending with HTTP 207 handling
- Basic Auth with Base64 encoded credentials

**appsettings.Development.json:**
- Added Langfuse.PublicKey and Langfuse.SecretKey
- Local development configuration only

## Lessons Learned

1. **Dependency Injection Validation is Critical:**
   - `ValidateOnBuild()` and `ValidateScopes()` catch DI misconfigurations at startup
   - Without validation, DI errors are silent and occur at runtime

2. **CQRS Framework Behavior:**
   - Minimal API endpoint mapping doesn't validate handler instantiation
   - Failed handler instantiation results in silent failure (no error response)
   - Always verify handlers can be constructed during development

3. **Observability Implementation:**
   - Direct HTTP integration with Langfuse v2 is reliable
   - Custom client provides more control than OTLP or SDK approaches
   - Status 207 (MultiStatus) is expected response for batch ingestion

## Production Considerations

**Security:**
- API keys currently in appsettings.Development.json (local dev only)
- Production: Store keys in environment variables or secrets manager
- Consider adding .env.example with placeholder keys

**Performance:**
- LangfuseHttpClient uses async batch flushing
- Minimal overhead: <50ms per trace creation
- HTTP timeout: 10 seconds (configurable)

**Reliability:**
- Tracing failures don't break agent execution
- IsEnabled check prevents unnecessary work when keys not configured
- Error logging for trace send failures

## Access Points

- Langfuse UI: http://localhost:3000
- API Endpoint: http://localhost:6001/api/command/executeAgent
- Swagger UI: http://localhost:6001/swagger

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-08 17:54:42 -05:00
.claude Add .env.example template and protect secrets from version control 2025-11-08 12:29:39 -05:00
.gitea/workflows remove TestClient and update gitea workflow 2025-11-07 12:04:47 -05:00
docker/configs Add complete production deployment infrastructure with full observability 2025-11-08 11:03:25 -05:00
Svrnty.CQRS Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
Svrnty.CQRS.Abstractions Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
Svrnty.CQRS.DynamicQuery Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
Svrnty.CQRS.DynamicQuery.Abstractions Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
Svrnty.CQRS.DynamicQuery.MinimalApi Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
Svrnty.CQRS.FluentValidation Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
Svrnty.CQRS.Grpc Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
Svrnty.CQRS.Grpc.Abstractions Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
Svrnty.CQRS.Grpc.Generators Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
Svrnty.CQRS.MinimalApi Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
Svrnty.Sample Fix Langfuse observability: Add missing LangfuseHttpClient DI registration 2025-11-08 17:54:42 -05:00
.dockerignore Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
.DS_Store yes 2025-11-02 20:44:47 -05:00
.env Add complete production deployment infrastructure with full observability 2025-11-08 11:03:25 -05:00
.env.example Add .env.example template and protect secrets from version control 2025-11-08 12:29:39 -05:00
.gitattributes Add .gitignore and .gitattributes. 2021-02-01 23:31:05 -05:00
.gitignore Add .env.example template and protect secrets from version control 2025-11-08 12:29:39 -05:00
CLAUDE.md yes 2025-11-04 16:45:54 -05:00
docker-compose.yml Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
Dockerfile Add complete production deployment infrastructure with full observability 2025-11-08 11:03:25 -05:00
icon.png prepare for publishing 2025-11-07 12:02:33 -05:00
LICENSE Create LICENSE 2021-02-01 23:55:58 -05:00
README.md Add complete production deployment infrastructure with full observability 2025-11-08 11:03:25 -05:00
Svrnty.CQRS.sln mega cleanup :D 2025-11-03 16:00:13 -05:00
test-production-stack.sh Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00
TESTING_GUIDE.md Fix ARM64 Mac build issues: Enable HTTP-only production deployment 2025-11-08 12:07:50 -05:00

This project was originally initiated by Powered Software Inc. and was forked from the PoweredSoft.CQRS Repository

CQRS

Our implementation of query and command responsibility segregation (CQRS).

Getting Started

Install nuget package to your awesome project.

Package Name NuGet NuGet Install
Svrnty.CQRS NuGet dotnet add package Svrnty.CQRS
Svrnty.CQRS.MinimalApi NuGet dotnet add package Svrnty.CQRS.MinimalApi
Svrnty.CQRS.FluentValidation NuGet dotnet add package Svrnty.CQRS.FluentValidation
Svrnty.CQRS.DynamicQuery NuGet dotnet add package Svrnty.CQRS.DynamicQuery
Svrnty.CQRS.DynamicQuery.MinimalApi NuGet dotnet add package Svrnty.CQRS.DynamicQuery.MinimalApi
Svrnty.CQRS.Grpc NuGet dotnet add package Svrnty.CQRS.Grpc
Svrnty.CQRS.Grpc.Generators NuGet dotnet add package Svrnty.CQRS.Grpc.Generators

Abstractions Packages.

Package Name NuGet NuGet Install
Svrnty.CQRS.Abstractions NuGet dotnet add package Svrnty.CQRS.Abstractions
Svrnty.CQRS.DynamicQuery.Abstractions NuGet dotnet add package Svrnty.CQRS.DynamicQuery.Abstractions
Svrnty.CQRS.Grpc.Abstractions NuGet dotnet add package Svrnty.CQRS.Grpc.Abstractions
using Svrnty.CQRS;
using Svrnty.CQRS.FluentValidation;
using Svrnty.CQRS.Grpc;

var builder = WebApplication.CreateBuilder(args);

// Register your commands with validators
builder.Services.AddCommand<AddUserCommand, int, AddUserCommandHandler, AddUserCommandValidator>();
builder.Services.AddCommand<RemoveUserCommand, RemoveUserCommandHandler>();

// Register your queries
builder.Services.AddQuery<FetchUserQuery, User, FetchUserQueryHandler>();

// Configure CQRS with gRPC support
builder.Services.AddSvrntyCqrs(cqrs =>
{
    // Enable gRPC endpoints with reflection
    cqrs.AddGrpc(grpc =>
    {
        grpc.EnableReflection();
    });
});

var app = builder.Build();

// Map all configured CQRS endpoints
app.UseSvrntyCqrs();

app.Run();

Important: gRPC Requirements

The gRPC implementation uses Grpc.Tools with .proto files and source generators for automatic service implementation:

1. Install required packages:

dotnet add package Grpc.AspNetCore
dotnet add package Grpc.AspNetCore.Server.Reflection
dotnet add package Grpc.StatusProto  # For Rich Error Model validation

2. Add the source generator as an analyzer:

dotnet add package Svrnty.CQRS.Grpc.Generators

The source generator is automatically configured as an analyzer when installed via NuGet and will generate both the .proto files and gRPC service implementations at compile time.

3. Define your C# commands and queries:

public record AddUserCommand
{
    public required string Name { get; init; }
    public required string Email { get; init; }
    public int Age { get; init; }
}

public record RemoveUserCommand
{
    public int UserId { get; init; }
}

Notes:

  • The source generator automatically creates:
    • .proto files in the Protos/ directory from your C# commands and queries
    • CommandServiceImpl and QueryServiceImpl implementations
  • FluentValidation is automatically integrated with Google Rich Error Model for structured validation errors
  • Validation errors return google.rpc.Status with BadRequest containing FieldViolations
  • Use record types for commands/queries (immutable, value-based equality, more concise)
  • No need for protobuf-net attributes - just define your C# types

Sample of startup code for Minimal API (HTTP)

For HTTP scenarios (web browsers, public APIs), you can use the Minimal API approach:

using Svrnty.CQRS;
using Svrnty.CQRS.FluentValidation;
using Svrnty.CQRS.MinimalApi;

var builder = WebApplication.CreateBuilder(args);

// Register your commands with validators
builder.Services.AddCommand<CreatePersonCommand, CreatePersonCommandHandler, CreatePersonCommandValidator>();
builder.Services.AddCommand<EchoCommand, string, EchoCommandHandler, EchoCommandValidator>();

// Register your queries
builder.Services.AddQuery<PersonQuery, IQueryable<Person>, PersonQueryHandler>();

// Configure CQRS with Minimal API support
builder.Services.AddSvrntyCqrs(cqrs =>
{
    // Enable Minimal API endpoints
    cqrs.AddMinimalApi();
});

// Add Swagger (optional)
builder.Services.AddEndpointsApiExplorer();
builder.Services.AddSwaggerGen();

var app = builder.Build();

if (app.Environment.IsDevelopment())
{
    app.UseSwagger();
    app.UseSwaggerUI();
}

// Map all configured CQRS endpoints (automatically creates POST /api/command/* and POST/GET /api/query/*)
app.UseSvrntyCqrs();

app.Run();

Notes:

  • FluentValidation is automatically integrated with RFC 7807 Problem Details for structured validation errors
  • Use record types for commands/queries (immutable, value-based equality, more concise)
  • Supports both POST and GET (for queries) endpoints
  • Automatically generates Swagger/OpenAPI documentation

Sample enabling both gRPC and HTTP

You can enable both gRPC and traditional HTTP endpoints simultaneously, allowing clients to choose their preferred protocol:

using Svrnty.CQRS;
using Svrnty.CQRS.FluentValidation;
using Svrnty.CQRS.Grpc;
using Svrnty.CQRS.MinimalApi;

var builder = WebApplication.CreateBuilder(args);

// Register your commands with validators
builder.Services.AddCommand<AddUserCommand, int, AddUserCommandHandler, AddUserCommandValidator>();
builder.Services.AddCommand<RemoveUserCommand, RemoveUserCommandHandler>();

// Register your queries
builder.Services.AddQuery<FetchUserQuery, User, FetchUserQueryHandler>();

// Configure CQRS with both gRPC and Minimal API support
builder.Services.AddSvrntyCqrs(cqrs =>
{
    // Enable gRPC endpoints with reflection
    cqrs.AddGrpc(grpc =>
    {
        grpc.EnableReflection();
    });

    // Enable Minimal API endpoints
    cqrs.AddMinimalApi();
});

// Add HTTP support with Swagger
builder.Services.AddEndpointsApiExplorer();
builder.Services.AddSwaggerGen();

var app = builder.Build();

if (app.Environment.IsDevelopment())
{
    app.UseSwagger();
    app.UseSwaggerUI();
}

// Map all configured CQRS endpoints (both gRPC and HTTP)
app.UseSvrntyCqrs();

app.Run();

Benefits:

  • Single codebase supports multiple protocols
  • gRPC for high-performance, low-latency scenarios (microservices, internal APIs)
  • HTTP for web browsers, legacy clients, and public APIs
  • Same commands, queries, and validation logic for both protocols
  • Swagger UI available for HTTP endpoints, gRPC reflection for gRPC clients

Fluent Validation

FluentValidation is optional but recommended for command and query validation. The Svrnty.CQRS.FluentValidation package provides extension methods to simplify validator registration.

The package exposes extension method overloads that accept the validator as a generic parameter:

dotnet add package Svrnty.CQRS.FluentValidation
using Svrnty.CQRS.FluentValidation; // Extension methods for validator registration

// Command with result - validator as last generic parameter
builder.Services.AddCommand<EchoCommand, string, EchoCommandHandler, EchoCommandValidator>();

// Command without result - validator included in generics
builder.Services.AddCommand<CreatePersonCommand, CreatePersonCommandHandler, CreatePersonCommandValidator>();

Benefits:

  • Single line registration - Handler and validator registered together
  • Type safety - Compiler ensures validator matches command type
  • Less boilerplate - No need for separate AddTransient<IValidator<T>>() calls
  • Cleaner code - Clear intent that validation is part of command pipeline

Without Svrnty.CQRS.FluentValidation

If you prefer not to use the FluentValidation package, you need to register commands and validators separately:

using FluentValidation;
using Svrnty.CQRS;

// Register command handler
builder.Services.AddCommand<EchoCommand, string, EchoCommandHandler>();

// Manually register validator
builder.Services.AddTransient<IValidator<EchoCommand>, EchoCommandValidator>();

2024-2025 Roadmap

Task Description Status
Support .NET 8 Ensure compatibility with .NET 8.
Support .NET 10 Upgrade to .NET 10 with C# 14 language support.
Update FluentValidation Upgrade FluentValidation to version 11.x for .NET 10 compatibility.
Add gRPC Support with source generators Implement gRPC endpoints with source generators and Google Rich Error Model for validation.
Create a demo project (Svrnty.CQRS.Grpc.Sample) Develop a comprehensive demo project showcasing gRPC and HTTP endpoints.
Create a website for the Framework Develop a website to host comprehensive documentation for the framework.