osrm-backend/features/car
Michael Bell 9ad432c5b2
Fix adding traffic signal penalties during compression (#6419)
Weight and duration penalties are flipped in the lambda function
that applies penalties from traffic signals.

Duration is in deciseconds, whilst weight is multipled by
10^weight_precision, with weight_precision being 1 by default.

Therefore, for default routability profile, the penalties end up
being the same, hence why no tests picked this up.

If distance weight is used however, it will incorrectly apply an
additional penalty to the weight, and not add the traffic signal
delay to the duration in the routing graph.

To confuse things further, in some API responses the values are
correct because they use geometry data instead, but it's still
possible that a sub-optimal route was selected.

However, given the distance weight is in meters, and the additional
penalty per traffic light would be 20, it's unlikely this would
have changed the routing results.

In any case, we correct the function to apply the arguments correctly.
2022-10-23 14:59:12 +01:00
..
access.feature Fix distance calculation consistency. (#6315) 2022-08-19 22:31:40 +01:00
advisory.feature Removes constant speed offset from calibration two years ago, resolves #3023. 2016-10-22 06:48:49 +02:00
avoid.feature Add failing test 2017-12-16 23:45:04 +00:00
barrier.feature Add kerb barrier exception to default car profile 2021-03-31 01:17:19 +01:00
bridge.feature update tests 2017-11-06 13:34:02 -05:00
classes.feature Set type of trivial intersections where classes change to Suppressed 2018-01-25 11:43:44 -05:00
conditional_restrictions.feature Add support for multiple via-way restrictions (#5907) 2020-12-20 13:59:57 -08:00
construction.feature Makes construction=minor ways routable again, see #4258 2017-07-19 16:24:45 +00:00
destination.feature Support snapping to multiple ways at an input location (#5953) 2022-08-27 11:36:20 +01:00
ferry.feature Fix distance calculation consistency. (#6315) 2022-08-19 22:31:40 +01:00
hov.feature expose data about turning onto restricted roads to turn function 2017-02-20 12:40:51 +00:00
link.feature cucumber: change syntax of node maps 2016-10-11 09:07:48 +02:00
maxspeed.feature Fix distance calculation consistency. (#6315) 2022-08-19 22:31:40 +01:00
multi_via_restrictions.feature Fix snapping target locations to ways used in turn restrictions (#6339) 2022-08-27 15:59:44 +01:00
names.feature remove a few tests that are simply testing same code paths as others 2017-08-10 12:28:31 +02:00
oneway.feature car: add tests oneway:<mode> tags 2017-02-01 16:50:18 +01:00
permissive.feature update profile and tests for pushing of bikes 2013-02-03 14:46:18 +01:00
physical_limitation.feature Decrease max height to 2 meters 2019-03-04 13:23:17 +03:00
restrictions.feature Adds cucumber scenario for u turn restrictions at intersection (#4484) 2022-10-10 22:27:27 +02:00
route_relations.feature Adds cardinal_directions flag to profiles and disables ref-rewriting by default 2017-10-26 20:38:41 +01:00
service.feature Use rate rounding up to tenth in routability tests 2017-07-03 21:58:32 +00:00
shuttle_train.feature cucumber: change syntax of node maps 2016-10-11 09:07:48 +02:00
side_bias.feature Use the correct driving_side property on the arrive step. (#4708) 2017-11-27 13:16:33 -08:00
speed.feature Fix distance calculation consistency. (#6315) 2022-08-19 22:31:40 +01:00
startpoint.feature Fix distance calculation consistency. (#6315) 2022-08-19 22:31:40 +01:00
summaries.feature Announce reference change if names are empty, #4830 2018-01-29 16:32:59 -05:00
surface.feature Fix distance calculation consistency. (#6315) 2022-08-19 22:31:40 +01:00
traffic_light_penalties.feature Fix adding traffic signal penalties during compression (#6419) 2022-10-23 14:59:12 +01:00
traffic_turn_penalties.feature Remove generate-edge-lookup argument in feature tests 2017-05-05 22:15:05 +00:00
via.feature Splits via tests into car and testbot domain, resolves #4061 2017-05-30 16:38:51 +02:00
way.feature cleanup indentation of cuke files 2013-08-29 19:29:13 +02:00
weight.feature Fix distance calculation consistency. (#6315) 2022-08-19 22:31:40 +01:00