prepare 5.4.0-rc.7

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 5.4.0-rc.7
+  - Chages from 5.4.0-rc.6
+    - Bugfixes re-introduce space between two entries in summaries
+
 # 5.4.0-rc.6
   - Changes from 5.4.0-rc.5
     - Bugfixes

features/car/summaries.feature

@@ -23,10 +23,10 @@ Feature: Basic Routing
             | df    | street |
 
         When I route I should get
-            | waypoints | route                               | summary               |
-            | a,e       | road,,1 st,1 st                     | road,1 st             |
-            | a,d,f     | road,,,street,street                | road;street           |
-            | a,e,f     | road,,1 st,1 st,1 st,street,street  | road,1 st;1 st,street |
+            | waypoints | route                               | summary                 |
+            | a,e       | road,,1 st,1 st                     | road, 1 st              |
+            | a,d,f     | road,,,street,street                | road;street             |
+            | a,e,f     | road,,1 st,1 st,1 st,street,street  | road, 1 st;1 st, street |
 
      Scenario: Name Empty
         Given the node map
@@ -51,8 +51,8 @@ Feature: Basic Routing
             | bc    |      | 101 |
 
         When I route I should get
-            | waypoints | route | summary  |
-            | a,c       | road, | road,101 |
+            | waypoints | route | summary   |
+            | a,c       | road, | road, 101 |
 
      Scenario: Only Refs
         Given the node map
@@ -64,8 +64,8 @@ Feature: Basic Routing
             | bc    |      | 101 |
 
         When I route I should get
-            | waypoints | route  | summary |
-            | a,c       | ,      | 100,101 |
+            | waypoints | route  | summary  |
+            | a,c       | ,      | 100, 101 |
 
      Scenario: Single Ref
         Given the node map

features/testbot/summary.feature

@@ -18,12 +18,12 @@ Feature: Basic Routing
             | de    |
 
         When I route I should get
-            | from | to | route          | summary |
-            | a    | e  | ab,bc,cd,de,de | ab,bc   |
-            | e    | a  | de,cd,bc,ab,ab | de,bc   |
-            | a    | b  | ab,ab          | ab      |
-            | b    | d  | bc,cd,cd       | bc,cd   |
-            | 1    | c  | bc,bc          | bc      |
+            | from | to | route          | summary  |
+            | a    | e  | ab,bc,cd,de,de | ab, bc   |
+            | e    | a  | de,cd,bc,ab,ab | de, bc   |
+            | a    | b  | ab,ab          | ab       |
+            | b    | d  | bc,cd,cd       | bc, cd   |
+            | 1    | c  | bc,bc          | bc       |
 
     @smallest
     Scenario: Check handling empty values
@@ -40,8 +40,8 @@ Feature: Basic Routing
             | df    | df   |
 
         When I route I should get
-            | from | to | route          | summary |
-            | e    | a  | de,,bc,ab,ab   | de,bc   |
+            | from | to | route          | summary  |
+            | e    | a  | de,,bc,ab,ab   | de, bc   |
 
     @smallest @todo
     Scenario: Summaries when routing on a simple network
@@ -74,6 +74,6 @@ Feature: Basic Routing
             | xey   | cross  |we need this because phantom node segments are not considered for the summary |
 
         When I route I should get
-            | from | to | route                     | summary      |
-            | a    | 1  | first,first,second,second | first,second |
+            | from | to | route                     | summary       |
+            | a    | 1  | first,first,second,second | first, second |
 

include/engine/guidance/assemble_leg.hpp

@@ -198,7 +198,7 @@ inline RouteLeg assembleLeg(const datafacade::BaseDataFacade &facade,
 
         const auto summary_names = summary_array | boost::adaptors::transformed(name_id_to_string) |
                                    boost::adaptors::filtered(not_empty);
-        summary = boost::algorithm::join(summary_names, ",");
+        summary = boost::algorithm::join(summary_names, ", ");
     }
 
     return RouteLeg{duration, distance, summary, {}};