Update changelog and bump to 5.2.7

.clang-format

@@ -46,7 +46,7 @@ DerivePointerAlignment: false
 DisableFormat:   false
 ExperimentalAutoDetectBinPacking: false
 ForEachMacros:   [ foreach, Q_FOREACH, BOOST_FOREACH ]
-IncludeCategories:
+IncludeCategories: 
   - Regex:           '^<'
     Priority:        3
   - Regex:           '^"(osrm|util|engine|extract|contract)/'

.travis.yml

@@ -13,6 +13,7 @@ notifications:
 branches:
   only:
     - master
+    - "5.2"
 
 cache:
   ccache: true
@@ -24,7 +25,6 @@ env:
   global:
    - CCACHE_TEMPDIR=/tmp/.ccache-temp
    - CCACHE_COMPRESS=1
-   - CASHER_TIME_OUT=1000
    - JOBS=4
 
 matrix:
@@ -72,14 +72,6 @@ matrix:
           packages: ['g++-5', 'libbz2-dev', 'libstxxl-dev', 'libstxxl1', 'libxml2-dev', 'libzip-dev', 'lua5.1', 'liblua5.1-0-dev', 'libtbb-dev', 'libgdal-dev', 'libluabind-dev', 'libboost-all-dev', 'ccache']
       env: CCOMPILER='gcc-5' CXXCOMPILER='g++-5' BUILD_TYPE='Release'
 
-    - os: linux
-      compiler: "gcc-5-release-i686"
-      env: TARGET_ARCH='i686' CCOMPILER='gcc-5' CXXCOMPILER='g++-5' BUILD_TYPE='Release'
-
-    - os: linux
-      compiler: "gcc-4.8-release-armhf"
-      env: TARGET_ARCH='armhf' CCOMPILER='arm-linux-gnueabihf-gcc-4.8' CXXCOMPILER='arm-linux-gnueabihf-g++-4.8' BUILD_TYPE='Release'
-
       # Disabled because of CI slowness
       #- os: linux
       #- compiler: gcc
@@ -123,20 +115,19 @@ matrix:
       #- env: CCOMPILER='clang-3.8' CXXCOMPILER='clang++-3.8' BUILD_TYPE='Release' BUILD_SHARED_LIBS=ON
 
 before_install:
-  - if [[ ! -z $TARGET_ARCH ]] ; then source ./scripts/travis/before_install.$TARGET_ARCH.sh ; fi
   - if [[ $(uname -s) == 'Darwin' ]]; then sudo mdutil -i off /; fi;
   - source ./scripts/install_node.sh 4
   - npm install
   - DEPS_DIR="${TRAVIS_BUILD_DIR}/deps"
   - export PATH=${DEPS_DIR}/bin:${PATH} && mkdir -p ${DEPS_DIR}
   - CMAKE_URL="https://mason-binaries.s3.amazonaws.com/${TRAVIS_OS_NAME}-x86_64/cmake/3.5.2.tar.gz"
-  - travis_retry wget --quiet -O - ${CMAKE_URL} | tar --strip-components=1 -xz -C ${DEPS_DIR} || exit 1
+  - travis_retry wget --quiet -O - ${CMAKE_URL} | tar --strip-components=1 -xz -C ${DEPS_DIR}
   - |
     if [[ ${CLANG_VERSION:-false} != false ]]; then
       export CCOMPILER='clang'
       export CXXCOMPILER='clang++'
       CLANG_URL="https://mason-binaries.s3.amazonaws.com/${TRAVIS_OS_NAME}-x86_64/clang/${CLANG_VERSION}.tar.gz"
-      travis_retry wget --quiet -O - ${CLANG_URL} | tar --strip-components=1 -xz -C ${DEPS_DIR} || exit 1
+      travis_retry wget --quiet -O - ${CLANG_URL} | tar --strip-components=1 -xz -C ${DEPS_DIR}
     fi
   - |
     if [[ "${TRAVIS_OS_NAME}" == "osx" ]]; then
@@ -171,7 +162,6 @@ install:
   - popd
 
 script:
-  - if [[ $TARGET_ARCH == armhf ]] ; then echo "Skip tests for $TARGET_ARCH" && exit 0 ; fi
   - echo "travis_fold:start:BENCHMARK"
   - make -C test/data benchmark
   - echo "travis_fold:end:BENCHMARK"

CHANGELOG.md

@@ -1,64 +1,24 @@
-# 5.3.0
-  Changes from 5.3.0-rc.3
-    - Guidance
-      - Only announce `use lane` on required turns (not using all lanes to go straight)
-      - Moved `lanes` to the intersection objects. This is BREAKING in relation to other Release Candidates but not with respect to other releases.
-    - Bugfixes
-      - Fix BREAKING: bug that could result in failure to load 'osrm.icd' files. This breaks the dataformat
-      - Fix: bug that results in segfaults when `use lane` instructions are suppressed
+# 5.2.7
+  - Bugfixes
+    - BREAKING: Fix bug that could result in failure to load 'osrm.icd' files. This breaks the dataformat
+    - Fix deduplication of parallel edges. Now uses correct weight.
 
-  Changes form 5.2.7
-    - API
-      - Introduces new `TurnType` in the form of `use lane`. The type indicates that you have to stick to a lane without turning
-      - Introduces `lanes` to the `Intersection` object. The lane data contains both the markings at the intersection and a flag indicating if they can be chosen for the next turn
-      - Removed unused `-s` from `osrm-datastore`
-    - Guidance
-      - Only announce `use lane` on required turns (not using all lanes to go straight)
-      - Improved detection of obvious turns
-      - Improved turn lane detection
-      - Reduce the number of end-of-road instructions in obvious cases
-    - Profile:
-      - bicycle.lua: Surface speeds never increase the actual speed
-    - Infrastructure
-      - Add 32bit support
-      - Add ARM NEON/VFP support
-      - Fix Windows builds
-      - Optimize speed file updates using mmap
-      - Add option to disable LTO for older compilers
-      - BREAKING: The new turn type changes the turn-type order. This breaks the **data format**.
-      - BREAKING: Turn lane data introduces two new files (osrm.tld,osrm.tls). This breaks the fileformat for older versions.
-    - Bugfixes:
-      - Fix devide by zero on updating speed data using osrm-contract
-
-# 5.3.0 RC3
-  Changes from 5.3.0-rc.2
-    - Guidance
-      - Improved detection of obvious turns
-      - Improved turn lane detection
-    - Bugfixes
-      - Fix bug that didn't chose minimal weights on overlapping edges
-
-# 5.3.0 RC2
-  Changes from 5.3.0-rc.1
-    - Bugfixes
-      - Fixes invalid checks in the lane-extraction part of the car profile
-
-# 5.3.0 RC1
-    - API
-     - Introduces new `TurnType` in the form of `use lane`. The type indicates that you have to stick to a lane without turning
-     - Introduces lanes to the route response. The lane data contains both the markings at the intersection and a flag indicating their involvement in the turn
-
-    - Infrastructure
-     - BREAKING: The new turn type changes the turn-type order. This breaks the **data format**.
-     - BREAKING: Turn lane data introduces two new files (osrm.tld,osrm.tls). This breaks the fileformat for older versions.
+# 5.2.6
+  - Bugfixes
+    - Fix numeric overflow in roundabout center calculation which throws an exception
 
 # 5.2.5
   - Bugfixes
     - Fixes a segfault caused by incorrect trimming logic for very short steps.
 
 # 5.2.4
+  Changes from 5.2.3:
   - Bugfixes:
-    - Fixed in issue that arised on roundabouts in combination with intermediate intersections and sliproads
+    - Fixed a crash that arised on roundabouts in combination with intermediate intersections and sliproads
+    - Fixed #2518: Invalid bilinear interpolation when using raster data
+    - Fixed #2546: The geometry returned by the match service was missing the last coordinate.
+
+  BREAKING: The data format changed between 5.2.3 and 5.2.4, you need to reprocess.
 
 # 5.2.3
   - Bugfixes:

CMakeLists.txt

@@ -9,8 +9,8 @@ endif()
 
 project(OSRM C CXX)
 set(OSRM_VERSION_MAJOR 5)
-set(OSRM_VERSION_MINOR 3)
-set(OSRM_VERSION_PATCH 0)
+set(OSRM_VERSION_MINOR 2)
+set(OSRM_VERSION_PATCH 7)
 
 # these two functions build up custom variables:
 #   OSRM_INCLUDE_PATHS and OSRM_DEFINES
@@ -39,7 +39,7 @@ if(CMAKE_SIZEOF_VOID_P EQUAL 8)
   set(bitness 64)
   message(STATUS "Building on a 64 bit system")
 else()
-  message(STATUS "Building on a 32 bit system")
+  message(WARNING "Building on a 32 bit system is unsupported")
 endif()
 
 if(WIN32 AND MSVC_VERSION LESS 1900)
@@ -53,7 +53,6 @@ option(BUILD_COMPONENTS "Build osrm-components" OFF)
 option(ENABLE_ASSERTIONS OFF)
 option(COVERAGE OFF)
 option(SANITIZER OFF)
-option(ENABLE_LTO "Use LTO if available" ON)
 
 include_directories(BEFORE ${CMAKE_CURRENT_BINARY_DIR}/include/)
 include_directories(BEFORE ${CMAKE_CURRENT_SOURCE_DIR}/include/)
@@ -119,7 +118,7 @@ if(CMAKE_BUILD_TYPE MATCHES Release)
   message(STATUS "Configuring OSRM in release mode")
   # Check if LTO is available
   check_cxx_compiler_flag("-flto" LTO_AVAILABLE)
-  if(ENABLE_LTO AND LTO_AVAILABLE)
+  if(LTO_AVAILABLE)
     set(OLD_CXX_FLAGS ${CMAKE_CXX_FLAGS})
     # GCC in addition allows parallelizing LTO
     if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
@@ -320,7 +319,7 @@ include_directories(SYSTEM ${OSRM_INCLUDE_PATHS})
 # Binaries
 target_link_libraries(osrm-datastore osrm_store ${Boost_LIBRARIES})
 target_link_libraries(osrm-extract osrm_extract ${Boost_LIBRARIES})
-target_link_libraries(osrm-contract ${Boost_LIBRARIES} ${TBB_LIBRARIES} osrm_contract)
+target_link_libraries(osrm-contract osrm_contract ${Boost_LIBRARIES})
 target_link_libraries(osrm-routed osrm ${Boost_LIBRARIES} ${OPTIONAL_SOCKET_LIBS} ${ZLIB_LIBRARY})
 
 set(EXTRACTOR_LIBRARIES

CONTRIBUTING.md

@@ -1,55 +0,0 @@
-# User
-
-Before you open a new issue, please search for older ones that cover the same issue.
-In general "me too" comments/issues are frowned upon.
-You can add a :+1: emoji to the issue if you want to express interest in this.
-
-# Developer
-
-We use `clang-format` version `3.8` to consistently format the code base. There is a helper script under `scripts/format.sh`.
-
-In general changes that affect the API and/or increase the memory consumption need to be discussed first.
-Often we don't include changes that would increase the memory consumption a lot if they are not generally usable (e.g. elevation data is a good example).
-
-## Pull Request
-
-Every pull-request that changes the API needs to update the docs in `docs/http.md` and add an entry to `CHANGELOG.md`.
-Breaking changes need to have a BREAKING prefix. See the [releasing documentation](docs/releasing.md) on how this affects the version.
-
-Early feedback is also important.
-You will see that a lot of the PR have tags like `[not ready]` or `[wip]`.
-We like to open PRs as soon as we are starting to work on something to make it visible to the rest of the team.
-If your work is going in entirely the wrong direction, there is a good chance someone will pick up on this before it is too late.
-Everyone is encouraged to read PRs of other people and give feedback.
-
-For every significant code change we require a pull request review before it is merged.
-If your pull request modifies the API this need to be signed of by a team discussion.
-This means you will need to find another member of the team with commit access and request a review of your pull request.
-
-Once your pull request is reviewed you can merge it! If you don't have commit access, ping someone that has commit access.
-If you do have commit access there are in general two accepted styles to merging:
-
-1. Make sure the branch is up to date with `master`. Run `git rebase master` to find out.
-2. Once that is ensured you can either:
-  - Click the nice green merge button (for a non-fast-forward merge)
-  - Merge by hand using a fast-forward merge
-
-Which merge you prefer is up to personal preference. In general it is recommended to use fast-forward merges because it creates a history that is sequential and easier to understand.
-
-# Maintainer
-
-## Doing a release
-
-There is an in-depth guide around how to push out a release once it is ready [here](docs/releasing.md).
-
-## The API
-
-Changes to the API need to be discussed and signed off by the team. Breaking changes even more so than additive changes.
-
-## Milestones
-
-If a pull request or an issue is applicable for the current or next milestone, depends on the target version number.
-Since we use semantic versioning we restrict breaking changes to major releases.
-After a Release Candidate is released we usually don't change the API anymore if it is not critical.
-Bigger code changes after a RC was released should also be avoided.
-

README.md

@@ -46,7 +46,7 @@ osrm-routed data.osrm
 Running a query on your local server:
 
 ```
-curl http://127.0.0.1:5000/route/v1/driving/13.388860,52.517037;13.385983,52.496891?steps=true&alternatives=true
+curl http://127.0.0.1:5000/13.388860,52.517037;13.385983,52.496891?steps=true&alternatives=true
 ```
 
 ### Running a request against the Demo Server
@@ -56,7 +56,7 @@ First read the [API usage policy](https://github.com/Project-OSRM/osrm-backend/w
 Then run simple query with instructions and alternatives on Berlin:
 
 ```
-curl https://router.project-osrm.org/route/v1/driving/13.388860,52.517037;13.385983,52.496891?steps=true&alternatives=true
+curl https://router.project-osrm.org/13.388860,52.517037;13.385983,52.496891?steps=true&alternatives=true
 ```
 
 ## References in publications

docker/Dockerfile

@@ -1,9 +1,18 @@
 FROM ubuntu:14.04
 
-RUN apt-get update -y && apt-get install -y  software-properties-common
-RUN add-apt-repository ppa:ubuntu-toolchain-r/test
-RUN apt-get update -y && apt-get install -y g++-5 libbz2-dev libstxxl-dev libstxxl1 libxml2-dev libzip-dev lua5.1 liblua5.1-0-dev libtbb-dev libgdal-dev libluabind-dev libboost-all-dev ccache
-RUN apt-get -y install curl cmake cmake-curses-gui git
+RUN apt-get update -y
+RUN apt-get install -y build-essential git-core python-pip python-software-properties software-properties-common
+
+RUN apt-get -y install gcc-4.8 g++-4.8 libboost1.55-all-dev llvm-3.4
+RUN apt-get -y install libbz2-dev libstxxl-dev libstxxl1 libxml2-dev
+RUN apt-get -y install libzip-dev lua5.1 liblua5.1-0-dev libtbb-dev libgdal-dev
+RUN apt-get -y install curl cmake cmake-curses-gui
+
+RUN pip install awscli
+
+
+# luabind
+RUN curl https://gist.githubusercontent.com/DennisOSRM/f2eb7b948e6fe1ae319e/raw/install-luabind.sh | sudo bash
 
 WORKDIR /opt
 RUN git clone --depth 1 --branch v0.31.0 https://github.com/creationix/nvm.git

docker/run-gcc.sh

@@ -5,8 +5,7 @@ set -o pipefail
 
 docker run \
     -i \
-    -e "CXX=g++-5" \
-    -e "CC=gcc-5" \
+    -e "CXX=g++" \
     -v `pwd`:/home/mapbox/osrm-backend \
     -t mapbox/osrm:linux \
     /bin/bash -lc "osrm-backend/docker/test.sh"

docs/http.md

@@ -357,7 +357,7 @@ Three input coordinates, `geometry=geojson`, `steps=false`:
 {
   "distance": 90.0,
   "duration": 300.0,
-  "geometry": {"type": "LineString", "coordinates": [[120.0, 10.0], [120.1, 10.0], [120.2, 10.0], [120.3, 10.0]]},
+  "geometry": {"type": "LineString", "coordinates": [[120., 10.], [120.1, 10.], [120.2, 10.], [120.3, 10.]]},
   "legs": [
     {
       "distance": 30.0,
@@ -410,7 +410,7 @@ With `steps=false` and `annotations=true`:
 {
   "distance": 30.0,
   "duration": 100.0,
-  "steps": [],
+  "steps": []
   "annotation": {
     "distance": [5,5,10,5,5],
     "duration": [15,15,40,15,15],
@@ -441,7 +441,7 @@ step.
 - `destinations`: The destinations of the way. Will be `undefined` if there are no destinations.
 - `mode`: A string signifying the mode of transportation.
 - `maneuver`: A `StepManeuver` object representing the maneuver.
-- `intersections`: A list of `Intersection` objects that are passed along the segment, the very first belonging to the StepManeuver
+- `intersections`: A list of `Intersections` that are passed along the segment, the very first belonging to the StepManeuver
 
 #### Example
 
@@ -451,30 +451,22 @@ step.
  "duration":15.6,
  "name":"Lortzingstraße",
  "maneuver":{
-     "type":"turn",
-     "modifier":"right",
-     },
+     "type":"depart",
+     "modifier":"left"
+ },
  "geometry":"{lu_IypwpAVrAvAdI",
  "mode":"driving",
  "intersections":[
     {"location":[13.39677,52.54366],
-    "in":3,
-    "out":2,
-    "bearings":[10,92,184,270],
-    "entry":["true","true","true","false"],
-    "lanes":[
-         {"indications":["left","straight"], "valid":"false"},
-         {"indications":["right"], "valid":"true"}
-    ]},
+    "out":1,
+    "bearings":[66,246],
+    "entry":["true","true"]},
     {"location":[13.394718,52.543096],
     "in":0,
-    "out":1,
-    "bearings":[60,240,330],
-    "entry":["false","true","true"]
-    "lanes":[
-         {"indications":["straight"], "valid":"true"},
-         {"indications":["right"], "valid":"false"}
-     ]}
+    "out":2,
+    "bearings":[60,150,240,330],
+    "entry":["false","true","true","true"]
+    }
 ]}
 ```
 
@@ -490,92 +482,62 @@ step.
 - `type` A string indicating the type of maneuver. **new identifiers might be introduced without API change**
    Types  unknown to the client should be handled like the `turn` type, the existance of correct `modifier` values is guranteed.
   
-  | `type`           | Description                                                  |
-  |------------------|--------------------------------------------------------------|
-  | `turn`           | a basic turn into direction of the `modifier`                |
-  | `new name`       | no turn is taken/possible, but the road name changes. The road can take a turn itself, following `modifier`.                  |
-  | `depart`         | indicates the departure of the leg                           |
-  | `arrive`         | indicates the destination of the leg                         |
-  | `merge`          | merge onto a street (e.g. getting on the highway from a ramp, the `modifier specifies the direction of the merge`) |
-  | `ramp`           | **Deprecated**. Replaced by `on_ramp` and `off_ramp`.        |
-  | `on ramp`        | take a ramp to enter a highway (direction given my `modifier`) |
-  | `off ramp`       | take a ramp to exit a highway (direction given my `modifier`)  |
-  | `fork`           | take the left/right side at a fork depending on `modifier`   |
-  | `end of road`    | road ends in a T intersection turn in direction of `modifier`|
-  | `use lane`       | going straight on a specific lane                            |
-  | `continue`       | Turn in direction of `modifier` to stay on the same road     |
-  | `roundabout`     | traverse roundabout, has additional field `exit` with NR if the roundabout is left. `the modifier specifies the direction of entering the roundabout` |
-  | `rotary`         | a larger version of a roundabout, can offer `rotary_name` in addition to the `exit` parameter.  |
-  | `roundabout turn`| Describes a turn at a small roundabout that should be treated as normal turn. The `modifier` indicates the turn direciton. Example instruction: `At the roundabout turn left`. |
-  | `notification`   | not an actual turn but a change in the driving conditions. For example the travel mode.  If the road takes a turn itself, the `modifier` describes the direction |
+  | `type`            | Description                                                  |
+  |-------------------|--------------------------------------------------------------|
+  | turn              | a basic turn into direction of the `modifier`                |
+  | new name          | no turn is taken/possible, but the road name changes. The road can take a turn itself, following `modifier`.                  |
+  | depart            | indicates the departure of the leg                           |
+  | arrive            | indicates the destination of the leg                         |
+  | merge             | merge onto a street (e.g. getting on the highway from a ramp, the `modifier specifies the direction of the merge`) |
+  | ramp              | **Deprecated**. Replaced by `on_ramp` and `off_ramp`.        |
+  | on ramp           | take a ramp to enter a highway (direction given my `modifier`) |
+  | off ramp          | take a ramp to exit a highway (direction given my `modifier`)  |
+  | fork              | take the left/right side at a fork depending on `modifier`   |
+  | end of road       | road ends in a T intersection turn in direction of `modifier`|
+  | continue          | Turn in direction of `modifier` to stay on the same road     |
+  | roundabout        | traverse roundabout, has additional field `exit` with NR if the roundabout is left. `the modifier specifies the direction of entering the roundabout` |
+  | rotary            | a larger version of a roundabout, can offer `rotary_name` in addition to the `exit` parameter.  |
+  | roundabout turn   | Describes a turn at a small roundabout that should be treated as normal turn. The `modifier` indicates the turn direciton. Example instruction: `At the roundabout turn left`. |
+  | notification      | not an actual turn but a change in the driving conditions. For example the travel mode.  If the road takes a turn itself, the `modifier` describes the direction |
 
   Please note that even though there are `new name` and `notification` instructions, the `mode` and `name` can change
   between all instructions. They only offer a fallback in case nothing else is to report.
 
+
 - `modifier` An optional `string` indicating the direction change of the maneuver.
-  
+
   | `modifier`        | Description                               |
   |-------------------|-------------------------------------------|
-  | `uturn`           | indicates  reversal of direction          |
-  | `sharp right`     | a sharp right turn                        |
-  | `right`           | a normal turn to the right                |
-  | `slight right`    | a slight turn to the right                |
-  | `straight`        | no relevant change in direction           |
-  | `slight left`     | a slight turn to the left                 |
-  | `left`            | a normal turn to the left                 |
-  | `sharp left`      | a sharp turn to the left                  |
-  
-  The list of turns without a modifier is limited to: `depart/arrive`. If the source/target location is close enough to the `depart/arrive` location, no modifier will be given.
+  | uturn             | indicates  reversal of direction          |
+  | sharp right       | a sharp right turn                        |
+  | right             | a normal turn to the right                |
+  | slight right      | a slight turn to the right                |
+  | straight          | no relevant change in direction           |
+  | slight left       | a slight turn to the left                 |
+  | left              | a normal turn to the left                 |
+  | sharp left        | a sharp turn to the left                  |
+
+ The list of turns without a modifier is limited to: `depart/arrive`. If the source/target location is close enough to the `depart/arrive` location, no modifier will be given.
   
   The meaning depends on the `type` field.
-  
+    
   | `type`                 | Description                                                                                                               |
   |------------------------|---------------------------------------------------------------------------------------------------------------------------|
   | `turn`                 | `modifier` indicates the change in direction accomplished through the turn                                                |
   | `depart`/`arrive`      | `modifier` indicates the position of departure point and arrival point in relation to the current direction of travel      |
-  
+ 
+
 - `exit` An optional `integer` indicating number of the exit to take. The field exists for the following `type` field:
   
   | `type`                 | Description                                                                                                               |
   |------------------------|---------------------------------------------------------------------------------------------------------------------------|
   | `roundabout`           | Number of the roundabout exit to take. If exit is `undefined` the destination is on the roundabout.                       |
   | else                   | Indicates the number of intersections passed until the turn. Example instruction: `at the fourth intersection, turn left` |
-
+  
 
 New properties (potentially depending on `type`) may be introduced in the future without an API version change.
 
-### Lane
-
-A `Lane` represents a turn lane at the corresponding turn location.
-
-#### Properties
-
-- `indications`: a indication (e.g. marking on the road) specifying the turn lane. A road can have multiple indications (e.g. an arrow pointing straight and left). The indications are given in an array, each containing one of the following types. Further indications might be added on without an API version change.
-  
-  | `value`                | Description                                                                                                               |
-  |------------------------|---------------------------------------------------------------------------------------------------------------------------|
-  | `none`                 | No dedicated indication is shown.                                                                                         |
-  | `uturn`                | An indication signaling the possibility to reverse (i.e. fully bend arrow).                                               |
-  | `sharp right`          | An indication indicating a sharp right turn (i.e. strongly bend arrow).                                                   |
-  | `right`                | An indication indicating a right turn (i.e. bend arrow).                                                                  |
-  | `slight right`         | An indication indicating a slight right turn (i.e. slightly bend arrow).                                                  |
-  | `straight`             | No dedicated indication is shown (i.e. straight arrow).                                                                   |
-  | `slight left`          | An indication indicating a slight left turn (i.e. slightly bend arrow).                                                   |
-  | `left`                 | An indication indicating a left turn (i.e. bend arrow).                                                                   |
-  | `sharp left`           | An indication indicating a sharp left turn (i.e. strongly bend arrow).                                                    |
-  
-- `valid`: a boolean flag indicating whether the lane is a valid choice in the current maneuver
-
-#### Example
-
-```json
-{
-    "indications": ["left", "straight"],
-    "valid": "false"
-}
- ```
-
-### Intersection
+### Intersections
 
 An intersection gives a full representation of any cross-way the path passes bay. For every step, the very first intersection (`intersections[0]`) corresponds to the
 location of the StepManeuver. Further intersections are listed for every cross-way until the next turn instruction.
@@ -591,7 +553,6 @@ location of the StepManeuver. Further intersections are listed for every cross-w
   in the direction of driving, the bearing has to be rotated by a value of 180. The value is not supplied for `depart` maneuvers.
 - `out`: index into the bearings/entry array. Used to extract the bearing just after the turn. Namely, The clockwise angle from true north to the
   direction of travel immediately after the maneuver/passing the intersection. The value is not supplied for `arrive` maneuvers.
-- `lanes`: Array of `Lane` objects that denote the available turn lanes at the turn location
 
 #### Example
 ```
@@ -601,11 +562,6 @@ location of the StepManeuver. Further intersections are listed for every cross-w
     "out":2,
     "bearings":[60,150,240,330],
     "entry":["false","true","true","true"]
-    "lanes":{
-        "indications": ["left", "straight"],
-        "valid": "false"
-    }
-                                                                                                                               ]}
 }
 ```
 

example/example.cpp

@@ -40,8 +40,8 @@ int main(int argc, const char *argv[]) try
     RouteParameters params;
 
     // Route in monaco
-    params.coordinates.push_back({util::FloatLongitude{7.419758}, util::FloatLatitude{43.731142}});
-    params.coordinates.push_back({util::FloatLongitude{7.419505}, util::FloatLatitude{43.736825}});
+    params.coordinates.push_back({util::FloatLongitude(7.419758), util::FloatLatitude(43.731142)});
+    params.coordinates.push_back({util::FloatLongitude(7.419505), util::FloatLatitude(43.736825)});
 
     // Response is in JSON format
     json::Object result;

features/bicycle/mode.feature

@@ -46,17 +46,14 @@ Feature: Bike - Mode flag
 
      Scenario: Bike - Mode when pushing bike against oneways
      	Given the node map
-     	 | a | b | e |
-     	 | f | c | d |
+     	 | a | b |   |
+     	 |   | c | d |
 
      	And the ways
      	 | nodes | highway | oneway |
      	 | ab    | primary |        |
      	 | bc    | primary | yes    |
      	 | cd    | primary |        |
-     	 | be    | primary |        |
-     	 | cf    | primary |        |
-
 
      	When I route I should get
      	 | from | to | route       | modes                                |

features/bicycle/oneway.feature

@@ -18,8 +18,8 @@ Feature: Bike - Oneway streets
 
     Scenario: Bike - Around the Block
         Given the node map
-            |   | a | b |   |
-            | f | d | c | e |
+            | a | b |
+            | d | c |
 
         And the ways
             | nodes | oneway | foot |
@@ -27,8 +27,6 @@ Feature: Bike - Oneway streets
             | bc    |        | no   |
             | cd    |        | no   |
             | da    |        | no   |
-            | df    |        | no   |
-            | ce    |        | no   |
 
         When I route I should get
             | from | to | route       |

features/bicycle/pushing.feature

@@ -87,16 +87,14 @@ Feature: Bike - Accessability of different way types
 
     Scenario: Bike - Instructions when pushing bike on oneways
         Given the node map
-            | a | b | e |
-            | f | c | d |
+            | a | b |   |
+            |   | c | d |
 
         And the ways
             | nodes | highway | oneway |
             | ab    | primary |        |
             | bc    | primary | yes    |
             | cd    | primary |        |
-            | be    | primary |        |
-            | cf    | primary |        |
 
         When I route I should get
             | from | to | route       | modes                                   |

features/bicycle/surface.feature

@@ -38,20 +38,3 @@ Feature: Bike - Surfaces
         | cycleway |         | 48s   |
         | nosense  |         |       |
         | nosense  | asphalt |       |
-
-    Scenario: Bicycle - Surfaces should not increase speed when pushing bikes
-      Given the node map
-         | a | b |
-         | c | d |
-
-      And the ways
-        | nodes | highway | oneway | surface |
-        | ab    | primary | yes    | asphalt |
-        | cd    | footway |        | asphalt |
-
-      When I route I should get
-        | from | to | route | modes                     | speed   |
-        | a    | b  | ab,ab | cycling,cycling           | 15 km/h |
-        | b    | a  | ab,ab | pushing bike,pushing bike | 6 km/h  |
-        | c    | d  | cd,cd | pushing bike,pushing bike | 6 km/h  |
-        | d    | c  | cd,cd | pushing bike,pushing bike | 6 km/h  |

features/car/oneway.feature

@@ -35,8 +35,8 @@ Feature: Car - Oneway streets
 
     Scenario: Car - Around the Block
         Given the node map
-            |   | a | b |   |
-            | f | d | c | e |
+            | a | b |
+            | d | c |
 
         And the ways
             | nodes | oneway |
@@ -44,8 +44,6 @@ Feature: Car - Oneway streets
             | bc    |        |
             | cd    |        |
             | da    |        |
-            | ce    |        |
-            | df    |        |
 
         When I route I should get
             | from | to | route       |

features/guidance/anticipate-lanes.feature

@@ -1,500 +0,0 @@
-@routing @guidance @turn-lanes
-Feature: Turn Lane Guidance
-
-    Background:
-        Given the profile "car"
-        Given a grid size of 20 meters
-
-    @anticipate
-    Scenario: Anticipate Lane Change for subsequent multi-lane intersections
-        Given the node map
-            | a |   | b |   | x |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   | c |   | d |   | z |
-            |   |   |   |   |   |   |   |
-            |   |   | y |   | e |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward           |
-            | ab    | through\|right\|right\|right |
-            | bx    |                              |
-            | bc    | left\|left\|through          |
-            | cd    | through\|right               |
-            | cy    |                              |
-            | dz    |                              |
-            | de    |                              |
-
-       When I route I should get
-            | waypoints | route          | turns                                         | lanes                                                                                                             | #      |
-            | a,d       | ab,bc,cd,cd    | depart,turn right,turn left,arrive            | ,straight:false right:true right:true right:false,left:true left:true straight:false,                             | 2 hops |
-            | a,e       | ab,bc,cd,de,de | depart,turn right,turn left,turn right,arrive | ,straight:false right:false right:true right:false,left:false left:true straight:false,straight:false right:true, | 3 hops |
-
-    @anticipate
-    Scenario: Anticipate Lane Change for quick same direction turns, staying on the same street
-        Given the node map
-            | a |   | b | x |
-            |   |   |   |   |
-            |   |   | c |   |
-            |   |   |   |   |
-            | e |   | d | y |
-
-        And the ways
-            | nodes | turn:lanes:forward    | turn:lanes:backward | name |
-            | ab    | through\|right\|right |                     | MySt |
-            | bx    |                       |                     | XSt  |
-            | bc    |                       | left\|right         | MySt |
-            | cd    | left\|right           | through\|through    | MySt |
-            | de    |                       | left\|left\|through | MySt |
-            | dy    |                       |                     | YSt  |
-
-       When I route I should get
-            | waypoints | route               | turns                                   | lanes                                                         |
-            | a,e       | MySt,MySt,MySt,MySt | depart,continue right,turn right,arrive | ,straight:false right:false right:true,left:false right:true, |
-            | e,a       | MySt,MySt,MySt,MySt | depart,continue left,turn left,arrive   | ,left:true left:false straight:false,left:true right:false,   |
-
-    @anticipate
-    Scenario: Anticipate Lane Change for quick same direction turns, changing between streets
-        Given the node map
-            | a |   | b | x |
-            |   |   |   |   |
-            |   |   | c |   |
-            |   |   |   |   |
-            | e |   | d | y |
-
-        And the ways
-            | nodes | turn:lanes:forward    | turn:lanes:backward | name |
-            | ab    | through\|right\|right |                     | AXSt |
-            | bx    |                       |                     | AXSt |
-            | bc    |                       | left\|right         | BDSt |
-            | cd    | left\|right           | through\|through    | BDSt |
-            | de    |                       | left\|left\|through | EYSt |
-            | dy    |                       |                     | EYSt |
-
-       When I route I should get
-            | waypoints | route               | turns                               | lanes                                                         |
-            | a,e       | AXSt,BDSt,EYSt,EYSt | depart,turn right,turn right,arrive | ,straight:false right:false right:true,left:false right:true, |
-            | e,a       | EYSt,BDSt,AXSt,AXSt | depart,turn left,turn left,arrive   | ,left:true left:false straight:false,left:true right:false,   |
-
-
-    @anticipate
-    Scenario: Anticipate Lane Change for quick turns during a merge
-        Given the node map
-            | a |   |   |   |   |
-            | x | b |   | c | y |
-            |   |   |   |   | d |
-
-        And the ways
-            | nodes | turn:lanes:forward       | name | highway       | oneway |
-            | ab    | slight_left\|slight_left | On   | motorway_link | yes    |
-            | xb    |                          | Hwy  | motorway      |        |
-            | bc    | through\|slight_right    | Hwy  | motorway      |        |
-            | cd    |                          | Off  | motorway_link | yes    |
-            | cy    |                          | Hwy  | motorway      |        |
-
-       When I route I should get
-            | waypoints | route          | turns                                           | lanes                                                                 |
-            | a,d       | On,Hwy,Off,Off | depart,merge slight right,off ramp right,arrive | ,slight left:false slight left:true,straight:false slight right:true, |
-
-
-    @anticipate
-    Scenario: Schoenefelder Kreuz
-    # https://www.openstreetmap.org/way/264306388#map=16/52.3202/13.5568
-        Given the node map
-            | a | b | x |   |   | i |
-            |   |   | c | d |   |   |
-            |   |   |   |   |   | j |
-
-        And the ways
-            | nodes | turn:lanes:forward                                  | lanes | highway       | oneway | name |
-            | ab    | none\|none\|none\|slight_right\|slight_right        |   5   | motorway      |        | abx  |
-            | bx    |                                                     |   3   | motorway      |        | abx  |
-            | bc    |                                                     |   2   | motorway_link | yes    | bcd  |
-            | cd    | slight_left\|slight_left;slight_right\|slight_right |   3   | motorway_link | yes    | bcd  |
-            | di    | slight_left\|slight_right                           |   2   | motorway_link | yes    | di   |
-            | dj    |                                                     |   2   | motorway_link | yes    | dj   |
-
-       When I route I should get
-            | waypoints | route         | turns                                          | lanes                                                                                                                                    |
-            | a,i       | abx,bcd,di,di | depart,off ramp right,fork slight left,arrive  | ,none:false none:false none:false slight right:true slight right:true,slight left:true slight left;slight right:true slight right:false, |
-            | a,j       | abx,bcd,dj,dj | depart,off ramp right,fork slight right,arrive | ,none:false none:false none:false slight right:true slight right:true,slight left:false slight left;slight right:true slight right:true, |
-
-
-    @anticipate
-    Scenario: Kreuz Oranienburg
-    # https://www.openstreetmap.org/way/4484007#map=18/52.70439/13.20269
-        Given the node map
-            | i |   |   |   |   | a |
-            | j |   | c | b |   | x |
-
-        And the ways
-            | nodes | turn:lanes:forward | lanes | highway       | oneway | name |
-            | ab    |                    | 1     | motorway_link | yes    | ab   |
-            | xb    |                    | 1     | motorway_link | yes    | xbcj |
-            | bc    | none\|slight_right | 2     | motorway_link | yes    | xbcj |
-            | ci    |                    | 1     | motorway_link | yes    | ci   |
-            | cj    |                    | 1     | motorway_link | yes    | xbcj |
-
-       When I route I should get
-            | waypoints | route         | turns                                             | lanes                           |
-            | a,i       | ab,xbcj,ci,ci | depart,merge slight left,turn slight right,arrive | ,,none:false slight right:true, |
-            | a,j       | ab,xbcj,xbcj  | depart,merge slight left,arrive                   | ,,                              |
-
-
-    @anticipate
-    Scenario: Lane anticipation for fan-in
-        Given the node map
-            | a |   | b |   | x |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   | c |   | d |   | z |
-            |   |   |   |   |   |   |   |
-            |   |   | y |   | e |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward           | name |
-            | ab    | through\|right\|right\|right | abx  |
-            | bx    |                              | abx  |
-            | bc    | left\|left\|through          | bcy  |
-            | cy    |                              | bcy  |
-            | cd    | through\|right               | cdz  |
-            | dz    |                              | cdz  |
-            | de    |                              | de   |
-
-       When I route I should get
-            | waypoints | route             | turns                                         | lanes                                                                                                             |
-            | a,e       | abx,bcy,cdz,de,de | depart,turn right,turn left,turn right,arrive | ,straight:false right:false right:true right:false,left:false left:true straight:false,straight:false right:true, |
-
-    @anticipate
-    Scenario: Lane anticipation for fan-out
-        Given the node map
-            | a |   | b |   | x |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   | c |   | d |   | z |
-            |   |   |   |   |   |   |   |
-            |   |   | y |   | e |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward           | name |
-            | ab    | through\|right               | abx  |
-            | bx    |                              | abx  |
-            | bc    | left\|left\|through          | bcy  |
-            | cy    |                              | bcy  |
-            | cd    | through\|right\|right\|right | cdz  |
-            | dz    |                              | cdz  |
-            | de    |                              | de   |
-
-       When I route I should get
-            | waypoints | route             | turns                                         | lanes                                                                                                          |
-            | a,e       | abx,bcy,cdz,de,de | depart,turn right,turn left,turn right,arrive | ,straight:false right:true,left:true left:true straight:false,straight:false right:true right:true right:true, |
-
-    @anticipate
-    Scenario: Lane anticipation for fan-in followed by fan-out
-        Given the node map
-            | a |   | b |   | x |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   | c |   | d |   | z |
-            |   |   |   |   |   |   |   |
-            |   |   | y |   | e |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward           | name |
-            | ab    | through\|right\|right\|right | abx  |
-            | bx    |                              | abx  |
-            | bc    | left\|left\|through          | bcy  |
-            | cy    |                              | bcy  |
-            | cd    | through\|right\|right\|right | cdz  |
-            | dz    |                              | cdz  |
-            | de    |                              | de   |
-
-       When I route I should get
-            | waypoints | route             | turns                                         | lanes                                                                                                                                 |
-            | a,e       | abx,bcy,cdz,de,de | depart,turn right,turn left,turn right,arrive | ,straight:false right:true right:true right:false,left:true left:true straight:false,straight:false right:true right:true right:true, |
-
-    @anticipate
-    Scenario: Lane anticipation for fan-out followed by fan-in
-        Given the node map
-            | a |   | b |   | x |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   | c |   | d |   | z |
-            |   |   |   |   |   |   |   |
-            |   |   | y |   | e |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward  | name |
-            | ab    | through\|right      | abx  |
-            | bx    |                     | abx  |
-            | bc    | left\|left\|through | bcy  |
-            | cy    |                     | bcy  |
-            | cd    | through\|right      | cdz  |
-            | dz    |                     | cdz  |
-            | de    |                     | de   |
-
-       When I route I should get
-            | waypoints | route             | turns                                         | lanes                                                                                     |
-            | a,e       | abx,bcy,cdz,de,de | depart,turn right,turn left,turn right,arrive | ,straight:false right:true,left:false left:true straight:false,straight:false right:true, |
-
-    @anticipate
-    Scenario: Lane anticipation for multiple hops with same number of lanes
-        Given the node map
-            | a |   | b |   | x |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   | c |   | d |   | z |
-            |   |   |   |   |   |   |   |
-            |   |   | y |   | e |   | f |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   | w |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward           | name |
-            | ab    | through\|right\|right\|right | abx  |
-            | bx    |                              | abx  |
-            | bc    | left\|left\|through          | bcy  |
-            | cy    |                              | bcy  |
-            | cd    | through\|right\|right        | cdz  |
-            | dz    |                              | cdz  |
-            | de    | left\|through                | dew  |
-            | ew    |                              | dew  |
-            | ef    |                              | ef   |
-
-       When I route I should get
-            | waypoints | route                 | turns                                                   | lanes                                                                                                                                                  |
-            | a,f       | abx,bcy,cdz,dew,ef,ef | depart,turn right,turn left,turn right,turn left,arrive | ,straight:false right:false right:true right:false,left:false left:true straight:false,straight:false right:true right:false,left:true straight:false, |
-
-    @anticipate @todo @bug @2661
-    Scenario: Anticipate with lanes in roundabout: roundabouts as the unit of anticipation
-        Given the node map
-            |   |   | e |   |   |
-            | a | b |   | d | f |
-            |   |   | c |   |   |
-            |   |   |   |   |   |
-            |   |   | g |   |   |
-            | k | h |   | j | l |
-            |   |   | i |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward                      | highway | junction   | #   |
-            | ab    | slight_right\|slight_right\|slight_right | primary |            |     |
-            | bc    | slight_left\|slight_right\|slight_right  | primary | roundabout | top |
-            | cd    |                                         | primary | roundabout | top |
-            | de    |                                         | primary | roundabout | top |
-            | eb    |                                         | primary | roundabout | top |
-            | df    |                                         | primary |            |     |
-            | cg    | slight_right\|slight_right              | primary |            |     |
-            | gh    | slight_left\|slight_right               | primary | roundabout | bot |
-            | hi    |                                         | primary | roundabout | bot |
-            | ij    | slight_left\|slight_right               | primary | roundabout | bot |
-            | jg    |                                         | primary | roundabout | bot |
-            | hk    |                                         | primary |            |     |
-            | jl    |                                         | primary |            |     |
-
-        When I route I should get
-            | #           | waypoints | route       | turns                                             | lanes                                                                                          |
-            | right-right | a,k       | ab,cg,hk,hk | depart,roundabout-exit-1,roundabout-exit-1,arrive | ,slight right:false slight right:false slight right:true,slight right:false slight right:true, |
-            | right-left  | a,l       | ab,cg,jl,jl | depart,roundabout-exit-1,roundabout-exit-2,arrive | ,slight right:false slight right:false slight right:true,slight right:false slight right:true, |
-            | todo exits  | a,f       | ab,df,df    | depart,roundabout-exit-2,arrive                   | ,slight right:false slight right:false slight right:true,                                      |
-            | todo exits  | a,e       | ab,bc,eb    | depart,roundabout-exit-undefined,arrive           | ,slight right:true slight right:true slight right:true,                                        |
-
-    @anticipate @todo
-    Scenario: Roundabout with lanes only tagged on exit
-        Given the node map
-            |   |   | e |   |   |
-            | a | b |   | d | f |
-            |   |   | c |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward                    | highway | junction   |
-            | ab    |                                       | primary |            |
-            | bc    |                                       | primary | roundabout |
-            | cd    | slight_left\|slight_left\|slight_right | primary | roundabout |
-            | de    |                                       | primary | roundabout |
-            | eb    |                                       | primary | roundabout |
-            | df    |                                       | primary |            |
-
-        When I route I should get
-            | waypoints | route    | turns                                                 | lanes                                                    |
-            | a,f       | ab,df,df | depart,roundabout-exit-1,use lane slight right,arrive | ,,slight left:false slight left:false slight right:true, |
-
-    @anticipate
-    Scenario: Anticipate with lanes in roundabout where we stay on the roundabout for multiple exits
-        Given the node map
-            |   |   | a |   |   |
-            |   |   | b |   |   |
-            |   | c |   | g | h |
-            |   |   |   |   |   |
-            |   | d |   | f |   |
-            |   |   | e |   |   |
-            | x |   |   |   | y |
-
-        And the ways
-            | nodes | turn:lanes:forward         | highway | junction   |
-            | ab    | slight_right\|slight_right | primary |            |
-            | bc    |                            | primary | roundabout |
-            | cd    |                            | primary | roundabout |
-            | de    |                            | primary | roundabout |
-            | ef    |                            | primary | roundabout |
-            | fg    | slight_right               | primary | roundabout |
-            | gb    |                            | primary | roundabout |
-            | gh    |                            | primary |            |
-            | cx    |                            | primary |            |
-            | dx    |                            | primary |            |
-            | ey    |                            | primary |            |
-            | fy    |                            | primary |            |
-
-        When I route I should get
-            | waypoints | route    | turns                           | lanes                                  |
-            | a,h       | ab,gh,gh | depart,roundabout-exit-5,arrive | ,slight right:false slight right:true, |
-
-    @anticipate
-    Scenario: Departing or arriving inside a roundabout does not yet anticipate lanes
-        Given the node map
-            |   |   | a |   |   |
-            | x | b |   | d | y |
-            |   |   | c |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward         | highway | junction   | name       |
-            | xb    | slight_right\|slight_right | primary |            | xb         |
-            | dy    |                            | primary |            | dy         |
-            | ab    |                            | primary | roundabout | roundabout |
-            | bc    |                            | primary | roundabout | roundabout |
-            | cd    | left\|slight_right         | primary | roundabout | roundabout |
-            | da    |                            | primary | roundabout | roundabout |
-
-        When I route I should get
-            | waypoints | route                    | turns                                   | lanes                                  |
-            | x,y       | xb,dy,dy                 | depart,roundabout-exit-1,arrive         | ,slight right:false slight right:true, |
-            | x,c       | xb,roundabout,roundabout | depart,roundabout-exit-undefined,arrive | ,slight right:true slight right:true,  |
-            | x,a       | xb,roundabout,roundabout | depart,roundabout-exit-undefined,arrive | ,slight right:true slight right:true,  |
-
-    @anticipate
-    Scenario: Departing or arriving inside a roundabout does not yet anticipate lanes (BIG version)
-        Given the node map
-            |   |   | a |   |   |
-            | x | b |   | d | y |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   | c |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward         | highway | junction   | name       |
-            | xb    | slight_right\|slight_right | primary |            | xb         |
-            | dy    |                            | primary |            | dy         |
-            | ab    |                            | primary | roundabout | roundabout |
-            | bc    |                            | primary | roundabout | roundabout |
-            | cd    | left\|slight_right         | primary | roundabout | roundabout |
-            | da    |                            | primary | roundabout | roundabout |
-
-        When I route I should get
-            | waypoints | route                    | turns                                   | lanes                                  |
-            | x,y       | xb,dy,dy                 | depart,roundabout-exit-1,arrive         | ,slight right:false slight right:true, |
-            | x,c       | xb,roundabout,roundabout | depart,roundabout-exit-undefined,arrive | ,slight right:true slight right:true,  |
-            | x,a       | xb,roundabout,roundabout | depart,roundabout-exit-undefined,arrive | ,slight right:true slight right:true,  |
-
-    @anticipate
-    Scenario: Anticipate Lanes for turns before and / or after roundabout
-        Given the node map
-            | a | b |   |   | x |
-            |   | c |   |   |   |
-            | d |   | f | g | z |
-            |   | e |   | h |   |
-            |   |   |   |   |   |
-            |   | y |   |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward                                 | highway | junction   | name  |
-            | ab    | through\|right\|right\|right\|right                | primary |            | abx   |
-            | bx    |                                                    | primary |            | abx   |
-            | bc    | right\|right\|right\|right                         | primary |            | bc    |
-            | cd    |                                                    | primary | roundabout | cdefc |
-            | de    | slight_left\|slight_left&slight_left\|slight_right | primary | roundabout | cdefc |
-            | ef    | left\|slight_right\|slight_right                   | primary | roundabout | cdefc |
-            | fc    |                                                    | primary | roundabout | cdefc |
-            | ey    |                                                    | primary |            | ey    |
-            | fg    | through\|right                                     | primary |            | fg    |
-            | gz    |                                                    | primary |            | gz    |
-            | gh    |                                                    | primary |            | gh    |
-
-        When I route I should get
-            | waypoints | route           | turns                                            | lanes                                                                                                                                    |
-            | a,h       | abx,bc,fg,gh,gh | depart,turn right,cdefc-exit-2,turn right,arrive | ,straight:false right:false right:false right:false right:true,right:false right:false right:false right:true,straight:false right:true, |
-
-    @anticipate @bug @todo
-    Scenario: Tripple Right keeping Left
-        Given the node map
-            | a |   |   |   | b |   | i |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            | f |   | e |   |   |   | g |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   | j | d |   | c |   |   |
-            |   |   |   |   | h |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward | highway   | name   |
-            | abi   | \|\|right\|right   | primary   | start  |
-            | bch   | \|\|right\|right   | primary   | first  |
-            | cdj   | \|\|right\|right   | primary   | second |
-            | de    | left\|right\|right | secondary | third  |
-            | feg   |                    | tertiary  | fourth |
-
-        When I route I should get
-            | waypoints | route                                  | turns                                                            | lanes                                                                                                                                                                      |
-            | a,f       | start,first,second,third,fourth,fourth | depart,turn right,turn right,turn right,end of road left,arrive  | ,none:false none:true right:false right:false,none:false none:true right:false right:false,none:false none:true right:false right:false,left:true right:false right:false, |
-            | a,g       | start,first,second,third,fourth,fourth | depart,turn right,turn right,turn right,end of road right,arrive | ,none:false none:false right:true right:true,none:false none:false right:true right:true,none:false none:false right:true right:true,left:false right:true right:true,     |
-
-    @anticipate @bug @todo
-    Scenario: Tripple Left keeping Right
-        Given the node map
-            | i |   | b |   |   |   | a |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            | g |   |   |   | e |   | f |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   | c |   | d | j |   |
-            |   |   | h |   |   |   |   |
-
-        And the ways
-            | nodes | turn:lanes:forward | highway   | name   |
-            | abi   | left\|left\|\|     | primary   | start  |
-            | bch   | left\|left\|\|     | primary   | first  |
-            | cdj   | left\|left\|\|     | primary   | second |
-            | de    | left\|left\|right  | secondary | third  |
-            | feg   |                    | tertiary  | fourth |
-
-        When I route I should get
-            | waypoints | route                                  | turns                                                         | lanes                                                                                                                                                               |
-            | a,f       | start,first,second,third,fourth,fourth | depart,turn left,turn left,turn left,end of road right,arrive | ,left:false left:false none:true none:false,left:false left:false none:true none:false,left:false left:false none:true none:false,left:false left:false right:true, |
-            | a,g       | start,first,second,third,fourth,fourth | depart,turn left,turn left,turn left,end of road left,arrive  | ,left:true left:true none:false none:false,left:true left:true none:false none:false,left:true left:true none:false none:false,left:true left:true right:false,     |

features/guidance/collapse.feature

@@ -525,9 +525,9 @@ Feature: Collapse
             | cf    | secondary | bottom |
 
         When I route I should get
-            | waypoints | turns                                   | route               |
-            | a,d       | depart,continue right,turn right,arrive | road,road,road,road |
-            | d,a       | depart,continue left,turn left,arrive   | road,road,road,road |
+            | waypoints | turns                                          | route               |
+            | a,d       | depart,continue right,end of road right,arrive | road,road,road,road |
+            | d,a       | depart,continue left,end of road left,arrive   | road,road,road,road |
 
     Scenario: Forking before a turn
         Given the node map
@@ -606,13 +606,13 @@ Feature: Collapse
             | restriction | bc       | fdcg   | c        | no_right_turn |
 
         When I route I should get
-            | waypoints | route                 | turns                                          |
-            | a,g       | road,cross,cross      | depart,turn left,arrive                        |
-            | a,e       | road,road,road        | depart,continue slight right,arrive            |
-            # We should discuss whether the next item should be collapsed to depart,turn right,arrive.
-            | a,f       | road,road,cross,cross | depart,continue slight right,turn right,arrive |
+          | waypoints | route                 | turns                                          |
+          | a,g       | road,cross,cross      | depart,turn left,arrive                        |
+          | a,e       | road,road,road        | depart,continue slight right,arrive            |
+          # We should discuss whether the next item should be collapsed to depart,turn right,arrive.
+          | a,f       | road,road,cross,cross | depart,continue slight right,turn right,arrive |
 
-    Scenario: On-Off on Highway
+     Scenario: On-Off on Highway
         Given the node map
             | f |   |   |   |
             | a | b | c | d |

features/guidance/dedicated-turn-roads.feature

@@ -57,21 +57,20 @@ Feature: Slipways and Dedicated Turn Lanes
 
     Scenario: Inner city expressway with on road
         Given the node map
-            | a | b |   |   |   | c | g |
-            |   |   |   |   | f |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   | d |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   | e |   |
+            | a | b |   |   |   | c |
+            |   |   |   |   | f |   |
+            |   |   |   |   |   |   |
+            |   |   |   |   |   |   |
+            |   |   |   |   |   |   |
+            |   |   |   |   |   | d |
+            |   |   |   |   |   |   |
+            |   |   |   |   |   |   |
+            |   |   |   |   |   |   |
+            |   |   |   |   |   | e |
 
         And the ways
             | nodes | highway      | name  |
             | abc   | primary      | road  |
-            | cg    | primary      | road  |
             | bfd   | trunk_link   |       |
             | cde   | trunk        | trunk |
 
@@ -124,46 +123,3 @@ Feature: Slipways and Dedicated Turn Lanes
        When I route I should get
             | waypoints | route          | turns                        |
             | a,f       | road,road,road | depart,continue uturn,arrive |
-
-    Scenario: Schwarzwaldstrasse Autobahn
-        Given the node map
-            |   |   |   |   | i |   |   |   |   |   | h |   |   |   |   | g |
-            |   |   | j |   |   |   |   |   |   |   |   |   |   |   |   |   |
-            | a |   |   |   |   |   |   | k |   |   |   |   |   |   |   |   |
-            |   |   |   | b |   | r | c |   | d |   | e |   |   |   |   | f |
-            |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   | l |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   | m |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   | n |   | q |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   | o |   | p |   |   |   |   |   |   |   |
-
-        And the nodes
-            # the traffic light at `l` is not actually in the data, but necessary for the test to check everything
-            # http://www.openstreetmap.org/#map=19/48.99211/8.40336
-            | node | highway         |
-            | r    | traffic_signals |
-            | l    | traffic_signals |
-
-        And the ways
-            | nodes | highway        | name               | ref  | oneway |
-            | abrcd | secondary      | Schwarzwaldstrasse | L561 | yes    |
-            | hija  | secondary      | Schwarzwaldstrasse | L561 | yes    |
-            | def   | secondary      | Ettlinger Strasse  |      | yes    |
-            | gh    | secondary      | Ettlinger Strasse  |      | yes    |
-            | blmn  | secondary_link |                    | L561 | yes    |
-            | hkc   | secondary_link | Ettlinger Strasse  |      | yes    |
-            | qdki  | secondary_link | Ettlinger Allee    |      | yes    |
-            | cn    | secondary_link | Ettlinger Allee    |      | yes    |
-            | no    | primary        | Ettlinger Allee    |      | yes    |
-            | pq    | primary        | Ettlinger Allee    |      | yes    |
-            | qe    | secondary_link | Ettlinger Allee    |      | yes    |
-
-        When I route I should get
-            | waypoints | route                                                     | turns                    |
-            | a,o       | Schwarzwaldstrasse (L561),Ettlinger Allee,Ettlinger Allee | depart,turn right,arrive |

features/guidance/end-of-road.feature

@@ -8,156 +8,116 @@ Feature: End Of Road Instructions
     Scenario: End of Road with through street
         Given the node map
             |   |   | c |
-            | a | e | b |
-            |   | f | d |
+            | a |   | b |
+            |   |   | d |
 
         And the ways
             | nodes  | highway |
-            | aeb    | primary |
+            | ab     | primary |
             | cbd    | primary |
-            | ef     | primary |
 
        When I route I should get
-            | waypoints | route       | turns                           |
-            | a,c       | aeb,cbd,cbd | depart,end of road left,arrive  |
-            | a,d       | aeb,cbd,cbd | depart,end of road right,arrive |
+            | waypoints | route      | turns                           |
+            | a,c       | ab,cbd,cbd | depart,end of road left,arrive  |
+            | a,d       | ab,cbd,cbd | depart,end of road right,arrive |
 
     Scenario: End of Road with three streets
         Given the node map
             |   |   | c |
-            | a | e | b |
-            |   | f | d |
+            | a |   | b |
+            |   |   | d |
 
         And the ways
             | nodes  | highway |
-            | aeb    | primary |
+            | ab     | primary |
             | cb     | primary |
             | bd     | primary |
-            | ef     | primary |
 
        When I route I should get
-            | waypoints | route     | turns                           |
-            | a,c       | aeb,cb,cb | depart,end of road left,arrive  |
-            | a,d       | aeb,bd,bd | depart,end of road right,arrive |
+            | waypoints | route    | turns                           |
+            | a,c       | ab,cb,cb | depart,end of road left,arrive  |
+            | a,d       | ab,bd,bd | depart,end of road right,arrive |
 
     Scenario: End of Road with three streets, slightly angled
         Given the node map
-            | a | e |   |   |   | c |
-            |   | f |   |   |   | b |
+            | a |   |   |   |   | c |
+            |   |   |   |   |   | b |
             |   |   |   |   |   | d |
 
         And the ways
             | nodes  | highway |
-            | aeb    | primary |
+            | ab     | primary |
             | cb     | primary |
             | bd     | primary |
-            | ef     | primary |
 
        When I route I should get
-            | waypoints | route     | turns                           |
-            | a,c       | aeb,cb,cb | depart,end of road left,arrive  |
-            | a,d       | aeb,bd,bd | depart,end of road right,arrive |
+            | waypoints | route    | turns                           |
+            | a,c       | ab,cb,cb | depart,end of road left,arrive  |
+            | a,d       | ab,bd,bd | depart,end of road right,arrive |
 
     Scenario: End of Road with three streets, slightly angled
         Given the node map
             |   |   |   |   |   | c |
-            |   | f |   |   |   | b |
-            | a | e |   |   |   | d |
+            |   |   |   |   |   | b |
+            | a |   |   |   |   | d |
 
         And the ways
             | nodes  | highway |
-            | aeb    | primary |
-            | ef     | primary |
+            | ab     | primary |
             | cb     | primary |
             | bd     | primary |
 
        When I route I should get
-            | waypoints | route     | turns                           |
-            | a,c       | aeb,cb,cb | depart,end of road left,arrive  |
-            | a,d       | aeb,bd,bd | depart,end of road right,arrive |
+            | waypoints | route    | turns                           |
+            | a,c       | ab,cb,cb | depart,end of road left,arrive  |
+            | a,d       | ab,bd,bd | depart,end of road right,arrive |
 
     Scenario: End of Road with through street, slightly angled
         Given the node map
-            | a | e |   |   |   | c |
-            |   | f |   |   |   | b |
+            | a |   |   |   |   | c |
+            |   |   |   |   |   | b |
             |   |   |   |   |   | d |
 
         And the ways
             | nodes  | highway |
-            | aeb    | primary |
-            | ef     | primary |
+            | ab     | primary |
             | cbd    | primary |
 
        When I route I should get
-            | waypoints | route       | turns                           |
-            | a,c       | aeb,cbd,cbd | depart,end of road left,arrive  |
-            | a,d       | aeb,cbd,cbd | depart,end of road right,arrive |
+            | waypoints | route      | turns                           |
+            | a,c       | ab,cbd,cbd | depart,end of road left,arrive  |
+            | a,d       | ab,cbd,cbd | depart,end of road right,arrive |
 
     Scenario: End of Road with through street, slightly angled
         Given the node map
             |   |   |   |   |   | c |
-            |   | f |   |   |   | b |
-            | a | e |   |   |   | d |
+            |   |   |   |   |   | b |
+            | a |   |   |   |   | d |
 
         And the ways
             | nodes  | highway |
-            | aeb    | primary |
-            | ef     | primary |
+            | ab     | primary |
             | cbd    | primary |
 
        When I route I should get
-            | waypoints | route       | turns                           |
-            | a,c       | aeb,cbd,cbd | depart,end of road left,arrive  |
-            | a,d       | aeb,cbd,cbd | depart,end of road right,arrive |
+            | waypoints | route      | turns                           |
+            | a,c       | ab,cbd,cbd | depart,end of road left,arrive  |
+            | a,d       | ab,cbd,cbd | depart,end of road right,arrive |
 
     Scenario: End of Road with two ramps - prefer ramp over end of road
         Given the node map
             |   |   | c |
-            | a | e | b |
-            |   | f | d |
+            | a |   | b |
+            |   |   | d |
 
         And the ways
             | nodes  | highway       |
-            | aeb    | primary       |
-            | ef     | primary       |
+            | ab     | primary       |
             | bc     | motorway_link |
             | bd     | motorway_link |
 
        When I route I should get
-            | waypoints | route     | turns                       |
-            | a,c       | aeb,bc,bc | depart,on ramp left,arrive  |
-            | a,d       | aeb,bd,bd | depart,on ramp right,arrive |
+            | waypoints | route    | turns                       |
+            | a,c       | ab,bc,bc | depart,on ramp left,arrive  |
+            | a,d       | ab,bd,bd | depart,on ramp right,arrive |
 
-    # http://www.openstreetmap.org/#map=19/52.49907/13.41836
-    @end-of-road @negative
-    Scenario: Don't Handle Circles as End-Of-Road
-        Given the node map
-            |   | r |   |   |   | q |   |   |   |   |   |   |
-            |   |   |   |   |   | a | s |   |   |   |   |   |
-            |   |   |   | b |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   | j |   |   |   |   |
-            |   |   |   |   |   |   |   |   |   |   |   |   |
-            | l |   | c |   |   |   |   | i |   |   |   | k |
-            |   |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   | h |   |   |   |   |
-            | m |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   | d |   |   |   |   |   |   |   |   | n |
-            |   |   |   | e |   |   | g |   |   |   |   |   |
-            |   |   |   |   | f |   |   |   |   |   |   |   |
-            |   |   |   |   | o |   | p |   |   |   |   |   |
-
-        And the ways
-            | nodes        | highway     | name  | oneway |
-            | abcdefghijsa | secondary   | kotti | yes    |
-            | ki           | secondary   | skal  | yes    |
-            | cl           | secondary   | skal  | yes    |
-            | md           | secondary   | skal  | yes    |
-            | gn           | secondary   | skal  | yes    |
-            | qa           | tertiary    | adal  | no     |
-            | br           | residential | rei   | yes    |
-            | fo           | secondary   | kstr  | yes    |
-            | pg           | secondary   | kstr  | yes    |
-
-        When I route I should get
-            | waypoints | route                | turns                               | #                                                      |
-            | k,l       | skal,kotti,skal,skal | depart,turn right,turn right,arrive | # could be a case to find better turn instructions for |

features/guidance/fork.feature

@@ -296,21 +296,3 @@ Feature: Fork Instructions
             | waypoints | route     | turns                           |
             | a,c       | abc,abc   | depart,arrive                   |
             | a,d       | abc,bd,bd | depart,turn slight right,arrive |
-
-     Scenario: Fork on motorway links - don't fork on through
-        Given the node map
-            | i |   |   |   |   | a |
-            | j |   | c | b |   | x |
-
-        And the ways
-            | nodes | name | highway       |
-            | xb    | xbcj | motorway_link |
-            | bc    | xbcj | motorway_link |
-            | cj    | xbcj | motorway_link |
-            | ci    | off  | motorway_link |
-            | ab    | on   | motorway_link |
-
-        When I route I should get
-            | waypoints | route           | turns                                             |
-            | a,j       | on,xbcj,xbcj    | depart,merge slight left,arrive                   |
-            | a,i       | on,xbcj,off,off | depart,merge slight left,turn slight right,arrive |

features/guidance/intersections.feature

@@ -17,8 +17,8 @@ Feature: Intersections Data
             | bd     | corner  |
 
        When I route I should get
-            | waypoints | route           | intersections                               |
-            | a,c       | through,through | true:90,true:90 true:180 false:270;true:270 |
+            | waypoints | route           | turns         | intersections                               |
+            | a,c       | through,through | depart,arrive | true:90,true:90 true:180 false:270;true:270 |
 
     Scenario: Passing Three Way North
         Given the node map
@@ -32,8 +32,8 @@ Feature: Intersections Data
             | bd     | corner  |
 
        When I route I should get
-            | waypoints | route           | intersections                             |
-            | a,c       | through,through | true:90,true:0 true:90 false:270;true:270 |
+            | waypoints | route           | turns         | intersections                             |
+            | a,c       | through,through | depart,arrive | true:90,true:0 true:90 false:270;true:270 |
 
     Scenario: Passing Oneway Street In
         Given the node map
@@ -47,8 +47,8 @@ Feature: Intersections Data
             | db     | corner  | yes    |
 
        When I route I should get
-            | waypoints | route           | intersections                              |
-            | a,c       | through,through | true:90,false:0 true:90 false:270;true:270 |
+            | waypoints | route           | turns         | intersections                              |
+            | a,c       | through,through | depart,arrive | true:90,false:0 true:90 false:270;true:270 |
 
     Scenario: Passing Oneway Street Out
         Given the node map
@@ -62,8 +62,8 @@ Feature: Intersections Data
             | bd     | corner  | yes    |
 
        When I route I should get
-            | waypoints | route           | intersections                             |
-            | a,c       | through,through | true:90,true:0 true:90 false:270;true:270 |
+            | waypoints | route           | turns         | intersections                             |
+            | a,c       | through,through | depart,arrive | true:90,true:0 true:90 false:270;true:270 |
 
     Scenario: Passing Two Intersections
         Given the node map
@@ -80,8 +80,27 @@ Feature: Intersections Data
             | cf     | corner  |
 
        When I route I should get
-            | waypoints | route           | intersections                                                        |
-            | a,d       | through,through | true:90,true:0 true:90 false:270,true:90 true:180 false:270;true:270 |
+            | waypoints | route           | turns         | intersections                                                        |
+            | a,d       | through,through | depart,arrive | true:90,true:0 true:90 false:270,true:90 true:180 false:270;true:270 |
+
+    Scenario: Regression test #2424
+        Given the node map
+            |   |   | e |   |   |   |   |   | i |   |   |   |   |
+            | a |   | b |   | c |   | d |   | h |   | k |   | m |
+            |   |   |   |   | f |   |   |   |   |   | l |   |   |
+
+        And the ways
+            | nodes  | name    |
+            | abcd   | Fritz-Elsas-Straße |
+            | hkm    | Fritz-Elsas-Straße |
+            | dhi    | Martin-Luther-Straße |
+            | be     | corner  |
+            | kl     | corner  |
+            | cf     | corner  |
+
+       When I route I should get
+            | waypoints | route | turns         |
+            | a,m       | Fritz-Elsas-Straße,Fritz-Elsas-Straße| depart,arrive |
 
     Scenario: Passing Two Intersections, Collapsing
         Given the node map
@@ -98,9 +117,9 @@ Feature: Intersections Data
             | cf     | corner        |
 
        When I route I should get
-            | waypoints | route                  | intersections                                                        |
-            | a,d       | through,through        | true:90,true:0 true:90 false:270,true:90 true:180 false:270;true:270 |
-            | f,a       | corner,through,through | true:0;true:90 false:180 true:270,true:0 false:90 true:270;true:90   |
+            | waypoints | route                  | turns                          | intersections                                                        |
+            | a,d       | through,through        | depart,arrive                  | true:90,true:0 true:90 false:270,true:90 true:180 false:270;true:270 |
+            | f,a       | corner,through,through | depart,end of road left,arrive | true:0;true:90 false:180 true:270,true:0 false:90 true:270;true:90   |
 
     Scenario: Roundabouts
         Given the node map
@@ -125,10 +144,10 @@ Feature: Intersections Data
             | hd    |            |
 
         When I route I should get
-            | waypoints | route          | intersections                                                                                                                 |
-            | e,f       | ea,fb,fb       | true:180;false:0 false:150 true:210,false:30 true:150 true:270;true:90                                                        |
-            | e,g       | ea,gc,gc       | true:180;false:0 false:150 true:210,false:30 true:150 true:270,true:30 true:180 false:330;true:0                              |
-            | e,h       | ea,hd,hd       | true:180;false:0 false:150 true:210,false:30 true:150 true:270,true:30 true:180 false:330,true:90 false:210 true:330;true:270 |
-            | e,2       | ea,abcda,abcda | true:180;false:0 false:150 true:210,false:30 true:150 true:270;true:327 +-1                                                   |
-            | 1,g       | abcda,gc,gc    | true:214;false:30 true:150 true:270,true:30 true:180 false:330;true:0                                                         |
-            | 1,3       | abcda,abcda    | true:214,false:30 true:150 true:270,true:30 true:180 false:330;true:214                                                       |
+            | waypoints | route          | turns                              | intersections                                                                                                                 |
+            | e,f       | ea,fb,fb       | depart,abcda-exit-1,arrive         | true:180;false:0 false:150 true:210,false:30 true:150 true:270;true:90                                                        |
+            | e,g       | ea,gc,gc       | depart,abcda-exit-2,arrive         | true:180;false:0 false:150 true:210,false:30 true:150 true:270,true:30 true:180 false:330;true:0                              |
+            | e,h       | ea,hd,hd       | depart,abcda-exit-3,arrive         | true:180;false:0 false:150 true:210,false:30 true:150 true:270,true:30 true:180 false:330,true:90 false:210 true:330;true:270 |
+            | e,2       | ea,abcda,abcda | depart,abcda-exit-undefined,arrive | true:180;false:0 false:150 true:210,false:30 true:150 true:270;true:327 +-1                                                   |
+            | 1,g       | abcda,gc,gc    | depart,abcda-exit-2,arrive         | true:214;false:30 true:150 true:270,true:30 true:180 false:330;true:0                                                         |
+            | 1,3       | abcda,abcda    | depart,arrive                      | true:214,false:30 true:150 true:270,true:30 true:180 false:330;true:214                                                       |

features/guidance/merge.feature

@@ -50,27 +50,3 @@ Feature: Merging
             | waypoints | route      | turns                           |
             | d,c       | db,abc,abc | depart,merge slight left,arrive |
 
-    Scenario: Merge onto a turning road
-        Given the node map
-            |   |   |   |   |   |   | e |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   | d |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   | c |   |   |
-            |   |   |   | b |   |   |   |
-            | a |   |   |   |   |   | f |
-
-        And the ways
-            | nodes | highway     | name |
-            | abcde | primary     | road |
-            | fd    | residential | in   |
-
-        When I route I should get
-            | waypoints | turns                           | route        |
-            | f,e       | depart,merge slight left,arrive | in,road,road |
-            | f,a       | depart,turn sharp left,arrive  | in,road,road |

features/guidance/motorway.feature

@@ -216,21 +216,3 @@ Feature: Motorway Guidance
             | waypoints | route      | turns                            |
             | d,c       | db,abc,abc | depart,merge slight left,arrive  |
             | e,c       | eb,abc,abc | depart,merge slight right,arrive |
-
-    Scenario: Handle 90 degree off ramps correctly
-        Given the node map
-            | a |   |   |   |   |
-            | x | b |   | c | y |
-            |   |   |   | d |   |
-
-        And the ways
-            | nodes | name | highway       | oneway |
-            | ab    | On   | motorway_link | yes    |
-            | xb    | Hwy  | motorway      |        |
-            | bc    | Hwy  | motorway      |        |
-            | cd    | Off  | motorway_link | yes    |
-            | cy    | Hwy  | motorway      |        |
-
-       When I route I should get
-            | waypoints | route               | turns                                           |
-            | a,d       | On,Hwy,Off,Off      | depart,merge slight right,off ramp right,arrive |

features/guidance/post-processing.feature

@@ -1,22 +0,0 @@
-@routing  @guidance @post-processing
-Feature: General Post-Processing related features
-
-    Background:
-        Given the profile "car"
-        Given a grid size of 10 meters
-
-    # this testcase used to crash geometry generation (at that time handled during intersection generation)
-    Scenario: Regression test #2424
-        Given the node map
-            |   |   | e |   |   |   |   |   | i |   |   |   |   |
-            | a |   | b |   | c |   | d |   | h |   | k |   | m |
-            |   |   |   |   | f |   |   |   |   |   | l |   |   |
-
-        And the ways
-            | nodes  | name                 |
-            | abcd   | Fritz-Elsas-Straße   |
-            | hkm    | Fritz-Elsas-Straße   |
-            | dhi    | Martin-Luther-Straße |
-            | be     | corner               |
-            | kl     | corner               |
-            | cf     | corner               |

features/guidance/roundabout.feature

@@ -437,42 +437,3 @@ Feature: Basic Roundabout
         When I route I should get
             | waypoints | route                                                   | turns                                                     |
             | a,k       | massachusetts,massachusetts,massachusetts,massachusetts | depart,sheridan circle-exit-2,dupont circle-exit-1,arrive |
-
-    Scenario: Enter and Exit - Traffic Signals
-        Given the node map
-            |   |   | a |   |   |
-            |   | i | b | l |   |
-            | h | g |   | c | d |
-            |   | j | e | k |   |
-            |   |   | f |   |   |
-
-       And the nodes
-            | node | highway         |
-            | i    | traffic_signals |
-            | j    | traffic_signals |
-            | k    | traffic_signals |
-            | l    | traffic_signals |
-
-       And the ways
-            | nodes     | junction   |
-            | ab        |            |
-            | cd        |            |
-            | ef        |            |
-            | gh        |            |
-            | bigjekclb | roundabout |
-
-       When I route I should get
-           | waypoints | route    | turns                           |
-           | a,d       | ab,cd,cd | depart,roundabout-exit-3,arrive |
-           | a,f       | ab,ef,ef | depart,roundabout-exit-2,arrive |
-           | a,h       | ab,gh,gh | depart,roundabout-exit-1,arrive |
-           | d,f       | cd,ef,ef | depart,roundabout-exit-3,arrive |
-           | d,h       | cd,gh,gh | depart,roundabout-exit-2,arrive |
-           | d,a       | cd,ab,ab | depart,roundabout-exit-1,arrive |
-           | f,h       | ef,gh,gh | depart,roundabout-exit-3,arrive |
-           | f,a       | ef,ab,ab | depart,roundabout-exit-2,arrive |
-           | f,d       | ef,cd,cd | depart,roundabout-exit-1,arrive |
-           | h,a       | gh,ab,ab | depart,roundabout-exit-3,arrive |
-           | h,d       | gh,cd,cd | depart,roundabout-exit-2,arrive |
-           | h,f       | gh,ef,ef | depart,roundabout-exit-1,arrive |
-

features/guidance/turn-lanes.feature

@@ -1,739 +0,0 @@
-@routing @guidance @turn-lanes
-Feature: Turn Lane Guidance
-
-    Background:
-        Given the profile "car"
-        Given a grid size of 20 meters
-
-    @bug
-    Scenario: Basic Turn Lane 3-way Turn with empty lanes
-        Given the node map
-            | a |   | b |   | c |
-            |   |   | d |   |   |
-
-        And the ways
-            | nodes  | turn:lanes     | turn:lanes:forward | turn:lanes:backward | name     |
-            | ab     |                | through\|right     |                     | in       |
-            | bc     |                |                    | left\|through\|\|   | straight |
-            | bd     |                |                    | left\|right         | right    |
-
-       When I route I should get
-            | waypoints | route                | turns                           | lanes                                            |
-            | a,c       | in,straight,straight | depart,new name straight,arrive | ,straight:true right:false,                      |
-            | a,d       | in,right,right       | depart,turn right,arrive        | ,straight:false right:true,                      |
-            | c,a       | straight,in,in       | depart,new name straight,arrive | ,left:false straight:true none:true none:true,   |
-            | c,d       | straight,right,right | depart,turn left,arrive         | ,left:true straight:false none:false none:false, |
-
-    Scenario: Basic Turn Lane 4-Way Turn
-        Given the node map
-            |   |   | e |   |   |
-            | a |   | b |   | c |
-            |   |   | d |   |   |
-
-        And the ways
-            | nodes  | turn:lanes     | turn:lanes:forward | turn:lanes:backward | name     |
-            | ab     |                | \|right            |                     | in       |
-            | bc     |                |                    |                     | straight |
-            | bd     |                |                    | left\|              | right    |
-            | be     |                |                    |                     | left     |
-
-       When I route I should get
-            | waypoints | route                   | turns                           | lanes                   |
-            | a,c       | in,straight,straight    | depart,new name straight,arrive | ,none:true right:false, |
-            | a,d       | in,right,right          | depart,turn right,arrive        | ,none:false right:true, |
-            | a,e       | in,left,left            | depart,turn left,arrive         | ,none:true right:false, |
-            | d,a       | right,in,in             | depart,turn left,arrive         | ,left:true none:false,  |
-            | d,e       | right,left,left         | depart,new name straight,arrive | ,left:false none:true,  |
-            | d,c       | right,straight,straight | depart,turn right,arrive        | ,left:false none:true,  |
-
-    Scenario: Basic Turn Lane 4-Way Turn using none
-        Given the node map
-            |   |   | e |   |   |
-            | a |   | b |   | c |
-            |   |   | d |   |   |
-
-        And the ways
-            | nodes  | turn:lanes     | turn:lanes:forward | turn:lanes:backward | name     |
-            | ab     |                | none\|right        |                     | in       |
-            | bc     |                |                    |                     | straight |
-            | bd     |                |                    | left\|none          | right    |
-            | be     |                |                    |                     | left     |
-
-       When I route I should get
-            | waypoints | route                | turns                           | lanes                   |
-            | a,c       | in,straight,straight | depart,new name straight,arrive | ,none:true right:false, |
-            | a,d       | in,right,right       | depart,turn right,arrive        | ,none:false right:true, |
-            | a,e       | in,left,left         | depart,turn left,arrive         | ,none:true right:false, |
-
-    Scenario: Basic Turn Lane 4-Way With U-Turn Lane
-        Given the node map
-            |   |   | e |   |   |
-            | a | 1 | b |   | c |
-            |   |   | d |   |   |
-
-        And the ways
-            | nodes  | turn:lanes     | turn:lanes:forward          | name     |
-            | ab     |                | reverse;left\|through;right | in       |
-            | bc     |                |                             | straight |
-            | bd     |                |                             | right    |
-            | be     |                |                             | left     |
-
-       When I route I should get
-            | from | to | bearings        | route                | turns                           | lanes                                  |
-            | a    | c  | 180,180 180,180 | in,straight,straight | depart,new name straight,arrive | ,left;uturn:false straight;right:true, |
-            | a    | d  | 180,180 180,180 | in,right,right       | depart,turn right,arrive        | ,left;uturn:false straight;right:true, |
-            | a    | e  | 180,180 180,180 | in,left,left         | depart,turn left,arrive         | ,left;uturn:true straight;right:false, |
-            | 1    | a  | 90,2 270,2      | in,in,in             | depart,turn uturn,arrive        | ,left;uturn:true straight;right:false, |
-
-
-    #this next test requires decision on how to announce lanes for going straight if there is no turn
-    Scenario: Turn with Bus-Lane
-        Given the node map
-            | a |   | b |   | c |
-            |   |   |   |   |   |
-            |   |   | d |   |   |
-
-        And the ways
-            | nodes | name | turn:lanes:forward | lanes:psv:forward |
-            | ab    | road | through\|right\|   | 1                 |
-            | bc    | road |                    |                   |
-            | bd    | turn |                    |                   |
-
-        When I route I should get
-            | waypoints | route          | turns                    | lanes                       |
-            | a,d       | road,turn,turn | depart,turn right,arrive | ,straight:false right:true, |
-            | a,c       | road,road      | depart,arrive            | ,                           |
-
-    @PROFILE @LANES
-    Scenario: Turn with Bus-Lane but without lanes
-        Given the node map
-            | a |   | b |   | c |
-            |   |   |   |   |   |
-            |   |   | d |   |   |
-
-        And the ways
-            | nodes | name | lanes:psv |
-            | ab    | road | 1         |
-            | bc    | road | yes       |
-            | bd    | turn |           |
-
-        When I route I should get
-            | waypoints | route          | turns                    |
-            | a,d       | road,turn,turn | depart,turn right,arrive |
-            | a,c       | road,road      | depart,arrive            |
-
-    #turn lanes are often drawn at the incoming road, even though the actual turn requires crossing the intersection first
-    @todo @bug
-    Scenario: Turn Lanes at Segregated Road
-        Given the node map
-            |   |   | i | l |   |   |
-            |   |   |   |   |   |   |
-            | h |   | g | f |   | e |
-            | a |   | b | c |   | d |
-            |   |   |   |   |   |   |
-            |   |   | j | k |   |   |
-
-        And the ways
-            | nodes | name  | turn:lanes:forward       | oneway |
-            | ab    | road  | left\|through\|right     | yes    |
-            | bc    | road  | left\|through            | yes    |
-            | cd    | road  |                          | yes    |
-            | ef    | road  | \|through\|through;right | yes    |
-            | fg    | road  | left;through\|through\|  | yes    |
-            | gh    | road  |                          | yes    |
-            | ig    | cross |                          | yes    |
-            | gb    | cross | left\|through            | yes    |
-            | bj    | cross |                          | yes    |
-            | kc    | cross | left\|through;right      | yes    |
-            | cf    | cross | left\|through            | yes    |
-            | fl    | cross |                          | yes    |
-
-        When I route I should get
-            | waypoints | route             | turns                           | lanes                                           |
-            | a,j       | road,cross,cross  | depart,turn right,arrive        | ,left:false straight:false right:true           |
-            | a,d       | road,road,road    | depart,use lane straight,arrive | ,left:false straight:true right:false,          |
-            | a,l       | road,cross,cross  | depart,turn left,arrive         | ,left:true straight:false right:false,          |
-            | a,h       | road,road,road    | depart,continue uturn,arrive    | ,left:true straight:false right:false,          |
-            | k,d       | cross,road,road   | depart,turn right,arrive        | ,left:false straight;right:true,                |
-            | k,l       | cross,cross,cross | depart,use lane straight,arrive | ,left:false straight;right:true,                |
-            | k,h       | cross,road,road   | depart,turn left,arrive         | ,left:true straight;right:false,                |
-            | k,j       | cross,cross,cross | depart,continue uturn,arrive    | ,left:true straight;right:false,                |
-            | e,l       | road,cross,cross  | depart,turn right,arrive        | ,none:false straight:false straight;right:true, |
-            | e,h       | road,road         | depart,arrive                   | ,none:false straight:true straight;right:true   |
-            | e,j       | road,cross,cross  | depart,turn left,arrive         | ,none:true straight:false straight;right:false, |
-            | e,d       | road,road,road    | depart,continue uturn,arrive    | ,none:true straight:false straight;right:false, |
-            | i,h       | cross,road,road   | depart,turn right,arrive        | ,,                                              |
-            | i,j       | cross,cross,cross | depart,use lane straight,arrive | ,left:false straight:true,                      |
-            | i,d       | cross,road,road   | depart,turn left,arrive         | ,left:true straight:false,                      |
-            | i,l       | cross,cross,cross | depart,continue uturn,arrive    | ,left:true straight:false,                      |
-
-    #copy of former case to prevent further regression
-    Scenario: Turn Lanes at Segregated Road
-        Given the node map
-            |   |   | i | l |   |   |
-            |   |   |   |   |   |   |
-            | h |   | g | f |   | e |
-            | a |   | b | c |   | d |
-            |   |   |   |   |   |   |
-            |   |   | j | k |   |   |
-
-        And the ways
-            | nodes | name  | turn:lanes:forward       | oneway |
-            | ab    | road  | left\|through\|right     | yes    |
-            | bc    | road  | left\|through            | yes    |
-            | cd    | road  |                          | yes    |
-            | ef    | road  | \|through\|through;right | yes    |
-            | fg    | road  | left;through\|through\|  | yes    |
-            | gh    | road  |                          | yes    |
-            | ig    | cross |                          | yes    |
-            | gb    | cross | left\|through            | yes    |
-            | bj    | cross |                          | yes    |
-            | kc    | cross | left\|through;right      | yes    |
-            | cf    | cross | left\|through            | yes    |
-            | fl    | cross |                          | yes    |
-
-        When I route I should get
-            | waypoints | route             | turns                        | lanes                                           |
-            | a,j       | road,cross,cross  | depart,turn right,arrive     | ,left:false straight:false right:true,          |
-            | k,d       | cross,road,road   | depart,turn right,arrive     | ,left:false straight;right:true,                |
-            | e,l       | road,cross,cross  | depart,turn right,arrive     | ,none:false straight:false straight;right:true, |
-            | i,h       | cross,road,road   | depart,turn right,arrive     | ,,                                              |
-            | i,j       | cross,cross       | depart,arrive                | ,                                               |
-            | i,l       | cross,cross,cross | depart,continue uturn,arrive | ,left:true straight:false,                      |
-
-    Scenario: Turn Lanes at Segregated Road
-        Given the node map
-            |   |   | g | f |   |   |
-            | a |   | b | c |   | d |
-            |   |   |   |   |   |   |
-            |   |   | j | k |   |   |
-
-        And the ways
-            | nodes | name  | turn:lanes:forward   | oneway |
-            | ab    | road  | left\|through\|right | yes    |
-            | bc    | road  |                      | yes    |
-            | cd    | road  |                      | yes    |
-            | gb    | cross |                      | yes    |
-            | bj    | cross |                      | yes    |
-            | kc    | cross |                      | yes    |
-            | cf    | cross |                      | yes    |
-
-        When I route I should get
-            | waypoints | route             | turns                           | lanes                                  |
-            | a,j       | road,cross,cross  | depart,turn right,arrive        | ,left:false straight:false right:true, |
-
-    #this can happen due to traffic lights / lanes not drawn up to the intersection itself
-    Scenario: Turn Lanes Given earlier than actual turn
-        Given the node map
-            | a |   | b | c |   | d |
-            |   |   |   |   |   |   |
-            |   |   |   | e |   |   |
-
-        And the ways
-            | nodes | name | turn:lanes:forward |
-            | ab    | road | \|right            |
-            | bc    | road |                    |
-            | cd    | road |                    |
-            | ce    | turn |                    |
-
-        When I route I should get
-            | waypoints | route          | turns                    | lanes                   |
-            | a,e       | road,turn,turn | depart,turn right,arrive | ,none:false right:true, |
-            | a,d       | road,road      | depart,arrive            | ,                       |
-
-    Scenario: Turn Lanes Given earlier than actual turn
-        Given the node map
-            | a |   | b | c | d |   | e |   | f | g | h |   | i |
-            |   |   | j |   |   |   |   |   |   |   | k |   |   |
-
-        And the ways
-            | nodes | name        | turn:lanes:forward | turn:lanes:backward |
-            | abc   | road        |                    |                     |
-            | cd    | road        |                    | left\|              |
-            | def   | road        |                    |                     |
-            | fg    | road        | \|right            |                     |
-            | ghi   | road        |                    |                     |
-            | bj    | first-turn  |                    |                     |
-            | hk    | second-turn |                    |                     |
-
-        When I route I should get
-            | waypoints | route                        | turns                    | lanes                   |
-            | a,k       | road,second-turn,second-turn | depart,turn right,arrive | ,none:false right:true, |
-            | a,i       | road,road                    | depart,arrive            | ,                       |
-            | i,j       | road,first-turn,first-turn   | depart,turn left,arrive  | ,left:true none:false,  |
-            | i,a       | road,road                    | depart,arrive            | ,                       |
-
-    Scenario: Passing a one-way street
-        Given the node map
-            | e |   |   | f |   |
-            | a |   | b | c | d |
-
-        And the ways
-            | nodes | name | turn:lanes:forward | oneway |
-            | ab    | road | left\|through      | no     |
-            | bcd   | road |                    | no     |
-            | eb    | owi  |                    | yes    |
-            | cf    | turn |                    |        |
-
-        When I route I should get
-            | waypoints | route          | turns                   | lanes                      |
-            | a,f       | road,turn,turn | depart,turn left,arrive | ,left:true straight:false, |
-
-    Scenario: Passing a one-way street, partly pulled back lanes
-        Given the node map
-            | e |   |   | f |   |
-            | a |   | b | c | d |
-            |   |   | g |   |   |
-
-        And the ways
-            | nodes | name  | turn:lanes:forward  | oneway |
-            | ab    | road  | left\|through;right | no     |
-            | bcd   | road  |                     | no     |
-            | eb    | owi   |                     | yes    |
-            | cf    | turn  |                     | no     |
-            | bg    | right |                     | no     |
-
-        When I route I should get
-            | waypoints | route            | turns                    | lanes                            |
-            | a,f       | road,turn,turn   | depart,turn left,arrive  | ,left:true straight;right:false, |
-            | a,g       | road,right,right | depart,turn right,arrive | ,left:false straight;right:true, |
-
-    Scenario: Passing a one-way street, partly pulled back lanes, no through
-        Given the node map
-            | e |   |   | f |
-            | a |   | b | c |
-            |   |   | g |   |
-
-        And the ways
-            | nodes | name  | turn:lanes:forward  | oneway |
-            | ab    | road  | left\|right         | no     |
-            | bc    | road  |                     | no     |
-            | eb    | owi   |                     | yes    |
-            | cf    | turn  |                     | no     |
-            | bg    | right |                     | no     |
-
-        When I route I should get
-            | waypoints | route            | turns                    | lanes                   |
-            | a,f       | road,turn,turn   | depart,turn left,arrive  | ,left:true right:false, |
-            | a,g       | road,right,right | depart,turn right,arrive | ,left:false right:true, |
-
-    @todo @bug
-    Scenario: Narrowing Turn Lanes
-        Given the node map
-            |   |   |   |   | g |   |
-            |   |   |   |   |   |   |
-            | a |   | b | c | d | e |
-            |   |   |   | f |   |   |
-
-        And the ways
-            | nodes | name    | turn:lanes:forward   |
-            | ab    | road    | left\|through\|right |
-            | bc    | road    |                      |
-            | cd    | road    | left\|through        |
-            | de    | through |                      |
-            | dg    | left    |                      |
-            | cf    | right   |                      |
-
-        When I route I should get
-            | waypoints | route                | turns                           | lanes                                  |
-            | a,g       | road,left,left       | depart,turn left,arrive         | ,left:true straight:false right:false, |
-            | a,e       | road,through,through | depart,new name straight,arrive | ,left:false straight:true right:false, |
-            | a,f       | road,right,right     | depart,turn right,arrive        | ,left:false straight:false right:true, |
-
-    Scenario: Turn at a traffic light
-        Given the node map
-            | a | b | c | d |
-            |   |   | e |   |
-
-        And the nodes
-            | node | highway         |
-            | b    | traffic_signals |
-
-        And the ways
-            | nodes | name | turn:lanes:forward |
-            | ab    | road | through\|right     |
-            | bc    | road |                    |
-            | cd    | road |                    |
-            | ce    | turn |                    |
-
-        When I route I should get
-            | waypoints | route          | turns                    | lanes                       |
-            | a,d       | road,road      | depart,arrive            | ,                           |
-            | a,e       | road,turn,turn | depart,turn right,arrive | ,straight:false right:true, |
-
-    @bug @todo
-    Scenario: Theodor Heuss Platz
-        Given the node map
-            |   |   |   | i | o |   |   | l |   |
-            |   |   | b |   |   |   | a |   | m |
-            |   | c |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   | h |   |
-            |   |   |   |   |   |   |   |   |   |
-            | j |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   | g |   |
-            |   |   |   |   |   |   |   |   |   |
-            |   | d |   |   |   |   |   |   |   |
-            |   |   | e |   |   |   | f |   |   |
-            |   |   |   |   | k |   |   |   | n |
-
-        And the nodes
-            | node | highway         |
-            | g    | traffic_signals |
-
-        And the ways
-            | nodes         | name          | turn:lanes:forward                                                | junction   | oneway | highway   |
-            | abcdef        | roundabout    |                                                                   | roundabout | yes    | primary   |
-            | gha           | roundabout    |                                                                   | roundabout | yes    | primary   |
-            | fg            | roundabout    | slight_left\|slight_left;slight_right\|slight_right\|slight_right | roundabout | yes    | primary   |
-            | aoib          | top           |                                                                   |            | yes    | primary   |
-            | cjd           | left          |                                                                   |            | yes    | primary   |
-            | ekf           | bottom        |                                                                   |            | yes    | primary   |
-            | fng           | bottom-right  |                                                                   |            | yes    | primary   |
-            | hma           | top-right     |                                                                   |            | yes    | primary   |
-            | hl            | top-right-out |                                                                   |            | yes    | secondary |
-
-        When I route I should get
-            | waypoints | route                           | turns                           | lanes                                                                                  |
-            | i,m       | top,top-right,top-right         | depart,roundabout-exit-4,arrive | ,slight left:false slight left;slight right:true slight right:true slight right:true,  |
-            | i,l       | top,top-right-out,top-right-out | depart,roundabout-exit-4,arrive | ,slight left:true slight left;slight right:true slight right:false slight right:false, |
-            | i,o       | top,top,top                     | depart,roundabout-exit-5,arrive | ,,                                                                                     |
-
-    Scenario: Turn Lanes Breaking up
-        Given the node map
-            |   |   |   | g |   |
-            |   |   |   |   |   |
-            |   |   |   | c |   |
-            | a | b |   | d | e |
-            |   |   |   |   |   |
-            |   |   |   | f |   |
-
-        And the ways
-            | nodes | name  | turn:lanes:forward           | oneway | highway   |
-            | ab    | road  | left\|left\|through\|through | yes    | primary   |
-            | bd    | road  | through\|through             | yes    | primary   |
-            | bc    | road  | left\|left                   | yes    | primary   |
-            | de    | road  |                              | yes    | primary   |
-            | fdcg  | cross |                              |        | secondary |
-
-        And the relations
-            | type        | way:from | way:to | node:via | restriction   |
-            | restriction | bd       | fdcg   | d        | no_left_turn  |
-            | restriction | bc       | fdcg   | c        | no_right_turn |
-
-        When I route I should get
-            | waypoints | route            | turns                   | lanes                                               |
-            | a,g       | road,cross,cross | depart,turn left,arrive | ,left:true left:true straight:false straight:false, |
-            | a,e       | road,road        | depart,arrive           | ,                                                   |
-
-    Scenario: U-Turn Road at Intersection
-        Given the node map
-            |   |   |   |   |   | h |   |
-            |   |   |   |   | f | e | j |
-            | a | b |   |   |   |   |   |
-            |   |   |   |   | c | d | i |
-            |   |   |   |   |   | g |   |
-
-        And the ways
-            | nodes | name  | turn:lanes:forward | oneway | highway  |
-            | ab    | road  |                    | no     | primary  |
-            | di    | road  |                    | yes    | primary  |
-            | bc    | road  | \|through\|right   | yes    | primary  |
-            | cd    | road  | \|through\|right   | yes    | primary  |
-            | fc    | road  |                    | no     | tertiary |
-            | jefb  | road  |                    | yes    | primary  |
-            | gdeh  | cross |                    | no     | primary  |
-
-       When I route I should get
-            | from | to | bearings        | route            | turns                        | lanes                                  |
-            | a    | g  | 180,180 180,180 | road,cross,cross | depart,turn right,arrive     | ,none:false straight:false right:true, |
-            | a    | h  | 180,180 180,180 | road,cross,cross | depart,turn left,arrive      | ,none:true straight:false right:false, |
-            | a    | i  | 180,180 180,180 | road,road        | depart,arrive                | ,                                      |
-            | b    | a  | 90,2 270,2      | road,road,road   | depart,continue uturn,arrive | ,none:true straight:false right:false, |
-
-    Scenario: Segregated Intersection Merges With Lanes
-        Given the node map
-            |   |   |   |   |   |   | f |
-            |   |   |   |   |   |   |   |
-            | e |   |   | d |   |   |   |
-            |   |   |   |   |   | c | g |
-            | a |   |   | b |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   |   |   |   |   | h |   |
-
-        And the ways
-            | nodes | name     | turn:lanes:forward                 | oneway | highway   |
-            | abc   | road     | left\|left\|left\|through\|through | yes    | primary   |
-            | cde   | road     |                                    | yes    | primary   |
-            | hc    | cross    |                                    | yes    | secondary |
-            | cg    | straight |                                    | no     | tertiary  |
-            | cf    | left     |                                    | yes    | primary   |
-
-        When I route I should get
-            | waypoints | route                  | turns                           | lanes                                                           |
-            | a,f       | road,left,left         | depart,turn left,arrive         | ,left:true left:true left:true straight:false straight:false,   |
-            | a,e       | road,road,road         | depart,turn uturn,arrive        | ,left:true left:false left:false straight:false straight:false, |
-            | a,g       | road,straight,straight | depart,new name straight,arrive | ,left:false left:false left:false straight:true straight:true,  |
-
-    @bug @todo
-    Scenario: Passing Through a Roundabout
-        Given the node map
-            |   |   | h |   | g |   |   |
-            |   | a |   |   |   | f | k |
-            | i |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |
-            |   | b |   |   |   | e |   |
-            |   |   | c |   | d |   |   |
-            |   |   |   |   | j |   |   |
-
-        And the ways
-            | nodes | name   | turn:lanes:forward                     | oneway | highway   | junction   |
-            | efgha | round  |                                        | yes    | primary   | roundabout |
-            | ab    | round  |                                        | yes    | primary   | roundabout |
-            | bc    | round  | slight_left\|slight_left\|slight_right | yes    | primary   | roundabout |
-            | cd    | round  |                                        | yes    | primary   | roundabout |
-            | de    | round  | slight_left\|slight_right              | yes    | primary   | roundabout |
-            | ib    | left   | slight_left\|slight_left\|slight_right | yes    | primary   |            |
-            | cj    | bottom |                                        | yes    | primary   |            |
-            | ek    | right  |                                        | yes    | primary   |            |
-
-        When I route I should get
-            | waypoints | route              | turns                      | lanes |
-            | i,j       | left,bottom,bottom | depart,round-exit-1,arrive | ,0,   |
-            | i,k       | left,right,right   | depart,round-exit-2,arrive | ,1,   |
-
-    Scenario: Crossing Traffic Light
-        Given the node map
-            | a |   | b |   | c |   | d |
-            |   |   |   |   |   |   | e |
-
-        And the nodes
-            | node | highway         |
-            | b    | traffic_signals |
-
-        And the ways
-            | nodes | name  | turn:lanes:forward                                   | highway |
-            | abc   | road  | through\|through\|through;slight_right\|slight_right | primary |
-            | cd    | road  |                                                      | primary |
-            | ce    | cross |                                                      | primary |
-
-        When I route I should get
-            | waypoints | route            | turns                           | lanes                                                                        |
-            | a,d       | road,road        | depart,arrive                   | ,                                                                            |
-            | a,e       | road,cross,cross | depart,turn slight right,arrive | ,straight:false straight:false straight;slight right:true slight right:true, |
-
-    Scenario: Highway Ramp
-        Given the node map
-            | a |   | b |   | c |   | d |
-            |   |   |   |   |   |   | e |
-
-        And the ways
-            | nodes | name | turn:lanes:forward                                   | highway       |
-            | abc   | hwy  | through\|through\|through;slight_right\|slight_right | motorway      |
-            | cd    | hwy  |                                                      | motorway      |
-            | ce    | ramp |                                                      | motorway_link |
-
-        When I route I should get
-            | waypoints | route         | turns                               | lanes                                                                        |
-            | a,d       | hwy,hwy       | depart,arrive                       | ,                                                                            |
-            | a,e       | hwy,ramp,ramp | depart,off ramp slight right,arrive | ,straight:false straight:false straight;slight right:true slight right:true, |
-
-    @bug @todo
-    Scenario: Turning Off Ramp
-        Given the node map
-            |   | a |   |
-            | d | c | b |
-            | e | f | g |
-            |   | h |   |
-
-        And the ways
-            | nodes | name | turn:lanes:forward | highway       | oneway |
-            | ac    | off  | left\|right        | motorway_link | yes    |
-            | bcd   | road |                    | primary       | yes    |
-            | cf    | road |                    | primary       |        |
-            | efg   | road |                    | primary       | yes    |
-            | fh    | on   |                    | motorway_link | yes    |
-
-        When I route I should get
-            | waypoints | route         | turns                    | lanes                   |
-            | a,d       | off,road,road | depart,turn_right,arrive | ,left:false right:true, |
-            | a,g       | off,road,road | depart,turn_left,arrive  | ,left:true right:false, |
-            | a,h       |               |                          |                         |
-
-    Scenario: Off Ramp In a Turn
-        Given the node map
-            | a |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   |   | b |   |   |   |   |   | c |
-            |   |   |   |   |   |   |   |   |   |   | d |   |
-
-        And the ways
-            | nodes | name | turn:lanes:forward             | highway       | oneway |
-            | ab    | hwy  | through\|through\|slight_right | motorway      | yes    |
-            | bc    | hwy  |                                | motorway      | yes    |
-            | bd    | ramp |                                | motorway_link | yes    |
-
-        When I route I should get
-            | waypoints | route         | turns                               | lanes                                             |
-            | a,c       | hwy,hwy       | depart,arrive                       | ,                                                 |
-            | a,d       | hwy,ramp,ramp | depart,off ramp slight right,arrive | ,straight:false straight:false slight right:true, |
-
-    Scenario: Reverse Lane in Segregated Road
-        Given the node map
-            | h |   |   |   |   | g |   |   |   |   |   | f |
-            |   |   |   |   |   |   |   | e |   |   |   |   |
-            |   |   |   |   |   |   |   | d |   |   |   |   |
-            | a |   |   |   |   | b |   |   |   |   |   | c |
-
-        And the ways
-            | nodes | name | turn:lanes:forward        | highway      | oneway |
-            | ab    | road | reverse\|through\|through | primary      | yes    |
-            | bc    | road |                           | primary      | yes    |
-            | bdeg  | road |                           | primary_link | yes    |
-            | fgh   | road |                           | primary      | yes    |
-
-        When I route I should get
-            | waypoints | route          | turns                        | lanes                                     |
-            | a,h       | road,road,road | depart,continue uturn,arrive | ,uturn:true straight:false straight:false,|
-
-    Scenario: Reverse Lane in Segregated Road with none
-        Given the node map
-            | h |   |   |   |   | g |   |   |   |   |   | f |
-            |   |   |   |   |   |   |   | e |   |   |   |   |
-            |   |   |   |   |   |   |   | d |   |   |   |   |
-            | a |   |   |   |   | b |   |   |   |   |   | c |
-
-        And the ways
-            | nodes | name | turn:lanes:forward     | highway      | oneway |
-            | ab    | road | reverse\|through\|none | primary      | yes    |
-            | bc    | road |                        | primary      | yes    |
-            | bdeg  | road |                        | primary_link | yes    |
-            | fgh   | road |                        | primary      | yes    |
-
-        When I route I should get
-            | waypoints | route          | turns                        | lanes                                  |
-            | a,h       | road,road,road | depart,continue uturn,arrive | ,uturn:true straight:false none:false, |
-
-    Scenario: Reverse Lane in Segregated Road with none, Service Turn Prior
-        Given the node map
-            | h |   |   |   |   | g |   |   |   |   |   | f |
-            |   |   |   |   |   |   |   | e |   |   |   |   |
-            |   |   |   |   |   |   |   | d |   |   |   |   |
-            | a |   | j |   |   | b |   |   |   |   |   | c |
-            |   |   | i |   |   |   |   |   |   |   |   |   |
-
-        And the ways
-            | nodes | name | turn:lanes:forward     | highway      | oneway |
-            | ajb   | road | reverse\|through\|none | primary      | yes    |
-            | bc    | road |                        | primary      | yes    |
-            | bdeg  | road |                        | primary_link | yes    |
-            | fgh   | road |                        | primary      | yes    |
-            | ji    | park |                        | service      | no     |
-
-        When I route I should get
-            | waypoints | route          | turns                        | lanes                                  |
-            | a,h       | road,road,road | depart,continue uturn,arrive | ,uturn:true straight:false none:false, |
-
-    Scenario: Don't collapse everything to u-turn / too wide
-        Given the node map
-            | a |   | b |   | e |
-            |   |   |   |   |   |
-            | d |   | c |   | f |
-
-        And the ways
-            | nodes | highway   | name   | turn:lanes:forward |
-            | ab    | primary   | road   | through\|right     |
-            | bc    | primary   | road   |                    |
-            | dc    | primary   | road   | left\|through      |
-            | be    | secondary | top    |                    |
-            | cf    | secondary | bottom |                    |
-
-        When I route I should get
-            | waypoints | turns                                   | route               | lanes                        |
-            | a,d       | depart,continue right,turn right,arrive | road,road,road,road | ,straight:false right:true,, |
-            | d,a       | depart,continue left,turn left,arrive   | road,road,road,road | ,left:true straight:false,,  |
-
-    Scenario: Merge Lanes Onto Freeway
-        Given the node map
-            | a |   |   | b | c |
-            |   | d |   |   |   |
-
-        And the ways
-            | nodes | highway       | name | turn:lanes:forward         |
-            | abc   | motorway      | Hwy  |                            |
-            | db    | motorway_link | ramp | slight_right\|slight_right |
-
-        When I route I should get
-            | waypoints | turns                           | route        | lanes                                 |
-            | d,c       | depart,merge slight left,arrive | ramp,Hwy,Hwy | ,slight right:true slight right:true, |
-
-    Scenario: Fork on motorway links - don't fork on through but use lane
-        Given the node map
-            | i |   |   |   |   | a |
-            | j |   | c | b |   | x |
-
-        And the ways
-            | nodes | name | highway       | turn:lanes:forward |
-            | xb    | xbcj | motorway_link |                    |
-            | bc    | xbcj | motorway_link | none\|slight_right |
-            | cj    | xbcj | motorway_link |                    |
-            | ci    | off  | motorway_link |                    |
-            | ab    | on   | motorway_link |                    |
-
-        When I route I should get
-            | waypoints | route           | turns                                             | lanes                           |
-            | a,j       | on,xbcj,xbcj    | depart,merge slight left,arrive                   | ,,                              |
-            | a,i       | on,xbcj,off,off | depart,merge slight left,turn slight right,arrive | ,,none:false slight right:true, |
-
-    #http://www.openstreetmap.org/#map=17/52.47414/13.35712
-    @todo @ramp @2645
-    Scenario: Kreuz Schoeneberg - Continue on ramp, don't merge
-        Given the node map
-            | i |   |   |   |   | j |   |   |   |   |   |   |   |   |   |   |   |
-            |   |   |   |   | k |   |   |   |   |   |   |   |   |   |   |   |   |
-            | h | g |   | l |   |   | f |   |   |   |   |   |   |   |   |   | e |
-            | d |   |   |   |   |   |   |   | c |   |   |   |   | b |   |   | a |
-
-        And the ways
-            | nodes | highway       | name  | oneway | lanes | turn:lanes            |
-            | ab    | motorway      | A 100 | yes    | 3     |                       |
-            | bc    | motorway      | A 100 | yes    | 4     | \|\|\|slight_right    |
-            | cd    | motorway      | A 100 | yes    | 3     |                       |
-            | eb    | motorway_link |       | yes    | 1     |                       |
-            | cf    | motorway_link |       | yes    | 1     |                       |
-            | fj    | motorway_link |       | yes    | 1     |                       |
-            | fl    | motorway_link |       | yes    | 1     |                       |
-            | kl    | motorway_link |       | yes    | 1     |                       |
-            | lg    | motorway_link |       | yes    | 2     | through\|slight_right |
-            | gi    | motorway_link |       | yes    | 1     |                       |
-            | gh    | motorway_link |       | yes    | 1     |                       |
-
-        When I route I should get
-            | waypoints | route        | turns                                                           | lanes                                                                                  |
-            | a,d       | A 100,A 100  | depart,arrive                                                   |                                                                                        |
-            | a,i       | A 100,,,,    | depart,off ramp slight right,fork slight left,turn right,arrive | ,none:false none:false none:false slight right:true,,straight:false slight right:true, |
-            | e,j       | ,,,          | depart,off ramp slight right,fork slight right,arrive           | ,none:false none:false none:false slight right:true,,,                                 |
-            | e,i       | ,,,,         | depart,off ramp right,fork slight left,use lane straight,arrive | ,none:false none:false none:false slight right:true,,straight:false slight right:true, |
-            | e,d       | ,A 100,A 100 | depart,merge slight left,arrive                                 | ,,                                                                                     |
-            | e,h       | ,,,,         | depart,off ramp right,fork left,use lane straight,arrive        | ,none:false none:false none:false slight right:true,,straight:true slight right:false, |
-
-    @collapse @use-lane
-    Scenario: Collapse Multiple Use Lanes
-        Given the node map
-            | x | a |   | b |   |   | c |   |   | d |
-            |   |   |   | e |   |   | f |   |   |   |
-
-        And the ways
-            | nodes | name | highway | turn:lanes:forward |
-            | ab    | road | primary | through,right      |
-            | bc    | road | primary | through,right      |
-            | cd    | road | primary |                    |
-            | xa    | road | primary |                    |
-            | be    | turn | primary |                    |
-            | cf    | turn | primary |                    |
-
-        When I route I should get
-            | waypoints | route     | turns         | lanes |
-            | x,d       | road,road | depart,arrive | ,     |
-
-
-

features/guidance/turn.feature

@@ -833,49 +833,3 @@ Feature: Simple Turns
             | a,d       | road,road        | depart,arrive           |
             | d,i       | road,cross,cross | depart,turn left,arrive |
             | d,g       | road,road        | depart,arrive           |
-
-     Scenario: Go onto turning major road
-        Given the node map
-            |   |   |   | c |
-            |   |   |   |   |
-            |   |   |   |   |
-            | a |   |   | b |
-            |   |   |   |   |
-            |   |   |   | d |
-
-        And the ways
-            | nodes | highway     | name |
-            | abc   | primary     | road |
-            | bd    | residential | in   |
-
-        When I route I should get
-            | waypoints | turns                           | route        |
-            | a,c       | depart,arrive                   | road,road    |
-            | d,a       | depart,turn left,arrive         | in,road,road |
-            | d,c       | depart,new name straight,arrive | in,road,road |
-
-    Scenario: Channing Street
-        Given the node map
-            |   |   | g | f |   |
-            |   |   |   |   |   |
-            | d |   | c | b | a |
-            |   |   |   |   |   |
-            |   |   |   |   |   |
-            |   |   | h | e |   |
-
-        And the nodes
-            | node | highway         |
-            | c    | traffic_signals |
-            | b    | traffic_signals |
-
-        And the ways
-            | nodes | name                           | highway     | oneway |
-            | ab    | Channing Street Northeast      | residential | no     |
-            | bcd   | Channing Street Northwest      | residential | yes    |
-            | ebf   | North Capitol Street Northeast | primary     | yes    |
-            | gch   | North Capitol Street Northeast | primary     | yes    |
-
-        When I route I should get
-            | waypoints | turns                   | route                                                                                   |
-            | a,d       | depart,arrive           | Channing Street Northeast,Channing Street Northwest                                     |
-            | a,h       | depart,turn left,arrive | Channing Street Northeast,North Capitol Street Northeast,North Capitol Street Northeast |

features/step_definitions/hooks.js

@@ -15,4 +15,16 @@ module.exports = function () {
         this.setOrigin(this.DEFAULT_ORIGIN);
         callback();
     });
+
+    this.Before('@ignore-platform-windows', () => {
+        this.skipThisScenario();
+    });
+
+    this.Before('@ignore-platform-unix', () => {
+        this.skipThisScenario();
+    });
+
+    this.Before('@ignore-platform-mac', () => {
+        this.skipThisScenario();
+    });
 };

features/support/data.js

@@ -223,7 +223,7 @@ module.exports = function () {
             };
 
             ['osrm', 'osrm.ebg', 'osrm.edges', 'osrm.enw', 'osrm.fileIndex', 'osrm.geometry', 'osrm.icd',
-             'osrm.names', 'osrm.nodes', 'osrm.properties', 'osrm.ramIndex', 'osrm.restrictions', 'osrm.tld', 'osrm.tls'].forEach(file => {
+             'osrm.names', 'osrm.nodes', 'osrm.properties', 'osrm.ramIndex', 'osrm.restrictions'].forEach(file => {
                  q.defer(rename, file);
              });
 
@@ -283,7 +283,7 @@ module.exports = function () {
 
             ['osrm', 'osrm.core', 'osrm.datasource_indexes', 'osrm.datasource_names', 'osrm.ebg','osrm.edges',
              'osrm.enw', 'osrm.fileIndex', 'osrm.geometry', 'osrm.hsgr', 'osrm.icd','osrm.level', 'osrm.names',
-             'osrm.nodes', 'osrm.properties', 'osrm.ramIndex', 'osrm.restrictions', 'osrm.tld', 'osrm.tls'].forEach((file) => {
+             'osrm.nodes', 'osrm.properties', 'osrm.ramIndex', 'osrm.restrictions'].forEach((file) => {
                  q.defer(rename, file);
              });
 

features/support/env.js

@@ -21,7 +21,7 @@ module.exports = function () {
         this.DEFAULT_GRID_SIZE = 100;    // meters
         this.PROFILES_PATH = path.resolve(this.ROOT_FOLDER, 'profiles');
         this.FIXTURES_PATH = path.resolve(this.ROOT_FOLDER, 'unit_tests/fixtures');
-        this.BIN_PATH = process.env.OSRM_BUILD_DIR && process.env.OSRM_BUILD_DIR || path.resolve(this.ROOT_FOLDER, 'build');
+        this.BIN_PATH = path.resolve(this.ROOT_FOLDER, 'build');
         this.DEFAULT_INPUT_FORMAT = 'osm';
         this.DEFAULT_ORIGIN = [1,1];
         this.DEFAULT_LOAD_METHOD = 'datastore';

features/support/hooks.js

@@ -33,4 +33,9 @@ module.exports = function () {
             });
         });
     });
+
+    this.Around('@stress', (scenario, callback) => {
+        // TODO implement stress timeout? Around support is being dropped in cucumber-js anyway
+        callback();
+    });
 };

features/support/route.js

@@ -168,17 +168,6 @@ module.exports = function () {
         return instructions.legs.map(l => l.annotation.nodes.map(n => n.toString()).join(',')).join(',');
     };
 
-    this.lanesList = (instructions) => {
-        return this.extractInstructionList(instructions, instruction => {
-            if( 'lanes' in instruction.intersections[0] )
-            {
-                return instruction.intersections[0].lanes.map( p => { return (p.indications).join(';') + ':' + p.valid; } ).join(' ');
-            } else
-            {
-                return '';
-            }});
-    };
-
     this.turnList = (instructions) => {
         return instructions.legs.reduce((m, v) => m.concat(v.steps), [])
             .map(v => {

features/support/shared_steps.js

@@ -33,8 +33,7 @@ module.exports = function () {
                 var afterRequest = (err, res, body) => {
                     if (err) return cb(err);
                     if (body && body.length) {
-                        let destinations, pronunciations, instructions, bearings, turns, modes, times,
-                            distances, summary, intersections, lanes;
+                        let destinations, pronunciations, instructions, bearings, turns, modes, times, distances, summary, intersections;
 
                         let json = JSON.parse(body);
 
@@ -50,7 +49,6 @@ module.exports = function () {
                             modes = this.modeList(json.routes[0]);
                             times = this.timeList(json.routes[0]);
                             distances = this.distanceList(json.routes[0]);
-                            lanes = this.lanesList(json.routes[0]);
                             summary = this.summary(json.routes[0]);
                         }
 
@@ -104,10 +102,6 @@ module.exports = function () {
                                 got.time = instructions ? util.format('%ds', time) : '';
                             }
 
-                            if (headers.has('lanes')) {
-                                got.lanes = (lanes || '').trim();
-                            }
-
                             if (headers.has('speed')) {
                                 if (row.speed !== '' && instructions) {
                                     if (!row.speed.match(/\d+ km\/h/))

features/testbot/basic.feature

@@ -266,24 +266,3 @@ Feature: Basic Routing
             | from | to | route | time |
             | a    | b  | ,     | 10s  |
             | b    | a  | ,     | 10s  |
-
-    Scenario: Ambiguous edge names - Use lexicographically smallest name
-        Given the node map
-            | a | b | c |
-
-        And the ways
-            | nodes | highway | name |
-            | ab    | primary |      |
-            | ab    | primary | Αβγ  |
-            | ab    | primary |      |
-            | ab    | primary | Abc  |
-            | ab    | primary |      |
-            | ab    | primary | Абв  |
-            | bc    | primary | Ηθι  |
-            | bc    | primary | Δεζ  |
-            | bc    | primary | Где  |
-
-        When I route I should get
-            | from | to | route       |
-            | a    | c  | Abc,Δεζ,Δεζ |
-            | c    | a  | Δεζ,Abc,Abc |

features/testbot/bearing.feature

@@ -59,10 +59,10 @@ Feature: Compass bearing
 
     Scenario: Bearing in a roundabout
         Given the node map
-            | k | d | c | j |
+            |   | d | c |   |
             | e |   |   | b |
             | f |   |   | a |
-            | l | g | h | i |
+            |   | g | h |   |
 
         And the ways
             | nodes | oneway |
@@ -74,14 +74,6 @@ Feature: Compass bearing
             | fg    | yes    |
             | gh    | yes    |
             | ha    | yes    |
-            | dk    | no     |
-            | ke    | no     |
-            | fl    | no     |
-            | lg    | no     |
-            | hi    | no     |
-            | ia    | no     |
-            | bj    | no     |
-            | cj    | no     |
 
         When I route I should get
             | from | to | route                   | bearing                                                     |
@@ -90,10 +82,8 @@ Feature: Compass bearing
 
     Scenario: Bearing should stay constant when zig-zagging
         Given the node map
-            | i | j | k |   |
             | b | d | f | h |
             | a | c | e | g |
-            |   | m | n | o |
 
         And the ways
             | nodes |
@@ -104,12 +94,6 @@ Feature: Compass bearing
             | ef    |
             | fg    |
             | gh    |
-            | bi    |
-            | cm    |
-            | dj    |
-            | en    |
-            | fk    |
-            | go    |
 
         When I route I should get
             | from | to | route                   | bearing               |

features/testbot/bearing_param.feature

@@ -14,11 +14,11 @@ Feature: Bearing parameter
             | ad    |
 
         When I route I should get
-            | from | to | bearings  | route | bearing    |
+            | from | to | bearings  | route | bearing |
             | b    | c  | 90 90     | ad,ad | 0->90,90->0|
-            | b    | c  | 180 90    |       |            |
+            | b    | c  | 180 90    |       |         |
             | b    | c  | 80 100    | ad,ad | 0->90,90->0|
-            | b    | c  | 79 100    |       |            |
+            | b    | c  | 79 100    |       |         |
             | b    | c  | 79,11 100 | ad,ad | 0->90,90->0|
 
     Scenario: Testbot - Intial bearing in simple case
@@ -33,13 +33,13 @@ Feature: Bearing parameter
             | bc    |
 
         When I route I should get
-            | from | to | bearings | route | bearing           |
-            | 0    | c  | 0 0      |       |                   |
-            | 0    | c  | 45 45    | bc,bc | 0->44,44->0 +- 1  |
-            | 0    | c  | 85 85    |       |                   |
-            | 0    | c  | 95 95    |       |                   |
+            | from | to | bearings | route | bearing |
+            | 0    | c  | 0 0      |       |         |
+            | 0    | c  | 45 45    | bc,bc | 0->44,44->0 +- 1|
+            | 0    | c  | 85 85    |       |         |
+            | 0    | c  | 95 95    |       |         |
             | 0    | c  | 135 135  | ac,ac | 0->135,135->0 +- 1|
-            | 0    | c  | 180 180  |       |                   |
+            | 0    | c  | 180 180  |       |         |
 
     Scenario: Testbot - Initial bearing on split way
         Given the node map
@@ -58,21 +58,21 @@ Feature: Bearing parameter
             | ha    | yes    |
 
         When I route I should get
-            | from | to | bearings | route          | bearing                             |
-            | 0    | b  | 10 10    | bc,bc          | 0->0,0->0                           |
-            | 0    | b  | 90 90    | ab,ab          | 0->90,90->0                         |
+            | from | to | bearings | route       | bearing       |
+            | 0    | b  | 10 10    | bc,bc       | 0->0,0->0     |
+            | 0    | b  | 90 90    | ab,ab       | 0->90,90->0   |
             # The returned bearing is wrong here, it's based on the snapped
             # coordinates, not the acutal edge bearing.  This should be
             # fixed one day, but it's only a problem when we snap two vias
             # to the same point - DP
-            #| 0    | b  | 170 170  | da          | 180                                   |
-            #| 0    | b  | 189 189  | da          | 180                                   |
-            | 0    | 1  | 90 270   | ab,bc,cd,cd    | 0->90,90->0,0->270,270->0           |
-            | 1    | d  | 10 10    | bc,bc          | 0->0,0->0                           |
+            #| 0    | b  | 170 170  | da          | 180           |
+            #| 0    | b  | 189 189  | da          | 180           |
+            | 0    | 1  | 90 270   | ab,bc,cd,cd    | 0->90,90->0,0->270,270->0      |
+            | 1    | d  | 10 10    | bc,bc          | 0->0,0->0  |
             | 1    | d  | 90 90    | ab,bc,cd,da,da | 0->90,90->0,0->270,270->180,180->0  |
-            | 1    | 0  | 189 189  | da,da          | 0->180,180->0                       |
-            | 1    | d  | 270 270  | cd,cd          | 0->270,270->0                       |
-            | 1    | d  | 349 349  |                |                                     |
+            | 1    | 0  | 189 189  | da,da       | 0->180,180->0 |
+            | 1    | d  | 270 270  | cd,cd       | 0->270,270->0 |
+            | 1    | d  | 349 349  |             |               |
 
     Scenario: Testbot - Initial bearing in all direction
         Given the node map

features/testbot/continue_straight.feature

@@ -3,7 +3,7 @@ Feature: U-turns at via points
 
     Background:
         Given the profile "testbot"
-        Given a grid size of 250 meters
+        Given a grid size of 100 meters
 
     Scenario: Continue straight at waypoints enabled by default
         Given the node map

features/testbot/loop.feature

@@ -75,12 +75,12 @@ Feature: Avoid weird loops caused by rounding errors
         And the node map
             | a |   |   |
             | b | e |   |
-            | h |   | 1 |
+            |   |   | 1 |
             |   |   |   |
             |   |   | 2 |
-            | g |   |   |
+            |   |   |   |
             |   | c | f |
-            | d |   |   |
+            |   | d |   |
 
         And the ways
             | nodes | highway     |
@@ -90,8 +90,6 @@ Feature: Avoid weird loops caused by rounding errors
             | be    | primary     |
             | ef    | primary     |
             | cf    | primary     |
-            | cg    | primary     |
-            | bh    | primary     |
 
         When I route I should get
             | waypoints | route                   |

features/testbot/oneway.feature

@@ -3,7 +3,6 @@ Feature: Testbot - oneways
 
     Background:
         Given the profile "testbot"
-        Given a grid size of 250 meters
 
     Scenario: Routing on a oneway roundabout
         Given the node map
@@ -60,8 +59,8 @@ Feature: Testbot - oneways
 
     Scenario: Testbot - Around the Block
         Given the node map
-            |   | a | b |   |
-            | e | d | c | f |
+            | a | b |
+            | d | c |
 
         And the ways
             | nodes | oneway | foot |
@@ -69,8 +68,6 @@ Feature: Testbot - oneways
             | bc    |        | no   |
             | cd    |        | no   |
             | da    |        | no   |
-            | de    |        | no   |
-            | cf    |        | no   |
 
         When I route I should get
             | from | to | route       |

features/testbot/summary.feature

@@ -29,7 +29,7 @@ Feature: Basic Routing
     Scenario: Check handling empty values
         Given the node map
             | a | b |  | c |   | d | f |
-            |   |   |  |   |   | e |   |
+            |   |   |  |   |   | e |
 
         And the ways
             | nodes | name |

features/testbot/time.feature

@@ -145,16 +145,14 @@ Feature: Estimation of travel time
 
     Scenario: Time of travel on a series of ways
         Given the node map
-            | a | b | e |
-            | f | c | d |
+            | a | b |   |
+            |   | c | d |
 
         And the ways
             | nodes | highway |
             | ab    | primary |
             | bc    | primary |
             | cd    | primary |
-            | be    | primary |
-            | cf    | primary |
 
         When I route I should get
             | from | to | route       | time    |

features/testbot/via.feature

@@ -85,16 +85,13 @@ Feature: Via points
     Scenario: Via points on ring of oneways
     # xa it to avoid only having a single ring, which cna trigger edge cases
         Given the node map
-            |   | x |   |   |   |   |   | g |   |
-            |   | a | 1 | b | 2 | c | 3 | d |   |
-            | i | f |   |   |   |   |   | e | h |
+            | x |   |   |   |   |   |   |
+            | a | 1 | b | 2 | c | 3 | d |
+            | f |   |   |   |   |   | e |
 
         And the ways
             | nodes | oneway |
             | xa    |        |
-            | if    |        |
-            | gd    |        |
-            | eh    |        |
             | ab    | yes    |
             | bc    | yes    |
             | cd    | yes    |
@@ -113,16 +110,13 @@ Feature: Via points
     Scenario: Via points on ring on the same oneway
     # xa it to avoid only having a single ring, which cna trigger edge cases
         Given the node map
-            |   | x |   |   |   | e |   |
-            |   | a | 1 | 2 | 3 | b |   |
-            | g | d |   |   |   | c | f |
+            | x |   |   |   |   |
+            | a | 1 | 2 | 3 | b |
+            | d |   |   |   | c |
 
         And the ways
             | nodes | oneway |
             | xa    |        |
-            | eb    |        |
-            | cf    |        |
-            | dg    |        |
             | ab    | yes    |
             | bc    | yes    |
             | cd    | yes    |

include/contractor/contractor.hpp

@@ -78,7 +78,7 @@ class Contractor
   private:
     ContractorConfig config;
 
-    EdgeID
+    std::size_t
     LoadEdgeExpandedGraph(const std::string &edge_based_graph_path,
                           util::DeallocatingVector<extractor::EdgeBasedEdge> &edge_based_edge_list,
                           const std::string &edge_segment_lookup_path,

include/contractor/crc32_processor.hpp

@@ -82,9 +82,6 @@ class IteratorbasedCRC32
                                  : "0"(crc), "c"(*str));
             ++str;
         }
-#else
-        (void)str;
-        (void)len;
 #endif
         return crc;
     }
@@ -98,11 +95,8 @@ class IteratorbasedCRC32
     }
 
 #if defined(__MINGW64__) || defined(_MSC_VER) || !defined(__x86_64__)
-    inline void __get_cpuid(int /*param*/,
-                            unsigned * /*eax*/,
-                            unsigned * /*ebx*/,
-                            unsigned *ecx,
-                            unsigned * /*edx*/) const
+    inline void
+    __get_cpuid(int param, unsigned *eax, unsigned *ebx, unsigned *ecx, unsigned *edx) const
     {
         *ecx = 0;
     }

include/engine/api/route_api.hpp

@@ -12,7 +12,6 @@
 #include "engine/guidance/assemble_overview.hpp"
 #include "engine/guidance/assemble_route.hpp"
 #include "engine/guidance/assemble_steps.hpp"
-#include "engine/guidance/lane_processing.hpp"
 #include "engine/guidance/post_processing.hpp"
 
 #include "engine/internal_route_result.hpp"
@@ -150,8 +149,6 @@ class RouteAPI : public BaseAPI
                                                               leg_geometry,
                                                               phantoms.source_phantom,
                                                               phantoms.target_phantom);
-                leg.steps = guidance::anticipateLaneChange(std::move(leg.steps));
-                leg.steps = guidance::collapseUseLane(std::move(leg.steps));
                 leg_geometry = guidance::resyncGeometry(std::move(leg_geometry), leg.steps);
             }
 

include/engine/datafacade/datafacade_base.hpp

@@ -7,7 +7,6 @@
 #include "extractor/edge_based_node.hpp"
 #include "extractor/external_memory_node.hpp"
 #include "extractor/guidance/turn_instruction.hpp"
-#include "extractor/guidance/turn_lane_types.hpp"
 #include "engine/phantom_node.hpp"
 #include "util/exception.hpp"
 #include "util/guidance/bearing_class.hpp"
@@ -139,11 +138,6 @@ class BaseDataFacade
                                                       const int bearing,
                                                       const int bearing_range) const = 0;
 
-    virtual bool hasLaneData(const EdgeID id) const = 0;
-    virtual util::guidance::LaneTupelIdPair GetLaneData(const EdgeID id) const = 0;
-    virtual extractor::guidance::TurnLaneDescription
-    GetTurnDescription(const LaneDescriptionID lane_description_id) const = 0;
-
     virtual unsigned GetCheckSum() const = 0;
 
     virtual bool IsCoreNode(const NodeID id) const = 0;

include/engine/datafacade/internal_datafacade.hpp

@@ -16,7 +16,6 @@
 #include "storage/storage_config.hpp"
 #include "engine/geospatial_query.hpp"
 #include "util/graph_loader.hpp"
-#include "util/guidance/turn_lanes.hpp"
 #include "util/io.hpp"
 #include "util/packed_vector.hpp"
 #include "util/range_table.hpp"
@@ -79,8 +78,6 @@ class InternalDataFacade final : public BaseDataFacade
     util::ShM<NodeID, false>::vector m_via_node_list;
     util::ShM<unsigned, false>::vector m_name_ID_list;
     util::ShM<extractor::guidance::TurnInstruction, false>::vector m_turn_instruction_list;
-    util::ShM<LaneDataID, false>::vector m_lane_data_id;
-    util::ShM<util::guidance::LaneTupelIdPair, false>::vector m_lane_tupel_id_pairs;
     util::ShM<extractor::TravelMode, false>::vector m_travel_mode_list;
     util::ShM<char, false>::vector m_names_char_list;
     util::ShM<unsigned, false>::vector m_geometry_indices;
@@ -89,8 +86,6 @@ class InternalDataFacade final : public BaseDataFacade
     util::ShM<unsigned, false>::vector m_segment_weights;
     util::ShM<uint8_t, false>::vector m_datasource_list;
     util::ShM<std::string, false>::vector m_datasource_names;
-    util::ShM<std::uint32_t, false>::vector m_lane_description_offsets;
-    util::ShM<extractor::guidance::TurnLaneType::Mask, false>::vector m_lane_description_masks;
     extractor::ProfileProperties m_profile_properties;
 
     std::unique_ptr<InternalRTree> m_static_rtree;
@@ -123,20 +118,6 @@ class InternalDataFacade final : public BaseDataFacade
                        sizeof(m_profile_properties));
     }
 
-    void LoadLaneTupelIdPairs(const boost::filesystem::path &lane_data_path)
-    {
-        boost::filesystem::ifstream in_stream(lane_data_path);
-        if (!in_stream)
-        {
-            throw util::exception("Could not open " + lane_data_path.string() + " for reading.");
-        }
-        std::uint64_t size;
-        in_stream.read(reinterpret_cast<char *>(&size), sizeof(size));
-        m_lane_tupel_id_pairs.resize(size);
-        in_stream.read(reinterpret_cast<char *>(&m_lane_tupel_id_pairs[0]),
-                       sizeof(m_lane_tupel_id_pairs) * size);
-    }
-
     void LoadTimestamp(const boost::filesystem::path &timestamp_path)
     {
         util::SimpleLogger().Write() << "Loading Timestamp";
@@ -192,7 +173,6 @@ class InternalDataFacade final : public BaseDataFacade
         m_via_node_list.resize(number_of_edges);
         m_name_ID_list.resize(number_of_edges);
         m_turn_instruction_list.resize(number_of_edges);
-        m_lane_data_id.resize(number_of_edges);
         m_travel_mode_list.resize(number_of_edges);
         m_entry_class_id_list.resize(number_of_edges);
 
@@ -204,7 +184,6 @@ class InternalDataFacade final : public BaseDataFacade
             m_via_node_list[i] = current_edge_data.via_node;
             m_name_ID_list[i] = current_edge_data.name_id;
             m_turn_instruction_list[i] = current_edge_data.turn_instruction;
-            m_lane_data_id[i] = current_edge_data.lane_data_id;
             m_travel_mode_list[i] = current_edge_data.travel_mode;
             m_entry_class_id_list[i] = current_edge_data.entry_classid;
         }
@@ -272,9 +251,9 @@ class InternalDataFacade final : public BaseDataFacade
         }
         BOOST_ASSERT(datasources_stream);
 
-        std::uint64_t number_of_datasources = 0;
+        std::size_t number_of_datasources = 0;
         datasources_stream.read(reinterpret_cast<char *>(&number_of_datasources),
-                                sizeof(number_of_datasources));
+                                sizeof(std::size_t));
         if (number_of_datasources > 0)
         {
             m_datasource_list.resize(number_of_datasources);
@@ -305,15 +284,6 @@ class InternalDataFacade final : public BaseDataFacade
             new InternalGeospatialQuery(*m_static_rtree, m_coordinate_list, *this));
     }
 
-    void LoadLaneDescriptions(const boost::filesystem::path &lane_description_file)
-    {
-        if (!util::deserializeAdjacencyArray(lane_description_file.string(),
-                                             m_lane_description_offsets,
-                                             m_lane_description_masks))
-            util::SimpleLogger().Write(logWARNING) << "Failed to read turn lane descriptions from "
-                                                   << lane_description_file.string();
-    }
-
     void LoadStreetNames(const boost::filesystem::path &names_file)
     {
         boost::filesystem::ifstream name_stream(names_file, std::ios::binary);
@@ -416,17 +386,11 @@ class InternalDataFacade final : public BaseDataFacade
         util::SimpleLogger().Write() << "loading street names";
         LoadStreetNames(config.names_data_path);
 
-        util::SimpleLogger().Write() << "loading lane tags";
-        LoadLaneDescriptions(config.turn_lane_description_path);
-
         util::SimpleLogger().Write() << "loading rtree";
         LoadRTree();
 
         util::SimpleLogger().Write() << "loading intersection class data";
         LoadIntersectionClasses(config.intersection_class_path);
-
-        util::SimpleLogger().Write() << "Loading Lane Data Pairs";
-        LoadLaneTupelIdPairs(config.turn_lane_data_path);
     }
 
     // search graph access
@@ -777,29 +741,6 @@ class InternalDataFacade final : public BaseDataFacade
     {
         return m_entry_class_table.at(entry_class_id);
     }
-
-    bool hasLaneData(const EdgeID id) const override final
-    {
-        return m_lane_data_id[id] != INVALID_LANE_DATAID;
-    }
-
-    util::guidance::LaneTupelIdPair GetLaneData(const EdgeID id) const override final
-    {
-        BOOST_ASSERT(hasLaneData(id));
-        return m_lane_tupel_id_pairs[m_lane_data_id[id]];
-    }
-
-    extractor::guidance::TurnLaneDescription
-    GetTurnDescription(const LaneDescriptionID lane_description_id) const override final
-    {
-        if (lane_description_id == INVALID_LANE_DESCRIPTIONID)
-            return {};
-        else
-            return extractor::guidance::TurnLaneDescription(
-                m_lane_description_masks.begin() + m_lane_description_offsets[lane_description_id],
-                m_lane_description_masks.begin() +
-                    m_lane_description_offsets[lane_description_id + 1]);
-    }
 };
 }
 }

include/engine/datafacade/shared_datafacade.hpp

@@ -9,11 +9,9 @@
 
 #include "extractor/compressed_edge_container.hpp"
 #include "extractor/guidance/turn_instruction.hpp"
-#include "extractor/guidance/turn_lane_types.hpp"
 #include "extractor/profile_properties.hpp"
 #include "util/guidance/bearing_class.hpp"
 #include "util/guidance/entry_class.hpp"
-#include "util/guidance/turn_lanes.hpp"
 
 #include "engine/geospatial_query.hpp"
 #include "util/make_unique.hpp"
@@ -81,7 +79,6 @@ class SharedDataFacade final : public BaseDataFacade
     util::PackedVector<OSMNodeID, true> m_osmnodeid_list;
     util::ShM<NodeID, true>::vector m_via_node_list;
     util::ShM<unsigned, true>::vector m_name_ID_list;
-    util::ShM<LaneDataID, true>::vector m_lane_data_id;
     util::ShM<extractor::guidance::TurnInstruction, true>::vector m_turn_instruction_list;
     util::ShM<extractor::TravelMode, true>::vector m_travel_mode_list;
     util::ShM<char, true>::vector m_names_char_list;
@@ -90,13 +87,10 @@ class SharedDataFacade final : public BaseDataFacade
     util::ShM<extractor::CompressedEdgeContainer::CompressedEdge, true>::vector m_geometry_list;
     util::ShM<bool, true>::vector m_is_core_node;
     util::ShM<uint8_t, true>::vector m_datasource_list;
-    util::ShM<std::uint32_t, true>::vector m_lane_description_offsets;
-    util::ShM<extractor::guidance::TurnLaneType::Mask, true>::vector m_lane_description_masks;
 
     util::ShM<char, true>::vector m_datasource_name_data;
     util::ShM<std::size_t, true>::vector m_datasource_name_offsets;
     util::ShM<std::size_t, true>::vector m_datasource_name_lengths;
-    util::ShM<util::guidance::LaneTupelIdPair, true>::vector m_lane_tupel_id_pairs;
 
     std::unique_ptr<SharedRTree> m_static_rtree;
     std::unique_ptr<SharedGeospatialQuery> m_geospatial_query;
@@ -183,8 +177,7 @@ class SharedDataFacade final : public BaseDataFacade
             osmnodeid_list_ptr,
             data_layout->num_entries[storage::SharedDataLayout::OSM_NODE_ID_LIST]);
         // We (ab)use the number of coordinates here because we know we have the same amount of ids
-        m_osmnodeid_list.set_number_of_entries(
-            data_layout->num_entries[storage::SharedDataLayout::COORDINATE_LIST]);
+        m_osmnodeid_list.set_number_of_entries(data_layout->num_entries[storage::SharedDataLayout::COORDINATE_LIST]);
 
         auto travel_mode_list_ptr = data_layout->GetBlockPtr<extractor::TravelMode>(
             shared_memory, storage::SharedDataLayout::TRAVEL_MODE);
@@ -192,19 +185,6 @@ class SharedDataFacade final : public BaseDataFacade
             travel_mode_list_ptr, data_layout->num_entries[storage::SharedDataLayout::TRAVEL_MODE]);
         m_travel_mode_list = std::move(travel_mode_list);
 
-        auto lane_data_id_ptr = data_layout->GetBlockPtr<LaneDataID>(
-            shared_memory, storage::SharedDataLayout::LANE_DATA_ID);
-        util::ShM<LaneDataID, true>::vector lane_data_id(
-            lane_data_id_ptr, data_layout->num_entries[storage::SharedDataLayout::LANE_DATA_ID]);
-        m_lane_data_id = std::move(lane_data_id);
-
-        auto lane_tupel_id_pair_ptr = data_layout->GetBlockPtr<util::guidance::LaneTupelIdPair>(
-            shared_memory, storage::SharedDataLayout::TURN_LANE_DATA);
-        util::ShM<util::guidance::LaneTupelIdPair, true>::vector lane_tupel_id_pair(
-            lane_tupel_id_pair_ptr,
-            data_layout->num_entries[storage::SharedDataLayout::TURN_LANE_DATA]);
-        m_lane_tupel_id_pairs = std::move(lane_tupel_id_pair);
-
         auto turn_instruction_list_ptr =
             data_layout->GetBlockPtr<extractor::guidance::TurnInstruction>(
                 shared_memory, storage::SharedDataLayout::TURN_INSTRUCTION);
@@ -257,23 +237,6 @@ class SharedDataFacade final : public BaseDataFacade
         m_names_char_list = std::move(names_char_list);
     }
 
-    void LoadTurnLaneDescriptions()
-    {
-        auto offsets_ptr = data_layout->GetBlockPtr<std::uint32_t>(
-            shared_memory, storage::SharedDataLayout::LANE_DESCRIPTION_OFFSETS);
-        util::ShM<std::uint32_t, true>::vector offsets(
-            offsets_ptr,
-            data_layout->num_entries[storage::SharedDataLayout::LANE_DESCRIPTION_OFFSETS]);
-        m_lane_description_offsets = std::move(offsets);
-
-        auto masks_ptr = data_layout->GetBlockPtr<extractor::guidance::TurnLaneType::Mask>(
-            shared_memory, storage::SharedDataLayout::LANE_DESCRIPTION_MASKS);
-
-        util::ShM<extractor::guidance::TurnLaneType::Mask, true>::vector masks(
-            masks_ptr, data_layout->num_entries[storage::SharedDataLayout::LANE_DESCRIPTION_MASKS]);
-        m_lane_description_masks = std::move(masks);
-    }
-
     void LoadCoreInformation()
     {
         if (data_layout->num_entries[storage::SharedDataLayout::CORE_MARKER] <= 0)
@@ -452,7 +415,6 @@ class SharedDataFacade final : public BaseDataFacade
                 LoadTimestamp();
                 LoadViaNodeList();
                 LoadNames();
-                LoadTurnLaneDescriptions();
                 LoadCoreInformation();
                 LoadProfileProperties();
                 LoadRTree();
@@ -820,28 +782,6 @@ class SharedDataFacade final : public BaseDataFacade
     {
         return m_entry_class_table.at(entry_class_id);
     }
-
-    bool hasLaneData(const EdgeID id) const override final
-    {
-        return INVALID_LANE_DATAID != m_lane_data_id.at(id);
-    }
-
-    util::guidance::LaneTupelIdPair GetLaneData(const EdgeID id) const override final
-    {
-        BOOST_ASSERT(hasLaneData(id));
-        return m_lane_tupel_id_pairs.at(m_lane_data_id.at(id));
-    }
-
-    extractor::guidance::TurnLaneDescription
-    GetTurnDescription(const LaneDescriptionID lane_description_id) const override final
-    {
-        if (lane_description_id == INVALID_LANE_DESCRIPTIONID)
-            return {};
-        else
-            return extractor::guidance::TurnLaneDescription(
-                m_lane_description_masks.begin() + m_lane_description_offsets[lane_description_id],
-                m_lane_description_masks.begin() + m_lane_description_offsets[lane_description_id + 1]);
-    }
 };
 }
 }

include/engine/guidance/assemble_geometry.hpp

@@ -3,7 +3,6 @@
 
 #include "extractor/guidance/turn_instruction.hpp"
 #include "extractor/travel_mode.hpp"
-#include "engine/datafacade/datafacade_base.hpp"
 #include "engine/guidance/leg_geometry.hpp"
 #include "engine/guidance/route_step.hpp"
 #include "engine/guidance/toolkit.hpp"
@@ -32,10 +31,11 @@ namespace guidance
 //             |---| segment 1
 //                 |---| segment 2
 //                     |---| segment 3
-inline LegGeometry assembleGeometry(const datafacade::BaseDataFacade &facade,
-                                    const std::vector<PathData> &leg_data,
-                                    const PhantomNode &source_node,
-                                    const PhantomNode &target_node)
+template <typename DataFacadeT>
+LegGeometry assembleGeometry(const DataFacadeT &facade,
+                             const std::vector<PathData> &leg_data,
+                             const PhantomNode &source_node,
+                             const PhantomNode &target_node)
 {
     LegGeometry geometry;
 

include/engine/guidance/assemble_steps.hpp

@@ -2,9 +2,7 @@
 #define ENGINE_GUIDANCE_ASSEMBLE_STEPS_HPP_
 
 #include "extractor/guidance/turn_instruction.hpp"
-#include "extractor/guidance/turn_lane_types.hpp"
 #include "extractor/travel_mode.hpp"
-#include "engine/datafacade/datafacade_base.hpp"
 #include "engine/guidance/leg_geometry.hpp"
 #include "engine/guidance/route_step.hpp"
 #include "engine/guidance/step_maneuver.hpp"
@@ -16,7 +14,6 @@
 #include "util/coordinate_calculation.hpp"
 #include "util/guidance/entry_class.hpp"
 #include "util/guidance/toolkit.hpp"
-#include "util/guidance/turn_lanes.hpp"
 #include "util/typedefs.hpp"
 
 #include <boost/optional.hpp>
@@ -37,13 +34,14 @@ std::pair<short, short> getIntermediateBearings(const LegGeometry &leg_geometry,
                                                 const std::size_t segment_index);
 } // ns detail
 
-inline std::vector<RouteStep> assembleSteps(const datafacade::BaseDataFacade &facade,
-                                            const std::vector<PathData> &leg_data,
-                                            const LegGeometry &leg_geometry,
-                                            const PhantomNode &source_node,
-                                            const PhantomNode &target_node,
-                                            const bool source_traversed_in_reverse,
-                                            const bool target_traversed_in_reverse)
+template <typename DataFacadeT>
+std::vector<RouteStep> assembleSteps(const DataFacadeT &facade,
+                                     const std::vector<PathData> &leg_data,
+                                     const LegGeometry &leg_geometry,
+                                     const PhantomNode &source_node,
+                                     const PhantomNode &target_node,
+                                     const bool source_traversed_in_reverse,
+                                     const bool target_traversed_in_reverse)
 {
     const double constexpr ZERO_DURATION = 0., ZERO_DISTANCE = 0.;
     const constexpr char *NO_ROTARY_NAME = "";
@@ -73,14 +71,11 @@ inline std::vector<RouteStep> assembleSteps(const datafacade::BaseDataFacade &fa
                           extractor::guidance::TurnInstruction::NO_TURN(),
                           WaypointType::Depart,
                           0};
-
     Intersection intersection{source_node.location,
                               std::vector<short>({bearings.second}),
                               std::vector<bool>({true}),
                               Intersection::NO_INDEX,
-                              0,
-                              util::guidance::LaneTupel(),
-                              {}};
+                              0};
 
     if (leg_data.size() > 0)
     {
@@ -139,11 +134,6 @@ inline std::vector<RouteStep> assembleSteps(const datafacade::BaseDataFacade &fa
                 intersection.location = facade.GetCoordinateOfNode(path_point.turn_via_node);
                 intersection.bearings.clear();
                 intersection.bearings.reserve(bearing_class.getAvailableBearings().size());
-                intersection.lanes = path_point.lane_data.first;
-                intersection.lane_description =
-                    path_point.lane_data.second != INVALID_LANE_DESCRIPTIONID
-                        ? facade.GetTurnDescription(path_point.lane_data.second)
-                        : extractor::guidance::TurnLaneDescription();
                 std::copy(bearing_class.getAvailableBearings().begin(),
                           bearing_class.getAvailableBearings().end(),
                           std::back_inserter(intersection.bearings));
@@ -213,15 +203,12 @@ inline std::vector<RouteStep> assembleSteps(const datafacade::BaseDataFacade &fa
                 extractor::guidance::TurnInstruction::NO_TURN(),
                 WaypointType::Arrive,
                 0};
-
     intersection = {
         target_node.location,
         std::vector<short>({static_cast<short>(util::bearing::reverseBearing(bearings.first))}),
         std::vector<bool>({true}),
         0,
-        Intersection::NO_INDEX,
-        util::guidance::LaneTupel(),
-        {}};
+        Intersection::NO_INDEX};
 
     BOOST_ASSERT(!leg_geometry.locations.empty());
     steps.push_back(RouteStep{target_node.name_id,
@@ -246,9 +233,6 @@ inline std::vector<RouteStep> assembleSteps(const datafacade::BaseDataFacade &fa
     BOOST_ASSERT(steps.back().intersections.front().bearings.size() == 1);
     BOOST_ASSERT(steps.back().intersections.front().entry.size() == 1);
     BOOST_ASSERT(steps.back().maneuver.waypoint_type == WaypointType::Arrive);
-    BOOST_ASSERT(steps.back().intersections.front().lanes.lanes_in_turn == 0);
-    BOOST_ASSERT(steps.back().intersections.front().lanes.first_lane_from_the_right == INVALID_LANEID);
-    BOOST_ASSERT(steps.back().intersections.front().lane_description.empty());
     return steps;
 }
 

include/engine/guidance/lane_processing.hpp

@@ -1,27 +0,0 @@
-#ifndef OSRM_ENGINE_GUIDANCE_LANE_PROCESSING_HPP_
-#define OSRM_ENGINE_GUIDANCE_LANE_PROCESSING_HPP_
-
-#include <vector>
-
-#include "engine/guidance/route_step.hpp"
-
-namespace osrm
-{
-namespace engine
-{
-namespace guidance
-{
-
-// Constrains lanes for multi-hop situations where lane changes depend on earlier ones.
-// Instead of forcing users to change lanes rapidly in a short amount of time,
-// we anticipate lane changes emitting only matching lanes early on.
-// the second parameter describes the duration that we feel two segments need to be apart to count
-// as separate maneuvers.
-std::vector<RouteStep> anticipateLaneChange(std::vector<RouteStep> steps,
-                                            const double min_duration_needed_for_lane_change = 15);
-
-} // namespace guidance
-} // namespace engine
-} // namespace osrm
-
-#endif /* OSRM_ENGINE_GUIDANCE_LANE_PROCESSING_HPP_ */

include/engine/guidance/post_processing.hpp

@@ -43,15 +43,6 @@ std::vector<RouteStep> buildIntersections(std::vector<RouteStep> steps);
 // remove steps invalidated by post-processing
 std::vector<RouteStep> removeNoTurnInstructions(std::vector<RouteStep> steps);
 
-// remove use lane information that is not actually a turn. For post-processing, we need to
-// associate lanes with every turn. Some of these use-lane instructions are not required after lane
-// anticipation anymore. This function removes all use lane instructions that are not actually used
-// anymore since all lanes going straight are used anyhow.
-// FIXME this is currently only a heuristic. We need knowledge on which lanes actually might become
-// turn lanes. If a straight lane becomes a turn lane, this might be something to consider. Right
-// now we bet on lane-anticipation to catch this.
-std::vector<RouteStep> collapseUseLane(std::vector<RouteStep> steps);
-
 // postProcess will break the connection between the leg geometry
 // for which a segment is supposed to represent exactly the coordinates
 // between routing maneuvers and the route steps itself.

include/engine/guidance/route_step.hpp

@@ -7,9 +7,6 @@
 #include "util/guidance/bearing_class.hpp"
 #include "util/guidance/entry_class.hpp"
 
-#include "extractor/guidance/turn_lane_types.hpp"
-#include "util/guidance/turn_lanes.hpp"
-
 #include <cstddef>
 
 #include <string>
@@ -37,10 +34,6 @@ struct Intersection
     std::vector<bool> entry;
     std::size_t in;
     std::size_t out;
-
-    // turn lane information
-    util::guidance::LaneTupel lanes;
-    extractor::guidance::TurnLaneDescription lane_description;
 };
 
 inline Intersection getInvalidIntersection()
@@ -49,9 +42,7 @@ inline Intersection getInvalidIntersection()
             {},
             {},
             Intersection::NO_INDEX,
-            Intersection::NO_INDEX,
-            util::guidance::LaneTupel(),
-            {}};
+            Intersection::NO_INDEX};
 }
 
 struct RouteStep

include/engine/guidance/step_maneuver.hpp

@@ -5,7 +5,6 @@
 #include "util/coordinate.hpp"
 
 #include <cstdint>
-#include <string>
 #include <vector>
 
 namespace osrm
@@ -28,7 +27,6 @@ struct StepManeuver
     short bearing_before;
     short bearing_after;
     extractor::guidance::TurnInstruction instruction;
-
     WaypointType waypoint_type;
     unsigned exit;
 };

include/engine/guidance/toolkit.hpp

@@ -2,13 +2,9 @@
 #define OSRM_ENGINE_GUIDANCE_TOOLKIT_HPP_
 
 #include "extractor/guidance/turn_instruction.hpp"
-#include "engine/guidance/route_step.hpp"
 #include "util/bearing.hpp"
-#include "util/guidance/toolkit.hpp"
 
 #include <algorithm>
-#include <iterator>
-#include <utility>
 
 namespace osrm
 {
@@ -17,10 +13,6 @@ namespace engine
 namespace guidance
 {
 
-using util::guidance::entersRoundabout;
-using util::guidance::leavesRoundabout;
-using util::guidance::staysOnRoundabout;
-
 // Silent Turn Instructions are not to be mentioned to the outside world but
 inline bool isSilent(const extractor::guidance::TurnInstruction instruction)
 {
@@ -29,6 +21,34 @@ inline bool isSilent(const extractor::guidance::TurnInstruction instruction)
            instruction.type == extractor::guidance::TurnType::StayOnRoundabout;
 }
 
+inline bool entersRoundabout(const extractor::guidance::TurnInstruction instruction)
+{
+    return (instruction.type == extractor::guidance::TurnType::EnterRoundabout ||
+            instruction.type == extractor::guidance::TurnType::EnterRotary ||
+            instruction.type == extractor::guidance::TurnType::EnterRoundaboutIntersection ||
+            instruction.type == extractor::guidance::TurnType::EnterRoundaboutAtExit ||
+            instruction.type == extractor::guidance::TurnType::EnterRotaryAtExit ||
+            instruction.type == extractor::guidance::TurnType::EnterRoundaboutIntersectionAtExit ||
+            instruction.type == extractor::guidance::TurnType::EnterAndExitRoundabout ||
+            instruction.type == extractor::guidance::TurnType::EnterAndExitRotary ||
+            instruction.type == extractor::guidance::TurnType::EnterAndExitRotary);
+}
+
+inline bool leavesRoundabout(const extractor::guidance::TurnInstruction instruction)
+{
+    return (instruction.type == extractor::guidance::TurnType::ExitRoundabout ||
+            instruction.type == extractor::guidance::TurnType::ExitRotary ||
+            instruction.type == extractor::guidance::TurnType::ExitRoundaboutIntersection ||
+            instruction.type == extractor::guidance::TurnType::EnterAndExitRoundabout ||
+            instruction.type == extractor::guidance::TurnType::EnterAndExitRotary ||
+            instruction.type == extractor::guidance::TurnType::EnterAndExitRoundaboutIntersection);
+}
+
+inline bool staysOnRoundabout(const extractor::guidance::TurnInstruction instruction)
+{
+    return instruction.type == extractor::guidance::TurnType::StayOnRoundabout;
+}
+
 inline extractor::guidance::DirectionModifier::Enum angleToDirectionModifier(const double bearing)
 {
     if (bearing < 135)
@@ -43,36 +63,10 @@ inline extractor::guidance::DirectionModifier::Enum angleToDirectionModifier(con
     return extractor::guidance::DirectionModifier::Left;
 }
 
-// Runs fn on RouteStep sub-ranges determined to be roundabouts.
-// The function fn is getting called with a roundabout range as in: [enter, .., leave].
-//
-// The following situations are taken care for (i.e. we discard them):
-//  - partial roundabout: enter without exit or exit without enter
-//  - data issues: no roundabout, exit before enter
-template <typename Iter, typename Fn> inline Fn forEachRoundabout(Iter first, Iter last, Fn fn)
+inline double angularDeviation(const double angle, const double from)
 {
-    while (first != last)
-    {
-        const auto enter = std::find_if(first, last, [](const RouteStep &step) {
-            return entersRoundabout(step.maneuver.instruction);
-        });
-
-        // enter has to come before leave, otherwise: faulty data / partial roundabout, skip those
-        const auto leave = std::find_if(enter, last, [](const RouteStep &step) {
-            return leavesRoundabout(step.maneuver.instruction);
-        });
-
-        // No roundabouts, or partial one (like start / end inside a roundabout)
-        if (enter == last || leave == last)
-            break;
-
-        (void)fn(std::make_pair(enter, leave));
-
-        // Skip to first step after the currently handled enter / leave pair
-        first = std::next(leave);
-    }
-
-    return fn;
+    const double deviation = std::abs(angle - from);
+    return std::min(360 - deviation, deviation);
 }
 
 } // namespace guidance

include/engine/internal_route_result.hpp

@@ -4,10 +4,10 @@
 #include "extractor/guidance/turn_instruction.hpp"
 #include "extractor/travel_mode.hpp"
 #include "engine/phantom_node.hpp"
-#include "osrm/coordinate.hpp"
-#include "util/guidance/turn_lanes.hpp"
 #include "util/typedefs.hpp"
 
+#include "osrm/coordinate.hpp"
+
 #include <vector>
 
 namespace osrm
@@ -27,8 +27,6 @@ struct PathData
     EdgeWeight duration_until_turn;
     // instruction to execute at the turn
     extractor::guidance::TurnInstruction turn_instruction;
-    // turn lane data
-    util::guidance::LaneTupelIdPair lane_data;
     // travel mode of the street that leads to the turn
     extractor::TravelMode travel_mode : 4;
     // entry class of the turn, indicating possibility of turns

include/engine/routing_algorithms/alternative_path.hpp

@@ -546,8 +546,8 @@ class AlternativeRouting final
             }
         }
 
-        via_path_index = static_cast<int64_t>(partially_unpacked_via_path.size()) - 1;
-        shortest_path_index = static_cast<int64_t>(partially_unpacked_shortest_path.size()) - 1;
+        via_path_index = partially_unpacked_via_path.size() - 1;
+        shortest_path_index = partially_unpacked_shortest_path.size() - 1;
         for (; via_path_index > 0 && shortest_path_index > 0;
              --via_path_index, --shortest_path_index)
         {

include/engine/routing_algorithms/routing_base.hpp

@@ -327,14 +327,10 @@ template <class DataFacadeT, class Derived> class BasicRoutingInterface
                                  name_index,
                                  weight_vector[i],
                                  extractor::guidance::TurnInstruction::NO_TURN(),
-                                 {{0, INVALID_LANEID}, INVALID_LANE_DESCRIPTIONID},
                                  travel_mode,
                                  INVALID_ENTRY_CLASSID});
                 }
                 BOOST_ASSERT(unpacked_path.size() > 0);
-                if (facade->hasLaneData(ed.id))
-                    unpacked_path.back().lane_data = facade->GetLaneData(ed.id);
-
                 unpacked_path.back().entry_classid = facade->GetEntryClassID(ed.id);
                 unpacked_path.back().turn_instruction = turn_instruction;
                 unpacked_path.back().duration_until_turn += (ed.distance - total_weight);
@@ -393,7 +389,6 @@ template <class DataFacadeT, class Derived> class BasicRoutingInterface
                 phantom_node_pair.target_phantom.name_id,
                 weight_vector[i],
                 extractor::guidance::TurnInstruction::NO_TURN(),
-                {{0, INVALID_LANEID}, INVALID_LANE_DESCRIPTIONID},
                 target_traversed_in_reverse ? phantom_node_pair.target_phantom.backward_travel_mode
                                             : phantom_node_pair.target_phantom.forward_travel_mode,
                 INVALID_ENTRY_CLASSID});

include/extractor/edge_based_graph_factory.hpp

@@ -13,7 +13,6 @@
 
 #include "extractor/guidance/turn_analysis.hpp"
 #include "extractor/guidance/turn_instruction.hpp"
-#include "extractor/guidance/turn_lane_types.hpp"
 #include "util/guidance/bearing_class.hpp"
 #include "util/guidance/entry_class.hpp"
 
@@ -43,60 +42,22 @@ namespace osrm
 namespace extractor
 {
 
-namespace lookup
-{
-// Set to 1 byte alignment
-#pragma pack(push, 1)
-struct SegmentHeaderBlock
-{
-    std::uint32_t num_osm_nodes;
-    OSMNodeID previous_osm_node_id;
-};
-#pragma pack(pop)
-static_assert(sizeof(SegmentHeaderBlock) == 12, "SegmentHeaderBlock is not packed correctly");
-
-#pragma pack(push, 1)
-struct SegmentBlock
-{
-    OSMNodeID this_osm_node_id;
-    double segment_length;
-    std::int32_t segment_weight;
-};
-#pragma pack(pop)
-static_assert(sizeof(SegmentBlock) == 20, "SegmentBlock is not packed correctly");
-
-#pragma pack(push, 1)
-struct PenaltyBlock
-{
-    std::uint32_t fixed_penalty;
-    OSMNodeID from_id;
-    OSMNodeID via_id;
-    OSMNodeID to_id;
-};
-#pragma pack(pop)
-static_assert(sizeof(PenaltyBlock) == 28, "PenaltyBlock is not packed correctly");
-}
-
 class EdgeBasedGraphFactory
 {
   public:
     EdgeBasedGraphFactory(const EdgeBasedGraphFactory &) = delete;
     EdgeBasedGraphFactory &operator=(const EdgeBasedGraphFactory &) = delete;
 
-    explicit EdgeBasedGraphFactory(
-        std::shared_ptr<util::NodeBasedDynamicGraph> node_based_graph,
-        const CompressedEdgeContainer &compressed_edge_container,
-        const std::unordered_set<NodeID> &barrier_nodes,
-        const std::unordered_set<NodeID> &traffic_lights,
-        std::shared_ptr<const RestrictionMap> restriction_map,
-        const std::vector<QueryNode> &node_info_list,
-        ProfileProperties profile_properties,
-        const util::NameTable &name_table,
-        const std::vector<std::uint32_t> &turn_lane_offsets,
-        const std::vector<guidance::TurnLaneType::Mask> &turn_lane_masks);
+    explicit EdgeBasedGraphFactory(std::shared_ptr<util::NodeBasedDynamicGraph> node_based_graph,
+                                   const CompressedEdgeContainer &compressed_edge_container,
+                                   const std::unordered_set<NodeID> &barrier_nodes,
+                                   const std::unordered_set<NodeID> &traffic_lights,
+                                   std::shared_ptr<const RestrictionMap> restriction_map,
+                                   const std::vector<QueryNode> &node_info_list,
+                                   ProfileProperties profile_properties,
+                                   const util::NameTable &name_table);
 
     void Run(const std::string &original_edge_data_filename,
-             const std::string &turn_lane_data_filename,
              lua_State *lua_state,
              const std::string &edge_segment_lookup_filename,
              const std::string &edge_penalty_filename,
@@ -143,7 +104,7 @@ class EdgeBasedGraphFactory
     //! list of edge based nodes (compressed segments)
     std::vector<EdgeBasedNode> m_edge_based_node_list;
     util::DeallocatingVector<EdgeBasedEdge> m_edge_based_edge_list;
-    EdgeID m_max_edge_id;
+    unsigned m_max_edge_id;
 
     const std::vector<QueryNode> &m_node_info_list;
     std::shared_ptr<util::NodeBasedDynamicGraph> m_node_based_graph;
@@ -156,14 +117,11 @@ class EdgeBasedGraphFactory
     ProfileProperties profile_properties;
 
     const util::NameTable &name_table;
-    const std::vector<std::uint32_t> &turn_lane_offsets;
-    const std::vector<guidance::TurnLaneType::Mask> &turn_lane_masks;
 
     void CompressGeometry();
     unsigned RenumberEdges();
     void GenerateEdgeExpandedNodes();
     void GenerateEdgeExpandedEdges(const std::string &original_edge_data_filename,
-                                   const std::string &turn_lane_data_filename,
                                    lua_State *lua_state,
                                    const std::string &edge_segment_lookup_filename,
                                    const std::string &edge_fixed_penalties_filename,

include/extractor/external_memory_node.hpp

@@ -5,8 +5,6 @@
 
 #include "util/typedefs.hpp"
 
-#include <cstdint>
-
 namespace osrm
 {
 namespace extractor
@@ -28,13 +26,13 @@ struct ExternalMemoryNode : QueryNode
     static ExternalMemoryNode min_value()
     {
         return ExternalMemoryNode(
-            util::FixedLongitude{0}, util::FixedLatitude{0}, MIN_OSM_NODEID, false, false);
+            util::FixedLongitude(0), util::FixedLatitude(0), MIN_OSM_NODEID, false, false);
     }
 
     static ExternalMemoryNode max_value()
     {
-        return ExternalMemoryNode(util::FixedLongitude{std::numeric_limits<std::int32_t>::max()},
-                                  util::FixedLatitude{std::numeric_limits<std::int32_t>::max()},
+        return ExternalMemoryNode(util::FixedLongitude(std::numeric_limits<int>::max()),
+                                  util::FixedLatitude(std::numeric_limits<int>::max()),
                                   MAX_OSM_NODEID,
                                   false,
                                   false);

include/extractor/extraction_containers.hpp

@@ -3,12 +3,10 @@
 
 #include "extractor/external_memory_node.hpp"
 #include "extractor/first_and_last_segment_of_way.hpp"
-#include "extractor/guidance/turn_lane_types.hpp"
 #include "extractor/internal_extractor_edge.hpp"
 #include "extractor/restriction.hpp"
 #include "extractor/scripting_environment.hpp"
 
-#include <cstdint>
 #include <stxxl/vector>
 #include <unordered_map>
 
@@ -39,11 +37,7 @@ class ExtractionContainers
     void WriteNodes(std::ofstream &file_out_stream) const;
     void WriteRestrictions(const std::string &restrictions_file_name) const;
     void WriteEdges(std::ofstream &file_out_stream) const;
-    void WriteCharData(const std::string &file_name);
-    void
-    WriteTurnLaneMasks(const std::string &file_name,
-                       const stxxl::vector<std::uint32_t> &turn_lane_offsets,
-                       const stxxl::vector<guidance::TurnLaneType::Mask> &turn_lane_masks) const;
+    void WriteNames(const std::string &names_file_name) const;
 
   public:
     using STXXLNodeIDVector = stxxl::vector<OSMNodeID>;
@@ -51,17 +45,12 @@ class ExtractionContainers
     using STXXLEdgeVector = stxxl::vector<InternalExtractorEdge>;
     using STXXLRestrictionsVector = stxxl::vector<InputRestrictionContainer>;
     using STXXLWayIDStartEndVector = stxxl::vector<FirstAndLastSegmentOfWay>;
-    using STXXLNameCharData = stxxl::vector<unsigned char>;
-    using STXXLNameOffsets = stxxl::vector<unsigned>;
 
     STXXLNodeIDVector used_node_id_list;
     STXXLNodeVector all_nodes_list;
     STXXLEdgeVector all_edges_list;
-    STXXLNameCharData name_char_data;
-    STXXLNameOffsets name_offsets;
-    // an adjacency array containing all turn lane masks
-    stxxl::vector<std::uint32_t> turn_lane_offsets;
-    stxxl::vector<guidance::TurnLaneType::Mask> turn_lane_masks;
+    stxxl::vector<char> name_char_data;
+    stxxl::vector<unsigned> name_lengths;
     STXXLRestrictionsVector restrictions_list;
     STXXLWayIDStartEndVector way_start_end_id_list;
     std::unordered_map<OSMNodeID, NodeID> external_to_internal_node_id_map;
@@ -72,7 +61,6 @@ class ExtractionContainers
     void PrepareData(const std::string &output_file_name,
                      const std::string &restrictions_file_name,
                      const std::string &names_file_name,
-                     const std::string &turn_lane_file_name,
                      lua_State *segment_state);
 };
 }

include/extractor/extraction_helper_functions.hpp

@@ -7,8 +7,6 @@
 #include <limits>
 #include <string>
 
-#include "extractor/guidance/toolkit.hpp"
-
 namespace osrm
 {
 namespace extractor
@@ -100,12 +98,6 @@ inline unsigned parseDuration(const std::string &s)
 
     return !s.empty() && iter == s.end() ? duration : std::numeric_limits<unsigned>::max();
 }
-
-inline std::string
-trimLaneString(std::string lane_string, std::int32_t count_left, std::int32_t count_right)
-{
-    return extractor::guidance::trimLaneString(std::move(lane_string), count_left, count_right);
-}
 }
 }
 

include/extractor/extraction_way.hpp

@@ -2,7 +2,6 @@
 #define EXTRACTION_WAY_HPP
 
 #include "extractor/travel_mode.hpp"
-#include "util/guidance/turn_lanes.hpp"
 #include "util/typedefs.hpp"
 
 #include <string>
@@ -36,8 +35,6 @@ struct ExtractionWay
         destinations.clear();
         forward_travel_mode = TRAVEL_MODE_INACCESSIBLE;
         backward_travel_mode = TRAVEL_MODE_INACCESSIBLE;
-        turn_lanes_forward.clear();
-        turn_lanes_backward.clear();
     }
 
     // These accessors exists because it's not possible to take the address of a bitfield,
@@ -53,8 +50,6 @@ struct ExtractionWay
     std::string name;
     std::string pronunciation;
     std::string destinations;
-    std::string turn_lanes_forward;
-    std::string turn_lanes_backward;
     bool roundabout;
     bool is_access_restricted;
     bool is_startpoint;

include/extractor/extractor.hpp

@@ -54,7 +54,7 @@ class Extractor
   private:
     ExtractorConfig config;
 
-    std::pair<std::size_t, EdgeID>
+    std::pair<std::size_t, std::size_t>
     BuildEdgeExpandedGraph(lua_State *lua_state,
                            const ProfileProperties &profile_properties,
                            std::vector<QueryNode> &internal_to_external_node_map,
@@ -79,7 +79,7 @@ class Extractor
                        std::vector<QueryNode> &internal_to_external_node_map);
 
     void WriteEdgeBasedGraph(const std::string &output_file_filename,
-                             const EdgeID max_edge_id,
+                             const size_t max_edge_id,
                              util::DeallocatingVector<EdgeBasedEdge> const &edge_based_edge_list);
 
     void WriteIntersectionClassificationData(

include/extractor/extractor_callbacks.hpp

@@ -2,8 +2,6 @@
 #define EXTRACTOR_CALLBACKS_HPP
 
 #include "util/typedefs.hpp"
-#include "extractor/guidance/turn_lane_types.hpp"
-
 #include <boost/functional/hash.hpp>
 #include <boost/optional/optional_fwd.hpp>
 
@@ -40,7 +38,6 @@ class ExtractorCallbacks
     using MapKey = std::pair<std::string, std::string>;
     using MapVal = unsigned;
     std::unordered_map<MapKey, MapVal, boost::hash<MapKey>> string_map;
-    std::unordered_map<guidance::TurnLaneDescription,LaneDescriptionID,guidance::TurnLaneDescription_hash> lane_description_map;
     ExtractionContainers &external_memory;
 
   public:

include/extractor/extractor_config.hpp

@@ -61,8 +61,6 @@ struct ExtractorConfig
         output_file_name = basepath + ".osrm";
         restriction_file_name = basepath + ".osrm.restrictions";
         names_file_name = basepath + ".osrm.names";
-        turn_lane_descriptions_file_name = basepath + ".osrm.tls";
-        turn_lane_data_file_name = basepath + ".osrm.tld";
         timestamp_file_name = basepath + ".osrm.timestamp";
         geometry_output_path = basepath + ".osrm.geometry";
         node_output_path = basepath + ".osrm.nodes";
@@ -84,8 +82,6 @@ struct ExtractorConfig
     std::string output_file_name;
     std::string restriction_file_name;
     std::string names_file_name;
-    std::string turn_lane_data_file_name;
-    std::string turn_lane_descriptions_file_name;
     std::string timestamp_file_name;
     std::string geometry_output_path;
     std::string edge_output_path;

include/extractor/guidance/classification_data.hpp

@@ -58,12 +58,6 @@ inline bool isLinkClass(const FunctionalRoadClass road_class)
            road_class == FunctionalRoadClass::TERTIARY_LINK;
 }
 
-// check wheter a class is a motorway like class
-inline bool isMotorwayClass(const FunctionalRoadClass road_class)
-{
-    return road_class == FunctionalRoadClass::MOTORWAY || road_class == FunctionalRoadClass::TRUNK;
-}
-
 // TODO augment this with all data required for guidance generation
 struct RoadClassificationData
 {

include/extractor/guidance/intersection.hpp

@@ -22,7 +22,6 @@ struct TurnOperation final
     EdgeID eid;
     double angle;
     TurnInstruction instruction;
-    LaneDataID lane_data_id;
 };
 
 // A Connected Road is the internal representation of a potential turn. Internally, we require
@@ -60,9 +59,6 @@ std::string toString(const ConnectedRoad &road);
 
 typedef std::vector<ConnectedRoad> Intersection;
 
-Intersection::const_iterator findClosestTurn(const Intersection &intersection, const double angle);
-Intersection::iterator findClosestTurn(Intersection &intersection, const double angle);
-
 } // namespace guidance
 } // namespace extractor
 } // namespace osrm

include/extractor/guidance/intersection_generator.hpp

@@ -5,7 +5,6 @@
 #include "extractor/guidance/intersection.hpp"
 #include "extractor/query_node.hpp"
 #include "extractor/restriction_map.hpp"
-#include "util/name_table.hpp"
 #include "util/node_based_graph.hpp"
 #include "util/typedefs.hpp"
 

include/extractor/guidance/motorway_handler.hpp

@@ -2,6 +2,7 @@
 #define OSRM_EXTRACTOR_GUIDANCE_MOTORWAY_HANDLER_HPP_
 
 #include "extractor/guidance/intersection.hpp"
+#include "extractor/guidance/intersection_generator.hpp"
 #include "extractor/guidance/intersection_handler.hpp"
 #include "extractor/query_node.hpp"
 
@@ -25,7 +26,8 @@ class MotorwayHandler : public IntersectionHandler
     MotorwayHandler(const util::NodeBasedDynamicGraph &node_based_graph,
                     const std::vector<QueryNode> &node_info_list,
                     const util::NameTable &name_table,
-                    const SuffixTable &street_name_suffix_table);
+                    const SuffixTable &street_name_suffix_table,
+                    const IntersectionGenerator &intersection_generator);
     ~MotorwayHandler() override final;
 
     // check whether the handler can actually handle the intersection
@@ -45,6 +47,8 @@ class MotorwayHandler : public IntersectionHandler
     Intersection fromRamp(const EdgeID via_edge, Intersection intersection) const;
 
     Intersection fallback(Intersection intersection) const;
+
+    const IntersectionGenerator &intersection_generator;
 };
 
 } // namespace guidance

include/extractor/guidance/toolkit.hpp

@@ -5,8 +5,6 @@
 #include "util/coordinate.hpp"
 #include "util/coordinate_calculation.hpp"
 #include "util/guidance/toolkit.hpp"
-#include "util/guidance/turn_lanes.hpp"
-#include "util/typedefs.hpp"
 
 #include "extractor/compressed_edge_container.hpp"
 #include "extractor/query_node.hpp"
@@ -22,12 +20,10 @@
 #include <cstdint>
 #include <map>
 #include <string>
-#include <unordered_map>
 #include <utility>
 
 #include <boost/algorithm/string.hpp>
 #include <boost/algorithm/string/predicate.hpp>
-#include <boost/functional/hash.hpp>
 
 namespace osrm
 {
@@ -36,12 +32,7 @@ namespace extractor
 namespace guidance
 {
 
-using util::guidance::LaneTupelIdPair;
-using LaneDataIdMap = std::unordered_map<LaneTupelIdPair, LaneDataID, boost::hash<LaneTupelIdPair>>;
-
 using util::guidance::angularDeviation;
-using util::guidance::entersRoundabout;
-using util::guidance::leavesRoundabout;
 
 namespace detail
 {
@@ -483,55 +474,7 @@ inline bool hasRoundaboutType(const TurnInstruction instruction)
                                                     TurnType::StayOnRoundabout};
     const auto valid_end = valid_types + 13;
     return std::find(valid_types, valid_end, instruction.type) != valid_end;
-}
-
-// Public service vehicle lanes and similar can introduce additional lanes into the lane string that
-// are not specifically marked for left/right turns. This function can be used from the profile to
-// trim the lane string appropriately
-//
-// left|throught|
-// in combination with lanes:psv:forward=1
-// will be corrected to left|throught, since the final lane is not drivable.
-// This is in contrast to a situation with lanes:psv:forward=0 (or not set) where left|through|
-// represents left|through|through
-inline std::string
-trimLaneString(std::string lane_string, std::int32_t count_left, std::int32_t count_right)
-{
-    if (count_left)
-    {
-        bool sane = count_left < static_cast<std::int32_t>(lane_string.size());
-        for (std::int32_t i = 0; i < count_left; ++i)
-            // this is adjusted for our fake pipe. The moment cucumber can handle multiple escaped
-            // pipes, the '&' part can be removed
-            if (lane_string[i] != '|' && lane_string[i] != '&')
-            {
-                sane = false;
-                break;
-            }
-
-        if (sane)
-        {
-            lane_string.erase(lane_string.begin(), lane_string.begin() + count_left);
-        }
-    }
-    if (count_right)
-    {
-        bool sane = count_right < static_cast<std::int32_t>(lane_string.size());
-        for (auto itr = lane_string.rbegin();
-             itr != lane_string.rend() && itr != lane_string.rbegin() + count_right;
-             ++itr)
-        {
-            if (*itr != '|' && *itr != '&')
-            {
-                sane = false;
-                break;
-            }
-        }
-        if (sane)
-            lane_string.resize(lane_string.size() - count_right);
-    }
-    return lane_string;
-}
+};
 
 } // namespace guidance
 } // namespace extractor

include/extractor/guidance/turn_analysis.hpp

@@ -44,14 +44,10 @@ class TurnAnalysis
                  const SuffixTable &street_name_suffix_table);
 
     // the entry into the turn analysis
+    std::vector<TurnOperation> getTurns(const NodeID from_node, const EdgeID via_eid) const;
+
+    // access to the intersection representation for classification purposes
     Intersection getIntersection(const NodeID from_node, const EdgeID via_eid) const;
-    Intersection
-    assignTurnTypes(const NodeID from_node, const EdgeID via_eid, Intersection intersection) const;
-
-    std::vector<TurnOperation>
-    transformIntersectionIntoTurns(const Intersection &intersection) const;
-
-    const IntersectionGenerator &getGenerator() const;
 
   private:
     const util::NodeBasedDynamicGraph &node_based_graph;

include/extractor/guidance/turn_discovery.hpp

@@ -1,38 +0,0 @@
-#ifndef OSRM_EXTRACTOR_GUIDANCE_TURN_DISCOVERY_HPP_
-#define OSRM_EXTRACTOR_GUIDANCE_TURN_DISCOVERY_HPP_
-
-#include "extractor/guidance/intersection.hpp"
-#include "extractor/guidance/turn_analysis.hpp"
-#include "util/typedefs.hpp"
-
-#include <string>
-
-namespace osrm
-{
-namespace extractor
-{
-namespace guidance
-{
-namespace lanes
-{
-
-// OSRM processes edges by looking at a via_edge, coming into an intersection. For turn lanes, we
-// might require to actually look back a turn. We do so in the hope that the turn lanes match up at
-// the previous intersection for all incoming lanes.
-bool findPreviousIntersection(
-    const NodeID node,
-    const EdgeID via_edge,
-    const Intersection intersection,
-    const TurnAnalysis &turn_analysis,                   // to generate other intersections
-    const util::NodeBasedDynamicGraph &node_based_graph, // query edge data
-    // output parameters, will be in an arbitrary state on failure
-    NodeID &result_node,
-    EdgeID &result_via_edge,
-    Intersection &result_intersection);
-
-} // namespace lanes
-} // namespace guidance
-} // namespace extractor
-} // namespace osrm
-
-#endif /*OSRM_EXTRACTOR_GUIDANCE_TURN_DISCOVERY_HPP_*/

include/extractor/guidance/turn_instruction.hpp

@@ -6,8 +6,6 @@
 #include <boost/assert.hpp>
 
 #include "extractor/guidance/roundabout_type.hpp"
-#include "util/guidance/turn_lanes.hpp"
-#include "util/typedefs.hpp"
 
 namespace osrm
 {
@@ -55,45 +53,48 @@ const constexpr Enum EnterRotary = 12;                 // Enter a rotary
 const constexpr Enum EnterAndExitRotary = 13;          // Touching a rotary
 const constexpr Enum EnterRoundaboutIntersection = 14; // Entering a small Roundabout
 const constexpr Enum EnterAndExitRoundaboutIntersection = 15; // Touching a roundabout
-const constexpr Enum UseLane = 16; // No Turn, but you need to stay on a given lane!
 
 // Values below here are silent instructions
-const constexpr Enum NoTurn = 17;                // end of segment without turn/middle of a segment
-const constexpr Enum Suppressed = 18;            // location that suppresses a turn
-const constexpr Enum EnterRoundaboutAtExit = 19; // Entering a small Roundabout at a countable exit
-const constexpr Enum ExitRoundabout = 20;        // Exiting a small Roundabout
-const constexpr Enum EnterRotaryAtExit = 21;     // Enter A Rotary at a countable exit
-const constexpr Enum ExitRotary = 22;            // Exit a rotary
+const constexpr Enum NoTurn = 16;                // end of segment without turn/middle of a segment
+const constexpr Enum Suppressed = 17;            // location that suppresses a turn
+const constexpr Enum EnterRoundaboutAtExit = 18; // Entering a small Roundabout at a countable exit
+const constexpr Enum ExitRoundabout = 19;        // Exiting a small Roundabout
+const constexpr Enum EnterRotaryAtExit = 20;     // Enter A Rotary at a countable exit
+const constexpr Enum ExitRotary = 21;            // Exit a rotary
 const constexpr Enum EnterRoundaboutIntersectionAtExit =
-    23; // Entering a small Roundabout at a countable exit
-const constexpr Enum ExitRoundaboutIntersection = 24; // Exiting a small Roundabout
-const constexpr Enum StayOnRoundabout = 25; // Continue on Either a small or a large Roundabout
+    22; // Entering a small Roundabout at a countable exit
+const constexpr Enum ExitRoundaboutIntersection = 23; // Exiting a small Roundabout
+const constexpr Enum StayOnRoundabout = 24; // Continue on Either a small or a large Roundabout
 const constexpr Enum Sliproad =
-    26; // Something that looks like a ramp, but is actually just a small sliproad
+    25; // Something that looks like a ramp, but is actually just a small sliproad
 }
 
 // turn angle in 1.40625 degree -> 128 == 180 degree
 struct TurnInstruction
 {
-    using LaneTupel = util::guidance::LaneTupel;
     TurnInstruction(const TurnType::Enum type = TurnType::Invalid,
-                    const DirectionModifier::Enum direction_modifier = DirectionModifier::UTurn)
+                    const DirectionModifier::Enum direction_modifier = DirectionModifier::Straight)
         : type(type), direction_modifier(direction_modifier)
     {
     }
 
     TurnType::Enum type : 5;
     DirectionModifier::Enum direction_modifier : 3;
-    // the lane tupel that is used for the turn
 
-    static TurnInstruction INVALID() { return {TurnType::Invalid, DirectionModifier::UTurn}; }
+    static TurnInstruction INVALID()
+    {
+        return TurnInstruction(TurnType::Invalid, DirectionModifier::UTurn);
+    }
 
-    static TurnInstruction NO_TURN() { return {TurnType::NoTurn, DirectionModifier::UTurn}; }
+    static TurnInstruction NO_TURN()
+    {
+        return TurnInstruction(TurnType::NoTurn, DirectionModifier::UTurn);
+    }
 
     static TurnInstruction REMAIN_ROUNDABOUT(const RoundaboutType,
                                              const DirectionModifier::Enum modifier)
     {
-        return {TurnType::StayOnRoundabout, modifier};
+        return TurnInstruction(TurnType::StayOnRoundabout, modifier);
     }
 
     static TurnInstruction ENTER_ROUNDABOUT(const RoundaboutType roundabout_type,
@@ -145,7 +146,7 @@ struct TurnInstruction
     }
 };
 
-static_assert(sizeof(TurnInstruction) == 1, "TurnInstruction does not fit a byte");
+static_assert(sizeof(TurnInstruction) == 1, "TurnInstruction does not fit one byte");
 
 inline bool operator!=(const TurnInstruction lhs, const TurnInstruction rhs)
 {

include/extractor/guidance/turn_lane_augmentation.hpp

@@ -1,24 +0,0 @@
-#ifndef OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_AUGMENTATION_HPP_
-#define OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_AUGMENTATION_HPP_
-
-#include "extractor/guidance/intersection.hpp"
-#include "extractor/guidance/turn_lane_data.hpp"
-
-namespace osrm
-{
-namespace extractor
-{
-namespace guidance
-{
-namespace lanes
-{
-
-LaneDataVector handleNoneValueAtSimpleTurn(LaneDataVector lane_data,
-                                           const Intersection &intersection);
-
-} // namespace lanes
-} // namespace guidance
-} // namespace extractor
-} // namespace osrm
-
-#endif /* OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_AUGMENTATION_HPP_ */

include/extractor/guidance/turn_lane_data.hpp

@@ -1,44 +0,0 @@
-#ifndef OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_DATA_HPP_
-#define OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_DATA_HPP_
-
-#include "util/typedefs.hpp"
-#include "extractor/guidance/turn_lane_types.hpp"
-#include <string>
-#include <vector>
-
-namespace osrm
-{
-namespace extractor
-{
-namespace guidance
-{
-namespace lanes
-{
-
-struct TurnLaneData
-{
-    TurnLaneType::Mask tag;
-    LaneID from;
-    LaneID to;
-
-    bool operator<(const TurnLaneData &other) const;
-};
-typedef std::vector<TurnLaneData> LaneDataVector;
-
-// convertes a string given in the OSM format into a TurnLaneData vector
-LaneDataVector laneDataFromDescription(const TurnLaneDescription &turn_lane_description);
-
-// Locate A Tag in a lane data vector (if multiple tags are set, the first one found is returned)
-LaneDataVector::const_iterator findTag(const TurnLaneType::Mask tag, const LaneDataVector &data);
-LaneDataVector::iterator findTag(const TurnLaneType::Mask tag, LaneDataVector &data);
-
-// Returns true if any of the queried tags is contained
-bool hasTag(const TurnLaneType::Mask tag, const LaneDataVector &data);
-
-} // namespace lane_data_generation
-
-} // namespace guidance
-} // namespace extractor
-} // namespace osrm
-
-#endif /* OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_DATA_HPP_ */

include/extractor/guidance/turn_lane_handler.hpp

@@ -1,85 +0,0 @@
-#ifndef OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_HANDLER_HPP_
-#define OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_HANDLER_HPP_
-
-#include "extractor/guidance/intersection.hpp"
-#include "extractor/guidance/toolkit.hpp"
-#include "extractor/guidance/turn_analysis.hpp"
-#include "extractor/guidance/turn_lane_data.hpp"
-#include "extractor/guidance/turn_lane_types.hpp"
-#include "extractor/query_node.hpp"
-
-#include "util/guidance/turn_lanes.hpp"
-#include "util/name_table.hpp"
-#include "util/node_based_graph.hpp"
-#include "util/typedefs.hpp"
-
-#include <cstdint>
-#include <map>
-#include <string>
-#include <utility>
-#include <vector>
-
-namespace osrm
-{
-namespace extractor
-{
-namespace guidance
-{
-
-// Given an Intersection, the graph to access the data and  the turn lanes, the turn lane matcher
-// assigns appropriate turn tupels to the different turns.
-namespace lanes
-{
-class TurnLaneHandler
-{
-  public:
-    typedef std::vector<TurnLaneData> LaneDataVector;
-
-    TurnLaneHandler(const util::NodeBasedDynamicGraph &node_based_graph,
-                    const std::vector<std::uint32_t> &turn_lane_offsets,
-                    const std::vector<TurnLaneType::Mask> &turn_lane_masks,
-                    const std::vector<QueryNode> &node_info_list,
-                    const TurnAnalysis &turn_analysis);
-
-    Intersection assignTurnLanes(const NodeID at,
-                                 const EdgeID via_edge,
-                                 Intersection intersection,
-                                 LaneDataIdMap &id_map) const;
-
-  private:
-    // we need to be able to look at previous intersections to, in some cases, find the correct turn
-    // lanes for a turn
-    const util::NodeBasedDynamicGraph &node_based_graph;
-    const std::vector<std::uint32_t> &turn_lane_offsets;
-    const std::vector<TurnLaneType::Mask> &turn_lane_masks;
-    const std::vector<QueryNode> &node_info_list;
-    const TurnAnalysis &turn_analysis;
-
-    // check whether we can handle an intersection
-    bool isSimpleIntersection(const LaneDataVector &turn_lane_data,
-                              const Intersection &intersection) const;
-
-    // in case of a simple intersection, assign the lane entries
-    Intersection simpleMatchTuplesToTurns(Intersection intersection,
-                                          const LaneDataVector &lane_data,
-                                          const LaneDescriptionID lane_string_id,
-                                          LaneDataIdMap &id_map) const;
-
-    // partition lane data into lane data relevant at current turn and at next turn
-    std::pair<TurnLaneHandler::LaneDataVector, TurnLaneHandler::LaneDataVector> partitionLaneData(
-        const NodeID at, LaneDataVector turn_lane_data, const Intersection &intersection) const;
-
-    // if the current intersections turn string is empty, we check whether there is an incoming
-    // intersection whose turns might be related to this current intersection
-    Intersection handleTurnAtPreviousIntersection(const NodeID at,
-                                                  const EdgeID via_edge,
-                                                  Intersection intersection,
-                                                  LaneDataIdMap &id_map) const;
-};
-
-} // namespace lanes
-} // namespace guidance
-} // namespace extractor
-} // namespace osrm
-
-#endif // OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_HANDLER_HPP_

include/extractor/guidance/turn_lane_matcher.hpp

@@ -1,51 +0,0 @@
-#ifndef OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_MATCHER_HPP_
-#define OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_MATCHER_HPP_
-
-#include "extractor/guidance/intersection.hpp"
-#include "extractor/guidance/toolkit.hpp"
-#include "extractor/guidance/turn_instruction.hpp"
-#include "extractor/guidance/turn_lane_data.hpp"
-
-#include "util/guidance/turn_lanes.hpp"
-#include "util/node_based_graph.hpp"
-
-#include <unordered_map>
-
-namespace osrm
-{
-namespace extractor
-{
-namespace guidance
-{
-namespace lanes
-{
-
-// Translate Turn Lane Tags into a matching modifier
-DirectionModifier::Enum getMatchingModifier(const TurnLaneType::Mask &tag);
-
-// check whether a match of a given tag and a turn instruction can be seen as valid
-bool isValidMatch(const TurnLaneType::Mask &tag, const TurnInstruction instruction);
-
-// localisation of the best possible match for a tag
-typename Intersection::const_iterator findBestMatch(const TurnLaneType::Mask &tag,
-                                                    const Intersection &intersection);
-typename Intersection::const_iterator
-findBestMatchForReverse(const TurnLaneType::Mask &leftmost_tag, const Intersection &intersection);
-
-// a match is trivial if all turns can be associated with their best match in a valid way and the
-// matches occur in order
-bool canMatchTrivially(const Intersection &intersection, const LaneDataVector &lane_data);
-
-// perform a trivial match on the turn lanes
-Intersection triviallyMatchLanesToTurns(Intersection intersection,
-                                        const LaneDataVector &lane_data,
-                                        const util::NodeBasedDynamicGraph &node_based_graph,
-                                        const LaneDescriptionID lane_string_id,
-                                        LaneDataIdMap &lane_data_to_id);
-
-} // namespace lanes
-} // namespace guidance
-} // namespace extractor
-} // namespace osrm
-
-#endif /*OSRM_EXTRACTOR_GUIDANCE_TURN_LANE_MATCHER_HPP_*/

include/extractor/guidance/turn_lane_types.hpp

@@ -1,102 +0,0 @@
-#ifndef OSRM_GUIDANCE_TURN_LANE_TYPES_HPP_
-#define OSRM_GUIDANCE_TURN_LANE_TYPES_HPP_
-
-#include <bitset>
-#include <cstddef>
-#include <cstdint>
-#include <string>
-#include <vector>
-
-#include <boost/assert.hpp>
-#include <boost/functional/hash_fwd.hpp>
-
-#include "util/simple_logger.hpp"
-#include "util/typedefs.hpp"
-#include "util/json_container.hpp"
-
-namespace osrm
-{
-namespace extractor
-{
-namespace guidance
-{
-
-namespace TurnLaneType
-{
-namespace detail
-{
-const constexpr std::size_t num_supported_lane_types = 11;
-
-const constexpr char *translations[detail::num_supported_lane_types] = {"none",
-                                                                        "straight",
-                                                                        "sharp left",
-                                                                        "left",
-                                                                        "slight left",
-                                                                        "slight right",
-                                                                        "right",
-                                                                        "sharp right",
-                                                                        "uturn",
-                                                                        "merge to left",
-                                                                        "merge to right"};
-
-} // namespace detail
-
-typedef std::uint16_t Mask;
-const constexpr Mask empty = 0u;
-const constexpr Mask none = 1u << 0u;
-const constexpr Mask straight = 1u << 1u;
-const constexpr Mask sharp_left = 1u << 2u;
-const constexpr Mask left = 1u << 3u;
-const constexpr Mask slight_left = 1u << 4u;
-const constexpr Mask slight_right = 1u << 5u;
-const constexpr Mask right = 1u << 6u;
-const constexpr Mask sharp_right = 1u << 7u;
-const constexpr Mask uturn = 1u << 8u;
-const constexpr Mask merge_to_left = 1u << 9u;
-const constexpr Mask merge_to_right = 1u << 10u;
-
-inline std::string toString(const Mask lane_type)
-{
-    if (lane_type == 0)
-        return "none";
-
-    std::bitset<8 * sizeof(Mask)> mask(lane_type);
-    std::string result = "";
-    for (std::size_t lane_id_nr = 0; lane_id_nr < detail::num_supported_lane_types; ++lane_id_nr)
-        if (mask[lane_id_nr])
-            result += (result.empty() ? detail::translations[lane_id_nr]
-                                      : (std::string(";") + detail::translations[lane_id_nr]));
-
-    return result;
-}
-
-inline util::json::Array toJsonArray(const Mask lane_type)
-{
-    util::json::Array result;
-    std::bitset<8 * sizeof(Mask)> mask(lane_type);
-    for (std::size_t lane_id_nr = 0; lane_id_nr < detail::num_supported_lane_types; ++lane_id_nr)
-        if (mask[lane_id_nr])
-            result.values.push_back(detail::translations[lane_id_nr]);
-    return result;
-}
-} // TurnLaneType
-
-typedef std::vector<TurnLaneType::Mask> TurnLaneDescription;
-
-// hash function for TurnLaneDescription
-struct TurnLaneDescription_hash
-{
-    std::size_t operator()(const TurnLaneDescription &lane_description) const
-    {
-        std::size_t seed = 0;
-        for (auto val : lane_description)
-            boost::hash_combine(seed, val);
-        return seed;
-    }
-};
-
-} // guidance
-} // extractor
-} // osrm
-
-#endif /* OSRM_GUIDANCE_TURN_LANE_TYPES_HPP_ */

include/extractor/internal_extractor_edge.hpp

@@ -29,6 +29,7 @@ struct InternalExtractorEdge
 
     struct WeightData
     {
+
         WeightData() : duration(0.0), type(WeightType::INVALID) {}
 
         union {
@@ -50,7 +51,6 @@ struct InternalExtractorEdge
                  true,
                  TRAVEL_MODE_INACCESSIBLE,
                  false,
-                 guidance::TurnLaneType::empty,
                  guidance::RoadClassificationData())
     {
     }
@@ -66,10 +66,9 @@ struct InternalExtractorEdge
                                    bool startpoint,
                                    TravelMode travel_mode,
                                    bool is_split,
-                                   LaneDescriptionID lane_description,
                                    guidance::RoadClassificationData road_classification)
-        : result(source,
-                 target,
+        : result(OSMNodeID(source),
+                 OSMNodeID(target),
                  name_id,
                  0,
                  forward,
@@ -79,7 +78,6 @@ struct InternalExtractorEdge
                  startpoint,
                  travel_mode,
                  is_split,
-                 lane_description,
                  std::move(road_classification)),
           weight_data(std::move(weight_data))
     {
@@ -106,7 +104,6 @@ struct InternalExtractorEdge
                                      true,
                                      TRAVEL_MODE_INACCESSIBLE,
                                      false,
-                                     INVALID_LANE_DESCRIPTIONID,
                                      guidance::RoadClassificationData());
     }
     static InternalExtractorEdge max_osm_value()
@@ -122,7 +119,6 @@ struct InternalExtractorEdge
                                      true,
                                      TRAVEL_MODE_INACCESSIBLE,
                                      false,
-                                     INVALID_LANE_DESCRIPTIONID,
                                      guidance::RoadClassificationData());
     }
 
@@ -142,6 +138,43 @@ struct InternalExtractorEdge
     }
 };
 
+struct CmpEdgeByInternalStartThenInternalTargetID
+{
+    using value_type = InternalExtractorEdge;
+    bool operator()(const InternalExtractorEdge &lhs, const InternalExtractorEdge &rhs) const
+    {
+        return (lhs.result.source < rhs.result.source) ||
+               ((lhs.result.source == rhs.result.source) &&
+                (lhs.result.target < rhs.result.target));
+    }
+
+    value_type max_value() { return InternalExtractorEdge::max_internal_value(); }
+    value_type min_value() { return InternalExtractorEdge::min_internal_value(); }
+};
+
+struct CmpEdgeByOSMStartID
+{
+    using value_type = InternalExtractorEdge;
+    bool operator()(const InternalExtractorEdge &lhs, const InternalExtractorEdge &rhs) const
+    {
+        return lhs.result.osm_source_id < rhs.result.osm_source_id;
+    }
+
+    value_type max_value() { return InternalExtractorEdge::max_osm_value(); }
+    value_type min_value() { return InternalExtractorEdge::min_osm_value(); }
+};
+
+struct CmpEdgeByOSMTargetID
+{
+    using value_type = InternalExtractorEdge;
+    bool operator()(const InternalExtractorEdge &lhs, const InternalExtractorEdge &rhs) const
+    {
+        return lhs.result.osm_target_id < rhs.result.osm_target_id;
+    }
+
+    value_type max_value() { return InternalExtractorEdge::max_osm_value(); }
+    value_type min_value() { return InternalExtractorEdge::min_osm_value(); }
+};
 }
 }
 

include/extractor/node_based_edge.hpp

@@ -26,7 +26,6 @@ struct NodeBasedEdge
                   bool startpoint,
                   TravelMode travel_mode,
                   bool is_split,
-                  const LaneDescriptionID lane_description_id,
                   guidance::RoadClassificationData road_classification);
 
     bool operator<(const NodeBasedEdge &other) const;
@@ -42,7 +41,6 @@ struct NodeBasedEdge
     bool startpoint : 1;
     bool is_split : 1;
     TravelMode travel_mode : 4;
-    LaneDescriptionID lane_description_id;
     guidance::RoadClassificationData road_classification;
 };
 
@@ -59,7 +57,6 @@ struct NodeBasedEdgeWithOSM : NodeBasedEdge
                          bool startpoint,
                          TravelMode travel_mode,
                          bool is_split,
-                         const LaneDescriptionID lane_description_id,
                          guidance::RoadClassificationData road_classification);
 
     OSMNodeID osm_source_id;
@@ -71,7 +68,7 @@ struct NodeBasedEdgeWithOSM : NodeBasedEdge
 inline NodeBasedEdge::NodeBasedEdge()
     : source(SPECIAL_NODEID), target(SPECIAL_NODEID), name_id(0), weight(0), forward(false),
       backward(false), roundabout(false), access_restricted(false), startpoint(true),
-      is_split(false), travel_mode(false), lane_description_id(INVALID_LANE_DESCRIPTIONID)
+      is_split(false), travel_mode(false)
 {
 }
 
@@ -86,12 +83,11 @@ inline NodeBasedEdge::NodeBasedEdge(NodeID source,
                                     bool startpoint,
                                     TravelMode travel_mode,
                                     bool is_split,
-                                    const LaneDescriptionID lane_description_id,
                                     guidance::RoadClassificationData road_classification)
     : source(source), target(target), name_id(name_id), weight(weight), forward(forward),
       backward(backward), roundabout(roundabout), access_restricted(access_restricted),
       startpoint(startpoint), is_split(is_split), travel_mode(travel_mode),
-      lane_description_id(lane_description_id), road_classification(std::move(road_classification))
+      road_classification(std::move(road_classification))
 {
 }
 
@@ -124,7 +120,6 @@ inline NodeBasedEdgeWithOSM::NodeBasedEdgeWithOSM(
     bool startpoint,
     TravelMode travel_mode,
     bool is_split,
-    const LaneDescriptionID lane_description_id,
     guidance::RoadClassificationData road_classification)
     : NodeBasedEdge(SPECIAL_NODEID,
                     SPECIAL_NODEID,
@@ -137,7 +132,6 @@ inline NodeBasedEdgeWithOSM::NodeBasedEdgeWithOSM(
                     startpoint,
                     travel_mode,
                     is_split,
-                    lane_description_id,
                     std::move(road_classification)),
       osm_source_id(std::move(source)), osm_target_id(std::move(target))
 {

include/extractor/original_edge_data.hpp

@@ -17,19 +17,18 @@ struct OriginalEdgeData
 {
     explicit OriginalEdgeData(NodeID via_node,
                               unsigned name_id,
-                              LaneDataID lane_data_id,
                               guidance::TurnInstruction turn_instruction,
                               EntryClassID entry_classid,
                               TravelMode travel_mode)
         : via_node(via_node), name_id(name_id), entry_classid(entry_classid),
-          lane_data_id(lane_data_id), turn_instruction(turn_instruction), travel_mode(travel_mode)
+          turn_instruction(turn_instruction), travel_mode(travel_mode)
     {
     }
 
     OriginalEdgeData()
         : via_node(std::numeric_limits<unsigned>::max()),
           name_id(std::numeric_limits<unsigned>::max()), entry_classid(INVALID_ENTRY_CLASSID),
-          lane_data_id(INVALID_LANE_DATAID), turn_instruction(guidance::TurnInstruction::INVALID()),
+          turn_instruction(guidance::TurnInstruction::INVALID()),
           travel_mode(TRAVEL_MODE_INACCESSIBLE)
     {
     }
@@ -37,13 +36,9 @@ struct OriginalEdgeData
     NodeID via_node;
     unsigned name_id;
     EntryClassID entry_classid;
-    LaneDataID lane_data_id;
     guidance::TurnInstruction turn_instruction;
     TravelMode travel_mode;
 };
-
-static_assert(sizeof(OriginalEdgeData) == 16,
-              "Increasing the size of OriginalEdgeData increases memory consumption");
 }
 }
 

include/extractor/query_node.hpp

@@ -6,7 +6,6 @@
 #include "util/coordinate.hpp"
 
 #include <limits>
-#include <cstdint>
 
 namespace osrm
 {
@@ -16,16 +15,16 @@ namespace extractor
 struct QueryNode
 {
     using key_type = OSMNodeID; // type of NodeID
-    using value_type = std::int32_t;     // type of lat,lons
+    using value_type = int;     // type of lat,lons
 
     explicit QueryNode(const util::FixedLongitude lon_,
                        const util::FixedLatitude lat_,
-                       const key_type node_id_)
-        : lon(lon_), lat(lat_), node_id(node_id_)
+                       key_type node_id)
+        : lon(lon_), lat(lat_), node_id(std::move(node_id))
     {
     }
     QueryNode()
-        : lon{std::numeric_limits<value_type>::max()}, lat{std::numeric_limits<value_type>::max()},
+        : lon(std::numeric_limits<int>::max()), lat(std::numeric_limits<int>::max()),
           node_id(SPECIAL_OSM_NODEID)
     {
     }
@@ -36,15 +35,15 @@ struct QueryNode
 
     static QueryNode min_value()
     {
-        return QueryNode(util::FixedLongitude{static_cast<value_type>(-180 * COORDINATE_PRECISION)},
-                         util::FixedLatitude{static_cast<value_type>(-90 * COORDINATE_PRECISION)},
+        return QueryNode(util::FixedLongitude(-180 * COORDINATE_PRECISION),
+                         util::FixedLatitude(-90 * COORDINATE_PRECISION),
                          MIN_OSM_NODEID);
     }
 
     static QueryNode max_value()
     {
-        return QueryNode(util::FixedLongitude{static_cast<value_type>(180 * COORDINATE_PRECISION)},
-                         util::FixedLatitude{static_cast<value_type>(90 * COORDINATE_PRECISION)},
+        return QueryNode(util::FixedLongitude(180 * COORDINATE_PRECISION),
+                         util::FixedLatitude(90 * COORDINATE_PRECISION),
                          MAX_OSM_NODEID);
     }
 };

include/server/api/base_parameters_grammar.hpp

@@ -111,15 +111,15 @@ struct BaseParametersGrammar : boost::spirit::qi::grammar<Iterator, Signature>
                                                 qi::_1,
                                                 qi::_2)];
 
-        location_rule =
-            (double_ > qi::lit(',') >
-             double_)[qi::_val = ph::bind(
-                          [](double lon, double lat) {
-                              return util::Coordinate(util::toFixed(util::FloatLongitude{lon}),
-                                                      util::toFixed(util::FloatLatitude{lat}));
-                          },
-                          qi::_1,
-                          qi::_2)];
+        location_rule = (double_ > qi::lit(',') >
+                         double_)[qi::_val = ph::bind(
+                                      [](double lon, double lat) {
+                                          return util::Coordinate(
+                                              util::FixedLongitude(lon * COORDINATE_PRECISION),
+                                              util::FixedLatitude(lat * COORDINATE_PRECISION));
+                                      },
+                                      qi::_1,
+                                      qi::_2)];
 
         polyline_rule = qi::as_string[qi::lit("polyline(") > +polyline_chars > ')']
                                      [qi::_val = ph::bind(

include/storage/shared_datatype.hpp

@@ -14,41 +14,7 @@ namespace storage
 {
 
 // Added at the start and end of each block as sanity check
-const constexpr char CANARY[4] = {'O', 'S', 'R', 'M'};
-
-const constexpr char *block_id_to_name[] = {"NAME_OFFSETS",
-                                            "NAME_BLOCKS",
-                                            "NAME_CHAR_LIST",
-                                            "NAME_ID_LIST",
-                                            "VIA_NODE_LIST",
-                                            "GRAPH_NODE_LIST",
-                                            "GRAPH_EDGE_LIST",
-                                            "COORDINATE_LIST",
-                                            "OSM_NODE_ID_LIST",
-                                            "TURN_INSTRUCTION",
-                                            "TRAVEL_MODE",
-                                            "ENTRY_CLASSID",
-                                            "R_SEARCH_TREE",
-                                            "GEOMETRIES_INDEX",
-                                            "GEOMETRIES_LIST",
-                                            "HSGR_CHECKSUM",
-                                            "TIMESTAMP",
-                                            "FILE_INDEX_PATH",
-                                            "CORE_MARKER",
-                                            "DATASOURCES_LIST",
-                                            "DATASOURCE_NAME_DATA",
-                                            "DATASOURCE_NAME_OFFSETS",
-                                            "DATASOURCE_NAME_LENGTHS",
-                                            "PROPERTIES",
-                                            "BEARING_CLASSID",
-                                            "BEARING_OFFSETS",
-                                            "BEARING_BLOCKS",
-                                            "BEARING_VALUES",
-                                            "ENTRY_CLASS",
-                                            "LANE_DATA_ID",
-                                            "TURN_LANE_DATA",
-                                            "LANE_DESCRIPTION_OFFSETS",
-                                            "LANE_DESCRIPTION_MASKS"};
+const constexpr char CANARY[] = "OSRM";
 
 struct SharedDataLayout
 {
@@ -64,8 +30,8 @@ struct SharedDataLayout
         COORDINATE_LIST,
         OSM_NODE_ID_LIST,
         TURN_INSTRUCTION,
-        TRAVEL_MODE,
         ENTRY_CLASSID,
+        TRAVEL_MODE,
         R_SEARCH_TREE,
         GEOMETRIES_INDEX,
         GEOMETRIES_LIST,
@@ -83,10 +49,6 @@ struct SharedDataLayout
         BEARING_BLOCKS,
         BEARING_VALUES,
         ENTRY_CLASS,
-        LANE_DATA_ID,
-        TURN_LANE_DATA,
-        LANE_DESCRIPTION_OFFSETS,
-        LANE_DESCRIPTION_MASKS,
         NUM_BLOCKS
     };
 
@@ -101,20 +63,15 @@ struct SharedDataLayout
         entry_size[bid] = sizeof(T);
     }
 
-    inline uint64_t AlignBlockSize(uint64_t block_size) const
-    {
-        const uint64_t alignment = 4;
-        return (block_size + (alignment - 1)) & ~(alignment - 1);
-    }
-
     inline uint64_t GetBlockSize(BlockID bid) const
     {
         // special bit encoding
         if (bid == CORE_MARKER)
         {
-            return AlignBlockSize((num_entries[bid] / 32 + 1) * entry_size[bid]);
+            return (num_entries[bid] / 32 + 1) * entry_size[bid];
         }
-        return AlignBlockSize(num_entries[bid] * entry_size[bid]);
+
+        return num_entries[bid] * entry_size[bid];
     }
 
     inline uint64_t GetSizeOfLayout() const
@@ -151,13 +108,11 @@ struct SharedDataLayout
             bool end_canary_alive = std::equal(CANARY, CANARY + sizeof(CANARY), end_canary_ptr);
             if (!start_canary_alive)
             {
-                throw util::exception(std::string("Start canary of block corrupted. (") +
-                                      block_id_to_name[bid] + ")");
+                throw util::exception("Start canary of block corrupted.");
             }
             if (!end_canary_alive)
             {
-                throw util::exception(std::string("End canary of block corrupted. (") +
-                                      block_id_to_name[bid] + ")");
+                throw util::exception("End canary of block corrupted.");
             }
         }
 
@@ -182,9 +137,6 @@ struct SharedDataTimestamp
     SharedDataType data;
     unsigned timestamp;
 };
-
-static_assert(sizeof(block_id_to_name) / sizeof(*block_id_to_name) == SharedDataLayout::NUM_BLOCKS,
-              "Number of blocks needs to match the number of Block names.");
 }
 }
 

include/storage/storage_config.hpp

@@ -65,8 +65,6 @@ struct StorageConfig final
     boost::filesystem::path names_data_path;
     boost::filesystem::path properties_path;
     boost::filesystem::path intersection_class_path;
-    boost::filesystem::path turn_lane_data_path;
-    boost::filesystem::path turn_lane_description_path;
 };
 }
 }

include/util/assert.hpp

@@ -0,0 +1,20 @@
+#ifndef OSRM_ASSERT_HPP
+#define OSRM_ASSERT_HPP
+
+#include <boost/assert.hpp>
+
+#include <stdexcept>
+
+namespace osrm
+{
+namespace util
+{
+// Assertion type to be thrown for stack unwinding
+struct assertionError final : std::logic_error
+{
+    assertionError(const char *msg) : std::logic_error{msg} {}
+};
+}
+}
+
+#endif

include/util/coordinate.hpp

@@ -61,7 +61,7 @@ inline FixedLatitude toFixed(const FloatLatitude floating)
 {
     const auto latitude = static_cast<double>(floating);
     const auto fixed = boost::numeric_cast<std::int32_t>(latitude * COORDINATE_PRECISION);
-    return FixedLatitude{fixed};
+    return FixedLatitude(fixed);
 }
 
 /**
@@ -75,7 +75,7 @@ inline FixedLongitude toFixed(const FloatLongitude floating)
 {
     const auto longitude = static_cast<double>(floating);
     const auto fixed = boost::numeric_cast<std::int32_t>(longitude * COORDINATE_PRECISION);
-    return FixedLongitude{fixed};
+    return FixedLongitude(fixed);
 }
 
 /**
@@ -89,7 +89,7 @@ inline FloatLatitude toFloating(const FixedLatitude fixed)
 {
     const auto latitude = static_cast<std::int32_t>(fixed);
     const auto floating = boost::numeric_cast<double>(latitude / COORDINATE_PRECISION);
-    return FloatLatitude{floating};
+    return FloatLatitude(floating);
 }
 
 /**
@@ -103,7 +103,7 @@ inline FloatLongitude toFloating(const FixedLongitude fixed)
 {
     const auto longitude = static_cast<std::int32_t>(fixed);
     const auto floating = boost::numeric_cast<double>(longitude / COORDINATE_PRECISION);
-    return FloatLongitude{floating};
+    return FloatLongitude(floating);
 }
 
 // fwd. decl.
@@ -127,7 +127,7 @@ struct Coordinate
     FixedLongitude lon;
     FixedLatitude lat;
 
-    Coordinate() : lon{std::numeric_limits<int>::min()}, lat{std::numeric_limits<int>::min()} {}
+    Coordinate() : lon(std::numeric_limits<int>::min()), lat(std::numeric_limits<int>::min()) {}
 
     Coordinate(const FloatCoordinate &other);
 
@@ -173,7 +173,7 @@ struct FloatCoordinate
     FloatLatitude lat;
 
     FloatCoordinate()
-        : lon{std::numeric_limits<double>::min()}, lat{std::numeric_limits<double>::min()}
+        : lon(std::numeric_limits<double>::min()), lat(std::numeric_limits<double>::min())
     {
     }
 

include/util/coordinate_calculation.hpp

@@ -61,10 +61,10 @@ inline std::pair<double, FloatCoordinate> projectPointOnSegment(const FloatCoord
 
     return {clamped_ratio,
             {
-                FloatLongitude{1.0 - clamped_ratio} * source.lon +
-                    target.lon * FloatLongitude{clamped_ratio},
-                FloatLatitude{1.0 - clamped_ratio} * source.lat +
-                    target.lat * FloatLatitude{clamped_ratio},
+                FloatLongitude(1.0 - clamped_ratio) * source.lon +
+                    target.lon * FloatLongitude(clamped_ratio),
+                FloatLatitude(1.0 - clamped_ratio) * source.lat +
+                    target.lat * FloatLatitude(clamped_ratio),
             }};
 }
 

include/util/debug.hpp

@@ -1,91 +0,0 @@
-#ifndef OSRM_ENGINE_GUIDANCE_DEBUG_HPP_
-#define OSRM_ENGINE_GUIDANCE_DEBUG_HPP_
-
-#include "extractor/guidance/intersection.hpp"
-#include "extractor/guidance/turn_lane_data.hpp"
-#include "extractor/query_node.hpp"
-#include "engine/guidance/route_step.hpp"
-#include "util/typedefs.hpp"
-
-#include <iomanip>
-#include <iostream>
-#include <vector>
-
-namespace osrm
-{
-namespace util
-{
-namespace guidance
-{
-inline void print(const engine::guidance::RouteStep &step)
-{
-    std::cout << static_cast<int>(step.maneuver.instruction.type) << " "
-              << static_cast<int>(step.maneuver.instruction.direction_modifier) << "  "
-              << static_cast<int>(step.maneuver.waypoint_type) << " "
-              << " Lanes: (" << static_cast<int>(step.maneuver.lanes.lanes_in_turn) << ", "
-              << static_cast<int>(step.maneuver.lanes.first_lane_from_the_right) << ")"
-              << " Duration: " << step.duration << " Distance: " << step.distance
-              << " Geometry: " << step.geometry_begin << " " << step.geometry_end
-              << " exit: " << step.maneuver.exit << " Intersections: " << step.intersections.size()
-              << " [";
-
-    for (const auto &intersection : step.intersections)
-    {
-        std::cout << "(bearings:";
-        for (auto bearing : intersection.bearings)
-            std::cout << " " << bearing;
-        std::cout << ", entry: ";
-        for (auto entry : intersection.entry)
-            std::cout << " " << (entry ? "true" : "false");
-        std::cout << ")";
-    }
-    std::cout << "] name[" << step.name_id << "]: " << step.name;
-}
-
-inline void print(const std::vector<engine::guidance::RouteStep> &steps)
-{
-    std::cout << "Path\n";
-    int segment = 0;
-    for (const auto &step : steps)
-    {
-        std::cout << "\t[" << segment++ << "]: ";
-        print(step);
-        std::cout << std::endl;
-    }
-}
-
-inline void print(const extractor::guidance::lanes::LaneDataVector &turn_lane_data)
-{
-    std::cout << " Tags:\n";
-    for (auto entry : turn_lane_data)
-        std::cout << "\t" << entry.tag << "("
-                  << extractor::guidance::TurnLaneType::toString(entry.tag)
-                  << ") from: " << static_cast<int>(entry.from)
-                  << " to: " << static_cast<int>(entry.to) << "\n";
-    std::cout << std::flush;
-}
-
-inline void
-printTurnAssignmentData(const NodeID at,
-                        const extractor::guidance::lanes::LaneDataVector &turn_lane_data,
-                        const extractor::guidance::Intersection &intersection,
-                        const std::vector<extractor::QueryNode> &node_info_list)
-{
-    std::cout << "[Turn Assignment Progress]\nLocation:";
-    auto coordinate = node_info_list[at];
-    std::cout << std::setprecision(12) << toFloating(coordinate.lat) << " "
-              << toFloating(coordinate.lon) << "\n";
-
-    std::cout << "  Intersection:\n";
-    for (const auto &road : intersection)
-        std::cout << "\t" << toString(road) << "\n";
-
-    // flushes as well
-    print(turn_lane_data);
-}
-
-} // namespace guidance
-} // namespace util
-} // namespace osrm
-
-#endif /*OSRM_ENGINE_GUIDANCE_DEBUG_HPP_*/

include/util/dynamic_graph.hpp

@@ -24,8 +24,8 @@ template <typename EdgeDataT> class DynamicGraph
 {
   public:
     using EdgeData = EdgeDataT;
-    using NodeIterator = std::uint32_t;
-    using EdgeIterator = std::uint32_t;
+    using NodeIterator = unsigned;
+    using EdgeIterator = unsigned;
     using EdgeRange = range<EdgeIterator>;
 
     class InputEdge

include/util/group_by.hpp

@@ -1,40 +0,0 @@
-#ifndef OSRM_GROUP_BY
-#define OSRM_GROUP_BY
-
-#include <algorithm>
-#include <utility>
-
-namespace osrm
-{
-namespace util
-{
-
-// Runs fn on consecutive items in sub-ranges determined by pred.
-//
-// Example:
-//   vector<int> v{1,2,2,2,3,4,4};
-//   group_by(first, last, even, print);
-//   >>> 2,2,2
-//   >>> 4,4
-//
-// Note: this mimics Python's itertools.groupby
-template <typename Iter, typename Pred, typename Fn>
-Fn group_by(Iter first, Iter last, Pred pred, Fn fn)
-{
-    while (first != last)
-    {
-        first = std::find_if(first, last, pred);
-        auto next = std::find_if_not(first, last, pred);
-
-        (void)fn(std::make_pair(first, next));
-
-        first = next;
-    }
-
-    return fn;
-}
-
-} // ns util
-} // ns osrm
-
-#endif

include/util/guidance/toolkit.hpp

@@ -65,70 +65,6 @@ mirrorDirectionModifier(const extractor::guidance::DirectionModifier::Enum modif
     return results[modifier];
 }
 
-inline bool hasLeftModifier(const extractor::guidance::TurnInstruction instruction)
-{
-    return instruction.direction_modifier == extractor::guidance::DirectionModifier::SharpLeft ||
-           instruction.direction_modifier == extractor::guidance::DirectionModifier::Left ||
-           instruction.direction_modifier == extractor::guidance::DirectionModifier::SlightLeft;
-}
-
-inline bool hasRightModifier(const extractor::guidance::TurnInstruction instruction)
-{
-    return instruction.direction_modifier == extractor::guidance::DirectionModifier::SharpRight ||
-           instruction.direction_modifier == extractor::guidance::DirectionModifier::Right ||
-           instruction.direction_modifier == extractor::guidance::DirectionModifier::SlightRight;
-}
-
-inline bool isLeftTurn(const extractor::guidance::TurnInstruction instruction)
-{
-    switch (instruction.type)
-    {
-    case extractor::guidance::TurnType::Merge:
-        return hasRightModifier(instruction);
-    default:
-        return hasLeftModifier(instruction);
-    }
-}
-
-inline bool isRightTurn(const extractor::guidance::TurnInstruction instruction)
-{
-    switch (instruction.type)
-    {
-    case extractor::guidance::TurnType::Merge:
-        return hasLeftModifier(instruction);
-    default:
-        return hasRightModifier(instruction);
-    }
-}
-
-inline bool entersRoundabout(const extractor::guidance::TurnInstruction instruction)
-{
-    return (instruction.type == extractor::guidance::TurnType::EnterRoundabout ||
-            instruction.type == extractor::guidance::TurnType::EnterRotary ||
-            instruction.type == extractor::guidance::TurnType::EnterRoundaboutIntersection ||
-            instruction.type == extractor::guidance::TurnType::EnterRoundaboutAtExit ||
-            instruction.type == extractor::guidance::TurnType::EnterRotaryAtExit ||
-            instruction.type == extractor::guidance::TurnType::EnterRoundaboutIntersectionAtExit ||
-            instruction.type == extractor::guidance::TurnType::EnterAndExitRoundabout ||
-            instruction.type == extractor::guidance::TurnType::EnterAndExitRotary ||
-            instruction.type == extractor::guidance::TurnType::EnterAndExitRotary);
-}
-
-inline bool leavesRoundabout(const extractor::guidance::TurnInstruction instruction)
-{
-    return (instruction.type == extractor::guidance::TurnType::ExitRoundabout ||
-            instruction.type == extractor::guidance::TurnType::ExitRotary ||
-            instruction.type == extractor::guidance::TurnType::ExitRoundaboutIntersection ||
-            instruction.type == extractor::guidance::TurnType::EnterAndExitRoundabout ||
-            instruction.type == extractor::guidance::TurnType::EnterAndExitRotary ||
-            instruction.type == extractor::guidance::TurnType::EnterAndExitRoundaboutIntersection);
-}
-
-inline bool staysOnRoundabout(const extractor::guidance::TurnInstruction instruction)
-{
-    return instruction.type == extractor::guidance::TurnType::StayOnRoundabout;
-}
-
 } // namespace guidance
 } // namespace util
 } // namespace osrm

include/util/guidance/turn_lanes.hpp

@@ -1,81 +0,0 @@
-#ifndef OSRM_UTIL_GUIDANCE_TURN_LANES_HPP
-#define OSRM_UTIL_GUIDANCE_TURN_LANES_HPP
-
-#include <cstddef>
-#include <cstdint>
-#include <functional>
-#include <vector>
-
-#include "util/typedefs.hpp"
-
-#include <boost/functional/hash.hpp>
-
-namespace osrm
-{
-namespace util
-{
-namespace guidance
-{
-class LaneTupel;
-} // namespace guidance
-} // namespace util
-} // namespace osrm
-
-namespace std
-{
-template <> struct hash<::osrm::util::guidance::LaneTupel>
-{
-    inline std::size_t operator()(const ::osrm::util::guidance::LaneTupel &bearing_class) const;
-};
-} // namespace std
-
-namespace osrm
-{
-namespace util
-{
-namespace guidance
-{
-
-// The mapping of turn lanes can be done two values. We describe every turn by the number of
-// contributing lanes and the first lane from the right..
-// Given a road like this:
-//           |   |   |
-//           |   |   |
-// -----------       |
-//      -^           |
-// -----------        -------------
-//      -^ ->
-// --------------------------------
-//      -v       |
-// ----------    |
-//          |    |
-//
-// we generate a set of tuples in the form of:
-// (2,1), (1,1), (1,0) for left, through and right respectively
-class LaneTupel
-{
-  public:
-    LaneTupel();
-    LaneTupel(const LaneID lanes_in_turn, const LaneID first_lane_from_the_right);
-
-    bool operator==(const LaneTupel other) const;
-    bool operator!=(const LaneTupel other) const;
-
-    LaneID lanes_in_turn;
-    LaneID first_lane_from_the_right;
-
-    friend std::size_t hash_value(const LaneTupel &tup)
-    {
-        std::size_t seed{0};
-        boost::hash_combine(seed, tup.lanes_in_turn);
-        boost::hash_combine(seed, tup.first_lane_from_the_right);
-        return seed;
-    }
-};
-
-using LaneTupelIdPair = std::pair<util::guidance::LaneTupel, LaneDescriptionID>;
-} // namespace guidance
-} // namespace util
-} // namespace osrm
-
-#endif /* OSRM_UTIL_GUIDANCE_TURN_LANES_HPP */

include/util/io.hpp

@@ -4,14 +4,12 @@
 #include "util/simple_logger.hpp"
 
 #include <boost/filesystem.hpp>
-#include <boost/numeric/conversion/cast.hpp>
 
 #include <cstddef>
 #include <cstdint>
 
 #include <bitset>
 #include <fstream>
-#include <stxxl/vector>
 #include <vector>
 
 #include "util/fingerprint.hpp"
@@ -90,84 +88,6 @@ bool deserializeVector(std::istream &stream, std::vector<simple_type> &data)
     return static_cast<bool>(stream);
 }
 
-// serializes a vector of vectors into an adjacency array (creates a copy of the data internally)
-template <typename simple_type>
-bool serializeVectorIntoAdjacencyArray(const std::string &filename,
-                                       const std::vector<std::vector<simple_type>> &data)
-{
-    std::ofstream out_stream(filename, std::ios::binary);
-    std::vector<std::uint32_t> offsets;
-    offsets.reserve(data.size() + 1);
-    std::uint64_t current_offset = 0;
-    offsets.push_back(current_offset);
-    for (auto const &vec : data)
-    {
-        current_offset += vec.size();
-        offsets.push_back(boost::numeric_cast<std::uint32_t>(current_offset));
-    }
-    if (!serializeVector(out_stream, offsets))
-        return false;
-
-    std::vector<simple_type> all_data;
-    all_data.reserve(offsets.back());
-    for (auto const &vec : data)
-        all_data.insert(all_data.end(), vec.begin(), vec.end());
-
-    if (!serializeVector(out_stream, all_data))
-        return false;
-
-    return static_cast<bool>(out_stream);
-}
-
-template <typename simple_type, std::size_t WRITE_BLOCK_BUFFER_SIZE = 1024>
-bool serializeVector(std::ofstream &out_stream, const stxxl::vector<simple_type> &data)
-{
-    const std::uint64_t size = data.size();
-    out_stream.write(reinterpret_cast<const char *>(&size), sizeof(size));
-
-    simple_type write_buffer[WRITE_BLOCK_BUFFER_SIZE];
-    std::size_t buffer_len = 0;
-
-    for (const auto entry : data)
-    {
-        write_buffer[buffer_len++] = entry;
-
-        if (buffer_len >= WRITE_BLOCK_BUFFER_SIZE)
-        {
-            out_stream.write(reinterpret_cast<const char *>(write_buffer),
-                             WRITE_BLOCK_BUFFER_SIZE * sizeof(simple_type));
-            buffer_len = 0;
-        }
-    }
-
-    // write remaining entries
-    if (buffer_len > 0)
-        out_stream.write(reinterpret_cast<const char *>(write_buffer),
-                         buffer_len * sizeof(simple_type));
-
-    return static_cast<bool>(out_stream);
-}
-
-template <typename simple_type>
-bool deserializeAdjacencyArray(const std::string &filename,
-                               std::vector<std::uint32_t> &offsets,
-                               std::vector<simple_type>& data)
-{
-    std::ifstream in_stream(filename, std::ios::binary);
-
-    if (!deserializeVector(in_stream, offsets))
-        return false;
-
-    if (!deserializeVector(in_stream, data))
-        return false;
-
-    // offsets have to match up with the size of the data
-    if (offsets.empty() || (offsets.back() != boost::numeric_cast<std::uint32_t>(data.size())))
-        return false;
-
-    return static_cast<bool>(in_stream);
-}
-
 inline bool serializeFlags(const boost::filesystem::path &path, const std::vector<bool> &flags)
 {
     // TODO this should be replaced with a FILE-based write using error checking

include/util/node_based_graph.hpp

@@ -20,8 +20,7 @@ struct NodeBasedEdgeData
     NodeBasedEdgeData()
         : distance(INVALID_EDGE_WEIGHT), edge_id(SPECIAL_NODEID),
           name_id(std::numeric_limits<unsigned>::max()), access_restricted(false), reversed(false),
-          roundabout(false), travel_mode(TRAVEL_MODE_INACCESSIBLE),
-          lane_description_id(INVALID_LANE_DESCRIPTIONID)
+          roundabout(false), travel_mode(TRAVEL_MODE_INACCESSIBLE)
     {
     }
 
@@ -32,11 +31,10 @@ struct NodeBasedEdgeData
                       bool reversed,
                       bool roundabout,
                       bool startpoint,
-                      extractor::TravelMode travel_mode,
-                      const LaneDescriptionID lane_description_id)
+                      extractor::TravelMode travel_mode)
         : distance(distance), edge_id(edge_id), name_id(name_id),
           access_restricted(access_restricted), reversed(reversed), roundabout(roundabout),
-          startpoint(startpoint), travel_mode(travel_mode), lane_description_id(lane_description_id)
+          startpoint(startpoint), travel_mode(travel_mode)
     {
     }
 
@@ -48,7 +46,6 @@ struct NodeBasedEdgeData
     bool roundabout : 1;
     bool startpoint : 1;
     extractor::TravelMode travel_mode : 4;
-    LaneDescriptionID lane_description_id;
     extractor::guidance::RoadClassificationData road_classification;
 
     bool IsCompatibleTo(const NodeBasedEdgeData &other) const
@@ -67,7 +64,7 @@ using NodeBasedDynamicGraph = DynamicGraph<NodeBasedEdgeData>;
 /// Since DynamicGraph expects directed edges, we need to insert
 /// two edges for undirected edges.
 inline std::shared_ptr<NodeBasedDynamicGraph>
-NodeBasedDynamicGraphFromEdges(NodeID number_of_nodes,
+NodeBasedDynamicGraphFromEdges(std::size_t number_of_nodes,
                                const std::vector<extractor::NodeBasedEdge> &input_edge_list)
 {
     auto edges_list = directedEdgesFromCompressed<NodeBasedDynamicGraph::InputEdge>(
@@ -83,12 +80,12 @@ NodeBasedDynamicGraphFromEdges(NodeID number_of_nodes,
             output_edge.data.travel_mode = input_edge.travel_mode;
             output_edge.data.startpoint = input_edge.startpoint;
             output_edge.data.road_classification = input_edge.road_classification;
-            output_edge.data.lane_description_id = input_edge.lane_description_id;
         });
 
     tbb::parallel_sort(edges_list.begin(), edges_list.end());
 
-    auto graph = std::make_shared<NodeBasedDynamicGraph>(number_of_nodes, edges_list);
+    auto graph = std::make_shared<NodeBasedDynamicGraph>(
+        static_cast<NodeBasedDynamicGraph::NodeIterator>(number_of_nodes), edges_list);
 
     return graph;
 }

include/util/packed_vector.hpp

@@ -12,6 +12,7 @@ namespace osrm
 namespace util
 {
 
+
 /**
  * Since OSM node IDs are (at the time of writing) not quite yet overflowing 32 bits, and
  * will predictably be containable within 33 bits for a long time, the following packs
@@ -20,16 +21,16 @@ namespace util
  * NOTE: this type is templated for future use, but will require a slight refactor to
  * configure BITSIZE and ELEMSIZE
  */
-template <typename T, bool UseSharedMemory = false> class PackedVector
+template <typename T, bool UseSharedMemory=false> class PackedVector
 {
     static const constexpr std::size_t BITSIZE = 33;
     static const constexpr std::size_t ELEMSIZE = 64;
     static const constexpr std::size_t PACKSIZE = BITSIZE * ELEMSIZE;
 
   public:
+
     /**
-     * Returns the size of the packed vector datastructure with `elements` packed elements (the size
-     * of
+     * Returns the size of the packed vector datastructure with `elements` packed elements (the size of
      * its underlying uint64 vector)
      */
     inline static std::size_t elements_to_blocks(std::size_t elements)
@@ -95,14 +96,14 @@ template <typename T, bool UseSharedMemory = false> class PackedVector
         if (left_index == 0)
         {
             // ID is at the far left side of this element
-            return T{elem >> (ELEMSIZE - BITSIZE)};
+            return static_cast<T>(elem >> (ELEMSIZE - BITSIZE));
         }
         else if (left_index >= BITSIZE)
         {
             // ID is entirely contained within this element
             const std::uint64_t at_right = elem >> (left_index - BITSIZE);
             const std::uint64_t left_mask = static_cast<std::uint64_t>(pow(2, BITSIZE)) - 1;
-            return T{at_right & left_mask};
+            return static_cast<T>(at_right & left_mask);
         }
         else
         {
@@ -114,7 +115,7 @@ template <typename T, bool UseSharedMemory = false> class PackedVector
             const std::uint64_t next_elem = static_cast<std::uint64_t>(vec.at(index + 1));
 
             const std::uint64_t right_side = next_elem >> (ELEMSIZE - (BITSIZE - left_index));
-            return T{left_side | right_side};
+            return static_cast<T>(left_side | right_side);
         }
     }
 

include/util/rectangle.hpp

@@ -23,10 +23,10 @@ namespace util
 struct RectangleInt2D
 {
     RectangleInt2D()
-        : min_lon{std::numeric_limits<std::int32_t>::max()},
-          max_lon{std::numeric_limits<std::int32_t>::min()},
-          min_lat{std::numeric_limits<std::int32_t>::max()},
-          max_lat{std::numeric_limits<std::int32_t>::min()}
+        : min_lon(std::numeric_limits<std::int32_t>::max()),
+          max_lon(std::numeric_limits<std::int32_t>::min()),
+          min_lat(std::numeric_limits<std::int32_t>::max()),
+          max_lat(std::numeric_limits<std::int32_t>::min())
     {
     }
 
@@ -56,10 +56,10 @@ struct RectangleInt2D
         max_lon = std::max(max_lon, other.max_lon);
         min_lat = std::min(min_lat, other.min_lat);
         max_lat = std::max(max_lat, other.max_lat);
-        BOOST_ASSERT(min_lon != FixedLongitude{std::numeric_limits<std::int32_t>::min()});
-        BOOST_ASSERT(min_lat != FixedLatitude{std::numeric_limits<std::int32_t>::min()});
-        BOOST_ASSERT(max_lon != FixedLongitude{std::numeric_limits<std::int32_t>::min()});
-        BOOST_ASSERT(max_lat != FixedLatitude{std::numeric_limits<std::int32_t>::min()});
+        BOOST_ASSERT(min_lon != FixedLongitude(std::numeric_limits<std::int32_t>::min()));
+        BOOST_ASSERT(min_lat != FixedLatitude(std::numeric_limits<std::int32_t>::min()));
+        BOOST_ASSERT(max_lon != FixedLongitude(std::numeric_limits<std::int32_t>::min()));
+        BOOST_ASSERT(max_lat != FixedLatitude(std::numeric_limits<std::int32_t>::min()));
     }
 
     Coordinate Centroid() const
@@ -67,8 +67,8 @@ struct RectangleInt2D
         Coordinate centroid;
         // The coordinates of the midpoints are given by:
         // x = (x1 + x2) /2 and y = (y1 + y2) /2.
-        centroid.lon = (min_lon + max_lon) / FixedLongitude{2};
-        centroid.lat = (min_lat + max_lat) / FixedLatitude{2};
+        centroid.lon = (min_lon + max_lon) / FixedLongitude(2);
+        centroid.lat = (min_lat + max_lat) / FixedLatitude(2);
         return centroid;
     }
 
@@ -169,10 +169,10 @@ struct RectangleInt2D
 
     bool IsValid() const
     {
-        return min_lon != FixedLongitude{std::numeric_limits<std::int32_t>::max()} &&
-               max_lon != FixedLongitude{std::numeric_limits<std::int32_t>::min()} &&
-               min_lat != FixedLatitude{std::numeric_limits<std::int32_t>::max()} &&
-               max_lat != FixedLatitude{std::numeric_limits<std::int32_t>::min()};
+        return min_lon != FixedLongitude(std::numeric_limits<std::int32_t>::max()) &&
+               max_lon != FixedLongitude(std::numeric_limits<std::int32_t>::min()) &&
+               min_lat != FixedLatitude(std::numeric_limits<std::int32_t>::max()) &&
+               max_lat != FixedLatitude(std::numeric_limits<std::int32_t>::min());
     }
 
     friend std::ostream &operator<<(std::ostream &out, const RectangleInt2D &rect);

include/util/static_rtree.hpp

@@ -193,8 +193,8 @@ class StaticRTree
                     Coordinate current_centroid = coordinate_calculation::centroid(
                         m_coordinate_list[current_element.u], m_coordinate_list[current_element.v]);
                     current_centroid.lat =
-                        FixedLatitude{static_cast<std::int32_t>(COORDINATE_PRECISION *
-                                      web_mercator::latToY(toFloating(current_centroid.lat)))};
+                        FixedLatitude(COORDINATE_PRECISION *
+                                      web_mercator::latToY(toFloating(current_centroid.lat)));
 
                     current_wrapper.m_hilbert_value = hilbertCode(current_centroid);
                 }

include/util/strong_typedef.hpp

@@ -40,32 +40,32 @@ namespace osrm
  * etc.  Also clarifies what this random "int" value is
  * being used for.
  */
-#define OSRM_STRONG_TYPEDEF(From, To)                                                                    \
-    struct To final                                                                                      \
-    {                                                                                                    \
-        static_assert(std::is_arithmetic<From>(), "");                                                   \
-        From __value;                                                                                    \
-        friend std::ostream &operator<<(std::ostream &stream, const To &inst);                           \
-                                                                                                         \
-        explicit operator From &() { return __value; }                                                   \
-        explicit operator From() const { return __value; }                                               \
-        To operator+(const To rhs_) const { return To{__value + static_cast<const From>(rhs_)}; }        \
-        To operator-(const To rhs_) const { return To{__value - static_cast<const From>(rhs_)}; }        \
-        To operator*(const To rhs_) const { return To{__value * static_cast<const From>(rhs_)}; }        \
-        To operator/(const To rhs_) const { return To{__value / static_cast<const From>(rhs_)}; }        \
-        bool operator<(const To z_) const { return __value < static_cast<const From>(z_); }              \
-        bool operator>(const To z_) const { return __value > static_cast<const From>(z_); }              \
-        bool operator<=(const To z_) const { return __value <= static_cast<const From>(z_); }            \
-        bool operator>=(const To z_) const { return __value >= static_cast<const From>(z_); }            \
-        bool operator==(const To z_) const { return __value == static_cast<const From>(z_); }            \
-        bool operator!=(const To z_) const { return __value != static_cast<const From>(z_); }            \
-    };                                                                                                   \
-    static_assert(std::is_trivial<To>(), #To " is not a trivial type");                                \
-    static_assert(std::is_standard_layout<To>(), #To " is not a standart layout");                     \
-    static_assert(std::is_pod<To>(), #To " is not a POD layout");                                      \
-    inline std::ostream &operator<<(std::ostream &stream, const To &inst)                                \
-    {                                                                                                    \
-        return stream << inst.__value;                                                                   \
+#define OSRM_STRONG_TYPEDEF(From, To)                                                              \
+    class To final                                                                                 \
+    {                                                                                              \
+        static_assert(std::is_arithmetic<From>(), "");                                             \
+        From x;                                                                                    \
+        friend std::ostream &operator<<(std::ostream &stream, const To &inst);                     \
+                                                                                                   \
+      public:                                                                                      \
+        To() = default;                                                                            \
+        explicit To(const From x_) : x(x_) {}                                                      \
+        explicit operator From &() { return x; }                                                   \
+        explicit operator From() const { return x; }                                               \
+        To operator+(const To rhs_) const { return To(x + static_cast<const From>(rhs_)); }        \
+        To operator-(const To rhs_) const { return To(x - static_cast<const From>(rhs_)); }        \
+        To operator*(const To rhs_) const { return To(x * static_cast<const From>(rhs_)); }        \
+        To operator/(const To rhs_) const { return To(x / static_cast<const From>(rhs_)); }        \
+        bool operator<(const To z_) const { return x < static_cast<const From>(z_); }              \
+        bool operator>(const To z_) const { return x > static_cast<const From>(z_); }              \
+        bool operator<=(const To z_) const { return x <= static_cast<const From>(z_); }            \
+        bool operator>=(const To z_) const { return x >= static_cast<const From>(z_); }            \
+        bool operator==(const To z_) const { return x == static_cast<const From>(z_); }            \
+        bool operator!=(const To z_) const { return x != static_cast<const From>(z_); }            \
+    };                                                                                             \
+    inline std::ostream &operator<<(std::ostream &stream, const To &inst)                          \
+    {                                                                                              \
+        return stream << inst.x;                                                                   \
     }
 
 #define OSRM_STRONG_TYPEDEF_HASHABLE(From, To)                                                     \