Fix review comments

This commit is contained in:
Siarhei Fedartsou 2024-06-06 21:03:08 +02:00
parent 55529beb29
commit 7f8be69001
2 changed files with 3 additions and 1 deletions

View File

@ -703,7 +703,7 @@ jobs:
run: | run: |
ccache -p ccache -p
ccache -s ccache -s
ci-complete: ci-complete:
runs-on: ubuntu-22.04 runs-on: ubuntu-22.04
needs: [build-test-publish, docker-image, windows-release-node, benchmarks] needs: [build-test-publish, docker-image, windows-release-node, benchmarks]

View File

@ -19417,6 +19417,7 @@ namespace sol { namespace function_detail {
template <bool is_yielding, bool no_trampoline> template <bool is_yielding, bool no_trampoline>
static int call(lua_State* L) static int call(lua_State* L)
// see https://github.com/ThePhD/sol2/issues/1581#issuecomment-2103463524
#if SOL_IS_ON(SOL_COMPILER_CLANG) #if SOL_IS_ON(SOL_COMPILER_CLANG)
// apparent regression in clang 18 - llvm/llvm-project#91362 // apparent regression in clang 18 - llvm/llvm-project#91362
#else #else
@ -19463,6 +19464,7 @@ namespace sol { namespace function_detail {
template <bool is_yielding, bool no_trampoline> template <bool is_yielding, bool no_trampoline>
static int call(lua_State* L) static int call(lua_State* L)
// see https://github.com/ThePhD/sol2/issues/1581#issuecomment-2103463524
#if SOL_IS_ON(SOL_COMPILER_CLANG) #if SOL_IS_ON(SOL_COMPILER_CLANG)
// apparent regression in clang 18 - llvm/llvm-project#91362 // apparent regression in clang 18 - llvm/llvm-project#91362
#else #else