From 7f8be690018c0fcd9315b9da947694a773682664 Mon Sep 17 00:00:00 2001 From: Siarhei Fedartsou Date: Thu, 6 Jun 2024 21:03:08 +0200 Subject: [PATCH] Fix review comments --- .github/workflows/osrm-backend.yml | 2 +- third_party/sol2/include/sol/sol.hpp | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/osrm-backend.yml b/.github/workflows/osrm-backend.yml index 827b1f10b..e787b31c6 100644 --- a/.github/workflows/osrm-backend.yml +++ b/.github/workflows/osrm-backend.yml @@ -703,7 +703,7 @@ jobs: run: | ccache -p ccache -s - + ci-complete: runs-on: ubuntu-22.04 needs: [build-test-publish, docker-image, windows-release-node, benchmarks] diff --git a/third_party/sol2/include/sol/sol.hpp b/third_party/sol2/include/sol/sol.hpp index 1fc55bf8d..d7da763f7 100644 --- a/third_party/sol2/include/sol/sol.hpp +++ b/third_party/sol2/include/sol/sol.hpp @@ -19417,6 +19417,7 @@ namespace sol { namespace function_detail { template static int call(lua_State* L) +// see https://github.com/ThePhD/sol2/issues/1581#issuecomment-2103463524 #if SOL_IS_ON(SOL_COMPILER_CLANG) // apparent regression in clang 18 - llvm/llvm-project#91362 #else @@ -19463,6 +19464,7 @@ namespace sol { namespace function_detail { template static int call(lua_State* L) +// see https://github.com/ThePhD/sol2/issues/1581#issuecomment-2103463524 #if SOL_IS_ON(SOL_COMPILER_CLANG) // apparent regression in clang 18 - llvm/llvm-project#91362 #else