Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

clean up derived classed and their functions to correctly use final keyword:

Browse Source 
functions marked as final need to be marked virtual. use override specifier to do so
This commit is contained in:
Dennis Luxen
2015-01-28 10:10:28 +01:00
parent 86ca9bd0f9
commit 2a8084b6c6
12 changed files with 148 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/distance_table.hpp
+3 -2
View File
@@ -65,9 +65,10 @@ template <class DataFacadeT> class DistanceTablePlugin final : public BasePlugin
virtual ~DistanceTablePlugin() {}
const std::string GetDescriptor() const final { return descriptor_string; }
const std::string GetDescriptor() const override final { return descriptor_string; }
int HandleRequest(const RouteParameters &route_parameters, JSON::Object &json_result) final
int HandleRequest(const RouteParameters &route_parameters,
JSON::Object &json_result) override final
{
if (!check_all_coordinates(route_parameters.coordinates))
{
plugins/hello_world.hpp
+3 -2
View File
@@ -45,9 +45,10 @@ class HelloWorldPlugin final : public BasePlugin
public:
HelloWorldPlugin() : descriptor_string("hello") {}
virtual ~HelloWorldPlugin() {}
const std::string GetDescriptor() const final { return descriptor_string; }
const std::string GetDescriptor() const override final { return descriptor_string; }
int HandleRequest(const RouteParameters &routeParameters, JSON::Object &json_result) final
int HandleRequest(const RouteParameters &routeParameters,
JSON::Object &json_result) override final
{
std::string temp_string;
json_result.values["title"] = "Hello World";
plugins/locate.hpp
+3 -2
View File
@@ -42,9 +42,10 @@ template <class DataFacadeT> class LocatePlugin final : public BasePlugin
{
public:
explicit LocatePlugin(DataFacadeT *facade) : descriptor_string("locate"), facade(facade) {}
const std::string GetDescriptor() const final { return descriptor_string; }
const std::string GetDescriptor() const override final { return descriptor_string; }
int HandleRequest(const RouteParameters &route_parameters, JSON::Object &json_result) final
int HandleRequest(const RouteParameters &route_parameters,
JSON::Object &json_result) override final
{
// check number of parameters
if (route_parameters.coordinates.empty() ||
plugins/nearest.hpp
+3 -2
View File
@@ -47,9 +47,10 @@ template <class DataFacadeT> class NearestPlugin final : public BasePlugin
public:
explicit NearestPlugin(DataFacadeT *facade) : facade(facade), descriptor_string("nearest") {}
const std::string GetDescriptor() const final { return descriptor_string; }
const std::string GetDescriptor() const override final { return descriptor_string; }
int HandleRequest(const RouteParameters &route_parameters, JSON::Object &json_result) final
int HandleRequest(const RouteParameters &route_parameters,
JSON::Object &json_result) override final
{
// check number of parameters
if (route_parameters.coordinates.empty() ||
plugins/timestamp.hpp
+3 -2
View File
@@ -43,8 +43,9 @@ template <class DataFacadeT> class TimestampPlugin final : public BasePlugin
: facade(facade), descriptor_string("timestamp")
{
}
const std::string GetDescriptor() const final { return descriptor_string; }
int HandleRequest(const RouteParameters &route_parameters, JSON::Object &json_result) final
const std::string GetDescriptor() const override final { return descriptor_string; }
int HandleRequest(const RouteParameters &route_parameters,
JSON::Object &json_result) override final
{
json_result.values["status"] = 0;
const std::string timestamp = facade->GetTimestamp();
plugins/viaroute.hpp
+3 -2
View File
@@ -69,9 +69,10 @@ template <class DataFacadeT> class ViaRoutePlugin final : public BasePlugin
virtual ~ViaRoutePlugin() {}
const std::string GetDescriptor() const final { return descriptor_string; }
const std::string GetDescriptor() const override final { return descriptor_string; }
int HandleRequest(const RouteParameters &route_parameters, JSON::Object &json_result) final
int HandleRequest(const RouteParameters &route_parameters,
JSON::Object &json_result) override final
{
if (!check_all_coordinates(route_parameters.coordinates))
{