diff --git a/Server/data_structures/internal_datafacade.hpp b/Server/data_structures/internal_datafacade.hpp index 8a481c5c5..0a246b791 100644 --- a/Server/data_structures/internal_datafacade.hpp +++ b/Server/data_structures/internal_datafacade.hpp @@ -46,7 +46,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #include #include -template class InternalDataFacade : public BaseDataFacade +template class InternalDataFacade final : public BaseDataFacade { private: @@ -309,52 +309,60 @@ template class InternalDataFacade : public BaseDataFacadeGetNumberOfNodes(); } + unsigned GetNumberOfNodes() const override final { return m_query_graph->GetNumberOfNodes(); } - unsigned GetNumberOfEdges() const final { return m_query_graph->GetNumberOfEdges(); } + unsigned GetNumberOfEdges() const override final { return m_query_graph->GetNumberOfEdges(); } - unsigned GetOutDegree(const NodeID n) const final { return m_query_graph->GetOutDegree(n); } + unsigned GetOutDegree(const NodeID n) const override final + { + return m_query_graph->GetOutDegree(n); + } - NodeID GetTarget(const EdgeID e) const final { return m_query_graph->GetTarget(e); } + NodeID GetTarget(const EdgeID e) const override final { return m_query_graph->GetTarget(e); } - // EdgeDataT &GetEdgeData(const EdgeID e) final { return m_query_graph->GetEdgeData(e); } + // EdgeDataT &GetEdgeData(const EdgeID e) override final { return m_query_graph->GetEdgeData(e); + // } - EdgeDataT &GetEdgeData(const EdgeID e) const final { return m_query_graph->GetEdgeData(e); } + EdgeDataT &GetEdgeData(const EdgeID e) const override final + { + return m_query_graph->GetEdgeData(e); + } - EdgeID BeginEdges(const NodeID n) const final { return m_query_graph->BeginEdges(n); } + EdgeID BeginEdges(const NodeID n) const override final { return m_query_graph->BeginEdges(n); } - EdgeID EndEdges(const NodeID n) const final { return m_query_graph->EndEdges(n); } + EdgeID EndEdges(const NodeID n) const override final { return m_query_graph->EndEdges(n); } - EdgeRange GetAdjacentEdgeRange(const NodeID node) const final + EdgeRange GetAdjacentEdgeRange(const NodeID node) const override final { return m_query_graph->GetAdjacentEdgeRange(node); }; // searches for a specific edge - EdgeID FindEdge(const NodeID from, const NodeID to) const final + EdgeID FindEdge(const NodeID from, const NodeID to) const override final { return m_query_graph->FindEdge(from, to); } - EdgeID FindEdgeInEitherDirection(const NodeID from, const NodeID to) const final + EdgeID FindEdgeInEitherDirection(const NodeID from, const NodeID to) const override final { return m_query_graph->FindEdgeInEitherDirection(from, to); } - EdgeID FindEdgeIndicateIfReverse(const NodeID from, const NodeID to, bool &result) const final + EdgeID + FindEdgeIndicateIfReverse(const NodeID from, const NodeID to, bool &result) const override final { return m_query_graph->FindEdgeIndicateIfReverse(from, to, result); } // node and edge information access - FixedPointCoordinate GetCoordinateOfNode(const unsigned id) const final + FixedPointCoordinate GetCoordinateOfNode(const unsigned id) const override final { return m_coordinate_list->at(id); }; bool EdgeIsCompressed(const unsigned id) const { return m_edge_is_compressed.at(id); } - TurnInstruction GetTurnInstructionForEdgeID(const unsigned id) const final + TurnInstruction GetTurnInstructionForEdgeID(const unsigned id) const override final { return m_turn_instruction_list.at(id); } @@ -363,7 +371,7 @@ template class InternalDataFacade : public BaseDataFacade class InternalDataFacade : public BaseDataFacade resulting_phantom_node_vector; auto result = IncrementalFindPhantomNodeForCoordinate(input_coordinate, @@ -391,7 +399,7 @@ template class InternalDataFacade : public BaseDataFacade &resulting_phantom_node_vector, - const unsigned number_of_results) final + const unsigned number_of_results) override final { if (!m_static_rtree.get()) { @@ -402,14 +410,14 @@ template class InternalDataFacade : public BaseDataFacade class InternalDataFacade : public BaseDataFacade &result_nodes) const final + std::vector &result_nodes) const override final { const unsigned begin = m_geometry_indices.at(id); const unsigned end = m_geometry_indices.at(id + 1); @@ -443,7 +451,7 @@ template class InternalDataFacade : public BaseDataFacade #include -template class SharedDataFacade : public BaseDataFacade +template class SharedDataFacade final : public BaseDataFacade { private: @@ -282,54 +282,61 @@ template class SharedDataFacade : public BaseDataFacadeGetNumberOfNodes(); } + unsigned GetNumberOfNodes() const override final { return m_query_graph->GetNumberOfNodes(); } - unsigned GetNumberOfEdges() const final { return m_query_graph->GetNumberOfEdges(); } + unsigned GetNumberOfEdges() const override final { return m_query_graph->GetNumberOfEdges(); } - unsigned GetOutDegree(const NodeID n) const final { return m_query_graph->GetOutDegree(n); } + unsigned GetOutDegree(const NodeID n) const override final + { + return m_query_graph->GetOutDegree(n); + } - NodeID GetTarget(const EdgeID e) const final { return m_query_graph->GetTarget(e); } + NodeID GetTarget(const EdgeID e) const override final { return m_query_graph->GetTarget(e); } - EdgeDataT &GetEdgeData(const EdgeID e) const final { return m_query_graph->GetEdgeData(e); } + EdgeDataT &GetEdgeData(const EdgeID e) const override final + { + return m_query_graph->GetEdgeData(e); + } - EdgeID BeginEdges(const NodeID n) const final { return m_query_graph->BeginEdges(n); } + EdgeID BeginEdges(const NodeID n) const override final { return m_query_graph->BeginEdges(n); } - EdgeID EndEdges(const NodeID n) const final { return m_query_graph->EndEdges(n); } + EdgeID EndEdges(const NodeID n) const override final { return m_query_graph->EndEdges(n); } - EdgeRange GetAdjacentEdgeRange(const NodeID node) const final + EdgeRange GetAdjacentEdgeRange(const NodeID node) const override final { return m_query_graph->GetAdjacentEdgeRange(node); }; // searches for a specific edge - EdgeID FindEdge(const NodeID from, const NodeID to) const final + EdgeID FindEdge(const NodeID from, const NodeID to) const override final { return m_query_graph->FindEdge(from, to); } - EdgeID FindEdgeInEitherDirection(const NodeID from, const NodeID to) const final + EdgeID FindEdgeInEitherDirection(const NodeID from, const NodeID to) const override final { return m_query_graph->FindEdgeInEitherDirection(from, to); } - EdgeID FindEdgeIndicateIfReverse(const NodeID from, const NodeID to, bool &result) const final + EdgeID + FindEdgeIndicateIfReverse(const NodeID from, const NodeID to, bool &result) const override final { return m_query_graph->FindEdgeIndicateIfReverse(from, to, result); } // node and edge information access - FixedPointCoordinate GetCoordinateOfNode(const NodeID id) const final + FixedPointCoordinate GetCoordinateOfNode(const NodeID id) const override final { return m_coordinate_list->at(id); }; - virtual bool EdgeIsCompressed(const unsigned id) const final + virtual bool EdgeIsCompressed(const unsigned id) const override final { return m_edge_is_compressed.at(id); } virtual void GetUncompressedGeometry(const unsigned id, - std::vector &result_nodes) const final + std::vector &result_nodes) const override final { const unsigned begin = m_geometry_indices.at(id); const unsigned end = m_geometry_indices.at(id + 1); @@ -339,12 +346,12 @@ template class SharedDataFacade : public BaseDataFacade class SharedDataFacade : public BaseDataFacadefirst) { @@ -365,7 +372,7 @@ template class SharedDataFacade : public BaseDataFacade resulting_phantom_node_vector; auto result = IncrementalFindPhantomNodeForCoordinate(input_coordinate, @@ -381,7 +388,7 @@ template class SharedDataFacade : public BaseDataFacade &resulting_phantom_node_vector, - const unsigned number_of_results) final + const unsigned number_of_results) override final { if (!m_static_rtree.get() || CURRENT_TIMESTAMP != m_static_rtree->first) { @@ -392,14 +399,14 @@ template class SharedDataFacade : public BaseDataFacade class SharedDataFacade : public BaseDataFacade class GPXDescriptor final : public BaseDescriptor class JSONDescriptor final : public BaseDescriptor< { } - void SetConfig(const DescriptorConfig &c) final { config = c; } + void SetConfig(const DescriptorConfig &c) override final { config = c; } unsigned DescribeLeg(const std::vector route_leg, const PhantomNodes &leg_phantoms, @@ -100,7 +100,7 @@ template class JSONDescriptor final : public BaseDescriptor< return added_element_count; } - void Run(const InternalRouteResult &raw_route, JSON::Object &json_result) final + void Run(const InternalRouteResult &raw_route, JSON::Object &json_result) override final { if (INVALID_EDGE_WEIGHT == raw_route.shortest_path_length) { diff --git a/plugins/distance_table.hpp b/plugins/distance_table.hpp index b7483f16f..0a8912640 100644 --- a/plugins/distance_table.hpp +++ b/plugins/distance_table.hpp @@ -65,9 +65,10 @@ template class DistanceTablePlugin final : public BasePlugin virtual ~DistanceTablePlugin() {} - const std::string GetDescriptor() const final { return descriptor_string; } + const std::string GetDescriptor() const override final { return descriptor_string; } - int HandleRequest(const RouteParameters &route_parameters, JSON::Object &json_result) final + int HandleRequest(const RouteParameters &route_parameters, + JSON::Object &json_result) override final { if (!check_all_coordinates(route_parameters.coordinates)) { diff --git a/plugins/hello_world.hpp b/plugins/hello_world.hpp index 97c03095b..5b08663db 100644 --- a/plugins/hello_world.hpp +++ b/plugins/hello_world.hpp @@ -45,9 +45,10 @@ class HelloWorldPlugin final : public BasePlugin public: HelloWorldPlugin() : descriptor_string("hello") {} virtual ~HelloWorldPlugin() {} - const std::string GetDescriptor() const final { return descriptor_string; } + const std::string GetDescriptor() const override final { return descriptor_string; } - int HandleRequest(const RouteParameters &routeParameters, JSON::Object &json_result) final + int HandleRequest(const RouteParameters &routeParameters, + JSON::Object &json_result) override final { std::string temp_string; json_result.values["title"] = "Hello World"; diff --git a/plugins/locate.hpp b/plugins/locate.hpp index 262935a67..260361462 100644 --- a/plugins/locate.hpp +++ b/plugins/locate.hpp @@ -42,9 +42,10 @@ template class LocatePlugin final : public BasePlugin { public: explicit LocatePlugin(DataFacadeT *facade) : descriptor_string("locate"), facade(facade) {} - const std::string GetDescriptor() const final { return descriptor_string; } + const std::string GetDescriptor() const override final { return descriptor_string; } - int HandleRequest(const RouteParameters &route_parameters, JSON::Object &json_result) final + int HandleRequest(const RouteParameters &route_parameters, + JSON::Object &json_result) override final { // check number of parameters if (route_parameters.coordinates.empty() || diff --git a/plugins/nearest.hpp b/plugins/nearest.hpp index 9add3040b..6221fcfb3 100644 --- a/plugins/nearest.hpp +++ b/plugins/nearest.hpp @@ -47,9 +47,10 @@ template class NearestPlugin final : public BasePlugin public: explicit NearestPlugin(DataFacadeT *facade) : facade(facade), descriptor_string("nearest") {} - const std::string GetDescriptor() const final { return descriptor_string; } + const std::string GetDescriptor() const override final { return descriptor_string; } - int HandleRequest(const RouteParameters &route_parameters, JSON::Object &json_result) final + int HandleRequest(const RouteParameters &route_parameters, + JSON::Object &json_result) override final { // check number of parameters if (route_parameters.coordinates.empty() || diff --git a/plugins/timestamp.hpp b/plugins/timestamp.hpp index b86174a50..db265ec47 100644 --- a/plugins/timestamp.hpp +++ b/plugins/timestamp.hpp @@ -43,8 +43,9 @@ template class TimestampPlugin final : public BasePlugin : facade(facade), descriptor_string("timestamp") { } - const std::string GetDescriptor() const final { return descriptor_string; } - int HandleRequest(const RouteParameters &route_parameters, JSON::Object &json_result) final + const std::string GetDescriptor() const override final { return descriptor_string; } + int HandleRequest(const RouteParameters &route_parameters, + JSON::Object &json_result) override final { json_result.values["status"] = 0; const std::string timestamp = facade->GetTimestamp(); diff --git a/plugins/viaroute.hpp b/plugins/viaroute.hpp index b253baa1c..630cba579 100644 --- a/plugins/viaroute.hpp +++ b/plugins/viaroute.hpp @@ -69,9 +69,10 @@ template class ViaRoutePlugin final : public BasePlugin virtual ~ViaRoutePlugin() {} - const std::string GetDescriptor() const final { return descriptor_string; } + const std::string GetDescriptor() const override final { return descriptor_string; } - int HandleRequest(const RouteParameters &route_parameters, JSON::Object &json_result) final + int HandleRequest(const RouteParameters &route_parameters, + JSON::Object &json_result) override final { if (!check_all_coordinates(route_parameters.coordinates)) { diff --git a/server/data_structures/internal_datafacade.hpp b/server/data_structures/internal_datafacade.hpp index 8a481c5c5..0a246b791 100644 --- a/server/data_structures/internal_datafacade.hpp +++ b/server/data_structures/internal_datafacade.hpp @@ -46,7 +46,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #include #include -template class InternalDataFacade : public BaseDataFacade +template class InternalDataFacade final : public BaseDataFacade { private: @@ -309,52 +309,60 @@ template class InternalDataFacade : public BaseDataFacadeGetNumberOfNodes(); } + unsigned GetNumberOfNodes() const override final { return m_query_graph->GetNumberOfNodes(); } - unsigned GetNumberOfEdges() const final { return m_query_graph->GetNumberOfEdges(); } + unsigned GetNumberOfEdges() const override final { return m_query_graph->GetNumberOfEdges(); } - unsigned GetOutDegree(const NodeID n) const final { return m_query_graph->GetOutDegree(n); } + unsigned GetOutDegree(const NodeID n) const override final + { + return m_query_graph->GetOutDegree(n); + } - NodeID GetTarget(const EdgeID e) const final { return m_query_graph->GetTarget(e); } + NodeID GetTarget(const EdgeID e) const override final { return m_query_graph->GetTarget(e); } - // EdgeDataT &GetEdgeData(const EdgeID e) final { return m_query_graph->GetEdgeData(e); } + // EdgeDataT &GetEdgeData(const EdgeID e) override final { return m_query_graph->GetEdgeData(e); + // } - EdgeDataT &GetEdgeData(const EdgeID e) const final { return m_query_graph->GetEdgeData(e); } + EdgeDataT &GetEdgeData(const EdgeID e) const override final + { + return m_query_graph->GetEdgeData(e); + } - EdgeID BeginEdges(const NodeID n) const final { return m_query_graph->BeginEdges(n); } + EdgeID BeginEdges(const NodeID n) const override final { return m_query_graph->BeginEdges(n); } - EdgeID EndEdges(const NodeID n) const final { return m_query_graph->EndEdges(n); } + EdgeID EndEdges(const NodeID n) const override final { return m_query_graph->EndEdges(n); } - EdgeRange GetAdjacentEdgeRange(const NodeID node) const final + EdgeRange GetAdjacentEdgeRange(const NodeID node) const override final { return m_query_graph->GetAdjacentEdgeRange(node); }; // searches for a specific edge - EdgeID FindEdge(const NodeID from, const NodeID to) const final + EdgeID FindEdge(const NodeID from, const NodeID to) const override final { return m_query_graph->FindEdge(from, to); } - EdgeID FindEdgeInEitherDirection(const NodeID from, const NodeID to) const final + EdgeID FindEdgeInEitherDirection(const NodeID from, const NodeID to) const override final { return m_query_graph->FindEdgeInEitherDirection(from, to); } - EdgeID FindEdgeIndicateIfReverse(const NodeID from, const NodeID to, bool &result) const final + EdgeID + FindEdgeIndicateIfReverse(const NodeID from, const NodeID to, bool &result) const override final { return m_query_graph->FindEdgeIndicateIfReverse(from, to, result); } // node and edge information access - FixedPointCoordinate GetCoordinateOfNode(const unsigned id) const final + FixedPointCoordinate GetCoordinateOfNode(const unsigned id) const override final { return m_coordinate_list->at(id); }; bool EdgeIsCompressed(const unsigned id) const { return m_edge_is_compressed.at(id); } - TurnInstruction GetTurnInstructionForEdgeID(const unsigned id) const final + TurnInstruction GetTurnInstructionForEdgeID(const unsigned id) const override final { return m_turn_instruction_list.at(id); } @@ -363,7 +371,7 @@ template class InternalDataFacade : public BaseDataFacade class InternalDataFacade : public BaseDataFacade resulting_phantom_node_vector; auto result = IncrementalFindPhantomNodeForCoordinate(input_coordinate, @@ -391,7 +399,7 @@ template class InternalDataFacade : public BaseDataFacade &resulting_phantom_node_vector, - const unsigned number_of_results) final + const unsigned number_of_results) override final { if (!m_static_rtree.get()) { @@ -402,14 +410,14 @@ template class InternalDataFacade : public BaseDataFacade class InternalDataFacade : public BaseDataFacade &result_nodes) const final + std::vector &result_nodes) const override final { const unsigned begin = m_geometry_indices.at(id); const unsigned end = m_geometry_indices.at(id + 1); @@ -443,7 +451,7 @@ template class InternalDataFacade : public BaseDataFacade #include -template class SharedDataFacade : public BaseDataFacade +template class SharedDataFacade final : public BaseDataFacade { private: @@ -282,54 +282,61 @@ template class SharedDataFacade : public BaseDataFacadeGetNumberOfNodes(); } + unsigned GetNumberOfNodes() const override final { return m_query_graph->GetNumberOfNodes(); } - unsigned GetNumberOfEdges() const final { return m_query_graph->GetNumberOfEdges(); } + unsigned GetNumberOfEdges() const override final { return m_query_graph->GetNumberOfEdges(); } - unsigned GetOutDegree(const NodeID n) const final { return m_query_graph->GetOutDegree(n); } + unsigned GetOutDegree(const NodeID n) const override final + { + return m_query_graph->GetOutDegree(n); + } - NodeID GetTarget(const EdgeID e) const final { return m_query_graph->GetTarget(e); } + NodeID GetTarget(const EdgeID e) const override final { return m_query_graph->GetTarget(e); } - EdgeDataT &GetEdgeData(const EdgeID e) const final { return m_query_graph->GetEdgeData(e); } + EdgeDataT &GetEdgeData(const EdgeID e) const override final + { + return m_query_graph->GetEdgeData(e); + } - EdgeID BeginEdges(const NodeID n) const final { return m_query_graph->BeginEdges(n); } + EdgeID BeginEdges(const NodeID n) const override final { return m_query_graph->BeginEdges(n); } - EdgeID EndEdges(const NodeID n) const final { return m_query_graph->EndEdges(n); } + EdgeID EndEdges(const NodeID n) const override final { return m_query_graph->EndEdges(n); } - EdgeRange GetAdjacentEdgeRange(const NodeID node) const final + EdgeRange GetAdjacentEdgeRange(const NodeID node) const override final { return m_query_graph->GetAdjacentEdgeRange(node); }; // searches for a specific edge - EdgeID FindEdge(const NodeID from, const NodeID to) const final + EdgeID FindEdge(const NodeID from, const NodeID to) const override final { return m_query_graph->FindEdge(from, to); } - EdgeID FindEdgeInEitherDirection(const NodeID from, const NodeID to) const final + EdgeID FindEdgeInEitherDirection(const NodeID from, const NodeID to) const override final { return m_query_graph->FindEdgeInEitherDirection(from, to); } - EdgeID FindEdgeIndicateIfReverse(const NodeID from, const NodeID to, bool &result) const final + EdgeID + FindEdgeIndicateIfReverse(const NodeID from, const NodeID to, bool &result) const override final { return m_query_graph->FindEdgeIndicateIfReverse(from, to, result); } // node and edge information access - FixedPointCoordinate GetCoordinateOfNode(const NodeID id) const final + FixedPointCoordinate GetCoordinateOfNode(const NodeID id) const override final { return m_coordinate_list->at(id); }; - virtual bool EdgeIsCompressed(const unsigned id) const final + virtual bool EdgeIsCompressed(const unsigned id) const override final { return m_edge_is_compressed.at(id); } virtual void GetUncompressedGeometry(const unsigned id, - std::vector &result_nodes) const final + std::vector &result_nodes) const override final { const unsigned begin = m_geometry_indices.at(id); const unsigned end = m_geometry_indices.at(id + 1); @@ -339,12 +346,12 @@ template class SharedDataFacade : public BaseDataFacade class SharedDataFacade : public BaseDataFacadefirst) { @@ -365,7 +372,7 @@ template class SharedDataFacade : public BaseDataFacade resulting_phantom_node_vector; auto result = IncrementalFindPhantomNodeForCoordinate(input_coordinate, @@ -381,7 +388,7 @@ template class SharedDataFacade : public BaseDataFacade &resulting_phantom_node_vector, - const unsigned number_of_results) final + const unsigned number_of_results) override final { if (!m_static_rtree.get() || CURRENT_TIMESTAMP != m_static_rtree->first) { @@ -392,14 +399,14 @@ template class SharedDataFacade : public BaseDataFacade class SharedDataFacade : public BaseDataFacade