Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

clean up derived classed and their functions to correctly use final keyword:

Browse Source 
functions marked as final need to be marked virtual. use override specifier to do so
This commit is contained in:
Dennis Luxen
2015-01-28 10:10:28 +01:00
parent 86ca9bd0f9
commit 2a8084b6c6
12 changed files with 148 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files
descriptors/gpx_descriptor.hpp
+2 -2
View File
@@ -65,9 +65,9 @@ template <class DataFacadeT> class GPXDescriptor final : public BaseDescriptor<D
public:
explicit GPXDescriptor(DataFacadeT *facade) : facade(facade) {}
void SetConfig(const DescriptorConfig &c) final { config = c; }
virtual void SetConfig(const DescriptorConfig &c) final { config = c; }
void Run(const InternalRouteResult &raw_route, JSON::Object &json_result) final
virtual void Run(const InternalRouteResult &raw_route, JSON::Object &json_result) final
{
JSON::Array json_route;
if (raw_route.shortest_path_length != INVALID_EDGE_WEIGHT)
descriptors/json_descriptor.hpp
+2 -2
View File
@@ -77,7 +77,7 @@ template <class DataFacadeT> class JSONDescriptor final : public BaseDescriptor<
{
}
void SetConfig(const DescriptorConfig &c) final { config = c; }
void SetConfig(const DescriptorConfig &c) override final { config = c; }
unsigned DescribeLeg(const std::vector<PathData> route_leg,
const PhantomNodes &leg_phantoms,
@@ -100,7 +100,7 @@ template <class DataFacadeT> class JSONDescriptor final : public BaseDescriptor<
return added_element_count;
}
void Run(const InternalRouteResult &raw_route, JSON::Object &json_result) final
void Run(const InternalRouteResult &raw_route, JSON::Object &json_result) override final
{
if (INVALID_EDGE_WEIGHT == raw_route.shortest_path_length)
{