CODEX_ADK/BACKEND/code-review-local.sh
jean-philippe 5cd9702a81 feat: Code quality improvements and review infrastructure
Fixed all 13 code review issues achieving 100/100 quality score:
- Cache JsonSerializerOptions in GlobalExceptionHandler (CA1869)
- Convert constant arrays to static readonly fields (CA1861)
- Add code review infrastructure (Roslynator + SonarScanner)

Performance optimizations:
- Eliminated allocations in exception handling middleware
- Optimized validator array usage in commands
- Improved migration index creation efficiency

Code review tools:
- Added ./code-review-local.sh for local analysis
- Added Roslynator CLI configuration
- Added comprehensive code review guide

Cleanup:
- Removed outdated temporary documentation
- Updated .gitignore for code review artifacts
- Removed .DS_Store files

Build status:  0 errors, 0 warnings
Code analysis:  0 diagnostics found
Quality score: 100/100

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-26 19:26:44 -04:00

53 lines
2.4 KiB
Bash
Executable File

#!/bin/bash
# Local Code Review using Roslynator
# No external server required - uses installed analyzers
set -e
GREEN='\033[0;32m'
YELLOW='\033[1;33m'
BLUE='\033[0;34m'
RED='\033[0;31m'
NC='\033[0m'
echo -e "${GREEN}╔════════════════════════════════════════╗${NC}"
echo -e "${GREEN}║ CODEX Code Review - Local Analysis ║${NC}"
echo -e "${GREEN}╚════════════════════════════════════════╝${NC}\n"
# Restore tools
echo -e "${YELLOW}→ Restoring tools...${NC}"
dotnet tool restore > /dev/null 2>&1
# Clean
echo -e "${YELLOW}→ Cleaning build artifacts...${NC}"
dotnet clean > /dev/null 2>&1
# Analyze with Roslynator
echo -e "\n${BLUE}═══════════════════════════════════════${NC}"
echo -e "${BLUE} Running Roslynator Analysis${NC}"
echo -e "${BLUE}═══════════════════════════════════════${NC}\n"
dotnet roslynator analyze \
--severity-level info \
--output code-review-results.xml \
Codex.sln
echo -e "\n${BLUE}═══════════════════════════════════════${NC}"
echo -e "${BLUE} Code Formatting Check${NC}"
echo -e "${BLUE}═══════════════════════════════════════${NC}\n"
dotnet format --verify-no-changes --verbosity diagnostic || echo -e "${YELLOW}⚠ Formatting issues detected. Run 'dotnet format' to fix.${NC}"
echo -e "\n${GREEN}═══════════════════════════════════════${NC}"
echo -e "${GREEN} Code Review Complete!${NC}"
echo -e "${GREEN}═══════════════════════════════════════${NC}\n"
if [ -f "code-review-results.xml" ]; then
echo -e "${BLUE}📊 Results saved to: code-review-results.xml${NC}"
fi
echo -e "\n${YELLOW}Quick Commands:${NC}"
echo -e " ${BLUE}dotnet format${NC} - Auto-fix formatting"
echo -e " ${BLUE}dotnet roslynator fix${NC} - Auto-fix code issues"
echo -e " ${BLUE}dotnet build${NC} - Standard build\n"