c1e3fa1af0
All checks were successful
plugin-tests / test (push) Successful in 25s
Lands the easy migrations + the automation skeleton. STT migration deferred
to Phase 2.1 (it touches the streaming engine + bootstrap JS — needs a new
streaming_hook public-API method OR forced-internal CONNECTION-MAP entries).
Migrated to plugin:
routes/vault_status.py GET /api/vault/status (from fork commit 3e2c74f3)
static/{app.js,app.css,fonts/} brand skin (from hermes-ext/)
Plugin auto-loaded by hermes-webui when HERMES_WEBUI_PYTHON_PLUGIN is set;
register_static + inject_stylesheet + inject_script wire the URL contract at
/plugins/svrnty/{app.css,app.js} per protocol §14 (Q5).
Automation skeleton:
Makefile one-liner targets: test · map · sync-upstream · smoke
scripts/boot-smoke.py start upstream+plugin, curl every endpoint
scripts/upstream-sync.py fetch tags + run matrix + JSON report
tests/evals/test_features.py 4 evals (loader contract · vault payload · brand URL contract · forced-internal=0)
tests/unit/test_brand_skin.py 4 asset-presence + wiring tests
tests/unit/test_vault_status.py 3 handler tests (register, success, error)
CONNECTION-MAP.md: 0 forced-internal dependencies; plugin uses only public API.
AST script timestamp removed so map-check is deterministic.
Tests: 11/11 PASS (4 evals + 7 unit). Integration tests deferred until
boot-smoke runs against a live hermes-webui (Phase 2.D + 2.E gate).
Deferred to next session:
P2.A STT migration (needs streaming_hook design — see routes/transcribe.py)
P2.D Revert 4 fork feature commits — needs STT migration first
P2.E Archive hermes-ext repo — gated on P2.D
P2.F Live boot smoke against real webui
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
70 lines
2.1 KiB
Python
70 lines
2.1 KiB
Python
"""Unit tests for routes/vault_status.py — minimal one-test-per-feature (P3.B).
|
|
|
|
These tests confirm the handler shape + payload contract independently of a
|
|
running hermes-webui. Integration tests against a real webui live in
|
|
tests/integration/.
|
|
"""
|
|
import json
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from routes import vault_status
|
|
|
|
|
|
class _FakeHandler:
|
|
"""Minimal stand-in for the http.server handler the route receives."""
|
|
def __init__(self):
|
|
self.status = None
|
|
self.headers = {}
|
|
self.body = b""
|
|
|
|
def send_response(self, code):
|
|
self.status = code
|
|
|
|
def send_header(self, k, v):
|
|
self.headers[k] = v
|
|
|
|
def end_headers(self):
|
|
pass
|
|
|
|
@property
|
|
def wfile(self):
|
|
outer = self
|
|
|
|
class _W:
|
|
def write(self_inner, b):
|
|
outer.body += b
|
|
return _W()
|
|
|
|
|
|
def test_register_wires_one_route():
|
|
"""register() calls api.register_route exactly once for /api/vault/status."""
|
|
api = MagicMock()
|
|
vault_status.register(api)
|
|
api.register_route.assert_called_once()
|
|
args = api.register_route.call_args[0]
|
|
assert args[0] == "/api/vault/status"
|
|
assert args[1] == "GET"
|
|
|
|
|
|
def test_handler_returns_secrets_array_on_credctl_success():
|
|
"""credctl list output → JSON {'secrets': [{'name': X}, ...]}."""
|
|
sample = "gitea\nmailchimp\nwoocommerce\n"
|
|
with patch("routes.vault_status.subprocess.run") as run:
|
|
run.return_value = MagicMock(stdout=sample, returncode=0)
|
|
h = _FakeHandler()
|
|
vault_status._handle_vault_status(h, None)
|
|
assert h.status == 200
|
|
payload = json.loads(h.body.decode())
|
|
names = {s["name"] for s in payload["secrets"]}
|
|
assert names == {"gitea", "mailchimp", "woocommerce"}
|
|
|
|
|
|
def test_handler_returns_empty_list_on_credctl_failure():
|
|
"""credctl missing or erroring → empty list, never raises."""
|
|
with patch("routes.vault_status.subprocess.run", side_effect=FileNotFoundError):
|
|
h = _FakeHandler()
|
|
vault_status._handle_vault_status(h, None)
|
|
assert h.status == 200
|
|
payload = json.loads(h.body.decode())
|
|
assert payload == {"secrets": []}
|