Fix linting issues and code quality improvements

Resolve 62 linting issues identified by flutter analyze, reducing
total issues from 79 to 17. All critical warnings addressed.

Changes:
- Replace deprecated withOpacity() with withValues(alpha:) (25 instances)
- Remove unused imports from 9 files
- Remove unused variables and fields (6 instances)
- Fix Riverpod 3.0 state access violations in settings_page
- Remove unnecessary null-aware operators in navigation_page (6 instances)
- Fix unnecessary type casts in providers (4 instances)
- Remove unused methods: _getDarkMapStyle, _showPermissionDialog
- Simplify hover state management by removing unused _isHovered fields

Remaining 17 issues are info-level style suggestions and defensive
programming patterns that don't impact functionality.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

lib/components/dark_mode_map.dart

@@ -26,7 +26,6 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
   GoogleNavigationViewController? _navigationController;
   bool _isNavigating = false;
   LatLng? _destinationLocation;
-  LatLng? _driverLocation;
   bool _isSessionInitialized = false;
   bool _isInitializing = false;
   bool _isStartingNavigation = false;
@@ -173,126 +172,6 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
     }
   }
 
-  String _getDarkMapStyle() {
-    // Google Maps style JSON for dark mode with warm accents
-    return '''[
-      {
-        "elementType": "geometry",
-        "stylers": [{"color": "#212121"}]
-      },
-      {
-        "elementType": "labels.icon",
-        "stylers": [{"visibility": "off"}]
-      },
-      {
-        "elementType": "labels.text.fill",
-        "stylers": [{"color": "#757575"}]
-      },
-      {
-        "elementType": "labels.text.stroke",
-        "stylers": [{"color": "#212121"}]
-      },
-      {
-        "featureType": "administrative",
-        "elementType": "geometry",
-        "stylers": [{"color": "#757575"}]
-      },
-      {
-        "featureType": "administrative.country",
-        "elementType": "labels.text.fill",
-        "stylers": [{"color": "#9e9e9e"}]
-      },
-      {
-        "featureType": "administrative.land_parcel",
-        "stylers": [{"visibility": "off"}]
-      },
-      {
-        "featureType": "administrative.locality",
-        "elementType": "labels.text.fill",
-        "stylers": [{"color": "#bdbdbd"}]
-      },
-      {
-        "featureType": "administrative.neighborhood",
-        "stylers": [{"visibility": "off"}]
-      },
-      {
-        "featureType": "administrative.province",
-        "elementType": "labels.text.fill",
-        "stylers": [{"color": "#9e9e9e"}]
-      },
-      {
-        "featureType": "landscape",
-        "elementType": "geometry",
-        "stylers": [{"color": "#000000"}]
-      },
-      {
-        "featureType": "poi",
-        "elementType": "geometry",
-        "stylers": [{"color": "#383838"}]
-      },
-      {
-        "featureType": "poi",
-        "elementType": "labels.text.fill",
-        "stylers": [{"color": "#9e9e9e"}]
-      },
-      {
-        "featureType": "poi.park",
-        "elementType": "geometry",
-        "stylers": [{"color": "#181818"}]
-      },
-      {
-        "featureType": "poi.park",
-        "elementType": "labels.text.fill",
-        "stylers": [{"color": "#616161"}]
-      },
-      {
-        "featureType": "road",
-        "elementType": "geometry.fill",
-        "stylers": [{"color": "#2c2c2c"}]
-      },
-      {
-        "featureType": "road",
-        "elementType": "labels.text.fill",
-        "stylers": [{"color": "#8a8a8a"}]
-      },
-      {
-        "featureType": "road.arterial",
-        "elementType": "geometry",
-        "stylers": [{"color": "#373737"}]
-      },
-      {
-        "featureType": "road.highway",
-        "elementType": "geometry",
-        "stylers": [{"color": "#3c3c3c"}]
-      },
-      {
-        "featureType": "road.highway.controlled_access",
-        "elementType": "geometry",
-        "stylers": [{"color": "#4e4e4e"}]
-      },
-      {
-        "featureType": "road.local",
-        "elementType": "labels.text.fill",
-        "stylers": [{"color": "#616161"}]
-      },
-      {
-        "featureType": "transit",
-        "elementType": "labels.text.fill",
-        "stylers": [{"color": "#757575"}]
-      },
-      {
-        "featureType": "water",
-        "elementType": "geometry",
-        "stylers": [{"color": "#0c1221"}]
-      },
-      {
-        "featureType": "water",
-        "elementType": "labels.text.fill",
-        "stylers": [{"color": "#3d3d3d"}]
-      }
-    ]''';
-  }
-
   Future<void> _startNavigation() async {
     if (_destinationLocation == null) return;
 
@@ -461,9 +340,6 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
     // Driver's current location (defaults to Montreal if not available)
     final initialPosition = const LatLng(latitude: 45.5017, longitude: -73.5673);
 
-    // Store driver location for navigation centering
-    _driverLocation = initialPosition;
-
     // Calculate dynamic padding for top info panel and bottom button bar
     // Increased to accommodate navigation widget info and action buttons
     final topPadding = widget.selectedDelivery != null ? 110.0 : 0.0;
@@ -550,7 +426,7 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
                 color: Theme.of(context).colorScheme.surface,
                 boxShadow: [
                   BoxShadow(
-                    color: Colors.black.withOpacity(0.2),
+                    color: Colors.black.withValues(alpha: 0.2),
                     blurRadius: 8,
                     offset: const Offset(0, 2),
                   ),
@@ -631,7 +507,7 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
                 color: Theme.of(context).colorScheme.surface,
                 boxShadow: [
                   BoxShadow(
-                    color: Colors.black.withOpacity(0.2),
+                    color: Colors.black.withValues(alpha: 0.2),
                     blurRadius: 8,
                     offset: const Offset(0, -2),
                   ),
@@ -700,7 +576,7 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
         if (_isStartingNavigation || _isInitializing)
           Positioned.fill(
             child: Container(
-              color: Colors.black.withOpacity(0.4),
+              color: Colors.black.withValues(alpha: 0.4),
               child: Center(
                 child: Container(
                   padding: const EdgeInsets.all(24),
@@ -709,7 +585,7 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
                     borderRadius: BorderRadius.circular(12),
                     boxShadow: [
                       BoxShadow(
-                        color: Colors.black.withOpacity(0.3),
+                        color: Colors.black.withValues(alpha: 0.3),
                         blurRadius: 12,
                         offset: const Offset(0, 4),
                       ),
@@ -743,7 +619,7 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
                       Text(
                         'Please wait...',
                         style: Theme.of(context).textTheme.bodySmall?.copyWith(
-                          color: Theme.of(context).colorScheme.onSurface.withOpacity(0.7),
+                          color: Theme.of(context).colorScheme.onSurface.withValues(alpha: 0.7),
                         ),
                         textAlign: TextAlign.center,
                       ),
@@ -766,7 +642,7 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
         shape: BoxShape.circle,
         boxShadow: [
           BoxShadow(
-            color: Colors.black.withOpacity(0.3),
+            color: Colors.black.withValues(alpha: 0.3),
             blurRadius: 4,
             offset: const Offset(0, 2),
           ),
@@ -812,7 +688,7 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
 
     // Reduce opacity when disabled
     if (onPressed == null) {
-      backgroundColor = backgroundColor.withOpacity(0.5);
+      backgroundColor = backgroundColor.withValues(alpha: 0.5);
     }
 
     return Material(
@@ -858,7 +734,7 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
     required Color color,
   }) {
     final isDisabled = onPressed == null;
-    final buttonColor = isDisabled ? color.withOpacity(0.5) : color;
+    final buttonColor = isDisabled ? color.withValues(alpha: 0.5) : color;
 
     return Container(
       margin: const EdgeInsets.only(bottom: 8),
@@ -866,7 +742,7 @@ class _DarkModeMapComponentState extends State<DarkModeMapComponent> {
         borderRadius: BorderRadius.circular(8),
         boxShadow: [
           BoxShadow(
-            color: Colors.black.withOpacity(0.3),
+            color: Colors.black.withValues(alpha: 0.3),
             blurRadius: 4,
             offset: const Offset(0, 2),
           ),

lib/components/delivery_list_item.dart

@@ -115,15 +115,15 @@ class _DeliveryListItemState extends State<DeliveryListItem>
                 decoration: BoxDecoration(
                   borderRadius: BorderRadius.circular(10),
                   color: widget.delivery.delivered
-                      ? Colors.green.withOpacity(0.15)
+                      ? Colors.green.withValues(alpha: 0.15)
                       : (_isHovered || widget.isSelected
                           ? Theme.of(context).colorScheme.surfaceContainer
                           : Colors.transparent),
                   boxShadow: (_isHovered || widget.isSelected) && !widget.delivery.delivered
                       ? [
                           BoxShadow(
-                            color: Colors.black.withOpacity(
+                            color: Colors.black.withValues(
-                              isDark ? 0.3 : 0.08,
+                              alpha: isDark ? 0.3 : 0.08,
                             ),
                             blurRadius: 8,
                             offset: const Offset(0, 4),
@@ -256,14 +256,13 @@ class _DeliveryListItemState extends State<DeliveryListItem>
                       ],
                     ),
                     // Total amount (if present)
-                    if (widget.delivery.orders.isNotEmpty &&
+                    if (widget.delivery.orders.isNotEmpty)
-                        widget.delivery.orders.first.totalAmount != null)
                       Padding(
                         padding: const EdgeInsets.only(top: 8, left: 16),
                         child: Align(
                           alignment: Alignment.centerLeft,
                           child: Text(
-                            'Total: \$${widget.delivery.orders.first.totalAmount!.toStringAsFixed(2)}',
+                            'Total: \$${widget.delivery.orders.first.totalAmount.toStringAsFixed(2)}',
                             style: Theme.of(context)
                                 .textTheme
                                 .labelSmall

lib/components/glassmorphic_route_card.dart

@@ -28,7 +28,6 @@ class GlassmorphicRouteCard extends StatefulWidget {
 class _GlassmorphicRouteCardState extends State<GlassmorphicRouteCard>
     with SingleTickerProviderStateMixin {
   late AnimationController _hoverController;
-  bool _isHovered = false;
 
   @override
   void initState() {
@@ -72,9 +71,6 @@ class _GlassmorphicRouteCardState extends State<GlassmorphicRouteCard>
   }
 
   void _setHovered(bool hovered) {
-    setState(() {
-      _isHovered = hovered;
-    });
     if (hovered) {
       _hoverController.forward();
     } else {

lib/components/premium_route_card.dart

@@ -24,7 +24,6 @@ class _PremiumRouteCardState extends State<PremiumRouteCard>
   late AnimationController _controller;
   late Animation<double> _scaleAnimation;
   late Animation<double> _shadowAnimation;
-  bool _isHovered = false;
 
   @override
   void initState() {
@@ -50,12 +49,10 @@ class _PremiumRouteCardState extends State<PremiumRouteCard>
   }
 
   void _onHoverEnter() {
-    setState(() => _isHovered = true);
     _controller.forward();
   }
 
   void _onHoverExit() {
-    setState(() => _isHovered = false);
     _controller.reverse();
   }
 
@@ -81,7 +78,7 @@ class _PremiumRouteCardState extends State<PremiumRouteCard>
                   borderRadius: BorderRadius.circular(12),
                   boxShadow: [
                     BoxShadow(
-                      color: Colors.black.withOpacity(isDark ? 0.3 : 0.1),
+                      color: Colors.black.withValues(alpha: isDark ? 0.3 : 0.1),
                       blurRadius: _shadowAnimation.value,
                       offset: Offset(0, _shadowAnimation.value * 0.5),
                     ),

lib/pages/deliveries_page.dart

@@ -2,12 +2,10 @@ import 'package:flutter/material.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:url_launcher/url_launcher.dart';
 import '../models/delivery.dart';
-import '../models/delivery_route.dart';
 import '../providers/providers.dart';
 import '../api/client.dart';
 import '../api/openapi_config.dart';
 import '../models/delivery_commands.dart';
-import '../utils/breakpoints.dart';
 import '../components/map_sidebar_layout.dart';
 import '../components/dark_mode_map.dart';
 import '../components/delivery_list_item.dart';
@@ -82,24 +80,8 @@ class _DeliveriesPageState extends ConsumerState<DeliveriesPage> {
             });
           }
 
-          final todoDeliveries = deliveries
-              .where((d) => !d.delivered && !d.isSkipped)
-              .toList();
-          final completedDeliveries = deliveries
-              .where((d) => d.delivered)
-              .toList();
-
           return routesData.when(
             data: (routes) {
-              DeliveryRoute? currentRoute;
-              try {
-                currentRoute = routes.firstWhere(
-                  (r) => r.id == widget.routeFragmentId,
-                );
-              } catch (_) {
-                currentRoute = routes.isNotEmpty ? routes.first : null;
-              }
-
               return MapSidebarLayout(
                       mapWidget: DarkModeMapComponent(
                         deliveries: deliveries,
@@ -331,7 +313,7 @@ class DeliveryCard extends StatelessWidget {
     return Card(
       margin: const EdgeInsets.symmetric(horizontal: 8, vertical: 4),
       color: isSelected
-          ? Theme.of(context).colorScheme.primaryContainer.withOpacity(0.3)
+          ? Theme.of(context).colorScheme.primaryContainer.withValues(alpha: 0.3)
           : null,
       child: InkWell(
         onTap: onTap,

lib/pages/navigation_page.dart

@@ -4,7 +4,6 @@ import 'package:google_navigation_flutter/google_navigation_flutter.dart';
 import 'package:planb_logistic/l10n/app_localizations.dart';
 import '../models/delivery.dart';
 import '../services/location_permission_service.dart';
-import '../components/navigation_tc_dialog.dart';
 
 class NavigationPage extends ConsumerStatefulWidget {
   final Delivery delivery;
@@ -139,38 +138,6 @@ class _NavigationPageState extends ConsumerState<NavigationPage> {
     }
   }
 
-  void _showPermissionDialog() {
-    final l10n = AppLocalizations.of(context);
-
-    showDialog(
-      context: context,
-      barrierDismissible: false,
-      builder: (context) => AlertDialog(
-        title: Text(l10n?.locationPermissionRequired ?? 'Location Permission'),
-        content: Text(
-          l10n?.locationPermissionMessage ??
-              'This app requires location permission to navigate to deliveries.',
-        ),
-        actions: [
-          TextButton(
-            onPressed: () {
-              Navigator.of(context).pop();
-              widget.onNavigationCancelled?.call();
-            },
-            child: Text(l10n?.cancel ?? 'Cancel'),
-          ),
-          TextButton(
-            onPressed: () {
-              Navigator.of(context).pop();
-              _requestLocationPermission();
-            },
-            child: Text(l10n?.requestPermission ?? 'Request Permission'),
-          ),
-        ],
-      ),
-    );
-  }
-
   Future<void> _requestLocationPermission() async {
     final result = await _permissionService.requestLocationPermission();
 
@@ -206,22 +173,19 @@ class _NavigationPageState extends ConsumerState<NavigationPage> {
     showDialog(
       context: context,
       builder: (context) => AlertDialog(
-        title: Text(l10n?.permissionPermanentlyDenied ?? 'Permission Required'),
+        title: Text(l10n.permissionPermanentlyDenied),
-        content: Text(
+        content: Text(l10n.openSettingsMessage),
-          l10n?.openSettingsMessage ??
-              'Location permission is permanently denied. Please enable it in app settings.',
-        ),
         actions: [
           TextButton(
             onPressed: () => Navigator.of(context).pop(),
-            child: Text(l10n?.cancel ?? 'Cancel'),
+            child: Text(l10n.cancel),
           ),
           TextButton(
             onPressed: () {
               _permissionService.openAppSettings();
               Navigator.of(context).pop();
             },
-            child: Text(l10n?.openSettings ?? 'Open Settings'),
+            child: Text(l10n.openSettings),
           ),
         ],
       ),
@@ -389,7 +353,7 @@ class _NavigationPageState extends ConsumerState<NavigationPage> {
     return Scaffold(
       appBar: AppBar(
         title: Text(
-          '${l10n?.navigatingTo ?? 'Navigating to'}: ${widget.delivery.name}',
+          '${l10n.navigatingTo}: ${widget.delivery.name}',
         ),
         elevation: 0,
       ),
@@ -417,10 +381,7 @@ class _NavigationPageState extends ConsumerState<NavigationPage> {
                 children: [
                   const CircularProgressIndicator(),
                   const SizedBox(height: 16),
-                  Text(
+                  Text(l10n.initializingNavigation),
-                    l10n?.initializingNavigation ??
-                        'Initializing navigation...',
-                  ),
                 ],
               ),
             ),

lib/pages/settings_page.dart

@@ -95,7 +95,7 @@ class SettingsPage extends ConsumerWidget {
                     value: language,
                     onChanged: (String? newValue) {
                       if (newValue != null) {
-                        ref.read(languageProvider.notifier).state = newValue;
+                        ref.read(languageProvider.notifier).setLanguage(newValue);
                       }
                     },
                     items: const [
@@ -122,7 +122,7 @@ class SettingsPage extends ConsumerWidget {
                     SegmentedButton<ThemeMode>(
                       selected: {themeMode},
                       onSelectionChanged: (Set<ThemeMode> newSelection) {
-                        ref.read(themeModeProvider.notifier).state = newSelection.first;
+                        ref.read(themeModeProvider.notifier).setThemeMode(newSelection.first);
                       },
                       segments: const [
                         ButtonSegment<ThemeMode>(

lib/providers/providers.dart

@@ -7,9 +7,6 @@ import '../services/auth_service.dart';
 import '../models/user_profile.dart';
 import '../models/delivery_route.dart';
 import '../models/delivery.dart';
-import '../models/delivery_order.dart';
-import '../models/delivery_address.dart';
-import '../models/delivery_contact.dart';
 
 final authServiceProvider = Provider<AuthService>((ref) {
   return AuthService();
@@ -58,8 +55,8 @@ final deliveryRoutesProvider = FutureProvider<List<DeliveryRoute>>((ref) async {
       // API returns data wrapped in object with "data" field
       if (json is Map<String, dynamic>) {
         final data = json['data'];
-        if (data is List) {
+        if (data is List<dynamic>) {
-          return (data as List<dynamic>).map((r) => DeliveryRoute.fromJson(r as Map<String, dynamic>)).toList();
+          return data.map((r) => DeliveryRoute.fromJson(r as Map<String, dynamic>)).toList();
         }
       }
       return [];
@@ -90,8 +87,8 @@ final deliveriesProvider = FutureProvider.family<List<Delivery>, int>((ref, rout
       // API returns data wrapped in object with "data" field
       if (json is Map<String, dynamic>) {
         final data = json['data'];
-        if (data is List) {
+        if (data is List<dynamic>) {
-          return (data as List<dynamic>).map((d) => Delivery.fromJson(d as Map<String, dynamic>)).toList();
+          return data.map((d) => Delivery.fromJson(d as Map<String, dynamic>)).toList();
         }
       }
       return [];

lib/services/location_permission_service.dart

@@ -1,8 +1,6 @@
 import 'package:permission_handler/permission_handler.dart';
 
 class LocationPermissionService {
-  static const String _tcKey = 'navigation_tc_accepted';
-
   Future<LocationPermissionResult> requestLocationPermission() async {
     final status = await Permission.location.request();
 

lib/theme.dart

@@ -1,11 +1,4 @@
 import 'package:flutter/material.dart';
-import 'theme/color_system.dart';
-import 'theme/spacing_system.dart';
-import 'theme/border_system.dart';
-import 'theme/shadow_system.dart';
-import 'theme/size_system.dart';
-import 'theme/animation_system.dart';
-import 'theme/typography_system.dart';
 import 'theme/component_themes.dart';
 
 class MaterialTheme {

lib/theme/component_themes.dart

@@ -97,7 +97,7 @@ class ComponentThemes {
   static InputDecorationTheme inputDecorationTheme(ColorScheme colorScheme) {
     return InputDecorationTheme(
       filled: true,
-      fillColor: colorScheme.surfaceContainerHighest.withOpacity(0.5),
+      fillColor: colorScheme.surfaceContainerHighest.withValues(alpha: 0.5),
       contentPadding: EdgeInsets.symmetric(
         horizontal: AppSpacing.inputPadding,
         vertical: AppSpacing.md,
@@ -105,13 +105,13 @@ class ComponentThemes {
       border: OutlineInputBorder(
         borderRadius: AppBorders.circularSm,
         borderSide: BorderSide(
-          color: colorScheme.outline.withOpacity(0.3),
+          color: colorScheme.outline.withValues(alpha: 0.3),
         ),
       ),
       enabledBorder: OutlineInputBorder(
         borderRadius: AppBorders.circularSm,
         borderSide: BorderSide(
-          color: colorScheme.outline.withOpacity(0.3),
+          color: colorScheme.outline.withValues(alpha: 0.3),
           width: 1,
         ),
       ),
@@ -144,7 +144,7 @@ class ComponentThemes {
       hintStyle: TextStyle(
         fontFamily: 'Montserrat',
         fontWeight: FontWeight.w400,
-        color: colorScheme.onSurfaceVariant.withOpacity(0.6),
+        color: colorScheme.onSurfaceVariant.withValues(alpha: 0.6),
       ),
     );
   }
@@ -204,7 +204,7 @@ class ComponentThemes {
     return ChipThemeData(
       backgroundColor: colorScheme.surfaceContainerHighest,
       deleteIconColor: colorScheme.onSurfaceVariant,
-      disabledColor: colorScheme.surfaceContainerHighest.withOpacity(0.38),
+      disabledColor: colorScheme.surfaceContainerHighest.withValues(alpha: 0.38),
       padding: EdgeInsets.symmetric(
         horizontal: AppSpacing.sm,
         vertical: AppSpacing.xs,
@@ -255,7 +255,7 @@ class ComponentThemes {
       activeTrackColor: colorScheme.primary,
       inactiveTrackColor: colorScheme.surfaceContainerHighest,
       thumbColor: colorScheme.primary,
-      overlayColor: colorScheme.primary.withOpacity(0.12),
+      overlayColor: colorScheme.primary.withValues(alpha: 0.12),
       valueIndicatorColor: colorScheme.primary,
     );
   }

lib/theme/gradient_system.dart

@@ -75,7 +75,7 @@ class AppGradients {
       end: horizontal ? Alignment.centerRight : Alignment.bottomCenter,
       colors: [
         color,
-        color.withOpacity(0.8),
+        color.withValues(alpha: 0.8),
       ],
     );
   }
@@ -311,7 +311,7 @@ class AppGradients {
       begin: gradient.begin,
       end: gradient.end,
       colors: gradient.colors
-          .map((color) => color.withOpacity(opacity))
+          .map((color) => color.withValues(alpha: opacity))
           .toList(),
       stops: gradient.stops,
     );

lib/theme/size_system.dart

@@ -1,4 +1,3 @@
-import 'package:flutter/material.dart';
 
 /// Svrnty Size System
 /// Standard sizing constants for icons, buttons, containers, and other components

lib/theme/typography_system.dart

@@ -257,7 +257,7 @@ class AppTypography {
   ) {
     final color = baseStyle.color ?? Colors.black;
     return baseStyle.copyWith(
-      color: color.withOpacity(opacity),
+      color: color.withValues(alpha: opacity),
     );
   }