osrm-backend/src
Michael Bell 9ad432c5b2
Fix adding traffic signal penalties during compression (#6419)
Weight and duration penalties are flipped in the lambda function
that applies penalties from traffic signals.

Duration is in deciseconds, whilst weight is multipled by
10^weight_precision, with weight_precision being 1 by default.

Therefore, for default routability profile, the penalties end up
being the same, hence why no tests picked this up.

If distance weight is used however, it will incorrectly apply an
additional penalty to the weight, and not add the traffic signal
delay to the duration in the routing graph.

To confuse things further, in some API responses the values are
correct because they use geometry data instead, but it's still
possible that a sub-optimal route was selected.

However, given the distance weight is in meters, and the additional
penalty per traffic light would be 20, it's unlikely this would
have changed the routing results.

In any case, we correct the function to apply the arguments correctly.
2022-10-23 14:59:12 +01:00
..
benchmarks Improve performance of JSON rendering (#6380) 2022-10-03 21:43:51 +02:00
contractor Migrate to modern TBB version (#6300) 2022-08-24 18:13:49 +02:00
customize Migrate to modern TBB version (#6300) 2022-08-24 18:13:49 +02:00
engine Update CI to use clang-tidy 14 (#6353) 2022-08-31 23:39:47 +02:00
extractor Fix adding traffic signal penalties during compression (#6419) 2022-10-23 14:59:12 +01:00
guidance Gracefully handle no-turn intersections in guidance processing. (#6382) 2022-10-01 14:35:08 +01:00
nodejs Get rid of Mason (#6387) 2022-10-06 14:13:12 +02:00
osrm Add missing files in exception message (#5360) 2022-08-22 08:32:25 +02:00
partitioner Update CI to use clang-tidy 14 (#6353) 2022-08-31 23:39:47 +02:00
server Revert back to using custom HTTP parser instead of Boost.Beast (#6407) 2022-10-14 14:37:33 +02:00
storage Remove redundant nullptr check. (#6326) 2022-08-25 00:01:56 +02:00
tools Do not generate intermediate .osrm file in osrm-extract. (#6354) 2022-09-30 14:29:10 +02:00
updater Support floats for speed value in traffic updates CSV (#6327) 2022-08-30 15:34:46 +02:00
util Add timestamps for logs (#6375) 2022-09-30 14:28:52 +02:00