osrm-backend/features
Michael Bell 9ad432c5b2
Fix adding traffic signal penalties during compression (#6419)
Weight and duration penalties are flipped in the lambda function
that applies penalties from traffic signals.

Duration is in deciseconds, whilst weight is multipled by
10^weight_precision, with weight_precision being 1 by default.

Therefore, for default routability profile, the penalties end up
being the same, hence why no tests picked this up.

If distance weight is used however, it will incorrectly apply an
additional penalty to the weight, and not add the traffic signal
delay to the duration in the routing graph.

To confuse things further, in some API responses the values are
correct because they use geometry data instead, but it's still
possible that a sub-optimal route was selected.

However, given the distance weight is in meters, and the additional
penalty per traffic light would be 20, it's unlikely this would
have changed the routing results.

In any case, we correct the function to apply the arguments correctly.
2022-10-23 14:59:12 +01:00
..
bicycle Add support for surface=metal,grass_paver,woodchips in bicyle profile (#6395) 2022-10-11 11:09:56 +02:00
car Fix adding traffic signal penalties during compression (#6419) 2022-10-23 14:59:12 +01:00
foot Ensure u-turn exists in intersection view (#6376) 2022-09-27 13:49:12 +01:00
guidance Gracefully handle no-turn intersections in guidance processing. (#6382) 2022-10-01 14:35:08 +01:00
lib Configure Undefined Behaviour Sanitizer (#6290) 2022-08-01 22:40:26 +01:00
nearest Add data_version field to responses of all plugins. (#5387) 2022-08-22 21:07:32 +02:00
options Fix turn.roads_on_the_left and turn.roads_on_the right for two-way roads #5128 2021-01-27 10:53:00 +01:00
raster Fix distance calculation consistency. (#6315) 2022-08-19 22:31:40 +01:00
step_definitions Revert back to using custom HTTP parser instead of Boost.Beast (#6407) 2022-10-14 14:37:33 +02:00
stress Fix bug with large HTTP requests leading to Bad Request in osrm-routed. (#6403) 2022-10-13 16:53:49 +02:00
support Fix distance calculation consistency. (#6315) 2022-08-19 22:31:40 +01:00
testbot Improve performance of JSON rendering (#6380) 2022-10-03 21:43:51 +02:00