Compare commits

...

7 Commits

Author SHA1 Message Date
Siarhei Fedartsou
c87ed8ebc0 Merge with master 2024-05-21 19:39:30 +02:00
Siarhei Fedartsou
f19d64970a Merge branch 'master' into pr-6611 2024-05-21 19:35:50 +02:00
Dennis Luxen
56d2d4dacd
Merge branch 'master' into boost_optional_merge 2024-05-06 17:39:54 +02:00
Mugr Rex
1107a14a2c Removed nodejs
Seems like my local build is ok, but in CI
the references to engine are still there
so I am reverting code in /nodejs to master
2023-04-24 19:16:27 +02:00
Mugr Rex
5b23b11129 Readded updater
Must have been lost while concating everything into one commit
2023-04-24 19:10:04 +02:00
Mugr Rex
23fb96c4f2 Fixed error in /nodejs 2023-04-21 13:16:14 +02:00
Mugr Rex
45bfe937aa Final merge commit 2023-04-20 16:04:04 +02:00
27 changed files with 1909 additions and 108 deletions

View File

@ -19,6 +19,7 @@
- NodeJS: - NodeJS:
- CHANGED: Use node-api instead of NAN. [#6452](https://github.com/Project-OSRM/osrm-backend/pull/6452) - CHANGED: Use node-api instead of NAN. [#6452](https://github.com/Project-OSRM/osrm-backend/pull/6452)
- Misc: - Misc:
- CHANGED: Partial fix migration from boost::optional to std::optional [#6551](https://github.com/Project-OSRM/osrm-backend/issues/6551), see also [#6592](https://github.com/Project-OSRM/osrm-backend/issues/6592)
- CHANGED: Update Conan Boost version to 1.85.0. [#6868](https://github.com/Project-OSRM/osrm-backend/pull/6868) - CHANGED: Update Conan Boost version to 1.85.0. [#6868](https://github.com/Project-OSRM/osrm-backend/pull/6868)
- FIXED: Fix an error in a RouteParameters AnnotationsType operator overload. [#6646](https://github.com/Project-OSRM/osrm-backend/pull/6646) - FIXED: Fix an error in a RouteParameters AnnotationsType operator overload. [#6646](https://github.com/Project-OSRM/osrm-backend/pull/6646)
- ADDED: Add support for "unlimited" to be passed as a value for the default-radius and max-matching-radius flags. [#6599](https://github.com/Project-OSRM/osrm-backend/pull/6599) - ADDED: Add support for "unlimited" to be passed as a value for the default-radius and max-matching-radius flags. [#6599](https://github.com/Project-OSRM/osrm-backend/pull/6599)

View File

@ -122,7 +122,7 @@ void routingStep(const DataFacade<Algorithm> &facade,
const EdgeWeight new_weight = reverseHeapNode->weight + heapNode.weight; const EdgeWeight new_weight = reverseHeapNode->weight + heapNode.weight;
if (new_weight < upper_bound) if (new_weight < upper_bound)
{ {
if (shouldForceStep(force_step_nodes, heapNode, reverseHeapNode.get()) || if (shouldForceStep(force_step_nodes, heapNode, *reverseHeapNode) ||
// in this case we are looking at a bi-directional way where the source // in this case we are looking at a bi-directional way where the source
// and target phantom are on the same edge based node // and target phantom are on the same edge based node
new_weight < EdgeWeight{0}) new_weight < EdgeWeight{0})

View File

@ -408,7 +408,7 @@ void routingStep(const DataFacade<Algorithm> &facade,
auto reverse_weight = reverseHeapNode->weight; auto reverse_weight = reverseHeapNode->weight;
auto path_weight = weight + reverse_weight; auto path_weight = weight + reverse_weight;
if (!shouldForceStep(force_step_nodes, heapNode, reverseHeapNode.get()) && if (!shouldForceStep(force_step_nodes, heapNode, *reverseHeapNode) &&
(path_weight >= EdgeWeight{0}) && (path_weight < path_upper_bound)) (path_weight >= EdgeWeight{0}) && (path_weight < path_upper_bound))
{ {
middle_node = heapNode.node; middle_node = heapNode.node;

View File

@ -11,8 +11,8 @@
#include "util/typedefs.hpp" #include "util/typedefs.hpp"
#include <boost/assert.hpp> #include <boost/assert.hpp>
#include <boost/optional.hpp>
#include <cstdint> #include <cstdint>
#include <optional>
#include <utility> #include <utility>
namespace osrm::extractor::intersection namespace osrm::extractor::intersection
@ -42,10 +42,10 @@ class NodeBasedGraphWalker
* selector not provinding any further edge to traverse) * selector not provinding any further edge to traverse)
*/ */
template <class accumulator_type, class selector_type> template <class accumulator_type, class selector_type>
boost::optional<std::pair<NodeID, EdgeID>> TraverseRoad(NodeID starting_at_node_id, std::optional<std::pair<NodeID, EdgeID>> TraverseRoad(NodeID starting_at_node_id,
EdgeID following_edge_id, EdgeID following_edge_id,
accumulator_type &accumulator, accumulator_type &accumulator,
const selector_type &selector) const; const selector_type &selector) const;
private: private:
const util::NodeBasedDynamicGraph &node_based_graph; const util::NodeBasedDynamicGraph &node_based_graph;
@ -111,11 +111,11 @@ struct SelectRoadByNameOnlyChoiceAndStraightness
* traversal. If no such edge is found, return {} is allowed. Usually you want to choose some * traversal. If no such edge is found, return {} is allowed. Usually you want to choose some
* form of obious turn to follow. * form of obious turn to follow.
*/ */
boost::optional<EdgeID> operator()(const NodeID nid, std::optional<EdgeID> operator()(const NodeID nid,
const EdgeID via_edge_id, const EdgeID via_edge_id,
const IntersectionView &intersection, const IntersectionView &intersection,
const util::NodeBasedDynamicGraph &node_based_graph, const util::NodeBasedDynamicGraph &node_based_graph,
const EdgeBasedNodeDataContainer &node_data_container) const; const EdgeBasedNodeDataContainer &node_data_container) const;
private: private:
const NameID desired_name_id; const NameID desired_name_id;
@ -138,11 +138,11 @@ struct SelectStraightmostRoadByNameAndOnlyChoice
* traversal. If no such edge is found, return {} is allowed. Usually you want to choose some * traversal. If no such edge is found, return {} is allowed. Usually you want to choose some
* form of obious turn to follow. * form of obious turn to follow.
*/ */
boost::optional<EdgeID> operator()(const NodeID nid, std::optional<EdgeID> operator()(const NodeID nid,
const EdgeID via_edge_id, const EdgeID via_edge_id,
const IntersectionView &intersection, const IntersectionView &intersection,
const util::NodeBasedDynamicGraph &node_based_graph, const util::NodeBasedDynamicGraph &node_based_graph,
const EdgeBasedNodeDataContainer &node_data_container) const; const EdgeBasedNodeDataContainer &node_data_container) const;
private: private:
const NameID desired_name_id; const NameID desired_name_id;
@ -187,7 +187,7 @@ struct IntersectionFinderAccumulator
}; };
template <class accumulator_type, class selector_type> template <class accumulator_type, class selector_type>
boost::optional<std::pair<NodeID, EdgeID>> std::optional<std::pair<NodeID, EdgeID>>
NodeBasedGraphWalker::TraverseRoad(NodeID current_node_id, NodeBasedGraphWalker::TraverseRoad(NodeID current_node_id,
EdgeID current_edge_id, EdgeID current_edge_id,
accumulator_type &accumulator, accumulator_type &accumulator,
@ -254,19 +254,19 @@ NodeBasedGraphWalker::TraverseRoad(NodeID current_node_id,
struct SkipTrafficSignalBarrierRoadSelector struct SkipTrafficSignalBarrierRoadSelector
{ {
boost::optional<EdgeID> operator()(const NodeID, std::optional<EdgeID> operator()(const NodeID,
const EdgeID, const EdgeID,
const IntersectionView &intersection, const IntersectionView &intersection,
const util::NodeBasedDynamicGraph &, const util::NodeBasedDynamicGraph &,
const EdgeBasedNodeDataContainer &) const const EdgeBasedNodeDataContainer &) const
{ {
if (intersection.isTrafficSignalOrBarrier()) if (intersection.isTrafficSignalOrBarrier())
{ {
return boost::make_optional(intersection[1].eid); return std::make_optional(intersection[1].eid);
} }
else else
{ {
return boost::none; return std::nullopt;
} }
} }
}; };

View File

@ -3,7 +3,7 @@
#include "maneuver_override.hpp" #include "maneuver_override.hpp"
#include <boost/optional.hpp> #include <optional>
#include <string> #include <string>
#include <vector> #include <vector>
@ -55,7 +55,7 @@ class ManeuverOverrideRelationParser
{ {
public: public:
ManeuverOverrideRelationParser(); ManeuverOverrideRelationParser();
boost::optional<InputManeuverOverride> TryParse(const osmium::Relation &relation) const; std::optional<InputManeuverOverride> TryParse(const osmium::Relation &relation) const;
}; };
} // namespace osrm::extractor } // namespace osrm::extractor

View File

@ -7,11 +7,11 @@
#include <boost/assert.hpp> #include <boost/assert.hpp>
#include <boost/numeric/conversion/cast.hpp> #include <boost/numeric/conversion/cast.hpp>
#include <boost/optional.hpp>
#include <algorithm> #include <algorithm>
#include <array> #include <array>
#include <cstdint> #include <cstdint>
#include <optional>
namespace osrm::extractor namespace osrm::extractor
{ {
@ -80,7 +80,7 @@ struct ProfileProperties
} }
// Check if this classes are excludable // Check if this classes are excludable
boost::optional<std::size_t> ClassesAreExcludable(ClassData classes) const std::optional<std::size_t> ClassesAreExcludable(ClassData classes) const
{ {
auto iter = std::find(excludable_classes.begin(), excludable_classes.end(), classes); auto iter = std::find(excludable_classes.begin(), excludable_classes.end(), classes);
if (iter != excludable_classes.end()) if (iter != excludable_classes.end())

View File

@ -15,11 +15,10 @@
#include <algorithm> #include <algorithm>
#include <cstddef> #include <cstddef>
#include <optional>
#include <utility> #include <utility>
#include <vector> #include <vector>
#include <boost/optional.hpp>
namespace osrm::guidance namespace osrm::guidance
{ {
@ -129,7 +128,7 @@ class IntersectionHandler
// ^ via // ^ via
// //
// For this scenario returns intersection at `b` and `b`. // For this scenario returns intersection at `b` and `b`.
boost::optional<IntersectionHandler::IntersectionViewAndNode> std::optional<IntersectionHandler::IntersectionViewAndNode>
getNextIntersection(const NodeID at, const EdgeID via) const; getNextIntersection(const NodeID at, const EdgeID via) const;
bool isSameName(const EdgeID source_edge_id, const EdgeID target_edge_id) const; bool isSameName(const EdgeID source_edge_id, const EdgeID target_edge_id) const;

View File

@ -9,10 +9,9 @@
#include "util/node_based_graph.hpp" #include "util/node_based_graph.hpp"
#include <optional>
#include <vector> #include <vector>
#include <boost/optional.hpp>
namespace osrm::guidance namespace osrm::guidance
{ {
@ -43,9 +42,9 @@ class SliproadHandler final : public IntersectionHandler
Intersection intersection) const override final; Intersection intersection) const override final;
private: private:
boost::optional<std::size_t> getObviousIndexWithSliproads(const EdgeID from, std::optional<std::size_t> getObviousIndexWithSliproads(const EdgeID from,
const Intersection &intersection, const Intersection &intersection,
const NodeID at) const; const NodeID at) const;
// Next intersection from `start` onto `onto` is too far away for a Siproad scenario // Next intersection from `start` onto `onto` is too far away for a Siproad scenario
bool nextIntersectionIsTooFarAway(const NodeID start, const EdgeID onto) const; bool nextIntersectionIsTooFarAway(const NodeID start, const EdgeID onto) const;

View File

@ -11,9 +11,8 @@
#include "util/attributes.hpp" #include "util/attributes.hpp"
#include "util/node_based_graph.hpp" #include "util/node_based_graph.hpp"
#include <boost/optional.hpp>
#include <cstddef> #include <cstddef>
#include <optional>
#include <utility> #include <utility>
#include <vector> #include <vector>
@ -72,7 +71,7 @@ class TurnHandler final : public IntersectionHandler
bool hasObvious(const EdgeID &via_edge, const Fork &fork) const; bool hasObvious(const EdgeID &via_edge, const Fork &fork) const;
boost::optional<Fork> findForkCandidatesByGeometry(Intersection &intersection) const; std::optional<Fork> findForkCandidatesByGeometry(Intersection &intersection) const;
bool isCompatibleByRoadClass(const Intersection &intersection, const Fork fork) const; bool isCompatibleByRoadClass(const Intersection &intersection, const Fork fork) const;
@ -96,7 +95,7 @@ class TurnHandler final : public IntersectionHandler
handleDistinctConflict(const EdgeID via_edge, ConnectedRoad &left, ConnectedRoad &right) const; handleDistinctConflict(const EdgeID via_edge, ConnectedRoad &left, ConnectedRoad &right) const;
// Classification // Classification
boost::optional<Fork> findFork(const EdgeID via_edge, Intersection &intersection) const; std::optional<Fork> findFork(const EdgeID via_edge, Intersection &intersection) const;
OSRM_ATTR_WARN_UNUSED OSRM_ATTR_WARN_UNUSED
Intersection assignLeftTurns(const EdgeID via_edge, Intersection assignLeftTurns(const EdgeID via_edge,

View File

@ -39,7 +39,7 @@ template <typename Key, typename Value> struct CSVFilesParser
{ {
} }
// Operator returns a lambda function that maps input Key to boost::optional<Value>. // Operator returns a lambda function that maps input Key to std::optional<Value>.
auto operator()(const std::vector<std::string> &csv_filenames) const auto operator()(const std::vector<std::string> &csv_filenames) const
{ {
try try

View File

@ -3,8 +3,7 @@
#include "util/typedefs.hpp" #include "util/typedefs.hpp"
#include <boost/optional.hpp> #include <optional>
#include <vector> #include <vector>
namespace osrm::updater namespace osrm::updater
@ -12,9 +11,9 @@ namespace osrm::updater
template <typename Key, typename Value> struct LookupTable template <typename Key, typename Value> struct LookupTable
{ {
boost::optional<Value> operator()(const Key &key) const std::optional<Value> operator()(const Key &key) const
{ {
using Result = boost::optional<Value>; using Result = std::optional<Value>;
const auto it = const auto it =
std::lower_bound(lookup.begin(), std::lower_bound(lookup.begin(),
lookup.end(), lookup.end(),
@ -50,7 +49,7 @@ struct SpeedSource final
{ {
SpeedSource() : speed(0.), rate() {} SpeedSource() : speed(0.), rate() {}
double speed; double speed;
boost::optional<double> rate; std::optional<double> rate;
std::uint8_t source; std::uint8_t source;
}; };

View File

@ -4,11 +4,11 @@
#include "util/coordinate.hpp" #include "util/coordinate.hpp"
#include <boost/math/constants/constants.hpp> #include <boost/math/constants/constants.hpp>
#include <boost/optional.hpp>
#include <algorithm> #include <algorithm>
#include <cmath> #include <cmath>
#include <numeric> #include <numeric>
#include <optional>
#include <utility> #include <utility>
#include <vector> #include <vector>
@ -109,9 +109,9 @@ double bearing(const Coordinate first_coordinate, const Coordinate second_coordi
double computeAngle(const Coordinate first, const Coordinate second, const Coordinate third); double computeAngle(const Coordinate first, const Coordinate second, const Coordinate third);
// find the center of a circle through three coordinates // find the center of a circle through three coordinates
boost::optional<Coordinate> circleCenter(const Coordinate first_coordinate, std::optional<Coordinate> circleCenter(const Coordinate first_coordinate,
const Coordinate second_coordinate, const Coordinate second_coordinate,
const Coordinate third_coordinate); const Coordinate third_coordinate);
// find the radius of a circle through three coordinates // find the radius of a circle through three coordinates
double circleRadius(const Coordinate first_coordinate, double circleRadius(const Coordinate first_coordinate,

View File

@ -1,6 +1,7 @@
#ifndef OSRM_GEOJSON_DEBUG_POLICIES #ifndef OSRM_GEOJSON_DEBUG_POLICIES
#define OSRM_GEOJSON_DEBUG_POLICIES #define OSRM_GEOJSON_DEBUG_POLICIES
#include <optional>
#include <vector> #include <vector>
#include "extractor/query_node.hpp" #include "extractor/query_node.hpp"
@ -9,8 +10,6 @@
#include "util/node_based_graph.hpp" #include "util/node_based_graph.hpp"
#include "util/typedefs.hpp" #include "util/typedefs.hpp"
#include <boost/optional.hpp>
namespace osrm::util namespace osrm::util
{ {
@ -20,7 +19,7 @@ struct NodeIdVectorToLineString
// converts a vector of node ids into a linestring geojson feature // converts a vector of node ids into a linestring geojson feature
util::json::Object operator()(const std::vector<NodeID> &node_ids, util::json::Object operator()(const std::vector<NodeID> &node_ids,
const boost::optional<json::Object> &properties = {}) const; const std::optional<json::Object> &properties = {}) const;
const std::vector<util::Coordinate> &node_coordinates; const std::vector<util::Coordinate> &node_coordinates;
}; };
@ -29,7 +28,7 @@ struct CoordinateVectorToLineString
{ {
// converts a vector of node ids into a linestring geojson feature // converts a vector of node ids into a linestring geojson feature
util::json::Object operator()(const std::vector<util::Coordinate> &coordinates, util::json::Object operator()(const std::vector<util::Coordinate> &coordinates,
const boost::optional<json::Object> &properties = {}) const; const std::optional<json::Object> &properties = {}) const;
}; };
struct NodeIdVectorToMultiPoint struct NodeIdVectorToMultiPoint
@ -38,7 +37,7 @@ struct NodeIdVectorToMultiPoint
// converts a vector of node ids into a linestring geojson feature // converts a vector of node ids into a linestring geojson feature
util::json::Object operator()(const std::vector<NodeID> &node_ids, util::json::Object operator()(const std::vector<NodeID> &node_ids,
const boost::optional<json::Object> &properties = {}) const; const std::optional<json::Object> &properties = {}) const;
const std::vector<util::Coordinate> &node_coordinates; const std::vector<util::Coordinate> &node_coordinates;
}; };
@ -47,7 +46,7 @@ struct CoordinateVectorToMultiPoint
{ {
// converts a vector of node ids into a linestring geojson feature // converts a vector of node ids into a linestring geojson feature
util::json::Object operator()(const std::vector<util::Coordinate> &coordinates, util::json::Object operator()(const std::vector<util::Coordinate> &coordinates,
const boost::optional<json::Object> &properties = {}) const; const std::optional<json::Object> &properties = {}) const;
}; };
} // namespace osrm::util } // namespace osrm::util

View File

@ -7,8 +7,7 @@
#include <algorithm> #include <algorithm>
#include <iterator> #include <iterator>
#include <optional>
#include <boost/optional.hpp>
namespace osrm::util namespace osrm::util
{ {
@ -84,7 +83,7 @@ struct NodeIdToCoordinate
inline util::json::Object makeFeature(std::string type, inline util::json::Object makeFeature(std::string type,
util::json::Array coordinates, util::json::Array coordinates,
const boost::optional<util::json::Object> &properties = {}) const std::optional<util::json::Object> &properties = {})
{ {
util::json::Object result; util::json::Object result;
result.values["type"] = "Feature"; result.values["type"] = "Feature";

View File

@ -3,12 +3,12 @@
#include <boost/assert.hpp> #include <boost/assert.hpp>
#include <boost/heap/d_ary_heap.hpp> #include <boost/heap/d_ary_heap.hpp>
#include <boost/optional.hpp>
#include <algorithm> #include <algorithm>
#include <cstdint> #include <cstdint>
#include <limits> #include <limits>
#include <map> #include <map>
#include <optional>
#include <unordered_map> #include <unordered_map>
#include <vector> #include <vector>
@ -290,26 +290,26 @@ class QueryHeap
return inserted_nodes[index].node == node; return inserted_nodes[index].node == node;
} }
boost::optional<HeapNode &> GetHeapNodeIfWasInserted(const NodeID node) HeapNode *GetHeapNodeIfWasInserted(const NodeID node)
{ {
const auto index = node_index.peek_index(node); const auto index = node_index.peek_index(node);
if (index >= static_cast<decltype(index)>(inserted_nodes.size()) || if (index >= static_cast<decltype(index)>(inserted_nodes.size()) ||
inserted_nodes[index].node != node) inserted_nodes[index].node != node)
{ {
return {}; return nullptr;
} }
return inserted_nodes[index]; return &inserted_nodes[index];
} }
boost::optional<const HeapNode &> GetHeapNodeIfWasInserted(const NodeID node) const const HeapNode *GetHeapNodeIfWasInserted(const NodeID node) const
{ {
const auto index = node_index.peek_index(node); const auto index = node_index.peek_index(node);
if (index >= static_cast<decltype(index)>(inserted_nodes.size()) || if (index >= static_cast<decltype(index)>(inserted_nodes.size()) ||
inserted_nodes[index].node != node) inserted_nodes[index].node != node)
{ {
return {}; return nullptr;
} }
return inserted_nodes[index]; return &inserted_nodes[index];
} }
NodeID Min() const NodeID Min() const

View File

@ -6,11 +6,11 @@
#include <boost/filesystem/path.hpp> #include <boost/filesystem/path.hpp>
#include <boost/geometry.hpp> #include <boost/geometry.hpp>
#include <boost/geometry/index/rtree.hpp> #include <boost/geometry/index/rtree.hpp>
#include <boost/optional.hpp>
#include <rapidjson/document.h> #include <rapidjson/document.h>
#include <chrono> #include <chrono>
#include <optional>
namespace osrm::updater namespace osrm::updater
{ {
@ -34,7 +34,7 @@ class Timezoner
Timezoner(const char geojson[], std::time_t utc_time_now); Timezoner(const char geojson[], std::time_t utc_time_now);
Timezoner(const boost::filesystem::path &tz_shapes_filename, std::time_t utc_time_now); Timezoner(const boost::filesystem::path &tz_shapes_filename, std::time_t utc_time_now);
boost::optional<struct tm> operator()(const point_t &point) const; std::optional<struct tm> operator()(const point_t &point) const;
private: private:
void LoadLocalTimesRTree(rapidjson::Document &geojson, std::time_t utc_time); void LoadLocalTimesRTree(rapidjson::Document &geojson, std::time_t utc_time);

View File

@ -66,7 +66,7 @@ SelectRoadByNameOnlyChoiceAndStraightness::SelectRoadByNameOnlyChoiceAndStraight
{ {
} }
boost::optional<EdgeID> SelectRoadByNameOnlyChoiceAndStraightness::operator()( std::optional<EdgeID> SelectRoadByNameOnlyChoiceAndStraightness::operator()(
const NodeID /*nid*/, const NodeID /*nid*/,
const EdgeID /*via_edge_id*/, const EdgeID /*via_edge_id*/,
const IntersectionView &intersection, const IntersectionView &intersection,
@ -118,7 +118,7 @@ SelectStraightmostRoadByNameAndOnlyChoice::SelectStraightmostRoadByNameAndOnlyCh
{ {
} }
boost::optional<EdgeID> SelectStraightmostRoadByNameAndOnlyChoice::operator()( std::optional<EdgeID> SelectStraightmostRoadByNameAndOnlyChoice::operator()(
const NodeID /*nid*/, const NodeID /*nid*/,
const EdgeID /*via_edge_id*/, const EdgeID /*via_edge_id*/,
const IntersectionView &intersection, const IntersectionView &intersection,
@ -241,7 +241,7 @@ boost::optional<EdgeID> SelectStraightmostRoadByNameAndOnlyChoice::operator()(
return {}; return {};
} }
return is_only_choice_with_same_name ? boost::optional<EdgeID>(min_element->eid) : boost::none; return is_only_choice_with_same_name ? std::optional<EdgeID>(min_element->eid) : std::nullopt;
} }
// --------------------------------------------------------------------------------- // ---------------------------------------------------------------------------------

View File

@ -1,9 +1,9 @@
#include "extractor/maneuver_override_relation_parser.hpp" #include "extractor/maneuver_override_relation_parser.hpp"
#include "extractor/maneuver_override.hpp" #include "extractor/maneuver_override.hpp"
#include <boost/optional/optional.hpp>
#include <boost/ref.hpp> #include <boost/ref.hpp>
#include <optional>
#include <osmium/osm.hpp> #include <osmium/osm.hpp>
#include <osmium/tags/filter.hpp> #include <osmium/tags/filter.hpp>
#include <osmium/tags/taglist.hpp> #include <osmium/tags/taglist.hpp>
@ -21,7 +21,7 @@ ManeuverOverrideRelationParser::ManeuverOverrideRelationParser() {}
* into an InputManeuverOverride object, if the relation is considered * into an InputManeuverOverride object, if the relation is considered
* valid (i.e. has the minimum tags we expect). * valid (i.e. has the minimum tags we expect).
*/ */
boost::optional<InputManeuverOverride> std::optional<InputManeuverOverride>
ManeuverOverrideRelationParser::TryParse(const osmium::Relation &relation) const ManeuverOverrideRelationParser::TryParse(const osmium::Relation &relation) const
{ {
@ -35,7 +35,7 @@ ManeuverOverrideRelationParser::TryParse(const osmium::Relation &relation) const
if (osmium::tags::match_none_of(tag_list, filter)) if (osmium::tags::match_none_of(tag_list, filter))
// if it's not a maneuver, continue; // if it's not a maneuver, continue;
{ {
return boost::none; return std::nullopt;
} }
// we pretend every restriction is a conditional restriction. If we do not find any restriction, // we pretend every restriction is a conditional restriction. If we do not find any restriction,
@ -130,7 +130,7 @@ ManeuverOverrideRelationParser::TryParse(const osmium::Relation &relation) const
} }
else else
{ {
return boost::none; return std::nullopt;
} }
return maneuver_override; return maneuver_override;
} }

View File

@ -427,7 +427,7 @@ void IntersectionHandler::assignTrivialTurns(const EdgeID via_eid,
} }
} }
boost::optional<IntersectionHandler::IntersectionViewAndNode> std::optional<IntersectionHandler::IntersectionViewAndNode>
IntersectionHandler::getNextIntersection(const NodeID at, const EdgeID via) const IntersectionHandler::getNextIntersection(const NodeID at, const EdgeID via) const
{ {
// We use the intersection generator to jump over traffic signals, barriers. The intersection // We use the intersection generator to jump over traffic signals, barriers. The intersection
@ -450,7 +450,7 @@ IntersectionHandler::getNextIntersection(const NodeID at, const EdgeID via) cons
if (intersection_parameters.node == SPECIAL_NODEID || if (intersection_parameters.node == SPECIAL_NODEID ||
intersection_parameters.edge == SPECIAL_EDGEID) intersection_parameters.edge == SPECIAL_EDGEID)
{ {
return boost::none; return {};
} }
auto intersection = extractor::intersection::getConnectedRoads<false>(node_based_graph, auto intersection = extractor::intersection::getConnectedRoads<false>(node_based_graph,
@ -465,11 +465,10 @@ IntersectionHandler::getNextIntersection(const NodeID at, const EdgeID via) cons
if (intersection.size() <= 2 || intersection.isTrafficSignalOrBarrier()) if (intersection.size() <= 2 || intersection.isTrafficSignalOrBarrier())
{ {
return boost::none; return {};
} }
return boost::make_optional( return std::make_optional(IntersectionViewAndNode{std::move(intersection), intersection_node});
IntersectionViewAndNode{std::move(intersection), intersection_node});
} }
bool IntersectionHandler::isSameName(const EdgeID source_edge_id, const EdgeID target_edge_id) const bool IntersectionHandler::isSameName(const EdgeID source_edge_id, const EdgeID target_edge_id) const

View File

@ -634,7 +634,7 @@ Intersection SliproadHandler::operator()(const NodeID /*nid*/,
// Implementation details // Implementation details
boost::optional<std::size_t> SliproadHandler::getObviousIndexWithSliproads( std::optional<std::size_t> SliproadHandler::getObviousIndexWithSliproads(
const EdgeID from, const Intersection &intersection, const NodeID at) const const EdgeID from, const Intersection &intersection, const NodeID at) const
{ {
BOOST_ASSERT(from != SPECIAL_EDGEID); BOOST_ASSERT(from != SPECIAL_EDGEID);
@ -645,14 +645,14 @@ boost::optional<std::size_t> SliproadHandler::getObviousIndexWithSliproads(
if (index != 0) if (index != 0)
{ {
return boost::make_optional(index); return std::make_optional(index);
} }
// Otherwise check if the road is forking into two and one of them is a Sliproad; // Otherwise check if the road is forking into two and one of them is a Sliproad;
// then the non-Sliproad is the obvious one. // then the non-Sliproad is the obvious one.
if (intersection.size() != 3) if (intersection.size() != 3)
{ {
return boost::none; return {};
} }
const auto forking = intersection[1].instruction.type == TurnType::Fork && const auto forking = intersection[1].instruction.type == TurnType::Fork &&
@ -660,7 +660,7 @@ boost::optional<std::size_t> SliproadHandler::getObviousIndexWithSliproads(
if (!forking) if (!forking)
{ {
return boost::none; return {};
} }
const auto first = getNextIntersection(at, intersection.getRightmostRoad().eid); const auto first = getNextIntersection(at, intersection.getRightmostRoad().eid);
@ -668,27 +668,27 @@ boost::optional<std::size_t> SliproadHandler::getObviousIndexWithSliproads(
if (!first || !second) if (!first || !second)
{ {
return boost::none; return {};
} }
if (first->intersection.isDeadEnd() || second->intersection.isDeadEnd()) if (first->intersection.isDeadEnd() || second->intersection.isDeadEnd())
{ {
return boost::none; return {};
} }
// In case of loops at the end of the road, we will arrive back at the intersection // In case of loops at the end of the road, we will arrive back at the intersection
// itself. If that is the case, the road is obviously not a sliproad. // itself. If that is the case, the road is obviously not a sliproad.
if (canBeTargetOfSliproad(first->intersection) && at != second->node) if (canBeTargetOfSliproad(first->intersection) && at != second->node)
{ {
return boost::make_optional(std::size_t{2}); return std::make_optional(std::size_t{2});
} }
if (canBeTargetOfSliproad(second->intersection) && at != first->node) if (canBeTargetOfSliproad(second->intersection) && at != first->node)
{ {
return boost::make_optional(std::size_t{1}); return std::make_optional(std::size_t{1});
} }
return boost::none; return {};
} }
bool SliproadHandler::nextIntersectionIsTooFarAway(const NodeID start, const EdgeID onto) const bool SliproadHandler::nextIntersectionIsTooFarAway(const NodeID start, const EdgeID onto) const

View File

@ -6,10 +6,10 @@
#include <algorithm> #include <algorithm>
#include <limits> #include <limits>
#include <optional>
#include <utility> #include <utility>
#include <boost/assert.hpp> #include <boost/assert.hpp>
#include <boost/optional.hpp>
using osrm::util::angularDeviation; using osrm::util::angularDeviation;
@ -590,7 +590,7 @@ Intersection TurnHandler::assignRightTurns(const EdgeID via_edge,
} }
// finds a fork candidate by just looking at the geometry and angle of an intersection // finds a fork candidate by just looking at the geometry and angle of an intersection
boost::optional<TurnHandler::Fork> std::optional<TurnHandler::Fork>
TurnHandler::findForkCandidatesByGeometry(Intersection &intersection) const TurnHandler::findForkCandidatesByGeometry(Intersection &intersection) const
{ {
if (intersection.size() >= 3) if (intersection.size() >= 3)
@ -647,7 +647,7 @@ TurnHandler::findForkCandidatesByGeometry(Intersection &intersection) const
} }
} }
} }
return boost::none; return {};
} }
// check if the fork candidates (all roads between left and right) and the // check if the fork candidates (all roads between left and right) and the
@ -695,8 +695,8 @@ bool TurnHandler::isCompatibleByRoadClass(const Intersection &intersection, cons
// Checks whether a three-way-intersection coming from `via_edge` is a fork // Checks whether a three-way-intersection coming from `via_edge` is a fork
// with `intersection` as described as in #IntersectionExplanation@intersection_handler.hpp // with `intersection` as described as in #IntersectionExplanation@intersection_handler.hpp
boost::optional<TurnHandler::Fork> TurnHandler::findFork(const EdgeID via_edge, std::optional<TurnHandler::Fork> TurnHandler::findFork(const EdgeID via_edge,
Intersection &intersection) const Intersection &intersection) const
{ {
auto fork = findForkCandidatesByGeometry(intersection); auto fork = findForkCandidatesByGeometry(intersection);
if (fork) if (fork)
@ -740,7 +740,7 @@ boost::optional<TurnHandler::Fork> TurnHandler::findFork(const EdgeID via_edge,
} }
} }
return boost::none; return {};
} }
void TurnHandler::handleDistinctConflict(const EdgeID via_edge, void TurnHandler::handleDistinctConflict(const EdgeID via_edge,

View File

@ -0,0 +1,68 @@
#ifndef OSRM_BINDINGS_NODE_JSON_V8_RENDERER_HPP
#define OSRM_BINDINGS_NODE_JSON_V8_RENDERER_HPP
#include "osrm/json_container.hpp"
#include <napi.h>
#include <functional>
namespace node_osrm
{
struct V8Renderer
{
explicit V8Renderer(const Napi::Env &env, Napi::Value &out) : env(env), out(out) {}
void operator()(const osrm::json::String &string) const
{
out = Napi::String::New(env, string.value);
}
void operator()(const osrm::json::Number &number) const
{
out = Napi::Number::New(env, number.value);
}
void operator()(const osrm::json::Object &object) const
{
Napi::Object obj = Napi::Object::New(env);
for (const auto &keyValue : object.values)
{
Napi::Value child;
mapbox::util::apply_visitor(V8Renderer(env, child), keyValue.second);
obj.Set(keyValue.first, child);
}
out = obj;
}
void operator()(const osrm::json::Array &array) const
{
Napi::Array a = Napi::Array::New(env, array.values.size());
for (auto i = 0u; i < array.values.size(); ++i)
{
Napi::Value child;
mapbox::util::apply_visitor(V8Renderer(env, child), array.values[i]);
a.Set(i, child);
}
out = a;
}
void operator()(const osrm::json::True &) const { out = Napi::Boolean::New(env, true); }
void operator()(const osrm::json::False &) const { out = Napi::Boolean::New(env, false); }
void operator()(const osrm::json::Null &) const { out = env.Null(); }
private:
const Napi::Env &env;
Napi::Value &out;
};
inline void renderToV8(const Napi::Env &env, Napi::Value &out, const osrm::json::Object &object)
{
V8Renderer renderer(env, out);
renderer(object);
}
} // namespace node_osrm
#endif // JSON_V8_RENDERER_HPP

32
src/nodejs/node_osrm.hpp Normal file
View File

@ -0,0 +1,32 @@
#ifndef OSRM_BINDINGS_NODE_HPP
#define OSRM_BINDINGS_NODE_HPP
#include "osrm/osrm_fwd.hpp"
#include <napi.h>
#include <memory>
namespace node_osrm
{
class Engine final : public Napi::ObjectWrap<Engine>
{
public:
static Napi::Object Init(Napi::Env env, Napi::Object exports);
Engine(const Napi::CallbackInfo &info);
std::shared_ptr<osrm::OSRM> this_;
private:
Napi::Value route(const Napi::CallbackInfo &info);
Napi::Value nearest(const Napi::CallbackInfo &info);
Napi::Value table(const Napi::CallbackInfo &info);
Napi::Value tile(const Napi::CallbackInfo &info);
Napi::Value match(const Napi::CallbackInfo &info);
Napi::Value trip(const Napi::CallbackInfo &info);
};
} // namespace node_osrm
#endif

File diff suppressed because it is too large Load Diff

View File

@ -9,6 +9,7 @@
#include <algorithm> #include <algorithm>
#include <iterator> #include <iterator>
#include <limits> #include <limits>
#include <optional>
#include <utility> #include <utility>
namespace osrm::util::coordinate_calculation namespace osrm::util::coordinate_calculation
@ -173,14 +174,14 @@ double computeAngle(const Coordinate first, const Coordinate second, const Coord
return angle; return angle;
} }
boost::optional<Coordinate> std::optional<Coordinate>
circleCenter(const Coordinate C1, const Coordinate C2, const Coordinate C3) circleCenter(const Coordinate C1, const Coordinate C2, const Coordinate C3)
{ {
// free after http://paulbourke.net/geometry/circlesphere/ // free after http://paulbourke.net/geometry/circlesphere/
// require three distinct points // require three distinct points
if (C1 == C2 || C2 == C3 || C1 == C3) if (C1 == C2 || C2 == C3 || C1 == C3)
{ {
return boost::none; return {};
} }
// define line through c1, c2 and c2,c3 // define line through c1, c2 and c2,c3
@ -195,7 +196,7 @@ circleCenter(const Coordinate C1, const Coordinate C2, const Coordinate C3)
(std::abs(C2C1_lat) < std::numeric_limits<double>::epsilon() && (std::abs(C2C1_lat) < std::numeric_limits<double>::epsilon() &&
std::abs(C3C2_lat) < std::numeric_limits<double>::epsilon())) std::abs(C3C2_lat) < std::numeric_limits<double>::epsilon()))
{ {
return boost::none; return {};
} }
else if (std::abs(C2C1_lon) < std::numeric_limits<double>::epsilon()) else if (std::abs(C2C1_lon) < std::numeric_limits<double>::epsilon())
{ {
@ -233,7 +234,7 @@ circleCenter(const Coordinate C1, const Coordinate C2, const Coordinate C3)
// can this ever happen? // can this ever happen?
if (std::abs(C2C1_slope - C3C2_slope) < std::numeric_limits<double>::epsilon()) if (std::abs(C2C1_slope - C3C2_slope) < std::numeric_limits<double>::epsilon())
return boost::none; return {};
const double C1_y = static_cast<double>(toFloating(C1.lat)); const double C1_y = static_cast<double>(toFloating(C1.lat));
const double C1_x = static_cast<double>(toFloating(C1.lon)); const double C1_x = static_cast<double>(toFloating(C1.lon));
@ -247,7 +248,7 @@ circleCenter(const Coordinate C1, const Coordinate C2, const Coordinate C3)
(2 * (C3C2_slope - C2C1_slope)); (2 * (C3C2_slope - C2C1_slope));
const double lat = (0.5 * (C1_x + C2_x) - lon) / C2C1_slope + 0.5 * (C1_y + C2_y); const double lat = (0.5 * (C1_x + C2_x) - lon) / C2C1_slope + 0.5 * (C1_y + C2_y);
if (lon < -180.0 || lon > 180.0 || lat < -90.0 || lat > 90.0) if (lon < -180.0 || lon > 180.0 || lat < -90.0 || lat > 90.0)
return boost::none; return {};
else else
return Coordinate(FloatLongitude{lon}, FloatLatitude{lat}); return Coordinate(FloatLongitude{lon}, FloatLatitude{lat});
} }

View File

@ -17,7 +17,7 @@ NodeIdVectorToLineString::NodeIdVectorToLineString(
// converts a vector of node ids into a linestring geojson feature // converts a vector of node ids into a linestring geojson feature
util::json::Object util::json::Object
NodeIdVectorToLineString::operator()(const std::vector<NodeID> &node_ids, NodeIdVectorToLineString::operator()(const std::vector<NodeID> &node_ids,
const boost::optional<json::Object> &properties) const const std::optional<json::Object> &properties) const
{ {
util::json::Array coordinates; util::json::Array coordinates;
std::transform(node_ids.begin(), std::transform(node_ids.begin(),
@ -37,7 +37,7 @@ NodeIdVectorToMultiPoint::NodeIdVectorToMultiPoint(
util::json::Object util::json::Object
NodeIdVectorToMultiPoint::operator()(const std::vector<NodeID> &node_ids, NodeIdVectorToMultiPoint::operator()(const std::vector<NodeID> &node_ids,
const boost::optional<json::Object> &properties) const const std::optional<json::Object> &properties) const
{ {
util::json::Array coordinates; util::json::Array coordinates;
std::transform(node_ids.begin(), std::transform(node_ids.begin(),
@ -51,7 +51,7 @@ NodeIdVectorToMultiPoint::operator()(const std::vector<NodeID> &node_ids,
//---------------------------------------------------------------- //----------------------------------------------------------------
util::json::Object util::json::Object
CoordinateVectorToMultiPoint::operator()(const std::vector<util::Coordinate> &input_coordinates, CoordinateVectorToMultiPoint::operator()(const std::vector<util::Coordinate> &input_coordinates,
const boost::optional<json::Object> &properties) const const std::optional<json::Object> &properties) const
{ {
auto coordinates = makeJsonArray(input_coordinates); auto coordinates = makeJsonArray(input_coordinates);
return makeFeature("MultiPoint", std::move(coordinates), properties); return makeFeature("MultiPoint", std::move(coordinates), properties);
@ -60,7 +60,7 @@ CoordinateVectorToMultiPoint::operator()(const std::vector<util::Coordinate> &in
//---------------------------------------------------------------- //----------------------------------------------------------------
util::json::Object util::json::Object
CoordinateVectorToLineString::operator()(const std::vector<util::Coordinate> &input_coordinates, CoordinateVectorToLineString::operator()(const std::vector<util::Coordinate> &input_coordinates,
const boost::optional<json::Object> &properties) const const std::optional<json::Object> &properties) const
{ {
auto coordinates = makeJsonArray(input_coordinates); auto coordinates = makeJsonArray(input_coordinates);
return makeFeature("LineString", std::move(coordinates), properties); return makeFeature("LineString", std::move(coordinates), properties);

View File

@ -5,13 +5,13 @@
#include <boost/filesystem/fstream.hpp> #include <boost/filesystem/fstream.hpp>
#include <boost/filesystem/path.hpp> #include <boost/filesystem/path.hpp>
#include <boost/optional.hpp>
#include <rapidjson/document.h> #include <rapidjson/document.h>
#include <rapidjson/error/en.h> #include <rapidjson/error/en.h>
#include <rapidjson/istreamwrapper.h> #include <rapidjson/istreamwrapper.h>
#include <fstream> #include <fstream>
#include <optional>
#include <regex> #include <regex>
#include <string> #include <string>
#include <unordered_map> #include <unordered_map>
@ -158,7 +158,7 @@ void Timezoner::LoadLocalTimesRTree(rapidjson::Document &geojson, std::time_t ut
rtree = rtree_t(polygons); rtree = rtree_t(polygons);
} }
boost::optional<struct tm> Timezoner::operator()(const point_t &point) const std::optional<struct tm> Timezoner::operator()(const point_t &point) const
{ {
std::vector<rtree_t::value_type> result; std::vector<rtree_t::value_type> result;
rtree.query(boost::geometry::index::intersects(point), std::back_inserter(result)); rtree.query(boost::geometry::index::intersects(point), std::back_inserter(result));
@ -168,6 +168,6 @@ boost::optional<struct tm> Timezoner::operator()(const point_t &point) const
if (boost::geometry::within(point, local_times[index].first)) if (boost::geometry::within(point, local_times[index].first))
return local_times[index].second; return local_times[index].second;
} }
return boost::none; return {};
} }
} // namespace osrm::updater } // namespace osrm::updater