Use mmap instead of read - it's a lot faster here.

Also clean up construction of STRONG_TYPEDEF so that it can be
packed properly in structs (this explains all the () -> {}) changes
here.

src/util/coordinate.cpp

@@ -19,16 +19,16 @@ namespace util
 
 bool Coordinate::IsValid() const
 {
-    return !(lat > FixedLatitude(90 * COORDINATE_PRECISION) ||
-             lat < FixedLatitude(-90 * COORDINATE_PRECISION) ||
-             lon > FixedLongitude(180 * COORDINATE_PRECISION) ||
-             lon < FixedLongitude(-180 * COORDINATE_PRECISION));
+    return !(lat > FixedLatitude{static_cast<std::int32_t>(90 * COORDINATE_PRECISION)} ||
+             lat < FixedLatitude{static_cast<std::int32_t>(-90 * COORDINATE_PRECISION)} ||
+             lon > FixedLongitude{static_cast<std::int32_t>(180 * COORDINATE_PRECISION)} ||
+             lon < FixedLongitude{static_cast<std::int32_t>(-180 * COORDINATE_PRECISION)});
 }
 
 bool FloatCoordinate::IsValid() const
 {
-    return !(lat > FloatLatitude(90) || lat < FloatLatitude(-90) || lon > FloatLongitude(180) ||
-             lon < FloatLongitude(-180));
+    return !(lat > FloatLatitude{90} || lat < FloatLatitude{-90} || lon > FloatLongitude{180} ||
+             lon < FloatLongitude{-180});
 }
 
 bool operator==(const Coordinate lhs, const Coordinate rhs)

src/util/coordinate_calculation.cpp

@@ -115,8 +115,8 @@ Coordinate centroid(const Coordinate lhs, const Coordinate rhs)
     Coordinate centroid;
     // The coordinates of the midpoints are given by:
     // x = (x1 + x2) /2 and y = (y1 + y2) /2.
-    centroid.lon = (lhs.lon + rhs.lon) / FixedLongitude(2);
-    centroid.lat = (lhs.lat + rhs.lat) / FixedLatitude(2);
+    centroid.lon = (lhs.lon + rhs.lon) / FixedLongitude{2};
+    centroid.lat = (lhs.lat + rhs.lat) / FixedLatitude{2};
     return centroid;
 }
 
@@ -261,7 +261,7 @@ circleCenter(const Coordinate C1, const Coordinate C2, const Coordinate C3)
         if (lon < -180.0 || lon > 180.0 || lat < -90.0 || lat > 90.0)
             return boost::none;
         else
-            return Coordinate(FloatLongitude(lon), FloatLatitude(lat));
+            return Coordinate(FloatLongitude{lon}, FloatLatitude{lat});
     }
 }
 
@@ -284,8 +284,8 @@ Coordinate interpolateLinear(double factor, const Coordinate from, const Coordin
     const auto to_lon = static_cast<std::int32_t>(to.lon);
     const auto to_lat = static_cast<std::int32_t>(to.lat);
 
-    FixedLongitude interpolated_lon(from_lon + factor * (to_lon - from_lon));
-    FixedLatitude interpolated_lat(from_lat + factor * (to_lat - from_lat));
+    FixedLongitude interpolated_lon{static_cast<std::int32_t>(from_lon + factor * (to_lon - from_lon))};
+    FixedLatitude interpolated_lat{static_cast<std::int32_t>(from_lat + factor * (to_lat - from_lat))};
 
     return {std::move(interpolated_lon), std::move(interpolated_lat)};
 }