Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Remove highway=bicycle safety bonus (#6296)

Browse Source 
* Remove highway=bicycle safety bonus

This removes a bonus for a road class that doesn't exist (cycleway would
be correct), but the code was buggy since safety_bonus is nil and caused
an arithmetic exception. We only caught this 4 (!) years later since
recently a way was tagged with highway=bicycle and made it in our OSM
data leading to preprocessing failures.
This commit is contained in:
Patrick Niklaus
2022-08-15 22:14:37 +02:00
committed by GitHub
parent f19247a7ca
commit e5450e8c68
2 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
profiles/bicycle.lua
-15
View File
@@ -543,21 +543,6 @@ function safety_handler(profile,way,result,data)
if result.duration > 0 then
result.weight = result.duration / forward_penalty
end
if data.highway == "bicycle" then
safety_bonus = safety_bonus + 0.2
if result.forward_speed > 0 then
-- convert from km/h to m/s
result.forward_rate = result.forward_speed / 3.6 * safety_bonus
end
if result.backward_speed > 0 then
-- convert from km/h to m/s
result.backward_rate = result.backward_speed / 3.6 * safety_bonus
end
if result.duration > 0 then
result.weight = result.duration / safety_bonus
end
end
end
end