Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Makes switching between floating and fixed coordinates safe wrt. overflows

Browse Source
This commit is contained in:
Daniel J. Hofmann 2016-03-21 15:37:18 +01:00 committed by Patrick Niklaus
parent 8e477437a6
commit df608e8b43
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
include/util/coordinate.hpp
View File

@ -30,6 +30,8 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include "util/strong_typedef.hpp" #include "util/strong_typedef.hpp"
#include <boost/numeric/conversion/cast.hpp>
#include <iosfwd> //for std::ostream #include <iosfwd> //for std::ostream
#include <string> #include <string>
#include <type_traits> #include <type_traits>
@ -50,22 +52,30 @@ OSRM_STRONG_TYPEDEF(double, FloatLongitude)
inline FixedLatitude toFixed(const FloatLatitude floating) inline FixedLatitude toFixed(const FloatLatitude floating)
{ {
return FixedLatitude(static_cast<double>(floating) * COORDINATE_PRECISION); const auto latitude = static_cast<double>(floating);
const auto fixed = boost::numeric_cast<std::int32_t>(latitude * COORDINATE_PRECISION);
return FixedLatitude(fixed);
} }
inline FixedLongitude toFixed(const FloatLongitude floating) inline FixedLongitude toFixed(const FloatLongitude floating)
{ {
return FixedLongitude(static_cast<double>(floating) * COORDINATE_PRECISION); const auto longitude = static_cast<double>(floating);
const auto fixed = boost::numeric_cast<std::int32_t>(longitude * COORDINATE_PRECISION);
return FixedLongitude(fixed);
} }
inline FloatLatitude toFloating(const FixedLatitude fixed) inline FloatLatitude toFloating(const FixedLatitude fixed)
{ {
return FloatLatitude(static_cast<int32_t>(fixed) / COORDINATE_PRECISION); const auto latitude = static_cast<std::int32_t>(fixed);
const auto floating = boost::numeric_cast<double>(latitude / COORDINATE_PRECISION);
return FloatLatitude(floating);
} }
inline FloatLongitude toFloating(const FixedLongitude fixed) inline FloatLongitude toFloating(const FixedLongitude fixed)
{ {
return FloatLongitude(static_cast<int32_t>(fixed) / COORDINATE_PRECISION); const auto longitude = static_cast<std::int32_t>(fixed);
const auto floating = boost::numeric_cast<double>(longitude / COORDINATE_PRECISION);
return FloatLongitude(floating);
} }
// Coordinate encoded as longitude, latitude // Coordinate encoded as longitude, latitude