Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Don't pass by const-value for a read-only view.

Browse Source 
I can't see a reason we pass by const-value here.

Note: changes API because of the `route_parameters` header.
This commit is contained in:
Daniel J. Hofmann 2015-09-08 23:34:20 +02:00
parent bed0598530
commit db092c828e
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
data_structures/route_parameters.cpp
View File

@ -134,7 +134,7 @@ void RouteParameters::addCoordinate(
static_cast<int>(COORDINATE_PRECISION * boost::fusion::at_c<1>(received_coordinates)));
}
void RouteParameters::getCoordinatesFromGeometry(const std::string geometry_string)
void RouteParameters::getCoordinatesFromGeometry(const std::string &geometry_string)
{
PolylineCompressor pc;
coordinates = pc.decode_string(geometry_string);

4
data_structures/static_rtree.hpp
View File

@ -345,8 +345,8 @@ class StaticRTree
// Construct a packed Hilbert-R-Tree with Kamel-Faloutsos algorithm [1]
explicit StaticRTree(const std::vector<EdgeDataT> &input_data_vector,
const std::string tree_node_filename,
const std::string leaf_node_filename,
const std::string &tree_node_filename,
const std::string &leaf_node_filename,
const std::vector<QueryNode> &coordinate_list)
: m_element_count(input_data_vector.size()), m_leaf_node_filename(leaf_node_filename)
{

2
include/osrm/route_parameters.hpp
View File

@ -79,7 +79,7 @@ struct RouteParameters
void addCoordinate(const boost::fusion::vector<double, double> &received_coordinates);
void getCoordinatesFromGeometry(const std::string geometry_string);
void getCoordinatesFromGeometry(const std::string &geometry_string);
short zoom_level;
bool print_instructions;