Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

adjust case/add clarification

Browse Source
This commit is contained in:
Moritz Kobitzsch 2016-09-29 10:26:04 +02:00
parent 1a96483f7b
commit da15e1fc5e
3 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -3,6 +3,8 @@
- Profiles - Profiles
- `restrictions` is now used for namespaced restrictions and restriction exceptions (e.g. `restriction:motorcar=` as well as `except=motorcar`) - `restrictions` is now used for namespaced restrictions and restriction exceptions (e.g. `restriction:motorcar=` as well as `except=motorcar`)
- replaced lhs/rhs profiles by using test defined profiles - replaced lhs/rhs profiles by using test defined profiles
- Guidance
- Notifications are now exposed more prominently, announcing turns onto a ferry/pushing your bike more prominently
- Trip Plugin - Trip Plugin
- changed internal behaviour to prefer the smallest lexicographic result over the largest one - changed internal behaviour to prefer the smallest lexicographic result over the largest one

4
features/guidance/collapse.feature
View File

@ -836,5 +836,5 @@ Feature: Collapse
| ej | primary | | off | yes | | ej | primary | | off | yes |
When I route I should get When I route I should get
| waypoints | route | turns | | waypoints | route | turns |
| k,j | on,ferry,,ferry,off,off | depart,new name straight,continue uturn,turn straight,new name straight,arrive | | k,j | on,ferry,,ferry,off,off | depart,notification straight,continue uturn,turn straight,notification straight,arrive |

12
src/extractor/guidance/intersection_handler.cpp
View File

@ -110,7 +110,11 @@ TurnInstruction IntersectionHandler::getInstructionForObvious(const std::size_t
else if (in_data.road_classification.IsRampClass() && else if (in_data.road_classification.IsRampClass() &&
out_data.road_classification.IsRampClass()) out_data.road_classification.IsRampClass())
{ {
return {in_mode == out_mode ? TurnType::Suppressed : TurnType::Notification, getTurnDirection(road.turn.angle)}; // This check is more a precaution than anything else. Our current travel modes
// cannot reach this, since all ramps are exposing the same travel type. But we
// could see toll-type at some point.
return {in_mode == out_mode ? TurnType::Suppressed : TurnType::Notification,
getTurnDirection(road.turn.angle)};
} }
else else
{ {
@ -137,13 +141,15 @@ TurnInstruction IntersectionHandler::getInstructionForObvious(const std::size_t
} }
else else
{ {
return {in_mode == out_mode ? TurnType::NewName : TurnType::Notification, getTurnDirection(road.turn.angle)}; return {in_mode == out_mode ? TurnType::NewName : TurnType::Notification,
getTurnDirection(road.turn.angle)};
} }
} }
// name has not changed, suppress a turn here or indicate mode change // name has not changed, suppress a turn here or indicate mode change
else else
{ {
return {in_mode == out_mode ? TurnType::Suppressed : TurnType::Notification, getTurnDirection(road.turn.angle)}; return {in_mode == out_mode ? TurnType::Suppressed : TurnType::Notification,
getTurnDirection(road.turn.angle)};
} }
} }
BOOST_ASSERT(type == TurnType::Continue); BOOST_ASSERT(type == TurnType::Continue);