Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Fixes Cucumber's Unknown Node Error Reporting

Browse Source 
Before: `unknown node %s`
After: `unknown node t`

https://nodejs.org/api/util.html#util_util_format_format_args
This commit is contained in:
Daniel J. Hofmann 2016-11-02 15:43:52 +01:00 committed by Patrick Niklaus
parent b749d9bd2f
commit ccf5552406
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
features/step_definitions/data.js
View File

@ -103,7 +103,7 @@ module.exports = function () {
let name = row.node, let name = row.node,
node = this.findNodeByName(name); node = this.findNodeByName(name);
delete row.node; delete row.node;
if (!node) throw new Error(util.format('*** unknown node %s'), name); if (!node) throw new Error(util.format('*** unknown node %s', name));
for (let key in row) { for (let key in row) {
if (key=='id') { if (key=='id') {
node.setID( row[key] ); node.setID( row[key] );

6
features/step_definitions/distance_matrix.js
View File

@ -16,18 +16,18 @@ module.exports = function () {
if (symmetric) { if (symmetric) {
columnHeaders.forEach((nodeName) => { columnHeaders.forEach((nodeName) => {
var node = this.findNodeByName(nodeName); var node = this.findNodeByName(nodeName);
if (!node) throw new Error(util.format('*** unknown node "%s"'), nodeName); if (!node) throw new Error(util.format('*** unknown node "%s"', nodeName));
waypoints.push({ coord: node, type: 'loc' }); waypoints.push({ coord: node, type: 'loc' });
}); });
} else { } else {
columnHeaders.forEach((nodeName) => { columnHeaders.forEach((nodeName) => {
var node = this.findNodeByName(nodeName); var node = this.findNodeByName(nodeName);
if (!node) throw new Error(util.format('*** unknown node "%s"'), nodeName); if (!node) throw new Error(util.format('*** unknown node "%s"', nodeName));
waypoints.push({ coord: node, type: 'dst' }); waypoints.push({ coord: node, type: 'dst' });
}); });
rowHeaders.forEach((nodeName) => { rowHeaders.forEach((nodeName) => {
var node = this.findNodeByName(nodeName); var node = this.findNodeByName(nodeName);
if (!node) throw new Error(util.format('*** unknown node "%s"'), nodeName); if (!node) throw new Error(util.format('*** unknown node "%s"', nodeName));
waypoints.push({ coord: node, type: 'src' }); waypoints.push({ coord: node, type: 'src' });
}); });
} }