Fix a couple of warnings found by PVS Studio (#6372)

.github/workflows/osrm-backend.yml

@@ -607,7 +607,6 @@ jobs:
       
         # Linux dev packages
         if [ "${TARGET_ARCH}" != "i686" ] && [ "${ENABLE_CONAN}" != "ON" ]; then
-          sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y
           sudo apt-get update -y
           sudo apt-get install -y libbz2-dev libxml2-dev libzip-dev liblua5.2-dev libboost-all-dev
           if [[ "${CCOMPILER}" != clang-* ]]; then

include/engine/phantom_node.hpp

@@ -54,6 +54,7 @@ struct PhantomNode
           forward_distance_offset(0), reverse_distance_offset(0),
           forward_duration(MAXIMAL_EDGE_DURATION), reverse_duration(MAXIMAL_EDGE_DURATION),
           forward_duration_offset(0), reverse_duration_offset(0),
+          component({INVALID_COMPONENTID, 0}),
           fwd_segment_position(0), is_valid_forward_source{false}, is_valid_forward_target{false},
           is_valid_reverse_source{false}, is_valid_reverse_target{false}, bearing(0)
 

include/extractor/node_based_edge.hpp

@@ -135,7 +135,8 @@ struct NodeBasedEdgeWithOSM : NodeBasedEdge
 
 inline NodeBasedEdgeClassification::NodeBasedEdgeClassification()
     : forward(false), backward(false), is_split(false), roundabout(false), circular(false),
-      startpoint(false), restricted(false)
+      startpoint(false), restricted(false), highway_turn_classification(0),
+      access_turn_classification(0)
 {
 }
 

include/extractor/restriction.hpp

@@ -28,7 +28,7 @@ struct TurnRestriction
     // The turn sequence that the restriction applies to.
     TurnPath turn_path;
     // Indicates if the restriction turn *must* or *must not* be taken.
-    bool is_only;
+    bool is_only = false;
     // We represent conditional and unconditional restrictions with the same structure.
     // Unconditional restrictions will have empty conditions.
     std::vector<util::OpeningHours> condition;

include/extractor/scripting_environment_lua.hpp

@@ -38,17 +38,17 @@ struct LuaScriptingContext final
     RasterContainer raster_sources;
     sol::state state;
 
-    bool has_turn_penalty_function;
-    bool has_node_function;
-    bool has_way_function;
-    bool has_segment_function;
+    bool has_turn_penalty_function = false;
+    bool has_node_function = false;
+    bool has_way_function = false;
+    bool has_segment_function = false;
 
     sol::function turn_function;
     sol::function way_function;
     sol::function node_function;
     sol::function segment_function;
 
-    int api_version;
+    int api_version = 4;
     sol::table profile_table;
 
     // Reference to immutable location dependent data and locations memo

include/partitioner/multi_level_graph.hpp

@@ -231,7 +231,7 @@ class MultiLevelGraph : public util::StaticGraph<EdgeDataT, Ownership>
 
   protected:
     Vector<EdgeOffset> node_to_edge_offset;
-    std::uint32_t connectivity_checksum;
+    std::uint32_t connectivity_checksum = 0;
 };
 
 using MultiLevelEdgeBasedGraph =

include/server/server.hpp

@@ -107,11 +107,11 @@ class Server
         }
     }
 
+    RequestHandler request_handler;
     unsigned thread_pool_size;
     boost::asio::io_context io_context;
     boost::asio::ip::tcp::acceptor acceptor;
     std::shared_ptr<Connection> new_connection;
-    RequestHandler request_handler;
 };
 } // namespace server
 } // namespace osrm

include/storage/shared_datatype.hpp

@@ -211,7 +211,7 @@ struct SharedRegion
 
     char name[MAX_NAME_LENGTH + 1];
     std::uint64_t timestamp;
-    std::uint16_t shm_key;
+    std::uint16_t shm_key = 0;
 };
 
 // Keeps a list of all shared regions in a fixed-sized struct

include/updater/updater_config.hpp

@@ -66,7 +66,7 @@ struct UpdaterConfig final : storage::IOConfig
         IOConfig::UseDefaultOutputNames(base);
     }
 
-    double log_edge_updates_factor;
+    double log_edge_updates_factor = 0.0;
     std::time_t valid_now;
 
     std::vector<std::string> segment_speed_lookup_paths;