Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Moving from references is a bad idea in parameter parsers, too

Browse Source
This commit is contained in:
Daniel J. Hofmann 2016-04-01 12:55:22 +02:00 committed by Patrick Niklaus
parent d27025003a
commit b25cd6aaf2
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/server/api/base_parameters_grammar.hpp
View File

@ -48,7 +48,7 @@ struct BaseParametersGrammar : boost::spirit::qi::grammar<std::string::iterator>
} }
base_parameters.bearings.push_back(std::move(bearing)); base_parameters.bearings.push_back(std::move(bearing));
}; };
const auto set_radiuses = [this](RadiusesT &radiuses) const auto set_radiuses = [this](RadiusesT radiuses)
{ {
base_parameters.radiuses = std::move(radiuses); base_parameters.radiuses = std::move(radiuses);
}; };

2
include/server/api/match_parameter_grammar.hpp
View File

@ -56,7 +56,7 @@ struct MatchParametersGrammar final : public BaseParametersGrammar
{ {
parameters.steps = steps; parameters.steps = steps;
}; };
const auto set_timestamps = [this](TimestampsT &timestamps) const auto set_timestamps = [this](TimestampsT timestamps)
{ {
parameters.timestamps = std::move(timestamps); parameters.timestamps = std::move(timestamps);
}; };

2
include/server/api/route_parameters_grammar.hpp
View File

@ -60,7 +60,7 @@ struct RouteParametersGrammar : public BaseParametersGrammar
{ {
parameters.alternatives = alternatives; parameters.alternatives = alternatives;
}; };
const auto set_uturns = [this](UturnsT &uturns) const auto set_uturns = [this](UturnsT uturns)
{ {
parameters.uturns = std::move(uturns); parameters.uturns = std::move(uturns);
}; };

4
include/server/api/table_parameter_grammar.hpp
View File

@ -28,11 +28,11 @@ struct TableParametersGrammar final : public BaseParametersGrammar
TableParametersGrammar() : BaseParametersGrammar(root_rule, parameters) TableParametersGrammar() : BaseParametersGrammar(root_rule, parameters)
{ {
const auto set_destiantions = [this](DestinationsT &dests) const auto set_destiantions = [this](DestinationsT dests)
{ {
parameters.destinations = std::move(dests); parameters.destinations = std::move(dests);
}; };
const auto set_sources = [this](SourcesT &sources) const auto set_sources = [this](SourcesT sources)
{ {
parameters.sources = std::move(sources); parameters.sources = std::move(sources);
}; };