Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Adds generate_hints=true for dropping hints in response, resolves #1789.

Browse Source 
Adds an `generate_hints=false` option which lets us skip generating and
emitting hints for Waypoints. This can be used to decrease the response
size when the user does not need hints anyway.

We should think about making `false` the default here in v6.
This commit is contained in:
Daniel J. Hofmann
2016-12-15 15:28:54 +01:00
parent f04d146ca3
commit b1f6797aab
13 changed files with 83 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
unit_tests/server/parameters_parser.cpp
+15
View File
@@ -49,6 +49,8 @@ BOOST_AUTO_TEST_CASE(invalid_route_urls)
29UL);
BOOST_CHECK_EQUAL(testInvalidOptions<RouteParameters>("1,2;3,4?overview=false&hints=;;; ;"),
32UL);
BOOST_CHECK_EQUAL(testInvalidOptions<RouteParameters>("1,2;3,4?generate_hints=notboolean"),
23UL);
BOOST_CHECK_EQUAL(testInvalidOptions<RouteParameters>("1,2;3,4?overview=false&geometries=foo"),
34UL);
BOOST_CHECK_EQUAL(testInvalidOptions<RouteParameters>("1,2;3,4?overview=false&overview=foo"),
@@ -296,6 +298,19 @@ BOOST_AUTO_TEST_CASE(valid_route_urls)
CHECK_EQUAL_RANGE(reference_10.radiuses, result_10->radiuses);
CHECK_EQUAL_RANGE(reference_10.coordinates, result_10->coordinates);
CHECK_EQUAL_RANGE(reference_10.hints, result_10->hints);
// Do not generate Hints when they are explicitely disabled
auto result_11 = parseParameters<RouteParameters>("1,2;3,4?generate_hints=false");
BOOST_CHECK(result_11);
BOOST_CHECK_EQUAL(result_11->generate_hints, false);
auto result_12 = parseParameters<RouteParameters>("1,2;3,4?generate_hints=true");
BOOST_CHECK(result_12);
BOOST_CHECK_EQUAL(result_12->generate_hints, true);
auto result_13 = parseParameters<RouteParameters>("1,2;3,4");
BOOST_CHECK(result_13);
BOOST_CHECK_EQUAL(result_13->generate_hints, true);
}
BOOST_AUTO_TEST_CASE(valid_table_urls)