RAII for auto-closing file streams

Small fixes I didn't want to include in unrelated PRs.

There are a few left in `storage.cpp` but since it's a single function
in 600 lines of code, I didn't want to touch the mess. The others are
safe to remove, cucumber and test run on Finland gives 👍.

src/extractor/compressed_edge_container.cpp

@@ -84,8 +84,6 @@ void CompressedEdgeContainer::SerializeInternalVector(const std::string &path) c
         }
     }
     BOOST_ASSERT(control_sum == prefix_sum_of_list_indices);
-    // all done, let's close the resource
-    geometry_out_stream.close();
 }
 
 // Adds info for a compressed edge to the container.   edge_id_2

src/extractor/edge_based_graph_factory.cpp

@@ -476,7 +476,6 @@ void EdgeBasedGraphFactory::GenerateEdgeExpandedEdges(
 
     edge_data_file.seekp(std::ios::beg);
     edge_data_file.write((char *)&original_edges_counter, sizeof(unsigned));
-    edge_data_file.close();
 
     util::SimpleLogger().Write() << "Generated " << m_edge_based_node_list.size()
                                  << " edge based nodes";

src/extractor/extraction_containers.cpp

@@ -90,8 +90,6 @@ void ExtractionContainers::PrepareData(const std::string &output_file_name,
         PrepareEdges(segment_state);
         WriteEdges(file_out_stream);
 
-        file_out_stream.close();
-
         PrepareRestrictions();
         WriteRestrictions(restrictions_file_name);
 
@@ -139,7 +137,6 @@ void ExtractionContainers::WriteNames(const std::string &names_file_name) const
 
     name_file_stream.write(write_buffer, buffer_len);
 
-    name_file_stream.close();
     TIMER_STOP(write_name_index);
     std::cout << "ok, after " << TIMER_SEC(write_name_index) << "s" << std::endl;
 }
@@ -586,7 +583,6 @@ void ExtractionContainers::WriteRestrictions(const std::string &path) const
     }
     restrictions_out_stream.seekp(count_position);
     restrictions_out_stream.write((char *)&written_restriction_count, sizeof(unsigned));
-    restrictions_out_stream.close();
     util::SimpleLogger().Write() << "usable restrictions: " << written_restriction_count;
 }
 

src/extractor/extractor.cpp

@@ -134,7 +134,6 @@ int Extractor::run()
 
         boost::filesystem::ofstream timestamp_out(config.timestamp_file_name);
         timestamp_out.write(timestamp.c_str(), timestamp.length());
-        timestamp_out.close();
 
         // initialize vectors holding parsed objects
         tbb::concurrent_vector<std::pair<std::size_t, ExtractionNode>> resulting_nodes;
@@ -558,7 +557,6 @@ void Extractor::WriteNodeMapping(const std::vector<QueryNode> &internal_to_exter
         node_stream.write((char *)internal_to_external_node_map.data(),
                           size_of_mapping * sizeof(QueryNode));
     }
-    node_stream.close();
 }
 
 /**
@@ -630,7 +628,6 @@ void Extractor::WriteEdgeBasedGraph(
     util::SimpleLogger().Write() << "ok, after " << TIMER_SEC(write_edges) << "s" << std::endl;
 
     util::SimpleLogger().Write() << "Processed " << number_of_used_edges << " edges";
-    file_out_stream.close();
 }
 }
 }