From a013da860e7ecb688d913d551cdde54e6e285f38 Mon Sep 17 00:00:00 2001 From: "Daniel J. Hofmann" Date: Wed, 9 Mar 2016 13:18:09 +0100 Subject: [PATCH] Fixes unneeded includes in contractor header and self-include --- include/contractor/contractor.hpp | 24 +++++++----------------- src/contractor/contractor.cpp | 16 ++++------------ 2 files changed, 11 insertions(+), 29 deletions(-) diff --git a/include/contractor/contractor.hpp b/include/contractor/contractor.hpp index 4398da894..1dfb420bd 100644 --- a/include/contractor/contractor.hpp +++ b/include/contractor/contractor.hpp @@ -1,30 +1,20 @@ #ifndef CONTRACTOR_CONTRACTOR_HPP #define CONTRACTOR_CONTRACTOR_HPP -#include "extractor/edge_based_edge.hpp" -#include "extractor/node_based_edge.hpp" -#include "contractor/contractor.hpp" #include "contractor/contractor_config.hpp" #include "contractor/query_edge.hpp" #include "extractor/edge_based_edge.hpp" #include "extractor/edge_based_node.hpp" -#include "util/static_graph.hpp" +#include "util/typedefs.hpp" #include "util/deallocating_vector.hpp" -#include "util/node_based_graph.hpp" - -#include #include +#include -struct lua_State; +#include namespace osrm { -namespace extractor -{ -struct SpeedProfileProperties; -struct EdgeBasedEdge; -} namespace contractor { @@ -34,11 +24,10 @@ class Contractor public: using EdgeData = QueryEdge::EdgeData; - explicit Contractor(ContractorConfig contractor_config) : config(std::move(contractor_config)) - { - } + explicit Contractor(const ContractorConfig &config_) : config{config_} {} + Contractor(const Contractor &) = delete; - Contractor& operator=(const Contractor &) = delete; + Contractor &operator=(const Contractor &) = delete; int Run(); @@ -61,6 +50,7 @@ class Contractor private: ContractorConfig config; + std::size_t LoadEdgeExpandedGraph(const std::string &edge_based_graph_path, util::DeallocatingVector &edge_based_edge_list, diff --git a/src/contractor/contractor.cpp b/src/contractor/contractor.cpp index 3cfcdef03..1f2bc66e8 100644 --- a/src/contractor/contractor.cpp +++ b/src/contractor/contractor.cpp @@ -1,18 +1,15 @@ #include "contractor/contractor.hpp" +#include "contractor/crc32_processor.hpp" #include "contractor/graph_contractor.hpp" -#include "extractor/edge_based_edge.hpp" +#include "extractor/node_based_edge.hpp" #include "extractor/compressed_edge_container.hpp" +#include "util/static_graph.hpp" #include "util/static_rtree.hpp" - -#include "util/deallocating_vector.hpp" - -#include "contractor/crc32_processor.hpp" #include "util/graph_loader.hpp" #include "util/io.hpp" #include "util/integer_range.hpp" -#include "util/lua_util.hpp" #include "util/exception.hpp" #include "util/simple_logger.hpp" #include "util/string_util.hpp" @@ -21,19 +18,16 @@ #include +#include #include -#include #include -#include #include #include #include #include -#include #include -#include #include namespace std @@ -71,8 +65,6 @@ int Contractor::Run() TIMER_START(preparing); - // Create a new lua state - util::SimpleLogger().Write() << "Loading edge-expanded graph representation"; util::DeallocatingVector edge_based_edge_list;