From 99b90125d7c1f8328c0b0a723a534184aa7dac25 Mon Sep 17 00:00:00 2001 From: Siarhei Fedartsou Date: Fri, 9 Sep 2022 14:34:22 +0200 Subject: [PATCH] wip --- src/nodejs/CMakeLists.txt | 3 +-- src/util/glibc_workaround.cpp | 14 +++++++------- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/nodejs/CMakeLists.txt b/src/nodejs/CMakeLists.txt index 799323477..e7a7680ce 100644 --- a/src/nodejs/CMakeLists.txt +++ b/src/nodejs/CMakeLists.txt @@ -17,8 +17,7 @@ add_nodejs_module(node_osrm node_osrm.cpp) set_target_properties(node_osrm PROPERTIES CXX_STANDARD 14) # TODO: we disable clang-tidy for this target, because it causes errors in third-party NodeJs related headers set_target_properties(node_osrm PROPERTIES CXX_CLANG_TIDY "") -# TODO: we turn off "warnings as errors" for this target, because it causes errors in third-party NodeJs related headers -# target_no_warning(node_osrm error) +# TODO: we turn off some warnings for this target, because it causes errors in third-party NodeJs related headers target_no_warning(node_osrm suggest-destructor-override) target_no_warning(node_osrm suggest-override) diff --git a/src/util/glibc_workaround.cpp b/src/util/glibc_workaround.cpp index 65bfb1252..ed185016f 100644 --- a/src/util/glibc_workaround.cpp +++ b/src/util/glibc_workaround.cpp @@ -7,13 +7,13 @@ // This is needed because libstdc++ itself uses this API - its not // just an issue of your code using it, ughhh -// // Note: only necessary on Linux -// #ifdef __linux__ -// #define _ENABLE_GLIBC_WORKAROUND -// #warning building with workaround -// #else -// #warning not building with workaround -// #endif +// Note: only necessary on Linux +#ifdef __linux__ +#define _ENABLE_GLIBC_WORKAROUND +#warning building with workaround +#else +#warning not building with workaround +#endif #ifdef _ENABLE_GLIBC_WORKAROUND namespace std