Update CI to use clang-tidy 14 (#6353)

.clang-tidy

@@ -12,6 +12,7 @@ Checks: >
     -bugprone-unhandled-self-assignment,
     -bugprone-forward-declaration-namespace,
     -bugprone-sizeof-expression,
+    -bugprone-throw-keyword-missing,
     -clang-analyzer-*,
     -clang-diagnostic-deprecated-declarations,
     -clang-diagnostic-constant-conversion,
@@ -64,6 +65,7 @@ Checks: >
     -readability-else-after-return,
     -readability-inconsistent-declaration-parameter-name,
     -readability-isolate-declaration,
+    -readability-identifier-length,
     -readability-redundant-declaration,
     -readability-uppercase-literal-suffix,
     -readability-named-parameter,

.github/workflows/osrm-backend.yml

@@ -145,11 +145,11 @@ jobs:
           - name: clang-11.0-debug-clang-tidy
             continue-on-error: false
             node: 12
-            runs-on: ubuntu-20.04
+            runs-on: ubuntu-22.04
             BUILD_TOOLS: ON
             BUILD_TYPE: Debug
-            CCOMPILER: clang-11
+            CCOMPILER: clang-14
-            CXXCOMPILER: clang++-11
+            CXXCOMPILER: clang++-14
             CUCUMBER_TIMEOUT: 60000
             ENABLE_CLANG_TIDY: ON
 

include/engine/api/table_api.hpp

@@ -32,6 +32,8 @@ namespace api
 class TableAPI final : public BaseAPI
 {
   public:
+    virtual ~TableAPI() = default;
+
     struct TableCellRef
     {
         TableCellRef(const std::size_t &row, const std::size_t &column) : row{row}, column{column}

include/engine/datafacade/algorithm_datafacade.hpp

@@ -31,6 +31,8 @@ template <> class AlgorithmDataFacade<CH>
     using EdgeData = contractor::QueryEdge::EdgeData;
     using EdgeRange = util::filtered_range<EdgeID, util::vector_view<bool>>;
 
+    virtual ~AlgorithmDataFacade() = default;
+
     // search graph access
     virtual unsigned GetNumberOfNodes() const = 0;
 
@@ -66,6 +68,8 @@ template <> class AlgorithmDataFacade<MLD>
     using EdgeData = customizer::EdgeBasedGraphEdgeData;
     using EdgeRange = util::range<EdgeID>;
 
+    virtual ~AlgorithmDataFacade() = default;
+
     // search graph access
     virtual unsigned GetNumberOfNodes() const = 0;
 

include/engine/routing_algorithms.hpp

@@ -19,6 +19,8 @@ namespace engine
 class RoutingAlgorithmsInterface
 {
   public:
+    virtual ~RoutingAlgorithmsInterface() = default;
+
     virtual InternalManyRoutesResult
     AlternativePathSearch(const PhantomEndpointCandidates &endpoint_candidates,
                           unsigned number_of_alternatives) const = 0;

include/extractor/raster_source.hpp

@@ -58,7 +58,7 @@ class RasterGrid
         for (unsigned int y = 0; y < ydim; y++)
         {
             // read one line from file.
-            file_reader.ReadLine(&buffer[0], xdim * 11);
+            file_reader.ReadLine(buffer.data(), xdim * 11);
             boost::algorithm::trim(buffer);
 
             std::vector<std::string> result;

include/partitioner/partition_graph.hpp

@@ -125,13 +125,13 @@ template <typename NodeEntryT, typename EdgeEntryT> class RemappableGraph
 
     NodeID GetID(const NodeT &node) const
     {
-        BOOST_ASSERT(&node >= &nodes[0] && &node <= &nodes.back());
+        BOOST_ASSERT(&node >= nodes.data() && &node <= &nodes.back());
-        return (&node - &nodes[0]);
+        return (&node - nodes.data());
     }
     EdgeID GetID(const EdgeT &edge) const
     {
-        BOOST_ASSERT(&edge >= &edges[0] && &edge <= &edges.back());
+        BOOST_ASSERT(&edge >= edges.data() && &edge <= &edges.back());
-        return (&edge - &edges[0]);
+        return (&edge - edges.data());
     }
 
     NodeIterator Begin() { return nodes.begin(); }
@@ -142,7 +142,7 @@ template <typename NodeEntryT, typename EdgeEntryT> class RemappableGraph
     // removes the edges from the graph that return true for the filter, returns new end
     template <typename FilterT> auto RemoveEdges(NodeT &node, FilterT filter)
     {
-        BOOST_ASSERT(&node >= &nodes[0] && &node <= &nodes.back());
+        BOOST_ASSERT(&node >= nodes.data() && &node <= &nodes.back());
         // required since we are not on std++17 yet, otherwise we are missing an argument_type
         const auto negate_filter = [&](const EdgeT &edge) { return !filter(edge); };
         const auto center = std::stable_partition(BeginEdges(node), EndEdges(node), negate_filter);

include/storage/view_factory.hpp

@@ -36,9 +36,6 @@
 #include "util/vector_view.hpp"
 
 #include "util/filtered_graph.hpp"
-#include "util/packed_vector.hpp"
-#include "util/vector_view.hpp"
-
 namespace osrm
 {
 namespace storage

include/util/dist_table_wrapper.hpp

@@ -25,7 +25,7 @@ template <typename T> class DistTableWrapper
     DistTableWrapper(std::vector<T> table, std::size_t number_of_nodes)
         : table_(std::move(table)), number_of_nodes_(number_of_nodes)
     {
-        BOOST_ASSERT_MSG(table.size() == 0, "table is empty");
+        BOOST_ASSERT_MSG(!table_.empty(), "table is empty");
         BOOST_ASSERT_MSG(number_of_nodes_ * number_of_nodes_ <= table_.size(),
                          "number_of_nodes_ is invalid");
     }

include/util/filtered_graph.hpp

@@ -126,8 +126,8 @@ class FilteredGraphImpl<util::StaticGraph<EdgeDataT, Ownership>, Ownership>
 
     FilteredGraphImpl() = default;
 
-    FilteredGraphImpl(Graph graph, Vector<bool> edge_filter_)
+    FilteredGraphImpl(Graph graph_, Vector<bool> edge_filter_)
-        : graph(std::move(graph)), edge_filter(std::move(edge_filter_))
+        : graph(std::move(graph_)), edge_filter(std::move(edge_filter_))
     {
         BOOST_ASSERT(edge_filter.empty() || edge_filter.size() == graph.GetNumberOfEdges());
     }

src/engine/datafacade/mmap_memory_allocator.cpp

@@ -39,7 +39,7 @@ MMapMemoryAllocator::MMapMemoryAllocator(const storage::StorageConfig &config)
         // prior to C++17 (which we're not using), those return a `const char *`,
         // which isn't compatible with the `char *` that AllocatedRegion expects
         // for it's memory_ptr
-        allocated_regions.push_back({&(rtree_filename[0]), std::move(fake_layout)});
+        allocated_regions.push_back({rtree_filename.data(), std::move(fake_layout)});
     }
 
     auto files = storage.GetStaticFiles();

src/engine/guidance/post_processing.cpp

@@ -15,8 +15,6 @@
 #include <boost/numeric/conversion/cast.hpp>
 #include <boost/range/iterator_range.hpp>
 
-#include "engine/guidance/collapsing_utility.hpp"
-
 #include <algorithm>
 #include <cmath>
 #include <cstddef>

src/extractor/intersection/coordinate_extractor.cpp

@@ -11,8 +11,6 @@
 #include "util/bearing.hpp"
 #include "util/coordinate_calculation.hpp"
 
-using osrm::util::angularDeviation;
-
 namespace osrm
 {
 namespace extractor

src/guidance/intersection_handler.cpp

@@ -7,13 +7,11 @@
 #include "util/log.hpp"
 
 #include "util/bearing.hpp"
-#include "util/coordinate_calculation.hpp"
 
 #include <algorithm>
 #include <cstddef>
 
 using EdgeData = osrm::util::NodeBasedDynamicGraph::EdgeData;
-using osrm::guidance::getTurnDirection;
 using osrm::util::angularDeviation;
 
 namespace osrm

src/guidance/motorway_handler.cpp

@@ -11,7 +11,6 @@
 
 #include <boost/assert.hpp>
 
-using osrm::guidance::getTurnDirection;
 using osrm::util::angularDeviation;
 
 namespace osrm

src/guidance/roundabout_handler.cpp

@@ -15,8 +15,6 @@
 
 #include <boost/assert.hpp>
 
-using osrm::guidance::getTurnDirection;
-
 namespace osrm
 {
 namespace guidance

src/guidance/segregated_intersection_classification.cpp

@@ -6,8 +6,6 @@
 #include "util/coordinate_calculation.hpp"
 #include <set>
 
-using osrm::guidance::getTurnDirection;
-
 namespace osrm
 {
 namespace guidance

src/guidance/sliproad_handler.cpp

@@ -12,7 +12,6 @@
 
 #include <boost/assert.hpp>
 
-using osrm::guidance::getTurnDirection;
 using osrm::util::angularDeviation;
 
 namespace osrm

src/guidance/turn_analysis.cpp

@@ -10,8 +10,6 @@
 #include <unordered_set>
 #include <utility>
 
-using osrm::guidance::getTurnDirection;
-
 namespace osrm
 {
 namespace guidance

src/guidance/turn_handler.cpp

@@ -11,7 +11,6 @@
 #include <boost/assert.hpp>
 #include <boost/optional.hpp>
 
-using osrm::guidance::getTurnDirection;
 using osrm::util::angularDeviation;
 
 namespace

src/partitioner/partitioner.cpp

@@ -29,9 +29,6 @@
 #include <boost/filesystem/operations.hpp>
 #include <tbb/global_control.h>
 
-#include "util/geojson_debug_logger.hpp"
-#include "util/geojson_debug_policies.hpp"
-#include "util/json_container.hpp"
 #include "util/timing_util.hpp"
 
 namespace osrm

src/server/connection.cpp

@@ -239,7 +239,7 @@ std::vector<char> Connection::compress_buffers(const std::vector<char> &uncompre
     boost::iostreams::filtering_ostream gzip_stream;
     gzip_stream.push(boost::iostreams::gzip_compressor(compression_parameters));
     gzip_stream.push(boost::iostreams::back_inserter(compressed_data));
-    gzip_stream.write(&uncompressed_data[0], uncompressed_data.size());
+    gzip_stream.write(uncompressed_data.data(), uncompressed_data.size());
     boost::iostreams::close(gzip_stream);
 
     return compressed_data;