Update CI to use clang-tidy 14 (#6353)

src/engine/datafacade/mmap_memory_allocator.cpp

@@ -39,7 +39,7 @@ MMapMemoryAllocator::MMapMemoryAllocator(const storage::StorageConfig &config)
         // prior to C++17 (which we're not using), those return a `const char *`,
         // which isn't compatible with the `char *` that AllocatedRegion expects
         // for it's memory_ptr
-        allocated_regions.push_back({&(rtree_filename[0]), std::move(fake_layout)});
+        allocated_regions.push_back({rtree_filename.data(), std::move(fake_layout)});
     }
 
     auto files = storage.GetStaticFiles();

src/engine/guidance/post_processing.cpp

@@ -15,8 +15,6 @@
 #include <boost/numeric/conversion/cast.hpp>
 #include <boost/range/iterator_range.hpp>
 
-#include "engine/guidance/collapsing_utility.hpp"
-
 #include <algorithm>
 #include <cmath>
 #include <cstddef>

src/extractor/intersection/coordinate_extractor.cpp

@@ -11,8 +11,6 @@
 #include "util/bearing.hpp"
 #include "util/coordinate_calculation.hpp"
 
-using osrm::util::angularDeviation;
-
 namespace osrm
 {
 namespace extractor

src/guidance/intersection_handler.cpp

@@ -7,13 +7,11 @@
 #include "util/log.hpp"
 
 #include "util/bearing.hpp"
-#include "util/coordinate_calculation.hpp"
 
 #include <algorithm>
 #include <cstddef>
 
 using EdgeData = osrm::util::NodeBasedDynamicGraph::EdgeData;
-using osrm::guidance::getTurnDirection;
 using osrm::util::angularDeviation;
 
 namespace osrm

src/guidance/motorway_handler.cpp

@@ -11,7 +11,6 @@
 
 #include <boost/assert.hpp>
 
-using osrm::guidance::getTurnDirection;
 using osrm::util::angularDeviation;
 
 namespace osrm

src/guidance/roundabout_handler.cpp

@@ -15,8 +15,6 @@
 
 #include <boost/assert.hpp>
 
-using osrm::guidance::getTurnDirection;
-
 namespace osrm
 {
 namespace guidance

src/guidance/segregated_intersection_classification.cpp

@@ -6,8 +6,6 @@
 #include "util/coordinate_calculation.hpp"
 #include <set>
 
-using osrm::guidance::getTurnDirection;
-
 namespace osrm
 {
 namespace guidance

src/guidance/sliproad_handler.cpp

@@ -12,7 +12,6 @@
 
 #include <boost/assert.hpp>
 
-using osrm::guidance::getTurnDirection;
 using osrm::util::angularDeviation;
 
 namespace osrm

src/guidance/turn_analysis.cpp

@@ -10,8 +10,6 @@
 #include <unordered_set>
 #include <utility>
 
-using osrm::guidance::getTurnDirection;
-
 namespace osrm
 {
 namespace guidance

src/guidance/turn_handler.cpp

@@ -11,7 +11,6 @@
 #include <boost/assert.hpp>
 #include <boost/optional.hpp>
 
-using osrm::guidance::getTurnDirection;
 using osrm::util::angularDeviation;
 
 namespace

src/partitioner/partitioner.cpp

@@ -29,9 +29,6 @@
 #include <boost/filesystem/operations.hpp>
 #include <tbb/global_control.h>
 
-#include "util/geojson_debug_logger.hpp"
-#include "util/geojson_debug_policies.hpp"
-#include "util/json_container.hpp"
 #include "util/timing_util.hpp"
 
 namespace osrm

src/server/connection.cpp

@@ -239,7 +239,7 @@ std::vector<char> Connection::compress_buffers(const std::vector<char> &uncompre
     boost::iostreams::filtering_ostream gzip_stream;
     gzip_stream.push(boost::iostreams::gzip_compressor(compression_parameters));
     gzip_stream.push(boost::iostreams::back_inserter(compressed_data));
-    gzip_stream.write(&uncompressed_data[0], uncompressed_data.size());
+    gzip_stream.write(uncompressed_data.data(), uncompressed_data.size());
     boost::iostreams::close(gzip_stream);
 
     return compressed_data;