Refactor CMake code related to compiler warnings, enable some additional warnings (#6355)

include/engine/api/base_api.hpp

@@ -123,9 +123,9 @@ class BaseAPI
 
         const auto &snapped_location = candidatesSnappedLocation(candidates);
         const auto &input_location = candidatesInputLocation(candidates);
-        auto location =
-            fbresult::Position(static_cast<double>(util::toFloating(snapped_location.lon)),
-                               static_cast<double>(util::toFloating(snapped_location.lat)));
+        auto location = fbresult::Position(
+            static_cast<float>(static_cast<double>(util::toFloating(snapped_location.lon))),
+            static_cast<float>(static_cast<double>(util::toFloating(snapped_location.lat))));
 
         const auto toName = [this](const auto &phantom) {
             return facade.GetNameForID(facade.GetNameIndex(phantom.forward_segment_id.id))
@@ -156,8 +156,8 @@ class BaseAPI
 
         auto waypoint = std::make_unique<fbresult::WaypointBuilder>(*builder);
         waypoint->add_location(&location);
-        waypoint->add_distance(
-            util::coordinate_calculation::greatCircleDistance(snapped_location, input_location));
+        waypoint->add_distance(static_cast<float>(
+            util::coordinate_calculation::greatCircleDistance(snapped_location, input_location)));
         waypoint->add_name(name_string);
         if (parameters.generate_hints)
         {

include/engine/engine.hpp

@@ -83,7 +83,7 @@ template <typename Algorithm> class Engine final : public EngineInterface
 
     Engine(const Engine &) = delete;
     Engine &operator=(const Engine &) = delete;
-    virtual ~Engine() = default;
+    virtual ~Engine() override = default;
 
     Status Route(const api::RouteParameters &params, api::ResultT &result) const override final
     {

include/engine/routing_algorithms.hpp

@@ -72,7 +72,7 @@ template <typename Algorithm> class RoutingAlgorithms final : public RoutingAlgo
     {
     }
 
-    virtual ~RoutingAlgorithms() = default;
+    virtual ~RoutingAlgorithms() override = default;
 
     InternalManyRoutesResult
     AlternativePathSearch(const PhantomEndpointCandidates &endpoint_candidates,