Enable performance-move-const-arg clang-tidy check (#6319)

src/contractor/contractor.cpp

@@ -115,7 +115,7 @@ int Contractor::Run()
     std::tie(query_graph, edge_filters) = contractExcludableGraph(
         toContractorGraph(number_of_edge_based_nodes, std::move(edge_based_edge_list)),
         std::move(node_weights),
-        std::move(node_filters));
+        node_filters);
     TIMER_STOP(contraction);
     util::Log() << "Contracted graph has " << query_graph.GetNumberOfEdges() << " edges.";
     util::Log() << "Contraction took " << TIMER_SEC(contraction) << " sec";

src/customize/customizer.cpp

@@ -96,8 +96,7 @@ auto LoadAndUpdateEdgeExpandedGraph(const CustomizationConfig &config,
     auto tidied = partitioner::prepareEdgesForUsageInGraph<
         typename partitioner::MultiLevelEdgeBasedGraph::InputEdge>(std::move(directed));
 
-    auto edge_based_graph =
-        partitioner::MultiLevelEdgeBasedGraph(mlp, num_nodes, std::move(tidied));
+    auto edge_based_graph = partitioner::MultiLevelEdgeBasedGraph(mlp, num_nodes, tidied);
 
     return edge_based_graph;
 }

src/engine/routing_algorithms/alternative_path_mld.cpp

@@ -851,7 +851,7 @@ InternalManyRoutesResult alternativePathSearch(SearchEngineData<Algorithm> &sear
     const auto extract_packed_path_from_heaps = [&](WeightedViaNode via) {
         auto packed_path = retrievePackedPathFromHeap(forward_heap, reverse_heap, via.node);
 
-        return WeightedViaNodePackedPath{std::move(via), std::move(packed_path)};
+        return WeightedViaNodePackedPath{via, std::move(packed_path)};
     };
 
     std::vector<WeightedViaNodePackedPath> weighted_packed_paths;

src/extractor/extraction_containers.cpp

@@ -276,7 +276,7 @@ void ExtractionContainers::PrepareNodes()
                 continue;
             }
             BOOST_ASSERT(node_iter->node_id == *ref_iter);
-            *used_nodes_iter = std::move(*ref_iter);
+            *used_nodes_iter = *ref_iter;
             used_nodes_iter++;
             node_iter++;
             ref_iter++;

src/extractor/extractor_callbacks.cpp

@@ -380,7 +380,7 @@ void ExtractorCallbacks::ProcessWay(const osmium::Way &input_way, const Extracti
                             parsed_way.pronunciation,
                             parsed_way.exits};
             auto v = MapVal{name_id};
-            string_map.emplace(std::move(k), std::move(v));
+            string_map.emplace(std::move(k), v);
         }
         else
         {
@@ -441,8 +441,8 @@ void ExtractorCallbacks::ProcessWay(const osmium::Way &input_way, const Extracti
                      parsed_way.highway_turn_classification,
                      parsed_way.access_turn_classification}};
 
-                external_memory.all_edges_list.push_back(InternalExtractorEdge(
-                    std::move(edge), forward_weight_data, forward_duration_data, {}));
+                external_memory.all_edges_list.push_back(
+                    InternalExtractorEdge(edge, forward_weight_data, forward_duration_data, {}));
             });
     }
 
@@ -475,8 +475,8 @@ void ExtractorCallbacks::ProcessWay(const osmium::Way &input_way, const Extracti
                      parsed_way.highway_turn_classification,
                      parsed_way.access_turn_classification}};
 
-                external_memory.all_edges_list.push_back(InternalExtractorEdge(
-                    std::move(edge), backward_weight_data, backward_duration_data, {}));
+                external_memory.all_edges_list.push_back(
+                    InternalExtractorEdge(edge, backward_weight_data, backward_duration_data, {}));
             });
     }
 

src/partitioner/inertial_flow.cpp

@@ -38,8 +38,8 @@ makeSpatialOrder(const BisectionGraphView &view, const double ratio, const doubl
 {
     struct NodeWithCoordinate
     {
-        NodeWithCoordinate(NodeID nid_, util::Coordinate coordinate_)
-            : nid{nid_}, coordinate{std::move(coordinate_)}
+        NodeWithCoordinate(NodeID nid_, const util::Coordinate &coordinate_)
+            : nid{nid_}, coordinate{coordinate_}
         {
         }
 

src/partitioner/recursive_bisection.cpp

@@ -86,13 +86,13 @@ RecursiveBisection::RecursiveBisection(BisectionGraph &bisection_graph_,
         TreeNode left_node{std::move(left_graph), node.depth + 1};
 
         if (!terminal(left_node))
-            feeder.add(std::move(left_node));
+            feeder.add(left_node);
 
         BisectionGraphView right_graph{bisection_graph, center, node.graph.End()};
         TreeNode right_node{std::move(right_graph), node.depth + 1};
 
         if (!terminal(right_node))
-            feeder.add(std::move(right_node));
+            feeder.add(right_node);
     });
 
     TIMER_STOP(bisection);

src/util/coordinate_calculation.cpp

@@ -283,7 +283,7 @@ Coordinate interpolateLinear(double factor, const Coordinate from, const Coordin
     FixedLatitude interpolated_lat{
         static_cast<std::int32_t>(from_lat + factor * (to_lat - from_lat))};
 
-    return {std::move(interpolated_lon), std::move(interpolated_lat)};
+    return {interpolated_lon, interpolated_lat};
 }
 
 // compute the signed area of a triangle