From 7dcd4b3e77f146ad7825db6313dc7431735fef91 Mon Sep 17 00:00:00 2001 From: Daniel Patterson Date: Wed, 27 Jan 2021 22:54:21 -0800 Subject: [PATCH] Comment out parameter parsing test - validation of values in the URL comes later. --- unit_tests/server/parameters_parser.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/unit_tests/server/parameters_parser.cpp b/unit_tests/server/parameters_parser.cpp index ab1cb686c..c53c5207f 100644 --- a/unit_tests/server/parameters_parser.cpp +++ b/unit_tests/server/parameters_parser.cpp @@ -108,8 +108,13 @@ BOOST_AUTO_TEST_CASE(invalid_table_urls) BOOST_CHECK_EQUAL( testInvalidOptions("1,2;3,4?annotations=durations&fallback_speed=-1"), 28UL); - BOOST_CHECK_EQUAL(testInvalidOptions("1,2;3,4?sources=2"), 7UL); - BOOST_CHECK_EQUAL(testInvalidOptions("1,2;3,4?destinations=2"), 7UL); + // TODO(danpat): this is only testing invalid grammar which isn't capable of checking + // for values that need to reference other things currently. These + // requests are gramatically correct, but semantically incorrect. + // The table service properly fails these, as it checks IsValid() after + // parsing, which fails when sources/destinations are too large + // BOOST_CHECK_EQUAL(testInvalidOptions("1,2;3,4?sources=2"), 7UL); + // BOOST_CHECK_EQUAL(testInvalidOptions("1,2;3,4?destinations=2"), 7UL); } BOOST_AUTO_TEST_CASE(valid_route_hint)