minor code refactoring, wip

Descriptors/DescriptionFactory.cpp

@@ -29,8 +29,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 DescriptionFactory::DescriptionFactory() : entireLength(0) {}
 
-DescriptionFactory::~DescriptionFactory() {}
-
 void DescriptionFactory::SetStartSegment(const PhantomNode &source)
 {
     start_phantom = source;
@@ -50,15 +48,14 @@ void DescriptionFactory::AppendSegment(const FixedPointCoordinate &coordinate,
     if ((1 == path_description.size()) && (path_description.back().location == coordinate))
     {
         path_description.back().name_id = path_point.name_id;
+        return;
     }
-    else
-    {
-        path_description.emplace_back(coordinate,
-                                      path_point.name_id,
-                                      path_point.segment_duration,
-                                      0,
-                                      path_point.turn_instruction);
-    }
+
+    path_description.emplace_back(coordinate,
+                                  path_point.name_id,
+                                  path_point.segment_duration,
+                                  0,
+                                  path_point.turn_instruction);
 }
 
 JSON::Value DescriptionFactory::AppendEncodedPolylineString(const bool return_encoded)

Descriptors/DescriptionFactory.h

@@ -76,7 +76,6 @@ class DescriptionFactory
     // I know, declaring this public is considered bad. I'm lazy
     std::vector<SegmentInformation> path_description;
     DescriptionFactory();
-    virtual ~DescriptionFactory();
     JSON::Value AppendUnencodedPolylineString() const;
     void AppendSegment(const FixedPointCoordinate &coordinate, const PathData &data);
     void BuildRouteSummary(const double distance, const unsigned time);
@@ -176,14 +175,14 @@ class DescriptionFactory
                 target_phantom.name_id = (path_description.end() - 2)->name_id;
             }
         }
-        if (std::numeric_limits<double>::epsilon() > path_description[0].length)
+        if (std::numeric_limits<double>::epsilon() > path_description.front().length)
         {
             if (path_description.size() > 2)
             {
                 path_description.erase(path_description.begin());
-                path_description[0].turn_instruction = TurnInstruction::HeadOn;
-                path_description[0].necessary = true;
-                start_phantom.name_id = path_description[0].name_id;
+                path_description.front().turn_instruction = TurnInstruction::HeadOn;
+                path_description.front().necessary = true;
+                start_phantom.name_id = path_description.front().name_id;
             }
         }