fix some small issues:

remove empty unit test

remove compiler directives

move trip related files from routing_algorithms to algorithms

run clang-format on files

fix all std::size_t related issues

improve code by adding std::move()s

clean up includes

fixing several code stye and improvement issues

add several small code improvements

return single scc in SplitUnaccessibleLocations() when theres only one

change ComputeRoute() to return an InternalRouteResult by value

improve some code style issues

data_structures/matrix_graph_wrapper.hpp

@@ -29,37 +29,42 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #define MATRIX_GRAPH_WRAPPER_H
 
 #include <vector>
+#include <cstddef>
+#include <iterator>
 
-//This Wrapper provides all methods that are needed for TarjanSCC, when the graph is given in a
-//matrix representation (e.g. as output from a distance table call)
+#include "../typedefs.h"
 
-template <typename T> class MatrixGraphWrapper {
-public:
+// This Wrapper provides all methods that are needed for TarjanSCC, when the graph is given in a
+// matrix representation (e.g. as output from a distance table call)
 
-    MatrixGraphWrapper(std::vector<T> table, const std::size_t number_of_nodes) : table_(table), number_of_nodes_(number_of_nodes) {};
+template <typename T> class MatrixGraphWrapper
+{
+  public:
+    MatrixGraphWrapper(std::vector<T> table, const std::size_t number_of_nodes)
+        : table_(std::move(table)), number_of_nodes_(number_of_nodes){};
 
-    std::size_t GetNumberOfNodes() const {
-        return number_of_nodes_;
-    }
+    std::size_t GetNumberOfNodes() const { return number_of_nodes_; }
+
+    std::vector<T> GetAdjacentEdgeRange(const NodeID node) const
+    {
 
-    std::vector<T> GetAdjacentEdgeRange(const NodeID node) const {
         std::vector<T> edges;
-        for (auto i = 0; i < number_of_nodes_; ++i) {
-            if (*(std::begin(table_) + node * number_of_nodes_ + i) != INVALID_EDGE_WEIGHT) {
+        // find all valid adjacent edges and move to vector `edges`
+        for (std::size_t i = 0; i < number_of_nodes_; ++i)
+        {
+            if (*(std::begin(table_) + node * number_of_nodes_ + i) != INVALID_EDGE_WEIGHT)
+            {
                 edges.push_back(i);
             }
         }
         return edges;
     }
 
-    EdgeWeight GetTarget(const EdgeWeight edge) const {
-        return edge;
-    }
+    EdgeWeight GetTarget(const EdgeWeight edge) const { return edge; }
 
-private:
-    std::vector<T> table_;
+  private:
+    const std::vector<T> table_;
     const std::size_t number_of_nodes_;
 };
 
-
 #endif // MATRIX_GRAPH_WRAPPER_H

data_structures/route_parameters.cpp

@@ -122,7 +122,6 @@ void RouteParameters::setLanguage(const std::string &language_string)
     language = language_string;
 }
 
-
 void RouteParameters::setGeometryFlag(const bool flag) { geometry = flag; }
 
 void RouteParameters::setCompressionFlag(const bool flag) { compression = flag; }