Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Avoid copying json::Value objects a lot when reallocating vector

Browse Source
This commit is contained in:
Daniel Patterson 2018-03-05 22:45:23 -08:00 committed by Patrick Niklaus
parent 8f633e61bf
commit 7154ed9d59
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@ -1,3 +1,8 @@
# 5.16.3
- Changes from 5.16.2:
- Performance
- FIXED: Speed up response time when lots of legs exist and geojson is used with `steps=true` [#4936](https://github.com/Project-OSRM/osrm-backend/pull/4936)
# 5.16.2 # 5.16.2
- Changes from 5.16.1: - Changes from 5.16.1:
- Bugfixes: - Bugfixes:

8
include/engine/api/route_api.hpp
View File

@ -211,12 +211,16 @@ class RouteAPI : public BaseAPI
} }
std::vector<util::json::Value> step_geometries; std::vector<util::json::Value> step_geometries;
const auto total_step_count =
std::accumulate(legs.begin(), legs.end(), 0, [](const auto &v, const auto &leg) {
return v + leg.steps.size();
});
step_geometries.reserve(total_step_count);
for (const auto idx : util::irange<std::size_t>(0UL, legs.size())) for (const auto idx : util::irange<std::size_t>(0UL, legs.size()))
{ {
auto &leg_geometry = leg_geometries[idx]; auto &leg_geometry = leg_geometries[idx];
step_geometries.reserve(step_geometries.size() + legs[idx].steps.size());
std::transform( std::transform(
legs[idx].steps.begin(), legs[idx].steps.begin(),
legs[idx].steps.end(), legs[idx].steps.end(),