wip

.github/workflows/osrm-backend.yml

@@ -398,7 +398,7 @@ jobs:
         fi
     - name: Give tar root ownership # https://github.com/actions/toolkit/issues/946#issuecomment-1590016041
       if: runner.os == 'Linux' && matrix.ENABLE_CONAN != 'ON'
-      run: sudo chown root:wheel /bin/tar && sudo chmod u+s /bin/tar
+      run: sudo chown root /bin/tar && sudo chmod u+s /bin/tar
     - name: Cache Boost
       if: steps.cache-boost.outputs.cache-hit != 'true' && runner.os == 'Linux' && matrix.ENABLE_CONAN != 'ON'
       id: cache-boost

CMakeLists.txt

@@ -4,7 +4,6 @@ set(CMAKE_CXX_STANDARD 20)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_CXX_EXTENSIONS OFF)
 
-
 if(CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_CURRENT_BINARY_DIR AND NOT MSVC_IDE)
   message(FATAL_ERROR "In-source builds are not allowed.
 Please create a directory and run cmake from there, passing the path to this source directory as the last argument.

cmake/warnings.cmake

@@ -77,20 +77,5 @@ add_warning(sizeof-array-argument)
 add_warning(switch-bool)
 add_warning(tautological-compare)
 add_warning(trampolines)
-# TODO: these warnings are not enabled by default, but we consider them as useful and good to enable in the future
-no_warning(implicit-int-conversion)
-no_warning(implicit-float-conversion)
-no_warning(unused-member-function)
-no_warning(old-style-cast)
-no_warning(non-virtual-dtor)
-no_warning(float-conversion)
-no_warning(sign-conversion)
-no_warning(shorten-64-to-32)
-no_warning(padded)
-no_warning(missing-noreturn)
-no_warning(deprecated-comma-subscript)
-no_warning(comma-subscript)
-no_warning(free-nonheap-object)
-no_warning(restrict)
-no_warning(ambiguous-reversed-operator)
-
+# these warnings are not enabled by default
+# no_warning(name-of-warning)