From 6643300d4fb7e43b484379af558daf6c67cac8c4 Mon Sep 17 00:00:00 2001 From: Michael Bell Date: Sat, 11 Dec 2021 16:41:10 +0000 Subject: [PATCH] Fix Mason CMake installation During the CI migration to Github Actions, a bug was introduced such that Mason CMake is not being added to the PATH environment variable correctly, so it defaults to the CMake installed in the OS environment. Simple fixing the typo fails as the Mason CMake version requires libssl 1.0 as a dependency, whilst the Ubuntu Focal runners are on the newer libssl 1.1. Therefore, we also bump the Mason CMake version to 3.21.2. --- .github/workflows/osrm-backend.yml | 4 ++-- CHANGELOG.md | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/osrm-backend.yml b/.github/workflows/osrm-backend.yml index c83eb45c1..1ce58a297 100644 --- a/.github/workflows/osrm-backend.yml +++ b/.github/workflows/osrm-backend.yml @@ -16,7 +16,7 @@ env: CCACHE_COMPRESS: 1 CASHER_TIME_OUT: 599 # one second less than 10m to avoid 10m timeout error: https://github.com/Project-OSRM/osrm-backend/issues/2742 CCACHE_VERSION: 3.3.1 - CMAKE_VERSION: 3.7.2 + CMAKE_VERSION: 3.21.2 ENABLE_NODE_BINDINGS: "ON" jobs: @@ -425,7 +425,7 @@ jobs: echo "MASON=${GITHUB_WORKSPACE}/scripts/mason.sh" >> $GITHUB_ENV echo "CMAKE_URL=https://mason-binaries.s3.amazonaws.com/${MASON_OS}-x86_64/cmake/${CMAKE_VERSION}.tar.gz" >> $GITHUB_ENV - echo "CMAKE_DIR=mason_packages/${MASON_OS}-x86_64/cmake/${CMAKE_VERSION}}" >> $GITHUB_ENV + echo "CMAKE_DIR=mason_packages/${MASON_OS}-x86_64/cmake/${CMAKE_VERSION}" >> $GITHUB_ENV - name: Install dev dependencies diff --git a/CHANGELOG.md b/CHANGELOG.md index de89940e3..fbd505b01 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ - CHANGED: Upgrade Ubuntu CI builds to 20.04 [#6119](https://github.com/Project-OSRM/osrm-backend/pull/6119) - CHANGED: Make building osrm-routed optional [#6144](https://github.com/Project-OSRM/osrm-backend/pull/6144) - FIXED: Run all unit tests in CI [#5248](https://github.com/Project-OSRM/osrm-backend/pull/5248) + - FIXED: Fix installation of Mason CMake [#6170](https://github.com/Project-OSRM/osrm-backend/pull/6170) # 5.26.0 - Changes from 5.25.0