From 5280ca4e1642085e1520ffff8a842c3cb0124fe7 Mon Sep 17 00:00:00 2001 From: Dennis Luxen Date: Fri, 4 Nov 2022 11:41:02 +0100 Subject: [PATCH] Pass string_view by value --- include/extractor/suffix_table.hpp | 2 +- include/util/guidance/name_announcements.hpp | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/extractor/suffix_table.hpp b/include/extractor/suffix_table.hpp index cadfb5e2e..53eb1062b 100644 --- a/include/extractor/suffix_table.hpp +++ b/include/extractor/suffix_table.hpp @@ -23,7 +23,7 @@ class SuffixTable final // check whether a string is part of the know suffix list bool isSuffix(const std::string &possible_suffix) const; - bool isSuffix(std::string_view possible_suffix) const; + bool isSuffix(std::string_view& possible_suffix) const; private: // Store lower-cased strings in SuffixTable and a set of StringViews for quick membership diff --git a/include/util/guidance/name_announcements.hpp b/include/util/guidance/name_announcements.hpp index 1ebf8a64a..a3dd72a06 100644 --- a/include/util/guidance/name_announcements.hpp +++ b/include/util/guidance/name_announcements.hpp @@ -27,8 +27,8 @@ namespace guidance // Name Change Logic // Used both during Extraction as well as during Post-Processing -inline std::string_view longest_common_substring(const std::string_view &lhs, - const std::string_view &rhs) +inline std::string_view longest_common_substring(const std::string_view lhs, + const std::string_view rhs) { if (lhs.empty() || rhs.empty()) return ""; @@ -131,8 +131,8 @@ inline bool requiresNameAnnounced(const StringView &from_name, const auto name_is_contained = boost::starts_with(from_name, to_name) || boost::starts_with(to_name, from_name); - const auto checkForPrefixOrSuffixChange = [](const std::string_view &first, - const std::string_view &second, + const auto checkForPrefixOrSuffixChange = [](const std::string_view first, + const std::string_view second, const SuffixTable &suffix_table) { std::string first_prefix, first_suffix, second_prefix, second_suffix; std::tie(first_prefix, first_suffix, second_prefix, second_suffix) = @@ -203,7 +203,7 @@ inline bool requiresNameAnnounced(const std::string &from_name, struct NopSuffixTable final { NopSuffixTable() {} - bool isSuffix(const std::string_view &) const { return false; } + bool isSuffix(const std::string_view) const { return false; } } static const table; return requiresNameAnnounced(std::string_view(from_name),