Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Directional Destination Tags (#3061)

Browse Source 
* cucumber test scenarios, #3027

* post review comments

* two tests are still failing

* fixed one test

* passing tests

* cleaner code refactor

* possible sceanrios for destination:ref:forward/backward

* added code for direction:ref:forward/backward, tests pass

* changelog

* store direction in variable

* added tags to taginfo

* fixed dumb error

* use boolean flags

* null pointer checks

* hopefully better null pointer checks
This commit is contained in:
Kajari Ghosh
2016-10-18 23:09:19 -04:00
committed by GitHub
parent f77a2474ea
commit 3f0f0e306b
6 changed files with 144 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
features/guidance/directional-destination-signs.feature
+43
View File
@@ -0,0 +1,43 @@
@routing @guidance
Feature: Destination Signs
Background:
Given the profile "car"
Scenario: Car - route name assembly with destination signs accounting for directional tags
Given the node map
"""
a b
c d
e f
g h
i j
k l
m n
o p
q r
"""
And the ways
| nodes | name | ref | destination | destination:ref | destination:forward | destination:backward | oneway | # |
| ab | AB | | Berlin | | | | yes | |
| cd | CD | | | | Berlin | | yes | |
| ef | EF | | | | Berlin | Hamburg | -1 | |
| gh | GH | | | A1 | | | yes | |
| ij | IJ | | Berlin | A1 | | | no | mis-tagged destination: not a oneway |
| kl | KL | | | A1 | Berlin | Hamburg | yes | |
| mn | MN | | Berlin | A1 | Berlin | Hamburg | yes | |
| op | OP | | Berlin | | | Hamburg | -1 | |
| qr | QR | | | | | Hamburg | -1 | |
When I route I should get
| from | to | route | destinations | ref | # |
| a | b | AB,AB | Berlin,Berlin | , | |
| c | d | CD,CD | Berlin,Berlin | , | |
| f | e | EF,EF | Hamburg,Hamburg | , | |
| g | h | GH,GH | A1,A1 | , | |
| i | j | IJ,IJ | , | , | guard against mis-tagging |
| k | l | KL,KL | A1: Berlin,A1: Berlin | , | |
| m | n | MN,MN | A1: Berlin,A1: Berlin | , | |
| p | o | OP,OP | Hamburg,Hamburg | , | |
| r | q | QR,QR | Hamburg,Hamburg | , | |
features/guidance/directional-ref-destination-signs.feature
+39
View File
@@ -0,0 +1,39 @@
@routing @guidance
Feature: Destination Signs
Background:
Given the profile "car"
Scenario: Car - route name assembly with destination signs accounting for directional:ref tags
Given the node map
"""
a b
c d
e f
g h
i j
k l
m n
o p
q r
"""
And the ways
| nodes | name | destination | destination:ref | destination:ref:forward | destination:ref:backward | destination:forward | destination:backward | oneway | # |
| ab | AB | Berlin | A1 | A1 | A2 | | | yes | |
| cd | CD | | A1 | A1 | A2 | Berlin | Hamburg | -1 | |
| ef | EF | | | A1 | A2 | Berlin | Hamburg | yes | |
| gh | GH | | | A1 | A2 | Berlin | Hamburg | -1 | |
| ij | IJ | Berlin | A1 | | A2 | Berlin | Hamburg | yes | |
| kl | KL | | A1 | | A2 | Berlin | Hamburg | -1 | |
| mn | MN | Berlin | A1 | A1 | | Berlin | Hamburg | no | mis-tagged destination: not a oneway |
When I route I should get
| from | to | route | destinations | ref | # |
| a | b | AB,AB | A1: Berlin,A1: Berlin | , | |
| d | c | CD,CD | A2: Hamburg,A2: Hamburg | , | |
| e | f | EF,EF | A1: Berlin,A1: Berlin | , | |
| h | g | GH,GH | A2: Hamburg,A2: Hamburg | , | |
| i | j | IJ,IJ | A1: Berlin,A1: Berlin | , | |
| l | k | KL,KL | A2: Hamburg,A2: Hamburg | , | |
| m | n | MN,MN | , | , | guard against mis-tagging |