diff --git a/features/guidance/maneuver-tag.feature b/features/guidance/maneuver-tag.feature index 29aa95f4d..d639566e6 100644 --- a/features/guidance/maneuver-tag.feature +++ b/features/guidance/maneuver-tag.feature @@ -28,6 +28,8 @@ Feature: Maneuver tag support | maneuver | hij | i | cde | turn | sharp_left | | maneuver | abc | c | cde | turn | slight_left | | maneuver | cde | c | cgi | turn | straight | + | maneuver | cde | c | cgi | turn | straight | + | manoeuvre | cde | c | abc | fork | right | When I route I should get | waypoints | route | turns | @@ -36,7 +38,7 @@ Feature: Maneuver tag support | b,g | A Street,C Street,C Street | depart,turn sharp right,arrive | # Testing re-awakening suppressed turns | a,e | A Street,B Street,B Street | depart,turn slight left,arrive | - | e,i | B Street,C Street,C Street | depart,turn straight,arrive | + | e,a | B Street,A Street,A Street | depart,fork right,arrive | Scenario: single via-way Given the node map diff --git a/src/extractor/maneuver_override_relation_parser.cpp b/src/extractor/maneuver_override_relation_parser.cpp index 812b8136a..50372d8b6 100644 --- a/src/extractor/maneuver_override_relation_parser.cpp +++ b/src/extractor/maneuver_override_relation_parser.cpp @@ -11,7 +11,8 @@ #include #include -#include +#include +#include #include #include @@ -31,16 +32,16 @@ ManeuverOverrideRelationParser::ManeuverOverrideRelationParser() {} boost::optional ManeuverOverrideRelationParser::TryParse(const osmium::Relation &relation) const { - osmium::tags::KeyFilter filter(false); - filter.add(true, "maneuver"); + + // Support both American and British spellings of maneuver/manoeuvre + osmium::tags::KeyValueFilter filter{false}; + filter.add(true, "type", "maneuver"); + filter.add(true, "type", "manoeuvre"); const osmium::TagList &tag_list = relation.tags(); - osmium::tags::KeyFilter::iterator fi_begin(filter, tag_list.begin(), tag_list.end()); - osmium::tags::KeyFilter::iterator fi_end(filter, tag_list.end(), tag_list.end()); - + if (osmium::tags::match_none_of(tag_list, filter)) // if it's not a maneuver, continue; - if (std::distance(fi_begin, fi_end) == 0) { return boost::none; } @@ -49,7 +50,16 @@ ManeuverOverrideRelationParser::TryParse(const osmium::Relation &relation) const // we can trim away the vector after parsing InputManeuverOverride maneuver_override; - maneuver_override.maneuver = relation.tags().get_value_by_key("maneuver", ""); + // Handle both spellings + if (relation.tags().has_key("maneuver")) + { + maneuver_override.maneuver = relation.tags().get_value_by_key("maneuver", ""); + } + else + { + maneuver_override.maneuver = relation.tags().get_value_by_key("manoeuvre", ""); + } + maneuver_override.direction = relation.tags().get_value_by_key("direction", ""); bool valid_relation = true;