diff --git a/CHANGELOG.md b/CHANGELOG.md index daa7c1d5e..44827b06e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ - ADDED: Add support for accessing edge flags in `process_segment` [#6658](https://github.com/Project-OSRM/osrm-backend/pull/6658) - Build: - CHANGED: Upgrade CI actions to latest versions [#6893](https://github.com/Project-OSRM/osrm-backend/pull/6893) + - CHANGED: Remove outdated warnings #6894 [#6894](https://github.com/Project-OSRM/osrm-backend/pull/6894) - ADDED: Add CI job which builds OSRM with gcc 12. [#6455](https://github.com/Project-OSRM/osrm-backend/pull/6455) - CHANGED: Upgrade to clang-tidy 15. [#6439](https://github.com/Project-OSRM/osrm-backend/pull/6439) - CHANGED: Update actions/cache to v3. [#6420](https://github.com/Project-OSRM/osrm-backend/pull/6420) diff --git a/cmake/warnings.cmake b/cmake/warnings.cmake index ad9cfb086..89040aa0e 100644 --- a/cmake/warnings.cmake +++ b/cmake/warnings.cmake @@ -50,9 +50,7 @@ add_warning(all) add_warning(extra) add_warning(pedantic) add_warning(error) # treat all warnings as errors -if(CMAKE_CXX_COMPILER_ID MATCHES "Clang") - add_warning(strict-overflow=2) -elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU") +if(CMAKE_CXX_COMPILER_ID MATCHES "GNU") add_warning(strict-overflow=1) endif() add_warning(suggest-override) @@ -79,15 +77,5 @@ add_warning(sizeof-array-argument) add_warning(switch-bool) add_warning(tautological-compare) add_warning(trampolines) -no_warning(c++17-extensions) -# TODO: these warnings are not enabled by default, but we consider them as useful and good to enable in the future -no_warning(implicit-int-conversion) -no_warning(implicit-float-conversion) -no_warning(unused-member-function) -no_warning(old-style-cast) -no_warning(non-virtual-dtor) -no_warning(float-conversion) -no_warning(sign-conversion) -no_warning(shorten-64-to-32) -no_warning(padded) -no_warning(missing-noreturn) \ No newline at end of file +# these warnings are not enabled by default +# no_warning(name-of-warning) \ No newline at end of file diff --git a/unit_tests/util/json_render.cpp b/unit_tests/util/json_render.cpp index 0fa084846..4d2ce23cf 100644 --- a/unit_tests/util/json_render.cpp +++ b/unit_tests/util/json_render.cpp @@ -87,7 +87,7 @@ BOOST_AUTO_TEST_CASE(test_json_issue_6531) BOOST_CHECK_EQUAL(output, "0.1234567892"); output.clear(); - renderer(123456789123456789); + renderer(123456789123456789.); BOOST_CHECK_EQUAL(output, "1.234567891e+17"); }