diff --git a/CHANGELOG.md b/CHANGELOG.md index a6bae2510..634043287 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +# 5.2.7 + - Bugfixes + - BREAKING: Fix bug that could result in failure to load 'osrm.icd' files. This breaks the dataformat + # 5.2.6 - Bugfixes - Fix numeric overflow in roundabout center calculation which throws an exception diff --git a/include/engine/datafacade/internal_datafacade.hpp b/include/engine/datafacade/internal_datafacade.hpp index 476ab179b..7660468b0 100644 --- a/include/engine/datafacade/internal_datafacade.hpp +++ b/include/engine/datafacade/internal_datafacade.hpp @@ -330,7 +330,7 @@ class InternalDataFacade final : public BaseDataFacade std::vector bearing_classes; // and the actual bearing values std::uint64_t num_bearings; - intersection_stream >> num_bearings; + intersection_stream.read(reinterpret_cast(&num_bearings),sizeof(num_bearings)); m_bearing_values_table.resize(num_bearings); intersection_stream.read(reinterpret_cast(&m_bearing_values_table[0]), sizeof(m_bearing_values_table[0]) * num_bearings); diff --git a/include/util/guidance/entry_class.hpp b/include/util/guidance/entry_class.hpp index 422c2d20e..715e12395 100644 --- a/include/util/guidance/entry_class.hpp +++ b/include/util/guidance/entry_class.hpp @@ -62,6 +62,13 @@ class EntryClass friend std::size_t std::hash::operator()(const EntryClass &) const; }; +#if not defined __GNUC__ or __GNUC__ > 4 +static_assert(std::is_trivially_copyable::value, + "Class is serialized trivially in " + "the datafacades. Bytewise writing " + "requires trivially copyable type"); +#endif + } // namespace guidance } // namespace utilr } // namespace osrm diff --git a/src/extractor/extractor.cpp b/src/extractor/extractor.cpp index 1406bdbb3..c83ed8ccd 100644 --- a/src/extractor/extractor.cpp +++ b/src/extractor/extractor.cpp @@ -661,7 +661,7 @@ void Extractor::WriteIntersectionClassificationData( util::RangeTable<> bearing_class_range_table(bearing_counts); file_out_stream << bearing_class_range_table; - file_out_stream << total_bearings; + file_out_stream.write(reinterpret_cast(&total_bearings), sizeof(total_bearings)); for (const auto &bearing_class : bearing_classes) { const auto &bearings = bearing_class.getAvailableBearings(); @@ -669,17 +669,18 @@ void Extractor::WriteIntersectionClassificationData( sizeof(bearings[0]) * bearings.size()); } - // FIXME - // This should be here, but g++4.8 does not have it... - // static_assert(std::is_trivially_copyable::value, - // "EntryClass Serialization requires trivial copyable entry classes"); + if (!static_cast(file_out_stream)) + { + throw util::exception("Failed to write to " + output_file_name + "."); + } util::serializeVector(file_out_stream, entry_classes); TIMER_STOP(write_edges); util::SimpleLogger().Write() << "ok, after " << TIMER_SEC(write_edges) << "s for " << node_based_intersection_classes.size() << " Indices into " << bearing_classes.size() << " bearing classes and " - << entry_classes.size() << " entry classes"; + << entry_classes.size() << " entry classes and " << total_bearings + << " bearing values." << std::endl; } } } diff --git a/src/storage/storage.cpp b/src/storage/storage.cpp index ca519d207..ade7f071a 100644 --- a/src/storage/storage.cpp +++ b/src/storage/storage.cpp @@ -360,7 +360,7 @@ int Storage::Run() } std::uint64_t num_bearings; - intersection_stream >> num_bearings; + intersection_stream.read(reinterpret_cast(&num_bearings),sizeof(num_bearings)); std::vector bearing_class_table(num_bearings); intersection_stream.read(reinterpret_cast(&bearing_class_table[0]),