Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Remove extra mutex unlocking in ConcurrentQueue.h

Browse Source 
As discussed in https://github.com/DennisOSRM/Project-OSRM/pull/998 , unlocking the mutex is performed on destruction. Second unlocking gives an assertion (for debug version) for Windows and FreeBSD 10.
This commit is contained in:
alex85k 2014-06-04 18:01:48 +06:00
parent 11459d38d0
commit 15adcd24be
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
DataStructures/ConcurrentQueue.h
View File

@ -46,7 +46,6 @@ template <typename Data> class ConcurrentQueue
[this] [this]
{ return m_internal_queue.size() < m_internal_queue.capacity(); }); { return m_internal_queue.size() < m_internal_queue.capacity(); });
m_internal_queue.push_back(data); m_internal_queue.push_back(data);
m_mutex.unlock();
m_not_empty.notify_one(); m_not_empty.notify_one();
} }
@ -60,7 +59,6 @@ template <typename Data> class ConcurrentQueue
{ return !m_internal_queue.empty(); }); { return !m_internal_queue.empty(); });
popped_value = m_internal_queue.front(); popped_value = m_internal_queue.front();
m_internal_queue.pop_front(); m_internal_queue.pop_front();
m_mutex.unlock();
m_not_full.notify_one(); m_not_full.notify_one();
} }
@ -73,7 +71,6 @@ template <typename Data> class ConcurrentQueue
} }
popped_value = m_internal_queue.front(); popped_value = m_internal_queue.front();
m_internal_queue.pop_front(); m_internal_queue.pop_front();
m_mutex.unlock();
m_not_full.notify_one(); m_not_full.notify_one();
return true; return true;
} }