Open-Harbor/osrm-backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

re-introduce space into summaries

Browse Source
This commit is contained in:
Moritz Kobitzsch 2016-09-30 14:36:09 +02:00
parent e4d0d49300
commit 10b93c6908
3 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
features/car/summaries.feature
View File

@ -23,10 +23,10 @@ Feature: Basic Routing
| df | street | | df | street |
When I route I should get When I route I should get
| waypoints | route | summary | | waypoints | route | summary |
| a,e | road,,1 st,1 st | road,1 st | | a,e | road,,1 st,1 st | road, 1 st |
| a,d,f | road,,,street,street | road;street | | a,d,f | road,,,street,street | road;street |
| a,e,f | road,,1 st,1 st,1 st,street,street | road,1 st;1 st,street | | a,e,f | road,,1 st,1 st,1 st,street,street | road, 1 st;1 st, street |
Scenario: Name Empty Scenario: Name Empty
Given the node map Given the node map
@ -51,8 +51,8 @@ Feature: Basic Routing
| bc | | 101 | | bc | | 101 |
When I route I should get When I route I should get
| waypoints | route | summary | | waypoints | route | summary |
| a,c | road, | road,101 | | a,c | road, | road, 101 |
Scenario: Only Refs Scenario: Only Refs
Given the node map Given the node map
@ -64,8 +64,8 @@ Feature: Basic Routing
| bc | | 101 | | bc | | 101 |
When I route I should get When I route I should get
| waypoints | route | summary | | waypoints | route | summary |
| a,c | , | 100,101 | | a,c | , | 100, 101 |
Scenario: Single Ref Scenario: Single Ref
Given the node map Given the node map

20
features/testbot/summary.feature
View File

@ -18,12 +18,12 @@ Feature: Basic Routing
| de | | de |
When I route I should get When I route I should get
| from | to | route | summary | | from | to | route | summary |
| a | e | ab,bc,cd,de,de | ab,bc | | a | e | ab,bc,cd,de,de | ab, bc |
| e | a | de,cd,bc,ab,ab | de,bc | | e | a | de,cd,bc,ab,ab | de, bc |
| a | b | ab,ab | ab | | a | b | ab,ab | ab |
| b | d | bc,cd,cd | bc,cd | | b | d | bc,cd,cd | bc, cd |
| 1 | c | bc,bc | bc | | 1 | c | bc,bc | bc |
@smallest @smallest
Scenario: Check handling empty values Scenario: Check handling empty values
@ -40,8 +40,8 @@ Feature: Basic Routing
| df | df | | df | df |
When I route I should get When I route I should get
| from | to | route | summary | | from | to | route | summary |
| e | a | de,,bc,ab,ab | de,bc | | e | a | de,,bc,ab,ab | de, bc |
@smallest @todo @smallest @todo
Scenario: Summaries when routing on a simple network Scenario: Summaries when routing on a simple network
@ -74,6 +74,6 @@ Feature: Basic Routing
| xey | cross |we need this because phantom node segments are not considered for the summary | | xey | cross |we need this because phantom node segments are not considered for the summary |
When I route I should get When I route I should get
| from | to | route | summary | | from | to | route | summary |
| a | 1 | first,first,second,second | first,second | | a | 1 | first,first,second,second | first, second |

2
include/engine/guidance/assemble_leg.hpp
View File

@ -198,7 +198,7 @@ inline RouteLeg assembleLeg(const datafacade::BaseDataFacade &facade,
const auto summary_names = summary_array | boost::adaptors::transformed(name_id_to_string) | const auto summary_names = summary_array | boost::adaptors::transformed(name_id_to_string) |
boost::adaptors::filtered(not_empty); boost::adaptors::filtered(not_empty);
summary = boost::algorithm::join(summary_names, ","); summary = boost::algorithm::join(summary_names, ", ");
} }
return RouteLeg{duration, distance, summary, {}}; return RouteLeg{duration, distance, summary, {}};