Merge pull request #8 from boris612/master

Enabled LessThan[OrEqual], GreaterThan[OrEqual] on strings
This commit is contained in:
dlebee 2019-11-27 16:07:11 -06:00 committed by GitHub
commit a1b3a3bda5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 77 additions and 4 deletions

View File

@ -123,5 +123,57 @@ namespace PoweredSoft.DynamicLinq.Test
b = Persons.AsQueryable().Where(t => t.FirstName.EndsWith("VID", StringComparison.OrdinalIgnoreCase)); b = Persons.AsQueryable().Where(t => t.FirstName.EndsWith("VID", StringComparison.OrdinalIgnoreCase));
QueryableAssert.AreEqual(a, b, "CaseInsensitive"); QueryableAssert.AreEqual(a, b, "CaseInsensitive");
} }
[DataTestMethod]
[DataRow("Denis")]
[DataRow("Ann")]
[DataRow("Tony")]
public void LessThan(string firstName)
{
IQueryable<MockPersonObject> a, b;
a = Persons.AsQueryable().Query(t => t.LessThan("FirstName", firstName));
b = Persons.AsQueryable().Where(t => t.FirstName.CompareTo(firstName) < 0);
QueryableAssert.AreEqual(a, b);
}
[DataTestMethod]
[DataRow("Denis")]
[DataRow("Ann")]
[DataRow("Tony")]
public void LessThanOrEqual(string firstName)
{
IQueryable<MockPersonObject> a, b;
a = Persons.AsQueryable().Query(t => t.LessThanOrEqual("FirstName", firstName));
b = Persons.AsQueryable().Where(t => t.FirstName.CompareTo(firstName) <= 0);
QueryableAssert.AreEqual(a, b);
}
[DataTestMethod]
[DataRow("Denis")]
[DataRow("Ann")]
[DataRow("Tony")]
public void GreaterThan(string firstName)
{
IQueryable<MockPersonObject> a, b;
a = Persons.AsQueryable().Query(t => t.GreaterThan("FirstName", firstName));
b = Persons.AsQueryable().Where(t => t.FirstName.CompareTo(firstName) > 0);
QueryableAssert.AreEqual(a, b);
}
[DataTestMethod]
[DataRow("Denis")]
[DataRow("Ann")]
[DataRow("Tony")]
public void GreaterThanOrEqual(string firstName)
{
IQueryable<MockPersonObject> a, b;
a = Persons.AsQueryable().Query(t => t.GreaterThanOrEqual("FirstName", firstName));
b = Persons.AsQueryable().Where(t => t.FirstName.CompareTo(firstName) >= 0);
QueryableAssert.AreEqual(a, b);
}
} }
} }

View File

@ -78,5 +78,6 @@ namespace PoweredSoft.DynamicLinq
internal static readonly MethodInfo IndexOfMethod = typeof(string).GetMethod("IndexOf", new Type[] { typeof(string), typeof(StringComparison) }); internal static readonly MethodInfo IndexOfMethod = typeof(string).GetMethod("IndexOf", new Type[] { typeof(string), typeof(StringComparison) });
internal static readonly MethodInfo AnyMethod = typeof(Enumerable).GetMethods(BindingFlags.Static | BindingFlags.Public).First(t => t.Name == "Any" && t.GetParameters().Count() == 2); internal static readonly MethodInfo AnyMethod = typeof(Enumerable).GetMethods(BindingFlags.Static | BindingFlags.Public).First(t => t.Name == "Any" && t.GetParameters().Count() == 2);
internal static readonly MethodInfo AllMethod = typeof(Enumerable).GetMethods(BindingFlags.Static | BindingFlags.Public).First(t => t.Name == "All" && t.GetParameters().Count() == 2); internal static readonly MethodInfo AllMethod = typeof(Enumerable).GetMethods(BindingFlags.Static | BindingFlags.Public).First(t => t.Name == "All" && t.GetParameters().Count() == 2);
internal static readonly MethodInfo CompareToMethod = typeof(string).GetMethod("CompareTo", new Type[] { typeof(string) });
} }
} }

View File

@ -47,13 +47,33 @@ namespace PoweredSoft.DynamicLinq.Helpers
ret = Expression.NotEqual(member, constant); ret = Expression.NotEqual(member, constant);
} }
else if (conditionOperator == ConditionOperators.GreaterThan) else if (conditionOperator == ConditionOperators.GreaterThan)
{
if (member.Type == stringType)
ret = Expression.GreaterThan(Expression.Call(member, Constants.CompareToMethod, constant), Expression.Constant(0));
else
ret = Expression.GreaterThan(member, constant); ret = Expression.GreaterThan(member, constant);
}
else if (conditionOperator == ConditionOperators.GreaterThanOrEqual) else if (conditionOperator == ConditionOperators.GreaterThanOrEqual)
{
if (member.Type == stringType)
ret = Expression.GreaterThanOrEqual(Expression.Call(member, Constants.CompareToMethod, constant), Expression.Constant(0));
else
ret = Expression.GreaterThanOrEqual(member, constant); ret = Expression.GreaterThanOrEqual(member, constant);
}
else if (conditionOperator == ConditionOperators.LessThan) else if (conditionOperator == ConditionOperators.LessThan)
{
if (member.Type == stringType)
ret = Expression.LessThan(Expression.Call(member, Constants.CompareToMethod, constant), Expression.Constant(0));
else
ret = Expression.LessThan(member, constant); ret = Expression.LessThan(member, constant);
}
else if (conditionOperator == ConditionOperators.LessThanOrEqual) else if (conditionOperator == ConditionOperators.LessThanOrEqual)
{
if (member.Type == stringType)
ret = Expression.LessThanOrEqual(Expression.Call(member, Constants.CompareToMethod, constant), Expression.Constant(0));
else
ret = Expression.LessThanOrEqual(member, constant); ret = Expression.LessThanOrEqual(member, constant);
}
else if (conditionOperator == ConditionOperators.Contains) else if (conditionOperator == ConditionOperators.Contains)
{ {
if (member.Type == stringType && stringComparision.HasValue) if (member.Type == stringType && stringComparision.HasValue)